)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4e58ef542464438289894228705c451f5bd8fb8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1905312_8ef2e8a9","updated":"2024-11-28 18:08:27.000000000","message":"@sahid.ferdjaoui@industrialdiscipline.com please merge these 3 patches, and I am fine with these changes (please consider the comment on this specific patch if Info level is enough)","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0b1cf99c0a4c63a2c93df4620a9d674d81438d05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5496d5c3_b45d7c13","updated":"2024-09-20 07:49:39.000000000","message":"recheck unrelated","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"35fac6bfa289eda272ed5777c734456bf2df1713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78b8f52c_d9987998","updated":"2025-03-07 09:09:27.000000000","message":"recheck timeout","commit_id":"77da6c37e6e9ea7ce424f70dc32533cffa841458"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bab770f6c692aa97bf5c36cfe99f4c3383ed3e00","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"                continue"},{"line_number":1260,"context_line":"            port \u003d port_detail[\u0027vif_port\u0027]"},{"line_number":1261,"context_line":"            device \u003d port_detail[\u0027device\u0027]"},{"line_number":1262,"context_line":"            # Do not bind a port if it\u0027s already bound"},{"line_number":1263,"context_line":"            cur_tag \u003d tags_by_name.get(port.port_name)"},{"line_number":1264,"context_line":"            if cur_tag is None:"},{"line_number":1265,"context_line":"                LOG.warning(\"During port binding, port %s was deleted \""}],"source_content_type":"text/x-python","patch_set":2,"id":"dbbf6166_fa16770e","line":1262,"updated":"2024-12-02 15:27:46.000000000","message":"I guess this is technically referring to L1301, but not related to this patch just noticing during review.","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21670f2cc5d22884452fa492436f494b6bc89d07","unresolved":true,"context_lines":[{"line_number":1263,"context_line":"            cur_tag \u003d tags_by_name.get(port.port_name)"},{"line_number":1264,"context_line":"            if cur_tag is None:"},{"line_number":1265,"context_line":"                LOG.warning(\"During port binding, port %s was deleted \""},{"line_number":1266,"context_line":"                            \"concurrently, skipping it\", port.port_name)"},{"line_number":1267,"context_line":"                continue"},{"line_number":1268,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1269,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a209dbf_208a968a","line":1266,"updated":"2024-09-20 13:56:01.000000000","message":"I\u0027m on the fence about this one, is info level enough?","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bab770f6c692aa97bf5c36cfe99f4c3383ed3e00","unresolved":true,"context_lines":[{"line_number":1263,"context_line":"            cur_tag \u003d tags_by_name.get(port.port_name)"},{"line_number":1264,"context_line":"            if cur_tag is None:"},{"line_number":1265,"context_line":"                LOG.warning(\"During port binding, port %s was deleted \""},{"line_number":1266,"context_line":"                            \"concurrently, skipping it\", port.port_name)"},{"line_number":1267,"context_line":"                continue"},{"line_number":1268,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1269,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"}],"source_content_type":"text/x-python","patch_set":2,"id":"23f63a42_c23b0066","line":1266,"in_reply_to":"18340950_bb3af3c8","updated":"2024-12-02 15:27:46.000000000","message":"Can you just describe when you\u0027re seeing it? Looking at code that uses the word \"concurrently\" most use LOG.debug, 2 use LOG.info and only 1 uses LOG.warning (ovn_client.update_port()). That was what I was basing my comment on - if a port sometimes disappears and we recover gracefully is there something an operator needs to do?","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3bb8ef5e483b1c4514456460ee45feedf5a406df","unresolved":true,"context_lines":[{"line_number":1263,"context_line":"            cur_tag \u003d tags_by_name.get(port.port_name)"},{"line_number":1264,"context_line":"            if cur_tag is None:"},{"line_number":1265,"context_line":"                LOG.warning(\"During port binding, port %s was deleted \""},{"line_number":1266,"context_line":"                            \"concurrently, skipping it\", port.port_name)"},{"line_number":1267,"context_line":"                continue"},{"line_number":1268,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1269,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"}],"source_content_type":"text/x-python","patch_set":2,"id":"82e2df4b_abc1dd97","line":1266,"in_reply_to":"23f63a42_c23b0066","updated":"2024-12-17 14:09:36.000000000","message":"The point is that Brian, we have some strange behaviors where flows disappears. I think it\u0027s mostly related to this:\n\nhttps://review.opendev.org/c/openstack/neutron/+/880334\n\nWhich is now fixed, I have backported it on our env but it\u0027s not yet deployed.\n\nAs I\u0027m facing difficulties to debug in prod I was considering sharing here what could be useful to highlight. But let\u0027s have it in INFO is you feel more comfortable with that.","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c8a886e63ff9a1ae3e0150f9d6e054a8c024cc07","unresolved":true,"context_lines":[{"line_number":1263,"context_line":"            cur_tag \u003d tags_by_name.get(port.port_name)"},{"line_number":1264,"context_line":"            if cur_tag is None:"},{"line_number":1265,"context_line":"                LOG.warning(\"During port binding, port %s was deleted \""},{"line_number":1266,"context_line":"                            \"concurrently, skipping it\", port.port_name)"},{"line_number":1267,"context_line":"                continue"},{"line_number":1268,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1269,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"}],"source_content_type":"text/x-python","patch_set":2,"id":"885a3711_a50c5e05","line":1266,"in_reply_to":"7a209dbf_208a968a","updated":"2024-09-27 09:43:10.000000000","message":"+1 for merging these to 1 patch.","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ec46686e8963f70e4e9a8439628121fc9b4dab41","unresolved":true,"context_lines":[{"line_number":1263,"context_line":"            cur_tag \u003d tags_by_name.get(port.port_name)"},{"line_number":1264,"context_line":"            if cur_tag is None:"},{"line_number":1265,"context_line":"                LOG.warning(\"During port binding, port %s was deleted \""},{"line_number":1266,"context_line":"                            \"concurrently, skipping it\", port.port_name)"},{"line_number":1267,"context_line":"                continue"},{"line_number":1268,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1269,"context_line":"                self.setup_arp_spoofing_protection(self.int_br,"}],"source_content_type":"text/x-python","patch_set":2,"id":"18340950_bb3af3c8","line":1266,"in_reply_to":"885a3711_a50c5e05","updated":"2024-11-28 09:55:45.000000000","message":"It is actually extremely weird to be in that condition. Are we sure we want to use INFO here?","commit_id":"d97bd0c71035e5de2ae60f48767737e3cbb4678d"}]}
