)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a89c09b4f35848406feb5d7de6d1be8cd01e46f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"418aaa33_c5b7b99b","updated":"2024-10-01 13:15:06.000000000","message":"recheck bug 2045785","commit_id":"9005786579446777736628d79316a7a8a6848730"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"41f66d5c841975c022f1c0dc16c9981a4d59bf4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6befc51_24bc4b9b","updated":"2024-09-30 22:33:12.000000000","message":"recheck neutron-tempest-plugin-openvswitch-iptables_hybrid failed on ovn-only patch","commit_id":"9005786579446777736628d79316a7a8a6848730"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9d67e513062610f27a7fadfa100379643b6bfe97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb63e537_caf1d568","updated":"2024-10-01 17:05:02.000000000","message":"recheck unit test timeout; checking with the team if it\u0027s a known issue","commit_id":"9005786579446777736628d79316a7a8a6848730"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"afbdfe05ea05fa8ab993459881a4134b8190536f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ad692fa_675631a2","updated":"2024-09-30 17:58:56.000000000","message":"recheck unrelated test failure","commit_id":"9005786579446777736628d79316a7a8a6848730"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0c46aeb2a62638bbe22e1c0c3cc3e25e622cbcef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b82a920a_97346d94","updated":"2024-10-02 00:22:34.000000000","message":"Re-sending it back into gate since the patch is identical. The git conflict was triggered by an (older, modified) parent patch that just merged.","commit_id":"c3b9c44f366cf2f0533d0f0c719ae0602b481f08"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a5ec7964896a6e6cf8b6869d2ce3fed5689f0e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cdad3940_98b4dbfa","updated":"2024-10-02 12:42:30.000000000","message":"recheck bug 2083503","commit_id":"c3b9c44f366cf2f0533d0f0c719ae0602b481f08"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6547449b6791716cde0f8d93a1dd5afcf8053c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db9294f7_77168fa0","updated":"2024-10-02 23:14:36.000000000","message":"recheck bug 2083570","commit_id":"c3b9c44f366cf2f0533d0f0c719ae0602b481f08"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c76f608755750cd422e4a2b9353fb2c07ff26be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"32c74cfc_02196621","updated":"2024-10-02 15:36:14.000000000","message":"recheck neutron-ovs-tempest-dvr-ha-multinode-full failed on a ovn patch","commit_id":"c3b9c44f366cf2f0533d0f0c719ae0602b481f08"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"231219ed225bcb2562d4f6f55bc9bd7363e455db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22aa0584_11ed183b","updated":"2024-10-02 07:00:00.000000000","message":"recheck not related error in neutron-ovs-tempest-dvr-ha-multinode-full","commit_id":"c3b9c44f366cf2f0533d0f0c719ae0602b481f08"}],"neutron/tests/unit/services/ovn_l3/test_plugin.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbc651a107e9c306bfb6365d39d386c4e6cd1207","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"964e43c0_678bb528","side":"PARENT","updated":"2024-09-26 18:14:28.000000000","message":"A question, not blaming this patch :) \n\nI don\u0027t understand why are these changes required. Ideally we should have unit tests for both scenarios, flag enabled and flag disabled.\n\nIf we need such changes, does it mean we had not been covering the `True` scenario before and now we won\u0027t cover the `False`?","commit_id":"9831da264491726659bfe3bc7142bcb53be96744"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6aa06c296f41304b50bbbb9e6c6a26a02ec97281","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4891a724_c2ffda55","side":"PARENT","in_reply_to":"185ae11e_95ae9edb","updated":"2024-09-27 17:47:08.000000000","message":"Done","commit_id":"9831da264491726659bfe3bc7142bcb53be96744"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cd0629961b292b71ddab9bd96c4cfa551ae5b5bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbd63c52_13f39ff3","side":"PARENT","in_reply_to":"964e43c0_678bb528","updated":"2024-09-26 19:54:48.000000000","message":"These changes here are needed to cover implicit default scenario, I think we need them. But it\u0027s a reasonable point to question if perhaps now we lose some coverage. Let me check which other scenarios we do (not) have for non-default (False) case.","commit_id":"9831da264491726659bfe3bc7142bcb53be96744"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5fe68ea3a70414442b8968d963f19c5fc6169428","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"185ae11e_95ae9edb","side":"PARENT","in_reply_to":"bb139d01_18f3fb77","updated":"2024-09-27 17:27:38.000000000","message":"I\u0027ve mixed in same test cases in two scenarios for the flag in the parent patch; this patch here is now very tiny. I hope it addresses your concerns.","commit_id":"9831da264491726659bfe3bc7142bcb53be96744"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"50a9dfb39d0beff3d35002006e5af781946f92f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb139d01_18f3fb77","side":"PARENT","in_reply_to":"fbd63c52_13f39ff3","updated":"2024-09-26 21:25:52.000000000","message":"Right, the point I tried to make was that changing a default flag should not have any impact on any unittest, as unittests are considered an independent unit. Now the change mocks a method (`get_networks`) for all test_methods which may have side effects. I assumed the new mocks are here to make the tests pass 😊\n\nAgain, I\u0027m not opposing this, just thinking out loud if we won\u0027t lose coverage. If we do, it may be better to use `set_override()` for the config value in some base class to a non-default (False) to keep the previous behavior in unittests and implement new coverage for the default in a followup patch.","commit_id":"9831da264491726659bfe3bc7142bcb53be96744"}]}