)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f79497fa6e698f9bbda53357fae4bf45ebf4e2b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84ff7836_114ad88d","updated":"2024-10-02 13:18:10.000000000","message":"So let me clarify the purpose of this patch. When scheduling a DVR router, we only need to know the \n\nWhat happens with ``L3_DVR_HA_scheduler_db_mixin``? This is also inheriting from ``L3_DVRsch_db_mixin``. Will this method be used to schedule the HA routers too (SNAT routers)?","commit_id":"e7e2bf79dee347aef3ea7cb44ff1f59db0b61fd0"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f79497fa6e698f9bbda53357fae4bf45ebf4e2b2","unresolved":true,"context_lines":[{"line_number":190,"context_line":"                    n_const.DEVICE_OWNER_ROUTER_GW):"},{"line_number":191,"context_line":"                continue"},{"line_number":192,"context_line":"            # NOTE(amorin) we may not want to keep subnets from external"},{"line_number":193,"context_line":"            # networks, because most of the time we don\u0027t need the DVR router"},{"line_number":194,"context_line":"            # namespaces to be spread accross the infrastructure"},{"line_number":195,"context_line":"            # See bug #2083226"},{"line_number":196,"context_line":"            if not keep_ext_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed8e0a49_70d57779","line":193,"range":{"start_line":193,"start_character":32,"end_line":193,"end_character":48},"updated":"2024-10-02 13:18:10.000000000","message":"\"most of the time\"? When could be needed? We can\u0027t document this method in this way.","commit_id":"e7e2bf79dee347aef3ea7cb44ff1f59db0b61fd0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f79497fa6e698f9bbda53357fae4bf45ebf4e2b2","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                network_id \u003d int_port[\u0027network_id\u0027]"},{"line_number":198,"context_line":"                network \u003d self._core_plugin.get_network("},{"line_number":199,"context_line":"                    context, network_id, \u0027router:external\u0027)"},{"line_number":200,"context_line":"                if network[\u0027router:external\u0027]:"},{"line_number":201,"context_line":"                    continue"},{"line_number":202,"context_line":"            int_ips \u003d int_port[\u0027fixed_ips\u0027]"},{"line_number":203,"context_line":"            if int_ips:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a63db7b_d9e4d37b","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":45},"updated":"2024-10-02 13:18:10.000000000","message":"We usually use \"external\" networks as GW networks. But we can use a \"external\" network for a non-gw network in the router. So you need to find the router GW network and check if int_port[\u0027network_id\u0027]\u003d\u003dgw_network.","commit_id":"e7e2bf79dee347aef3ea7cb44ff1f59db0b61fd0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a91538fd7df42988708a10c93b5ac161a631b17","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        # See bug #2083226"},{"line_number":401,"context_line":"        query \u003d query.filter("},{"line_number":402,"context_line":"            models_v2.IPAllocation.network_id \u003d\u003d models_v2.Network.id)"},{"line_number":403,"context_line":"        query \u003d query.filter(~models_v2.Network.external.has())"},{"line_number":404,"context_line":"        return query"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @db_api.CONTEXT_READER"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce2e3ff1_c6fb6e1e","line":403,"range":{"start_line":403,"start_character":40,"end_line":403,"end_character":63},"updated":"2024-10-02 13:18:55.000000000","message":"Same comment as before","commit_id":"e7e2bf79dee347aef3ea7cb44ff1f59db0b61fd0"}]}