)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c1b351e3b7563d85f3062f14c6502697e9bead87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b8a6535_d4352d12","updated":"2024-11-06 21:41:50.000000000","message":"lgtm, just needs a rebase","commit_id":"7818f2c592d265bd7b9e2bdb091e65b4fce34a9d"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cb417c678648dba1f065f4978c5c8c2f7b784579","unresolved":true,"context_lines":[{"line_number":878,"context_line":"        self.fake_ovn_client._nb_idl.db_set.assert_has_calls("},{"line_number":879,"context_line":"            expected_calls)"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def test_check_fdb_aging_settings(self):"},{"line_number":882,"context_line":"        cfg.CONF.set_override(\u0027fdb_age_threshold\u0027, 5, group\u003d\u0027ovn\u0027)"},{"line_number":883,"context_line":"        networks \u003d [{\u0027id\u0027: \u0027foo\u0027,"},{"line_number":884,"context_line":"                     \u0027provider:physical_network\u0027: \u0027datacentre\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c5b9aa8_f2d259ac","side":"PARENT","line":881,"updated":"2024-10-04 17:50:10.000000000","message":"why deleting these? is it because you think they are now useless?","commit_id":"ee3150de51e853444f16d74989de886ab8c239ae"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aa689176055ff37e7023e8eb8b9bc37a51350f7e","unresolved":true,"context_lines":[{"line_number":878,"context_line":"        self.fake_ovn_client._nb_idl.db_set.assert_has_calls("},{"line_number":879,"context_line":"            expected_calls)"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def test_check_fdb_aging_settings(self):"},{"line_number":882,"context_line":"        cfg.CONF.set_override(\u0027fdb_age_threshold\u0027, 5, group\u003d\u0027ovn\u0027)"},{"line_number":883,"context_line":"        networks \u003d [{\u0027id\u0027: \u0027foo\u0027,"},{"line_number":884,"context_line":"                     \u0027provider:physical_network\u0027: \u0027datacentre\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"454c1b97_e2665d88","side":"PARENT","line":881,"in_reply_to":"1c5b9aa8_f2d259ac","updated":"2024-10-04 18:14:58.000000000","message":"almost, I think they were useless even before 😊\n\nImho testing a method calls specific methods with certain arguments doesn\u0027t validate correctness. To make those tests passed we would just replace the method name with a different name and different arguments which doesn\u0027t seem particularly useful.","commit_id":"ee3150de51e853444f16d74989de886ab8c239ae"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"a97804ed05b4bb7a166e0c40d3a4615354d4ec69","unresolved":true,"context_lines":[{"line_number":878,"context_line":"        self.fake_ovn_client._nb_idl.db_set.assert_has_calls("},{"line_number":879,"context_line":"            expected_calls)"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def test_check_fdb_aging_settings(self):"},{"line_number":882,"context_line":"        cfg.CONF.set_override(\u0027fdb_age_threshold\u0027, 5, group\u003d\u0027ovn\u0027)"},{"line_number":883,"context_line":"        networks \u003d [{\u0027id\u0027: \u0027foo\u0027,"},{"line_number":884,"context_line":"                     \u0027provider:physical_network\u0027: \u0027datacentre\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5416ab64_87ec939b","side":"PARENT","line":881,"in_reply_to":"454c1b97_e2665d88","updated":"2024-10-04 20:14:28.000000000","message":"\u003e almost, I think they were useless even before 😊\n\n+1000. Also there are functional tests in `neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py` which cover this in a better way.","commit_id":"ee3150de51e853444f16d74989de886ab8c239ae"}]}