)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a9907bee90e6d7f34e83102aa0a4a980810d9e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28c5490a_c3e8cd0d","updated":"2024-10-06 02:23:30.000000000","message":"I had changed these (I think recently) to use metaclass\u003d, which was recommended at the time, I\u0027d rather not change them all back. Plus it\u0027s also used in Nova, Keystone, Octavia, Zuul, .... Let\u0027s not change for the sake of changing.","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2e20d2873c84593e8d93b47e48c47dc896139037","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38264208_97f907c2","updated":"2024-10-08 15:42:26.000000000","message":"This is a WIP, shouldn\u0027t be merged unless I add a hacking rule.","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8a080b525700db12e11912f6321845a957a4690f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff796206_7b492edf","in_reply_to":"28c5490a_c3e8cd0d","updated":"2024-10-06 02:31:57.000000000","message":"As a follow-on, codesearch found 24 occurrences of (ABC) in all of Opendev, but 641 files using (metaclass\u003dabc.ABCMeta), some had multiple occurrences.","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc2c88d0aedcdc8503e264a3c780935067309977","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6779069e_1ad7694e","in_reply_to":"473d5326_0f8f752e","updated":"2024-10-07 18:59:33.000000000","message":"I still think neutron should stay consistent with *all* of the other opendev projects wrt metaclass\u003d usage, including in the patch you linked. This was the recommended way when we removed usage of the six library in 2020, and makes them all consistent in their usage. Maybe I missed it, but I did see anything in the PEP guide recommending abc.ABC [0].\n\n[0] https://peps.python.org/pep-3119/","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ef624180696b874248fb8ed8c640e0ebcd391185","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e098301d_4878d31a","in_reply_to":"6779069e_1ad7694e","updated":"2024-10-08 14:56:21.000000000","message":"Both ways are the same [1]: ABC is an abstraction for metaclass\u003dABCMeta.\n\nBoth have the same support but ABC is preferred. Now that we have this patch ready, let\u0027s go for it.\n\nhttps://hg.python.org/cpython/file/3.4/Lib/abc.py#l234","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"93d48f49e23ac357715deea7f038677b7fd91def","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"473d5326_0f8f752e","in_reply_to":"f4ed2a03_3cfda14c","updated":"2024-10-07 13:59:13.000000000","message":"For context, the patch that was -1d for abc.ABC use is: https://review.opendev.org/c/openstack/neutron/+/929866","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f332e309671aacc91fb0377850d15294cc8b8c4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4ed2a03_3cfda14c","in_reply_to":"ff796206_7b492edf","updated":"2024-10-07 13:56:52.000000000","message":"So, `abc.ABC` is the preferred way by upstream python docs. I\u0027d be fine with just using it in my patches and let others use the other form, since both are fine, but you -1d a patch where I used it because it\u0027s not consistent with the rest of the code. Since abc.ABC is arguably less confusing / preferred, this patch is an attempt to reconcile both requests.\n\nI\u0027d rather we don\u0027t -1 patches when abc.ABC is used, since it\u0027s a legit code, while keeping the metaclass\u003d form whenever it\u0027s used. Thoughts?","commit_id":"293600275e4bce73164ad6822c80a6b291791e29"}]}