)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7d034332f2c9e24f293cd444378aad5163334a66","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace deprecated is_advsvc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This context property was deprecated in neutron-lib 3.0.0[1], in favor"},{"line_number":10,"context_line":"of the new is_service_role property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] 8ccdecc7d1599119e3f020051449b547db89ee3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"43e3f7fc_5fbfd0c6","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":57},"updated":"2024-10-07 06:19:35.000000000","message":"3.8.0","commit_id":"fb6e663f9add044fb376179bd6ba74e853d51a35"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"19c96b08ee72b4e5b4b5531897fd2168081320f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace deprecated is_advsvc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This context property was deprecated in neutron-lib 3.0.0[1], in favor"},{"line_number":10,"context_line":"of the new is_service_role property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] 8ccdecc7d1599119e3f020051449b547db89ee3e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"56eb191f_d5eb5052","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":57},"in_reply_to":"43e3f7fc_5fbfd0c6","updated":"2024-10-07 06:57:59.000000000","message":"Oops. Yes. 3.8.0 is the correct one.\n\nhttps://github.com/openstack/neutron-lib/commit/8ccdecc7d1599119e3f020051449b547db89ee3e","commit_id":"fb6e663f9add044fb376179bd6ba74e853d51a35"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7d034332f2c9e24f293cd444378aad5163334a66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8fca62ff_6a40fe42","updated":"2024-10-07 06:19:35.000000000","message":"There are other places in the code where is_advsvc is used: https://codesearch.openstack.org/?q\u003dis_advsvc\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"fb6e663f9add044fb376179bd6ba74e853d51a35"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"11d321336358581128cdc3870ca697c5057a71b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ce9b6dd_a47e82c3","updated":"2024-10-06 03:40:55.000000000","message":"recheck timeout in api call","commit_id":"fb6e663f9add044fb376179bd6ba74e853d51a35"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c7af2f9aeb18b10722cc765be7910f8267951d3d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a50850f6_eceb4556","in_reply_to":"11452140_e3d5e51f","updated":"2024-10-07 10:41:50.000000000","message":"Could you please specifically point any remaining code ? I rebased this on current master and checked the remaining `.is_advsvc()` call but could not find any.\nThe policy itself is deprecated but is still kept so can\u0027t be removed now, IIUC.\n\n```\n$ grep -r \u0027\\.is_advsvc\u0027 neutron/\n$ grep -r \u0027is_advsvc\u0027 neutron/\nneutron/tests/unit/db/quota/test_api.py:                                       is_admin\u003dFalse, is_advsvc\u003dFalse)\nneutron/tests/unit/db/quota/test_api.py:                                       is_admin\u003dTrue, is_advsvc\u003dTrue)\nneutron/tests/unit/quota/test_resource_registry.py:                              is_admin\u003dFalse, is_advsvc\u003dFalse)\nneutron/tests/unit/quota/test_resource_registry.py:                              is_admin\u003dFalse, is_advsvc\u003dFalse)\nneutron/tests/unit/quota/test_resource_registry.py:                              is_admin\u003dFalse, is_advsvc\u003dFalse)\nneutron/tests/unit/test_policy.py:            \"context_is_advsvc\": \"role:advsvc\",\nneutron/tests/unit/test_policy.py:                           \"rule:external or rule:context_is_advsvc\",\nneutron/tests/unit/test_policy.py:                               \"rule:context_is_advsvc\",\nneutron/tests/unit/test_policy.py:                \"rule:context_is_advsvc or rule:admin_or_network_owner or \"\nneutron/tests/unit/test_policy.py:                \"rule:context_is_advsvc or rule:admin_or_network_owner\"),\nneutron/tests/unit/test_policy.py:                \"rule:context_is_advsvc or rule:admin_or_network_owner or \"\nneutron/tests/unit/test_policy.py:            \"update_port\": \"rule:admin_or_owner or rule:context_is_advsvc\",\nneutron/tests/unit/test_policy.py:            \"get_port\": \"rule:admin_or_owner or rule:context_is_advsvc\",\nneutron/tests/unit/test_policy.py:            \"delete_port\": \"rule:admin_or_owner or rule:context_is_advsvc\",\nneutron/conf/policies/base.py:        \u0027context_is_advsvc\u0027,\nneutron/policy.py:ADVSVC_CTX_POLICY \u003d \u0027context_is_advsvc\u0027\n```\n\nI updated the change to drop usage of is_advsvc argument (because all these are redundant) but if you find anything still left, please let me know.","commit_id":"fb6e663f9add044fb376179bd6ba74e853d51a35"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f01cb6b08ed051fd22f7582ec705f925bc73348","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11452140_e3d5e51f","in_reply_to":"8fca62ff_6a40fe42","updated":"2024-10-07 10:31:44.000000000","message":"Same comment as in PS1.","commit_id":"fb6e663f9add044fb376179bd6ba74e853d51a35"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19709cdacad38b698667af7b3b365c6cbe7d0d56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a121c62_85bab744","updated":"2024-10-09 11:02:43.000000000","message":"https://github.com/openstack/neutron/blob/9ec96f5e68f7fd7402889987cf9d60a6ffb65ec1/doc/source/contributor/internals/policy.rst#L165, that no longer applies to the code","commit_id":"8d267e53ce6f2d2135feb141be10a919b08c90bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7d7d3408cae6d6e1a8a7940204d589e9b2bbd4fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"109615ee_a444859a","updated":"2024-10-13 15:27:16.000000000","message":"recheck timeout while waiting for ssh connection. No legit problem is found in this change itself.","commit_id":"0f8f73caf6a64932ac05ce433760aa1d77b1073c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"27bda7af080d646b633d08fb03289092aa5e90c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70ef5eee_4345b8ae","updated":"2024-10-11 16:27:30.000000000","message":"thanks","commit_id":"0f8f73caf6a64932ac05ce433760aa1d77b1073c"}]}