)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"353265a2b72ae2fd9e3f5e84d204f12f98648b62","unresolved":true,"context_lines":[{"line_number":18,"context_line":"Other plugins that connect to the OVN database can then also rely on the"},{"line_number":19,"context_line":"information stored in the OVN DB\u0027s"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-Bug: #2083832"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ibe8bda2f81bda7a89e3a994db55cd394a18decb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6dbb8058_eda2d918","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":11},"updated":"2024-10-08 11:05:54.000000000","message":"This can be Closes-Bug, am I right?","commit_id":"b4c20996476619808f787dae9e7c781c777e2fd3"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"e186785cbb4681ba48c6ef270969b0206d7825a1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Other plugins that connect to the OVN database can then also rely on the"},{"line_number":19,"context_line":"information stored in the OVN DB\u0027s"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-Bug: #2083832"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ibe8bda2f81bda7a89e3a994db55cd394a18decb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5312346a_db79db28","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":11},"in_reply_to":"6dbb8058_eda2d918","updated":"2024-10-22 06:03:21.000000000","message":"Done","commit_id":"b4c20996476619808f787dae9e7c781c777e2fd3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7f3866d164ee90e3b57893ec80680e7dc09c983f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ca8060ff_a47df851","updated":"2024-10-07 10:30:58.000000000","message":"Please create a LP bug describing the current issue.","commit_id":"97e85248363d25d9ae509e950ea705a6c13891a9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b2d7bf58577f15252b363afe1c130e693704f26a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"14dfad4c_e3e00a76","updated":"2024-10-08 09:53:02.000000000","message":"recheck\nfunctional job failed with too many open files (see: https://launchpad.net/bugs/2080199)","commit_id":"b4c20996476619808f787dae9e7c781c777e2fd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"71003197e4781a531de839f8b96b76079eb7663a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"05a1cf03_f3b4ddfd","updated":"2024-10-21 13:39:31.000000000","message":"If you fix the pep8, I\u0027ll give you a +2\n\nErrors:\n2024-10-14 14:23:24.546437 | ubuntu-jammy | ./neutron/services/ovn_l3/plugin.py:262:80: E501 line too long (84 \u003e 79 characters)\n2024-10-14 14:23:24.748441 | ubuntu-jammy |                 ext_ids \u003d (\"external_ids\", {ovn_const.OVN_HOST_ID_EXT_ID_KEY: host})\n2024-10-14 14:23:24.748507 | ubuntu-jammy |                                                                                ^\n2024-10-14 14:23:24.748520 | ubuntu-jammy | ./neutron/services/ovn_l3/plugin.py:263:80: E501 line too long (88 \u003e 79 characters)\n2024-10-14 14:23:24.748531 | ubuntu-jammy |                 txn.add(self._nb_ovn.db_set(\"Logical_Switch_Port\", port[\"id\"], ext_ids))\n2024-10-14 14:23:24.748542 | ubuntu-jammy |                                                                                ^\n2024-10-14 14:23:24.748562 | ubuntu-jammy | pep8: 26334 C exit 1 (19.69 seconds) /home/zuul/src/opendev.org/openstack/neutron\u003e fla","commit_id":"c072ecefb6827747437a5a83154fc995f15e7fc9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"22a54213bdb743e578c6387dbae5c9fa30660c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"777e052b_e43672c2","in_reply_to":"05a1cf03_f3b4ddfd","updated":"2024-10-21 13:40:17.000000000","message":"Nevermind, these errors are from older PS","commit_id":"c072ecefb6827747437a5a83154fc995f15e7fc9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d801e321b2c33b3db6af78d9c2b225a75e9abfb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4991e45b_e9b7e4c0","updated":"2024-10-25 11:58:36.000000000","message":"Thanks","commit_id":"4b032bdbb2a6843b776c367486d1620ea6ae71a5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5fe5672b574bb0326d201614376e97f88c25c7e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ab681897_2017262d","updated":"2024-10-25 11:58:56.000000000","message":"recheck\nold policy default job failure is not related","commit_id":"4b032bdbb2a6843b776c367486d1620ea6ae71a5"}],"neutron/services/ovn_l3/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20e11ffa3ad74798b17236fbbb779a20c9a545f5","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                self._plugin.update_port_status(context, port[\u0027id\u0027], status)"},{"line_number":256,"context_line":"            # Updates OVN NB database with hostname for lsp router gateway port"},{"line_number":257,"context_line":"            # and bump ovn revision number"},{"line_number":258,"context_line":"            db_port \u003d self._plugin.get_port(context, port[\u0027id\u0027])"},{"line_number":259,"context_line":"            check_rev_cmd \u003d self._nb_ovn.check_revision_number("},{"line_number":260,"context_line":"                port[\u0027id\u0027], db_port, ovn_const.TYPE_PORTS)"},{"line_number":261,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"e124351b_4853868b","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":2},"updated":"2024-10-14 12:54:45.000000000","message":"Why are you retrieving again the port? The plugin.get_ports() method should give you the same information. There should not be needed a second DB access.","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"7516eef2bd7f8862bb686002c8c2b243836d00a4","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                self._plugin.update_port_status(context, port[\u0027id\u0027], status)"},{"line_number":256,"context_line":"            # Updates OVN NB database with hostname for lsp router gateway port"},{"line_number":257,"context_line":"            # and bump ovn revision number"},{"line_number":258,"context_line":"            db_port \u003d self._plugin.get_port(context, port[\u0027id\u0027])"},{"line_number":259,"context_line":"            check_rev_cmd \u003d self._nb_ovn.check_revision_number("},{"line_number":260,"context_line":"                port[\u0027id\u0027], db_port, ovn_const.TYPE_PORTS)"},{"line_number":261,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"22b0bb73_dd62f5c7","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":2},"in_reply_to":"a98e35c7_03537751","updated":"2024-10-23 10:50:51.000000000","message":"Done","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"e186785cbb4681ba48c6ef270969b0206d7825a1","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                self._plugin.update_port_status(context, port[\u0027id\u0027], status)"},{"line_number":256,"context_line":"            # Updates OVN NB database with hostname for lsp router gateway port"},{"line_number":257,"context_line":"            # and bump ovn revision number"},{"line_number":258,"context_line":"            db_port \u003d self._plugin.get_port(context, port[\u0027id\u0027])"},{"line_number":259,"context_line":"            check_rev_cmd \u003d self._nb_ovn.check_revision_number("},{"line_number":260,"context_line":"                port[\u0027id\u0027], db_port, ovn_const.TYPE_PORTS)"},{"line_number":261,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a98e35c7_03537751","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":2},"in_reply_to":"e124351b_4853868b","updated":"2024-10-22 06:03:21.000000000","message":"Thank you, I\u0027m kind of new to all this. Now, I rechecked and it seems we don\u0027t have to touch revision number here at all, as it\u0027s already bumped by update_port.","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20e11ffa3ad74798b17236fbbb779a20c9a545f5","unresolved":true,"context_lines":[{"line_number":260,"context_line":"                port[\u0027id\u0027], db_port, ovn_const.TYPE_PORTS)"},{"line_number":261,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":262,"context_line":"                ext_ids \u003d (\u0027external_ids\u0027,"},{"line_number":263,"context_line":"                        {ovn_const.OVN_HOST_ID_EXT_ID_KEY: host})"},{"line_number":264,"context_line":"                txn.add("},{"line_number":265,"context_line":"                    self._nb_ovn.db_set("},{"line_number":266,"context_line":"                        \u0027Logical_Switch_Port\u0027, port[\u0027id\u0027], ext_ids))"}],"source_content_type":"text/x-python","patch_set":4,"id":"b1f46008_d7bb9499","line":263,"updated":"2024-10-14 12:54:45.000000000","message":"indentation here is a bit weird","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"e186785cbb4681ba48c6ef270969b0206d7825a1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                port[\u0027id\u0027], db_port, ovn_const.TYPE_PORTS)"},{"line_number":261,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":262,"context_line":"                ext_ids \u003d (\u0027external_ids\u0027,"},{"line_number":263,"context_line":"                        {ovn_const.OVN_HOST_ID_EXT_ID_KEY: host})"},{"line_number":264,"context_line":"                txn.add("},{"line_number":265,"context_line":"                    self._nb_ovn.db_set("},{"line_number":266,"context_line":"                        \u0027Logical_Switch_Port\u0027, port[\u0027id\u0027], ext_ids))"}],"source_content_type":"text/x-python","patch_set":4,"id":"6ae195ba_89f5b260","line":263,"in_reply_to":"b1f46008_d7bb9499","updated":"2024-10-22 06:03:21.000000000","message":"Done","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20e11ffa3ad74798b17236fbbb779a20c9a545f5","unresolved":true,"context_lines":[{"line_number":267,"context_line":"                txn.add(check_rev_cmd)"},{"line_number":268,"context_line":"            if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":269,"context_line":"                ovn_revision_numbers_db.bump_revision(context, db_port,"},{"line_number":270,"context_line":"                                                    ovn_const.TYPE_PORTS)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def schedule_unhosted_gateways(self, event_from_chassis\u003dNone):"},{"line_number":273,"context_line":"        # GW ports and its physnets."}],"source_content_type":"text/x-python","patch_set":4,"id":"a131dad7_f2fa4c34","line":270,"updated":"2024-10-14 12:54:45.000000000","message":"ditto","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"e186785cbb4681ba48c6ef270969b0206d7825a1","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                txn.add(check_rev_cmd)"},{"line_number":268,"context_line":"            if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":269,"context_line":"                ovn_revision_numbers_db.bump_revision(context, db_port,"},{"line_number":270,"context_line":"                                                    ovn_const.TYPE_PORTS)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def schedule_unhosted_gateways(self, event_from_chassis\u003dNone):"},{"line_number":273,"context_line":"        # GW ports and its physnets."}],"source_content_type":"text/x-python","patch_set":4,"id":"5e276662_bd40f210","line":270,"in_reply_to":"a131dad7_f2fa4c34","updated":"2024-10-22 06:03:21.000000000","message":"Done","commit_id":"84372f086a0ffd2502f2f2bdc00b75d61d3e30d5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea0d2e1f69b25c01b4c0dcda43a5a9dac1144238","unresolved":true,"context_lines":[{"line_number":261,"context_line":"                            \"Logical_Switch_Port\", port[\"id\"], ext_ids"},{"line_number":262,"context_line":"                        )"},{"line_number":263,"context_line":"                    )"},{"line_number":264,"context_line":"            if port[\"status\"] !\u003d status:"},{"line_number":265,"context_line":"                self._plugin.update_port_status(context, port[\u0027id\u0027], status)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def schedule_unhosted_gateways(self, event_from_chassis\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a4a18acb_d0a72594","line":264,"updated":"2024-10-22 19:30:47.000000000","message":"nit: changing from \u0027status\u0027 to \"status\" made this line show up as changed, should just leave it alone since it\u0027s not needed as part of the change","commit_id":"c072ecefb6827747437a5a83154fc995f15e7fc9"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"7516eef2bd7f8862bb686002c8c2b243836d00a4","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                            \"Logical_Switch_Port\", port[\"id\"], ext_ids"},{"line_number":262,"context_line":"                        )"},{"line_number":263,"context_line":"                    )"},{"line_number":264,"context_line":"            if port[\"status\"] !\u003d status:"},{"line_number":265,"context_line":"                self._plugin.update_port_status(context, port[\u0027id\u0027], status)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def schedule_unhosted_gateways(self, event_from_chassis\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"49a11adf_cd93a27a","line":264,"in_reply_to":"a4a18acb_d0a72594","updated":"2024-10-23 10:50:51.000000000","message":"Done","commit_id":"c072ecefb6827747437a5a83154fc995f15e7fc9"}],"neutron/tests/functional/services/ovn_l3/test_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea0d2e1f69b25c01b4c0dcda43a5a9dac1144238","unresolved":true,"context_lines":[{"line_number":535,"context_line":"        cmd \u003d self.sb_api.db_find_rows(\u0027Port_Binding\u0027,"},{"line_number":536,"context_line":"                                       (\u0027logical_port\u0027, \u0027\u003d\u0027, port_id))"},{"line_number":537,"context_line":"        rows \u003d cmd.execute(check_error\u003dTrue)"},{"line_number":538,"context_line":"        return rows[0] if rows else None"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def test_router_gateway_port_binding_host_id(self):"},{"line_number":541,"context_line":"        # Test setting chassis on chassisredirect port in Port_Binding table,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2aa65061_a93d2df3","line":538,"updated":"2024-10-22 19:30:47.000000000","message":"Technically this is Ok even if it never return None (will throw exception), and is what other functional tests do. Just leaving a comment since I had to double-check.","commit_id":"c072ecefb6827747437a5a83154fc995f15e7fc9"},{"author":{"_account_id":35983,"name":"Aleksandr Chudinov","email":"silentirk@me.com","username":"silentirk"},"change_message_id":"7516eef2bd7f8862bb686002c8c2b243836d00a4","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        cmd \u003d self.sb_api.db_find_rows(\u0027Port_Binding\u0027,"},{"line_number":536,"context_line":"                                       (\u0027logical_port\u0027, \u0027\u003d\u0027, port_id))"},{"line_number":537,"context_line":"        rows \u003d cmd.execute(check_error\u003dTrue)"},{"line_number":538,"context_line":"        return rows[0] if rows else None"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    def test_router_gateway_port_binding_host_id(self):"},{"line_number":541,"context_line":"        # Test setting chassis on chassisredirect port in Port_Binding table,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dbfb89ed_4c013731","line":538,"in_reply_to":"2aa65061_a93d2df3","updated":"2024-10-23 10:50:51.000000000","message":"Acknowledged","commit_id":"c072ecefb6827747437a5a83154fc995f15e7fc9"}]}