)]}'
{"neutron/tests/fullstack/test_l3_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb87f996e4e1ca08a3d51c864e834508cf02650","unresolved":true,"context_lines":[{"line_number":487,"context_line":"        )"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        def is_one_host_active_for_router():"},{"line_number":490,"context_line":"            active_hosts \u003d get_active_hosts()"},{"line_number":491,"context_line":"            return len(active_hosts) \u003d\u003d 1"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7835850b_a3fb0209","line":490,"updated":"2024-10-08 17:16:18.000000000","message":"If active_hosts was defined outside this scope could we just use it on L503? Just trying to save calls to get_active_hosts() if it was already successful.","commit_id":"3c3b4375565ff3a83cf92c4ae362685e7a15f115"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"803c39aa8aae86c7c610e886dddb8e25166da759","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        )"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        def is_one_host_active_for_router():"},{"line_number":490,"context_line":"            active_hosts \u003d get_active_hosts()"},{"line_number":491,"context_line":"            return len(active_hosts) \u003d\u003d 1"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5c339e8_6ad0fefd","line":490,"in_reply_to":"7835850b_a3fb0209","updated":"2024-10-09 07:18:16.000000000","message":"but this function is later called by the \"wait_until_true\" in L494 and it needs to call get_active_hosts() every time it is checking it","commit_id":"3c3b4375565ff3a83cf92c4ae362685e7a15f115"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb87f996e4e1ca08a3d51c864e834508cf02650","unresolved":true,"context_lines":[{"line_number":500,"context_line":"                self.fail(\u0027Number of active hosts for router: %s\u0027,"},{"line_number":501,"context_line":"                          len(active_hosts))"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        active_host \u003d get_active_hosts()[0]"},{"line_number":504,"context_line":"        backup_host \u003d next("},{"line_number":505,"context_line":"            h for h in self.environment.hosts if h !\u003d active_host)"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ace6bcc_c8737694","line":503,"updated":"2024-10-08 17:16:18.000000000","message":"Or can the except just be un-indented and save a get_active_hosts() call?\n\ntry:\n    common_utils.wait_until_true(\n        is_one_host_active_for_router, timeout\u003d15)\nexcept common_utils.WaitTimeout:\n    pass\n\nactive_hosts \u003d get_active_hosts()\n# Test one last time:\nif len(active_hosts) !\u003d 1:\n    self.fail(\u0027Number of active hosts for router: %s\u0027,\n              len(active_hosts))\n                  \nactive_host \u003d active_hosts[0]","commit_id":"3c3b4375565ff3a83cf92c4ae362685e7a15f115"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"803c39aa8aae86c7c610e886dddb8e25166da759","unresolved":false,"context_lines":[{"line_number":500,"context_line":"                self.fail(\u0027Number of active hosts for router: %s\u0027,"},{"line_number":501,"context_line":"                          len(active_hosts))"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        active_host \u003d get_active_hosts()[0]"},{"line_number":504,"context_line":"        backup_host \u003d next("},{"line_number":505,"context_line":"            h for h in self.environment.hosts if h !\u003d active_host)"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a089d1c4_4c6cd03b","line":503,"in_reply_to":"1ace6bcc_c8737694","updated":"2024-10-09 07:18:16.000000000","message":"Done","commit_id":"3c3b4375565ff3a83cf92c4ae362685e7a15f115"}]}