)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f4b206fc59131a27bc94b833e0a4eba3d9e8033d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e9340c4_0d1499c1","updated":"2024-11-05 14:58:09.000000000","message":"Question: does it mean that the set_port_status_down call will result in inconsistent state, namely: neutron port status is set to DOWN, while `Logical_Switch_Port.external_ids.neutron:host_id` is left in the NB database (and vice versa: neutron port is UP, but `host_id` is not populated)? If so, is it not an issue?","commit_id":"c0bdb0c8a33286acb4d44ad865f0000309fc79b6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"385b227d8e4635748c0a051f8d259e6c4cff58d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ef5bc20_a8bd59c7","updated":"2024-11-05 10:46:39.000000000","message":"recheck grenade\nerror connecting to identity server","commit_id":"c0bdb0c8a33286acb4d44ad865f0000309fc79b6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b36cc25c86d3e2610fa7bf2ff79941c318d3ccb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ef28f225_e91c13c5","in_reply_to":"5e9340c4_0d1499c1","updated":"2024-11-05 15:07:18.000000000","message":"* If we call update_lsp_host_info with up\u003dTrue but the port is down, then another update_lsp_host_info call will be done later removing any host info\n* If we call update_lsp_host_info with up\u003dFalse but the port is up, similar to the previous line, it will be another call to update_lsp_host_info that will set the host info\n\nWhat this patch is preventing is the concurrence of the update_lsp_host_info calls, if the transitions are done faster than the Neutron API processing. This check is ensuring that the expected port status is correct.","commit_id":"c0bdb0c8a33286acb4d44ad865f0000309fc79b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d05900b6287cbab48f4a46ada490b787f7f8ef5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"35724655_c2c225b8","in_reply_to":"ef28f225_e91c13c5","updated":"2024-11-05 16:34:10.000000000","message":"This was discussed at https://meetings.opendev.org/irclogs/%23openstack-neutron/%23openstack-neutron.2024-11-05.log.html#t2024-11-05T15:13:36 and while I don\u0027t think the concern was resolved, I don\u0027t feel confident enough to block this from merging.","commit_id":"c0bdb0c8a33286acb4d44ad865f0000309fc79b6"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7970615e88d8ba99fd0efaca6ef63b38377f3488","unresolved":true,"context_lines":[{"line_number":303,"context_line":"            # Check LSP status. The port can be switched to DOWN before calling"},{"line_number":304,"context_line":"            # this method."},{"line_number":305,"context_line":"            if not self._nb_idl.lsp_get_up(db_port.id).execute("},{"line_number":306,"context_line":"                    check_error\u003dTrue):"},{"line_number":307,"context_line":"                LOG.warning(\u0027Logical_Switch_Port %s host information not \u0027"},{"line_number":308,"context_line":"                            \u0027updated, the port state is down\u0027)"},{"line_number":309,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"b46e1814_747f2ef3","line":306,"updated":"2024-11-04 17:07:21.000000000","message":"Since this is being done in both cases here, it could be called before the if/else and saved to a local value.\n\nis_lsp_up \u003d self._nb_idl.lsp_get_up(...","commit_id":"7835ea658e34d331ef52a7660bb4c3a4f979b4cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c02f5219a461ec231dfea8af70c424506f3f7e82","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            # Check LSP status. The port can be switched to DOWN before calling"},{"line_number":304,"context_line":"            # this method."},{"line_number":305,"context_line":"            if not self._nb_idl.lsp_get_up(db_port.id).execute("},{"line_number":306,"context_line":"                    check_error\u003dTrue):"},{"line_number":307,"context_line":"                LOG.warning(\u0027Logical_Switch_Port %s host information not \u0027"},{"line_number":308,"context_line":"                            \u0027updated, the port state is down\u0027)"},{"line_number":309,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"e54096a7_55cc763e","line":306,"in_reply_to":"b46e1814_747f2ef3","updated":"2024-11-05 10:45:52.000000000","message":"Done","commit_id":"7835ea658e34d331ef52a7660bb4c3a4f979b4cc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f4b206fc59131a27bc94b833e0a4eba3d9e8033d","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            # NOTE(ralonsoh): OVN subports don\u0027t have host ID information."},{"line_number":300,"context_line":"            return"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if up:"},{"line_number":303,"context_line":"            if not db_port.port_bindings:"},{"line_number":304,"context_line":"                return"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"989600b7_90fb2df4","side":"PARENT","line":302,"updated":"2024-11-05 14:58:09.000000000","message":"You could probably do the check once before the main block:\n\n```\nif bool(up) !\u003d bool(port_up):\n    LOG.warning(\u0027Discrepancy!\u0027)\n    return\n\nif up:\n    ...\nelse:\n    ... \n```","commit_id":"9bd0b21a370de96dfd6601c002a56168d6bdfbe5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b36cc25c86d3e2610fa7bf2ff79941c318d3ccb5","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            # NOTE(ralonsoh): OVN subports don\u0027t have host ID information."},{"line_number":300,"context_line":"            return"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        if up:"},{"line_number":303,"context_line":"            if not db_port.port_bindings:"},{"line_number":304,"context_line":"                return"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a5fb2e08_f559093e","side":"PARENT","line":302,"in_reply_to":"989600b7_90fb2df4","updated":"2024-11-05 15:07:18.000000000","message":"I\u0027ll do it in a follow-up patch.","commit_id":"9bd0b21a370de96dfd6601c002a56168d6bdfbe5"}]}