)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0665a8ef265192145d883f2d80a370e0d4b6e3c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4395d737_901d5567","updated":"2024-11-06 11:23:38.000000000","message":"-1 just for visibility","commit_id":"81df1dbd2b78662be84a6f85fb3c9a66c578514a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"aa065523cbffcbc53477055e08c88e3c28d726a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75baa3f8_44a86821","updated":"2024-11-06 14:01:19.000000000","message":"Waiting for the backport up to 2023.1","commit_id":"81df1dbd2b78662be84a6f85fb3c9a66c578514a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2ca45e100c832122de213345f4f435a7e19e878d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51c573a7_02ccee91","updated":"2024-11-06 21:16:25.000000000","message":"recheck","commit_id":"65727c0fba03a914a7d409bce4c0b881dd6a091f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9287d5ca2dbf0b4cbb011d8ecb915356bb6d5d09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bf93ca25_d6ca603d","updated":"2024-11-08 12:28:27.000000000","message":"recheck\njob: neutron-ovn-tempest-ipv6-only-ovs-release\ntest: tearDownClass (tempest.serial_tests.scenario.test_aggregates_basic_ops.TestAggregatesBasicOps)","commit_id":"d8884a99e03533533f7bacef598e9a6af592e3fa"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7561adee4a83841bf0fdb59dbea3b0babdd9f702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"35b8e19f_795d0c2d","updated":"2024-11-07 22:04:37.000000000","message":"recheck openstack-tox-py39 no logs","commit_id":"d8884a99e03533533f7bacef598e9a6af592e3fa"}],"neutron/agent/ovn/metadata/agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0665a8ef265192145d883f2d80a370e0d4b6e3c3","unresolved":true,"context_lines":[{"line_number":72,"context_line":"def _match_only_if_additional_chassis_is_supported(f):"},{"line_number":73,"context_line":"    @functools.wraps(f)"},{"line_number":74,"context_line":"    def wrapped(self, row, old):"},{"line_number":75,"context_line":"        if not hasattr(row, \u0027additional_chassis\u0027):"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        return f(self, row, old)"},{"line_number":78,"context_line":"    return wrapped"}],"source_content_type":"text/x-python","patch_set":1,"id":"bdd60301_77081a58","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":22},"updated":"2024-11-06 11:23:38.000000000","message":"But we have an event lock when retrieving the sb_idl [1]. That should wait until the IDL is initialized. In what case this is not happening?\n\n[1]https://github.com/openstack/neutron/blob/a145e3ad59c37ec98e4217cd994a0a335144beaf/neutron/agent/ovn/metadata/agent.py#L386-L389","commit_id":"81df1dbd2b78662be84a6f85fb3c9a66c578514a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e301058a40c7086b6a6166e5a0055511cf92954e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def _match_only_if_additional_chassis_is_supported(f):"},{"line_number":73,"context_line":"    @functools.wraps(f)"},{"line_number":74,"context_line":"    def wrapped(self, row, old):"},{"line_number":75,"context_line":"        if not hasattr(row, \u0027additional_chassis\u0027):"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        return f(self, row, old)"},{"line_number":78,"context_line":"    return wrapped"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0a30e7d_3e4f6d44","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":22},"in_reply_to":"7db1ddf6_526f7dda","updated":"2024-11-06 14:01:05.000000000","message":"Right, the event handler notify method is called during the IDL init method. That means we can\u0027t call sb_idl in a event match method because the IDL object could not be instantiated yet.","commit_id":"81df1dbd2b78662be84a6f85fb3c9a66c578514a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6a107f7371686518bb13ae46fd8943e19b8a358e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"def _match_only_if_additional_chassis_is_supported(f):"},{"line_number":73,"context_line":"    @functools.wraps(f)"},{"line_number":74,"context_line":"    def wrapped(self, row, old):"},{"line_number":75,"context_line":"        if not hasattr(row, \u0027additional_chassis\u0027):"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        return f(self, row, old)"},{"line_number":78,"context_line":"    return wrapped"}],"source_content_type":"text/x-python","patch_set":1,"id":"7db1ddf6_526f7dda","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":22},"in_reply_to":"bdd60301_77081a58","updated":"2024-11-06 13:37:46.000000000","message":"In case this event comes in before the lock is set right after the IDL is instantiated - between the lines https://github.com/openstack/neutron/blob/a145e3ad59c37ec98e4217cd994a0a335144beaf/neutron/agent/ovn/metadata/agent.py#L458\n\nThat line you pasted is exactly where it\u0027s gonna hang indefinitely","commit_id":"81df1dbd2b78662be84a6f85fb3c9a66c578514a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7d7933af3e863dd3a336c7f58f0401ae1839a822","unresolved":true,"context_lines":[{"line_number":72,"context_line":"def _match_only_if_additional_chassis_is_supported(f):"},{"line_number":73,"context_line":"    @functools.wraps(f)"},{"line_number":74,"context_line":"    def wrapped(self, row, old):"},{"line_number":75,"context_line":"        if not ovn_utils.is_additional_chassis_supported(self.agent.sb_idl):"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        return f(self, row, old)"},{"line_number":78,"context_line":"    return wrapped"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f44d9bf_7195a90c","side":"PARENT","line":75,"updated":"2024-11-07 00:19:29.000000000","message":"the plan was to - eventually - drop is_additional_chassis_supported once we require ovn 22.09+. There\u0027s an appropriate todo note where the check function is defined, so we won\u0027t forget about it. Should we add a similar todo here to clean up later?","commit_id":"a145e3ad59c37ec98e4217cd994a0a335144beaf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"68d00a4686f84c73e526131bb00e9448ba7b65ff","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def _match_only_if_additional_chassis_is_supported(f):"},{"line_number":73,"context_line":"    @functools.wraps(f)"},{"line_number":74,"context_line":"    def wrapped(self, row, old):"},{"line_number":75,"context_line":"        if not ovn_utils.is_additional_chassis_supported(self.agent.sb_idl):"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        return f(self, row, old)"},{"line_number":78,"context_line":"    return wrapped"}],"source_content_type":"text/x-python","patch_set":4,"id":"a71a847c_c79ed36d","side":"PARENT","line":75,"in_reply_to":"2f44d9bf_7195a90c","updated":"2024-11-07 13:23:06.000000000","message":"Done","commit_id":"a145e3ad59c37ec98e4217cd994a0a335144beaf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e92fd870f943246eac3e446b5460716ba9e3420","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    return wrapped"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# TODO(jlibosva): Remove the decorator after we depend on OVN version that has"},{"line_number":73,"context_line":"# the schema containing the additional_chassis column"},{"line_number":74,"context_line":"def _match_only_if_additional_chassis_is_supported(f):"},{"line_number":75,"context_line":"    @functools.wraps(f)"}],"source_content_type":"text/x-python","patch_set":6,"id":"07f0536f_f6d34baf","line":72,"range":{"start_line":72,"start_character":58,"end_line":72,"end_character":69},"updated":"2024-11-07 14:59:53.000000000","message":"...which is 22.09+ btw","commit_id":"d8884a99e03533533f7bacef598e9a6af592e3fa"}]}