)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"696e2fe58d0481abf674744a5d5072111bb37183","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f795569_90489f7b","updated":"2024-11-07 19:03:23.000000000","message":"Part of quality hardening effort.","commit_id":"a6392b56fd47b0d66afd458fc37c757ab809a3cf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"003fc9ce9de8260d2ccd477f7b6bd5543367b6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34985207_8c65c667","updated":"2024-11-07 21:59:24.000000000","message":"recheck unrelated test failure","commit_id":"a6392b56fd47b0d66afd458fc37c757ab809a3cf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"78fb73bebf61422c4820f7089050b3aa8fdbcb77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dcf7dcd5_35dceae5","updated":"2024-11-06 21:24:44.000000000","message":"recheck unrelated test failure","commit_id":"a6392b56fd47b0d66afd458fc37c757ab809a3cf"}],"neutron/cmd/ovn/neutron_ovn_db_sync_util.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54f395fba8c68e6a5925b68ba137671ce15d6fb5","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        ovn_api \u003d impl_idl_ovn.OvsdbNbOvnIdl.from_worker(mech_worker)"},{"line_number":217,"context_line":"    except RuntimeError:"},{"line_number":218,"context_line":"        LOG.error(\u0027Invalid --ovn-ovn_nb_connection parameter provided.\u0027)"},{"line_number":219,"context_line":"        invalid_nb_sb_api \u003d True"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    try:"},{"line_number":222,"context_line":"        ovn_sb_api \u003d impl_idl_ovn.OvsdbSbOvnIdl.from_worker(mech_worker)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb778c14_4ba3ac01","line":219,"updated":"2024-11-05 23:26:44.000000000","message":"confused here. why would we have to proceed and check the other argument if we already know that the first is invalid?..","commit_id":"bef71792b4e3ed7e70956f9191426113d5ffb269"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"387e9269fa2fa7c797dc5eea1d1626b6c6f8628a","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        ovn_api \u003d impl_idl_ovn.OvsdbNbOvnIdl.from_worker(mech_worker)"},{"line_number":217,"context_line":"    except RuntimeError:"},{"line_number":218,"context_line":"        LOG.error(\u0027Invalid --ovn-ovn_nb_connection parameter provided.\u0027)"},{"line_number":219,"context_line":"        invalid_nb_sb_api \u003d True"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    try:"},{"line_number":222,"context_line":"        ovn_sb_api \u003d impl_idl_ovn.OvsdbSbOvnIdl.from_worker(mech_worker)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ea2b0341_91fd3c68","line":219,"in_reply_to":"cb778c14_4ba3ac01","updated":"2024-11-05 23:58:35.000000000","message":"We don\u0027t have to proceed, this was just the easiest way to remove one \u0027return\u0027 and start enforcing the too-many-return-statements check. I can do it a different way.","commit_id":"bef71792b4e3ed7e70956f9191426113d5ffb269"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21e082c58119c44d1553aff9c84a0031a612915a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        ovn_api \u003d impl_idl_ovn.OvsdbNbOvnIdl.from_worker(mech_worker)"},{"line_number":217,"context_line":"    except RuntimeError:"},{"line_number":218,"context_line":"        LOG.error(\u0027Invalid --ovn-ovn_nb_connection parameter provided.\u0027)"},{"line_number":219,"context_line":"        invalid_nb_sb_api \u003d True"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    try:"},{"line_number":222,"context_line":"        ovn_sb_api \u003d impl_idl_ovn.OvsdbSbOvnIdl.from_worker(mech_worker)"}],"source_content_type":"text/x-python","patch_set":1,"id":"63be735b_3ebf4c46","line":219,"in_reply_to":"ea2b0341_91fd3c68","updated":"2024-11-05 23:59:05.000000000","message":"Done","commit_id":"bef71792b4e3ed7e70956f9191426113d5ffb269"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"91ac5aeb0eb7949a98365fd05ac27a0483192194","unresolved":true,"context_lines":[{"line_number":215,"context_line":"        ovn_api \u003d impl_idl_ovn.OvsdbNbOvnIdl.from_worker(mech_worker)"},{"line_number":216,"context_line":"        ovn_sb_api \u003d impl_idl_ovn.OvsdbSbOvnIdl.from_worker(mech_worker)"},{"line_number":217,"context_line":"    except RuntimeError:"},{"line_number":218,"context_line":"        LOG.error(\u0027Invalid --ovn-ovn_nb_connection or --ovn-ovn_sb_connection \u0027"},{"line_number":219,"context_line":"                  \u0027parameter provided.\u0027)"},{"line_number":220,"context_line":"        return"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f2469b98_dd8bdb55","line":218,"updated":"2024-11-06 02:47:32.000000000","message":"This makes it worse: now the user doesn\u0027t know which is the invalid one (they did know it before the change).\n\nI think it\u0027s a worthy check to do, but if it\u0027s not fitting, like in this particular case, we may disable it for just this function (pylint allow to add a comment before the function to achieve it).\n\n---\n\nIf we insist on complying to the pylint check here, I think we should look into splitting this main() function into separate logical pieces. I also find the fact that this tool doesn\u0027t return an error return code on invalid CLI arguments a problem. We should probably not return None but e.g. raise a SystemExit(1) to reflect that an error happened.","commit_id":"d77366740be757d3eef5499dec888540fa211d01"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c38ef0b969368584491b889be5604d0a84c5e7ee","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        ovn_api \u003d impl_idl_ovn.OvsdbNbOvnIdl.from_worker(mech_worker)"},{"line_number":216,"context_line":"        ovn_sb_api \u003d impl_idl_ovn.OvsdbSbOvnIdl.from_worker(mech_worker)"},{"line_number":217,"context_line":"    except RuntimeError:"},{"line_number":218,"context_line":"        LOG.error(\u0027Invalid --ovn-ovn_nb_connection or --ovn-ovn_sb_connection \u0027"},{"line_number":219,"context_line":"                  \u0027parameter provided.\u0027)"},{"line_number":220,"context_line":"        return"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"331a7a14_b81042f5","line":218,"in_reply_to":"f2469b98_dd8bdb55","updated":"2024-11-06 17:14:04.000000000","message":"Just going to remove this part for now","commit_id":"d77366740be757d3eef5499dec888540fa211d01"}],"neutron/plugins/ml2/extensions/dns_integration.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54f395fba8c68e6a5925b68ba137671ce15d6fb5","unresolved":true,"context_lines":[{"line_number":393,"context_line":"            return False"},{"line_number":394,"context_line":"        provider_net \u003d segments[0]"},{"line_number":395,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_LOCAL:"},{"line_number":396,"context_line":"            return True"},{"line_number":397,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_FLAT:"},{"line_number":398,"context_line":"            return False"},{"line_number":399,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_VLAN:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b592970_dd4f34e7","side":"PARENT","line":396,"updated":"2024-11-05 23:26:44.000000000","message":"confused here too","commit_id":"822edc31c8c3235e037605da3c083661f0d2b866"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"387e9269fa2fa7c797dc5eea1d1626b6c6f8628a","unresolved":true,"context_lines":[{"line_number":393,"context_line":"            return False"},{"line_number":394,"context_line":"        provider_net \u003d segments[0]"},{"line_number":395,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_LOCAL:"},{"line_number":396,"context_line":"            return True"},{"line_number":397,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_FLAT:"},{"line_number":398,"context_line":"            return False"},{"line_number":399,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_VLAN:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1884db60_580aa11a","side":"PARENT","line":396,"in_reply_to":"0b592970_dd4f34e7","updated":"2024-11-05 23:58:35.000000000","message":"I was trying to not remove the code and just keep for reference, but since the default action is True I can just remove it. Let me see if I can tweak it a little to still remove the too-many-return-statements pylint warning.","commit_id":"822edc31c8c3235e037605da3c083661f0d2b866"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"21e082c58119c44d1553aff9c84a0031a612915a","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            return False"},{"line_number":394,"context_line":"        provider_net \u003d segments[0]"},{"line_number":395,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_LOCAL:"},{"line_number":396,"context_line":"            return True"},{"line_number":397,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_FLAT:"},{"line_number":398,"context_line":"            return False"},{"line_number":399,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_VLAN:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcb5a1fb_7868e22a","side":"PARENT","line":396,"in_reply_to":"1884db60_580aa11a","updated":"2024-11-05 23:59:05.000000000","message":"Done","commit_id":"822edc31c8c3235e037605da3c083661f0d2b866"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"91ac5aeb0eb7949a98365fd05ac27a0483192194","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        provider_net \u003d segments[0]"},{"line_number":398,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_FLAT:"},{"line_number":399,"context_line":"            dns_needed \u003d False"},{"line_number":400,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_VLAN:"},{"line_number":401,"context_line":"            dns_needed \u003d self._is_vlan_tenant_network(provider_net)"},{"line_number":402,"context_line":"        if provider_net[\u0027network_type\u0027] in ["},{"line_number":403,"context_line":"                lib_const.TYPE_GRE, lib_const.TYPE_VXLAN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0595bafe_02a4ed8c","line":400,"updated":"2024-11-06 02:47:32.000000000","message":"At the very least, these should be `else if`s to make sure they don\u0027t ever overlap. (Of course, having a proper `match` statement here that comes with Python 3.10 would help here... Alas.)","commit_id":"d77366740be757d3eef5499dec888540fa211d01"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c38ef0b969368584491b889be5604d0a84c5e7ee","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        provider_net \u003d segments[0]"},{"line_number":398,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_FLAT:"},{"line_number":399,"context_line":"            dns_needed \u003d False"},{"line_number":400,"context_line":"        if provider_net[\u0027network_type\u0027] \u003d\u003d lib_const.TYPE_VLAN:"},{"line_number":401,"context_line":"            dns_needed \u003d self._is_vlan_tenant_network(provider_net)"},{"line_number":402,"context_line":"        if provider_net[\u0027network_type\u0027] in ["},{"line_number":403,"context_line":"                lib_const.TYPE_GRE, lib_const.TYPE_VXLAN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"2673bbd8_8963ad95","line":400,"in_reply_to":"0595bafe_02a4ed8c","updated":"2024-11-06 17:14:04.000000000","message":"Or we start using switch (aka \u0027match argument\u0027), but it\u0027s only in python 3.10 and later 😞\n\nI\u0027m just going to leave this alone and put the .pylintrc disable back","commit_id":"d77366740be757d3eef5499dec888540fa211d01"}]}