)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0daef422f1541f7c9c01605a33daf596246cd7bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"903b0363_096f8b10","updated":"2024-11-06 17:07:20.000000000","message":"Thanks for the change, seems the pylint cleanup continues :)\n\nI was only able to get to autogen.py on my first pass.\n\nI\u0027m guessing there is some .pylintrc work so these aren\u0027t re-introduced.","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"93f97642d53882b677198427752ad374a2ca2599","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85ec8c77_e75b6d82","updated":"2024-11-06 07:36:27.000000000","message":"This is the best I could do while watching US election this night. I\u0027ll think later if this is worth pursuing. Comments telling this is crap are very much welcome.","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"296f477112f56d23876e1e01e756d3249f375e6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43ac2af0_e86bd98f","updated":"2024-11-07 15:11:39.000000000","message":"Final nits","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b959b8253372483e636aa2476fed73f1e79ab3ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78a62815_90c0d725","updated":"2024-11-07 22:18:52.000000000","message":"A lot of the functional failures are with self.device_exists_with_ips_and_mac() but I\u0027m confused as I don\u0027t see that changing here, and the other change seems to be a child of this?","commit_id":"ba296b60fa0a9fd62fef602fecc9308577188b9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"691d894e0c6cc00cf33d91b834a8d8b554bb4429","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"66f7bf2c_0e612518","in_reply_to":"78a62815_90c0d725","updated":"2024-11-07 22:24:05.000000000","message":"That\u0027s because I messed the return value from the function - it\u0027s supposed to return False when any addresses are not present, but I return bool(set(x)); since x is not empty, it will return True. I will flip it back.","commit_id":"ba296b60fa0a9fd62fef602fecc9308577188b9e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2935c43f109f5bf2b9230588b701291d09fa6ae1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d660086a_5aeb2fd4","updated":"2024-11-19 15:02:01.000000000","message":"recheck quagga","commit_id":"6183792316d0162b4e0c07b3905e4878407b1f80"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0daef422f1541f7c9c01605a33daf596246cd7bf","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"def check_cookie_mask(cookie):"},{"line_number":1438,"context_line":"    cookie \u003d str(cookie)"},{"line_number":1439,"context_line":"    if \u0027/\u0027 not in cookie:"},{"line_number":1440,"context_line":"        return cookie + \u0027/-1\u0027"},{"line_number":1441,"context_line":"    return cookie"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3e2cbf9f_caae1d4b","line":1440,"range":{"start_line":1440,"start_character":8,"end_line":1440,"end_character":29},"updated":"2024-11-06 17:07:20.000000000","message":"nit: i guess this could be:\n\n  cookie +\u003d \u0027/-1\u0027\n\nAnd we just have a single return statement","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"653d5b94b797948bd236bb7b2f5aacf8fc255883","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"def check_cookie_mask(cookie):"},{"line_number":1438,"context_line":"    cookie \u003d str(cookie)"},{"line_number":1439,"context_line":"    if \u0027/\u0027 not in cookie:"},{"line_number":1440,"context_line":"        return cookie + \u0027/-1\u0027"},{"line_number":1441,"context_line":"    return cookie"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"331918e9_ac0fa145","line":1440,"range":{"start_line":1440,"start_character":8,"end_line":1440,"end_character":29},"in_reply_to":"3e2cbf9f_caae1d4b","updated":"2024-11-07 00:54:28.000000000","message":"Done","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"296f477112f56d23876e1e01e756d3249f375e6e","unresolved":true,"context_lines":[{"line_number":248,"context_line":"                                          segment)"},{"line_number":249,"context_line":"            rv \u003d getattr(driver, action)(**action_kwargs)"},{"line_number":250,"context_line":"            if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":251,"context_line":"                return rv"},{"line_number":252,"context_line":"            return True"},{"line_number":253,"context_line":"        except exceptions.Conflict:"},{"line_number":254,"context_line":"            # No need to resync here, the agent will receive the event related"}],"source_content_type":"text/x-python","patch_set":3,"id":"5968fac5_b4845eb7","line":251,"updated":"2024-11-07 15:11:39.000000000","message":"Looking at the above we could actually get rid of the local, as I don\u0027t see rv being used below:\n\nif action \u003d\u003d \u0027get_metadata_bind_interface\u0027:\n    return getattr(driver, action)(**action_kwargs)","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"061985a5bb925f0036a786e73a5f7908d708fef8","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                                          segment)"},{"line_number":249,"context_line":"            rv \u003d getattr(driver, action)(**action_kwargs)"},{"line_number":250,"context_line":"            if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":251,"context_line":"                return rv"},{"line_number":252,"context_line":"            return True"},{"line_number":253,"context_line":"        except exceptions.Conflict:"},{"line_number":254,"context_line":"            # No need to resync here, the agent will receive the event related"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c25b80e_8d8902cd","line":251,"in_reply_to":"5968fac5_b4845eb7","updated":"2024-11-07 16:14:50.000000000","message":"Done","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13b75a79a6fa118825737d091d866a3ec4d378bc","unresolved":true,"context_lines":[{"line_number":247,"context_line":"                                          self.plugin_rpc,"},{"line_number":248,"context_line":"                                          segment)"},{"line_number":249,"context_line":"            if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":250,"context_line":"                return getattr(driver, action)(**action_kwargs)"},{"line_number":251,"context_line":"            return True"},{"line_number":252,"context_line":"        except exceptions.Conflict:"},{"line_number":253,"context_line":"            # No need to resync here, the agent will receive the event related"}],"source_content_type":"text/x-python","patch_set":4,"id":"a2296e97_60d3c369","line":250,"updated":"2024-11-07 16:37:41.000000000","message":"I think I was wrong about this part, should just leave alone based on test failures","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9242ab7d6063cd7ad95cdb00ccb22498bbccfcdb","unresolved":true,"context_lines":[{"line_number":247,"context_line":"                                          self.plugin_rpc,"},{"line_number":248,"context_line":"                                          segment)"},{"line_number":249,"context_line":"            if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":250,"context_line":"                return getattr(driver, action)(**action_kwargs)"},{"line_number":251,"context_line":"            return True"},{"line_number":252,"context_line":"        except exceptions.Conflict:"},{"line_number":253,"context_line":"            # No need to resync here, the agent will receive the event related"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0b3b788_3cbaa20c","line":250,"in_reply_to":"a2296e97_60d3c369","updated":"2024-11-07 18:31:09.000000000","message":"Indeed. The point here is to __call__ an action... I will add a note explaining this.","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54932f6190c77d12bea17e0bac1440beec42ac40","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                          self.plugin_rpc,"},{"line_number":248,"context_line":"                                          segment)"},{"line_number":249,"context_line":"            if action \u003d\u003d \u0027get_metadata_bind_interface\u0027:"},{"line_number":250,"context_line":"                return getattr(driver, action)(**action_kwargs)"},{"line_number":251,"context_line":"            return True"},{"line_number":252,"context_line":"        except exceptions.Conflict:"},{"line_number":253,"context_line":"            # No need to resync here, the agent will receive the event related"}],"source_content_type":"text/x-python","patch_set":4,"id":"798655b5_c81a7749","line":250,"in_reply_to":"b0b3b788_3cbaa20c","updated":"2024-11-07 18:33:30.000000000","message":"Done","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0daef422f1541f7c9c01605a33daf596246cd7bf","unresolved":true,"context_lines":[{"line_number":800,"context_line":"                # processing queue (like events from fullsync) in order to"},{"line_number":801,"context_line":"                # prevent deleted router re-creation"},{"line_number":802,"context_line":"                rp.fetched_and_processed(update.timestamp)"},{"line_number":803,"context_line":"            else:"},{"line_number":804,"context_line":"                self._resync_router(update)"},{"line_number":805,"context_line":"            LOG.info(\"Finished a router delete for %s, update_id %s. \""},{"line_number":806,"context_line":"                     \"Time elapsed: %.3f\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7695000e_393697ea","line":803,"range":{"start_line":803,"start_character":12,"end_line":803,"end_character":17},"updated":"2024-11-06 17:07:20.000000000","message":"is this \u0027else\u0027 required?","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"653d5b94b797948bd236bb7b2f5aacf8fc255883","unresolved":true,"context_lines":[{"line_number":800,"context_line":"                # processing queue (like events from fullsync) in order to"},{"line_number":801,"context_line":"                # prevent deleted router re-creation"},{"line_number":802,"context_line":"                rp.fetched_and_processed(update.timestamp)"},{"line_number":803,"context_line":"            else:"},{"line_number":804,"context_line":"                self._resync_router(update)"},{"line_number":805,"context_line":"            LOG.info(\"Finished a router delete for %s, update_id %s. \""},{"line_number":806,"context_line":"                     \"Time elapsed: %.3f\","}],"source_content_type":"text/x-python","patch_set":1,"id":"e6fb27a6_102d6d73","line":803,"range":{"start_line":803,"start_character":12,"end_line":803,"end_character":17},"in_reply_to":"7695000e_393697ea","updated":"2024-11-07 00:54:28.000000000","message":"Yes? Unless you mean there\u0027s a bug here. If so, I don\u0027t have an opinion.","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"296f477112f56d23876e1e01e756d3249f375e6e","unresolved":false,"context_lines":[{"line_number":800,"context_line":"                # processing queue (like events from fullsync) in order to"},{"line_number":801,"context_line":"                # prevent deleted router re-creation"},{"line_number":802,"context_line":"                rp.fetched_and_processed(update.timestamp)"},{"line_number":803,"context_line":"            else:"},{"line_number":804,"context_line":"                self._resync_router(update)"},{"line_number":805,"context_line":"            LOG.info(\"Finished a router delete for %s, update_id %s. \""},{"line_number":806,"context_line":"                     \"Time elapsed: %.3f\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ef53cb0c_25933c00","line":803,"range":{"start_line":803,"start_character":12,"end_line":803,"end_character":17},"in_reply_to":"e6fb27a6_102d6d73","updated":"2024-11-07 15:11:39.000000000","message":"Sorry, my brain must have been thinking of some of the other changes where you were removing the else, nevermind...","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0daef422f1541f7c9c01605a33daf596246cd7bf","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        \"\"\"this method is normally called before the ha_router object is fully"},{"line_number":150,"context_line":"        initialized"},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        return self.router.get(\u0027_ha_state\u0027) \u003d\u003d \u0027active\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def initialize(self, process_monitor):"},{"line_number":155,"context_line":"        ha_port \u003d self.router.get(n_consts.HA_INTERFACE_KEY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aabb943_4c3ba505","line":152,"updated":"2024-11-06 17:07:20.000000000","message":"I have this in https://review.opendev.org/c/openstack/neutron/+/934193 if it merges first","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"653d5b94b797948bd236bb7b2f5aacf8fc255883","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\"this method is normally called before the ha_router object is fully"},{"line_number":150,"context_line":"        initialized"},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        return self.router.get(\u0027_ha_state\u0027) \u003d\u003d \u0027active\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def initialize(self, process_monitor):"},{"line_number":155,"context_line":"        ha_port \u003d self.router.get(n_consts.HA_INTERFACE_KEY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb39e056_abcc2a7e","line":152,"in_reply_to":"1aabb943_4c3ba505","updated":"2024-11-07 00:54:28.000000000","message":"Acknowledged","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fd5a35eb9bbd45bb514f3fe9a2e3a3be31fc7b42","unresolved":true,"context_lines":[{"line_number":330,"context_line":"                return False"},{"line_number":331,"context_line":"            conf \u003d manager.get_conf_on_disk()"},{"line_number":332,"context_line":"            managed_by_keepalived \u003d conf and ipv6_lladdr in conf"},{"line_number":333,"context_line":"            if managed_by_keepalived:"},{"line_number":334,"context_line":"                return False"},{"line_number":335,"context_line":"        return True"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d2092e87_72c1d132","line":333,"updated":"2024-11-19 18:09:10.000000000","message":"Super nit: probably don\u0027t need the local variable, but it\u0027s not technically part of the if/else cleanup","commit_id":"6183792316d0162b4e0c07b3905e4878407b1f80"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ac699e36ed511a5d192ec230426c04c48b566b4","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                return False"},{"line_number":331,"context_line":"            conf \u003d manager.get_conf_on_disk()"},{"line_number":332,"context_line":"            managed_by_keepalived \u003d conf and ipv6_lladdr in conf"},{"line_number":333,"context_line":"            if managed_by_keepalived:"},{"line_number":334,"context_line":"                return False"},{"line_number":335,"context_line":"        return True"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"87bc6a7c_47ca80fa","line":333,"in_reply_to":"133f928e_054f14d9","updated":"2024-11-19 21:48:11.000000000","message":"Done","commit_id":"6183792316d0162b4e0c07b3905e4878407b1f80"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aa64e67b81c20ed69d3d585600ed0464ee9bbea7","unresolved":true,"context_lines":[{"line_number":330,"context_line":"                return False"},{"line_number":331,"context_line":"            conf \u003d manager.get_conf_on_disk()"},{"line_number":332,"context_line":"            managed_by_keepalived \u003d conf and ipv6_lladdr in conf"},{"line_number":333,"context_line":"            if managed_by_keepalived:"},{"line_number":334,"context_line":"                return False"},{"line_number":335,"context_line":"        return True"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"133f928e_054f14d9","line":333,"in_reply_to":"d2092e87_72c1d132","updated":"2024-11-19 18:24:52.000000000","message":"I think it may be here to explain what this conditional \"means\".","commit_id":"6183792316d0162b4e0c07b3905e4878407b1f80"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"296f477112f56d23876e1e01e756d3249f375e6e","unresolved":true,"context_lines":[{"line_number":814,"context_line":"        for ip_cidr in ip_cidrs:"},{"line_number":815,"context_line":"            if ip_cidr not in device_ip_cidrs:"},{"line_number":816,"context_line":"                return False"},{"line_number":817,"context_line":"        return True"},{"line_number":818,"context_line":"    except RuntimeError:"},{"line_number":819,"context_line":"        return False"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"e3a03767_9ec79aa4","line":817,"updated":"2024-11-07 15:11:39.000000000","message":"Another place where \u0027return True\u0027 should maybe be the last line of the function. The whole for() loop can probably be moved since it can\u0027t throw a RuntimeError","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"061985a5bb925f0036a786e73a5f7908d708fef8","unresolved":false,"context_lines":[{"line_number":814,"context_line":"        for ip_cidr in ip_cidrs:"},{"line_number":815,"context_line":"            if ip_cidr not in device_ip_cidrs:"},{"line_number":816,"context_line":"                return False"},{"line_number":817,"context_line":"        return True"},{"line_number":818,"context_line":"    except RuntimeError:"},{"line_number":819,"context_line":"        return False"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ce32d456_bb342752","line":817,"in_reply_to":"e3a03767_9ec79aa4","updated":"2024-11-07 16:14:50.000000000","message":"This actually is just set arithmetics, I\u0027ll drop for loop.","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0daef422f1541f7c9c01605a33daf596246cd7bf","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            agent_utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":176,"context_line":"                                privsep_exec\u003dTrue)"},{"line_number":177,"context_line":"            return True"},{"line_number":178,"context_line":"        except RuntimeError as e:"},{"line_number":179,"context_line":"            LOG.debug(\"Exception while checking supported feature via \""},{"line_number":180,"context_line":"                      \"command %s. Exception: %s\", full_args, e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7fe2ba94_c600dc58","line":177,"updated":"2024-11-06 17:07:20.000000000","message":"nit: maybe just leave this on L186, but without the else of course ?","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"653d5b94b797948bd236bb7b2f5aacf8fc255883","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            agent_utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":176,"context_line":"                                privsep_exec\u003dTrue)"},{"line_number":177,"context_line":"            return True"},{"line_number":178,"context_line":"        except RuntimeError as e:"},{"line_number":179,"context_line":"            LOG.debug(\"Exception while checking supported feature via \""},{"line_number":180,"context_line":"                      \"command %s. Exception: %s\", full_args, e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f61ad6d0_ef2b99b1","line":177,"in_reply_to":"7fe2ba94_c600dc58","updated":"2024-11-07 00:54:28.000000000","message":"Done","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"}],"neutron/db/dns_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0daef422f1541f7c9c01605a33daf596246cd7bf","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                context, floatingip_data))"},{"line_number":136,"context_line":"        if dns_data_db:"},{"line_number":137,"context_line":"            if not (dns_data_db[\u0027published_dns_name\u0027] !\u003d current_dns_name or"},{"line_number":138,"context_line":"                    dns_data_db[\u0027published_dns_domain\u0027] !\u003d current_dns_domain):"},{"line_number":139,"context_line":"                return"},{"line_number":140,"context_line":"            dns_actions_data \u003d DNSActionsData("},{"line_number":141,"context_line":"                previous_dns_name\u003ddns_data_db[\u0027published_dns_name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d66a927_f9dd7d94","line":138,"updated":"2024-11-06 17:07:20.000000000","message":"I had to read this twice with the double-negative, removing the \u0027not\u0027 and using \u003d\u003d with \u0027and\u0027 should have same effect I think","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"653d5b94b797948bd236bb7b2f5aacf8fc255883","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                context, floatingip_data))"},{"line_number":136,"context_line":"        if dns_data_db:"},{"line_number":137,"context_line":"            if not (dns_data_db[\u0027published_dns_name\u0027] !\u003d current_dns_name or"},{"line_number":138,"context_line":"                    dns_data_db[\u0027published_dns_domain\u0027] !\u003d current_dns_domain):"},{"line_number":139,"context_line":"                return"},{"line_number":140,"context_line":"            dns_actions_data \u003d DNSActionsData("},{"line_number":141,"context_line":"                previous_dns_name\u003ddns_data_db[\u0027published_dns_name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0d05465_45df9fc1","line":138,"in_reply_to":"6d66a927_f9dd7d94","updated":"2024-11-07 00:54:28.000000000","message":"Done","commit_id":"3efbb6ead4d2d1f82c41f02b376c4e7754604551"}],"neutron/ipam/utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"296f477112f56d23876e1e01e756d3249f375e6e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    net \u003d netaddr.IPNetwork(cidr)"},{"line_number":24,"context_line":"    # Check that the IP is valid on subnet. In IPv4 this cannot be the"},{"line_number":25,"context_line":"    # network or the broadcast address"},{"line_number":26,"context_line":"    if net.version !\u003d constants.IP_VERSION_6:"},{"line_number":27,"context_line":"        return ip !\u003d net.network and ip !\u003d net.broadcast and ip in net"},{"line_number":28,"context_line":"    # NOTE(njohnston): In some cases the code cannot know the owner of the"},{"line_number":29,"context_line":"    # port. In these cases port_owner should an empty string, and we pass it"}],"source_content_type":"text/x-python","patch_set":3,"id":"177c96c1_05eb7c1e","line":26,"updated":"2024-11-07 15:11:39.000000000","message":"\u003d\u003d IP_VERSION_4 ?","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"061985a5bb925f0036a786e73a5f7908d708fef8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    net \u003d netaddr.IPNetwork(cidr)"},{"line_number":24,"context_line":"    # Check that the IP is valid on subnet. In IPv4 this cannot be the"},{"line_number":25,"context_line":"    # network or the broadcast address"},{"line_number":26,"context_line":"    if net.version !\u003d constants.IP_VERSION_6:"},{"line_number":27,"context_line":"        return ip !\u003d net.network and ip !\u003d net.broadcast and ip in net"},{"line_number":28,"context_line":"    # NOTE(njohnston): In some cases the code cannot know the owner of the"},{"line_number":29,"context_line":"    # port. In these cases port_owner should an empty string, and we pass it"}],"source_content_type":"text/x-python","patch_set":3,"id":"40f430a6_50da7e1d","line":26,"in_reply_to":"177c96c1_05eb7c1e","updated":"2024-11-07 16:14:50.000000000","message":"Done","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"296f477112f56d23876e1e01e756d3249f375e6e","unresolved":true,"context_lines":[{"line_number":2511,"context_line":"        if not ret_val:"},{"line_number":2512,"context_line":"            LOG.debug(\u0027The host %s is not matching for port %s host %s!\u0027,"},{"line_number":2513,"context_line":"                      host, port_id, port_host)"},{"line_number":2514,"context_line":"        return ret_val"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":2517,"context_line":"    def get_ports_from_devices(self, context, devices):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5b67f9_10e3b90c","line":2514,"updated":"2024-11-07 15:11:39.000000000","message":"This can probably be simplified to remove the local ret_val as well, something like:\n\nport_host \u003d db.get_port_binding_host(context, port_id)\nif port_host \u003d\u003d host:\n    return port\nLOG.debug(\u0027The host %s is not matching for port %s host %s!\u0027,\n          host, port_id, port_host)","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"061985a5bb925f0036a786e73a5f7908d708fef8","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"        if not ret_val:"},{"line_number":2512,"context_line":"            LOG.debug(\u0027The host %s is not matching for port %s host %s!\u0027,"},{"line_number":2513,"context_line":"                      host, port_id, port_host)"},{"line_number":2514,"context_line":"        return ret_val"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":2517,"context_line":"    def get_ports_from_devices(self, context, devices):"}],"source_content_type":"text/x-python","patch_set":3,"id":"b982325f_ad5d2e3a","line":2514,"in_reply_to":"ba5b67f9_10e3b90c","updated":"2024-11-07 16:14:50.000000000","message":"Wow I just read the code and it\u0027s horrible indeed.","commit_id":"7cdcdaa1daf6816758ebd9cf6b917811368fe15c"}]}