)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8b5a8813c4895da669c047e55bb4420294d03dc4","unresolved":true,"context_lines":[{"line_number":803,"context_line":""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"def device_exists_with_ips_and_mac(device_name, ip_cidrs,"},{"line_number":806,"context_line":"                                   mac, namespace\u003dNone) -\u003e bool:"},{"line_number":807,"context_line":"    \"\"\"Return True if the device with the given IP addresses and MAC address"},{"line_number":808,"context_line":"    exists in the namespace."},{"line_number":809,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"a4b53153_2389919d","side":"PARENT","line":806,"updated":"2024-11-07 16:47:45.000000000","message":"This is called from functional tests, I\u0027m assuming they will go \u003cboom\u003e\n\nneutron/tests/functional/agent/l3/framework.py\nneutron/tests/functional/agent/linux/test_ip_lib.py\nneutron/tests/functional/agent/l3/test_dvr_router.py\nneutron/tests/functional/agent/l3/test_ha_router.py","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"46b3be8f6438a68bba191f1ac73d6362c3bbed8c","unresolved":true,"context_lines":[{"line_number":803,"context_line":""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"def device_exists_with_ips_and_mac(device_name, ip_cidrs,"},{"line_number":806,"context_line":"                                   mac, namespace\u003dNone) -\u003e bool:"},{"line_number":807,"context_line":"    \"\"\"Return True if the device with the given IP addresses and MAC address"},{"line_number":808,"context_line":"    exists in the namespace."},{"line_number":809,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5e6b3d44_a49b8bcf","side":"PARENT","line":806,"in_reply_to":"51e8f1a3_a242684c","updated":"2024-11-07 22:28:10.000000000","message":"oops, that was embarassing. without it, the refactor may not be as nice. i will post it but let me know if you think it\u0027s not worth now.","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"383defeed8e29e137168dad5792a0fe6fa6c58d6","unresolved":false,"context_lines":[{"line_number":803,"context_line":""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"def device_exists_with_ips_and_mac(device_name, ip_cidrs,"},{"line_number":806,"context_line":"                                   mac, namespace\u003dNone) -\u003e bool:"},{"line_number":807,"context_line":"    \"\"\"Return True if the device with the given IP addresses and MAC address"},{"line_number":808,"context_line":"    exists in the namespace."},{"line_number":809,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"08a3539a_114a93d8","side":"PARENT","line":806,"in_reply_to":"5e6b3d44_a49b8bcf","updated":"2024-11-07 22:28:20.000000000","message":"Done","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ac4b18df66d3a442b437f69c7fb6578fb187f429","unresolved":false,"context_lines":[{"line_number":803,"context_line":""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"def device_exists_with_ips_and_mac(device_name, ip_cidrs,"},{"line_number":806,"context_line":"                                   mac, namespace\u003dNone) -\u003e bool:"},{"line_number":807,"context_line":"    \"\"\"Return True if the device with the given IP addresses and MAC address"},{"line_number":808,"context_line":"    exists in the namespace."},{"line_number":809,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"8d2d5b2f_9203924c","side":"PARENT","line":806,"in_reply_to":"6ecdabc8_94bd501f","updated":"2024-11-07 18:24:15.000000000","message":"Done","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1346fcf45c6abf99c4b4ae1ebdec98c38ca63a82","unresolved":true,"context_lines":[{"line_number":803,"context_line":""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"def device_exists_with_ips_and_mac(device_name, ip_cidrs,"},{"line_number":806,"context_line":"                                   mac, namespace\u003dNone) -\u003e bool:"},{"line_number":807,"context_line":"    \"\"\"Return True if the device with the given IP addresses and MAC address"},{"line_number":808,"context_line":"    exists in the namespace."},{"line_number":809,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"51e8f1a3_a242684c","side":"PARENT","line":806,"in_reply_to":"8d2d5b2f_9203924c","updated":"2024-11-07 22:04:22.000000000","message":"There is a function with the same name in l3/framework.py, but there are other cases calling this directly.\n\nneutron/tests/functional/agent/l3/test_dvr_router.py\n\nfrom neutron.agent.linux import ip_lib\n\n        def check_fg_port_created(device_name, ip_cidrs, mac, namespace):\n            success \u003d ip_lib.device_exists_with_ips_and_mac(\n                device_name, ip_cidrs, mac, namespace\u003dnamespace)","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e29058c038acdce615f66a698d06bf67ae144254","unresolved":true,"context_lines":[{"line_number":803,"context_line":""},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"def device_exists_with_ips_and_mac(device_name, ip_cidrs,"},{"line_number":806,"context_line":"                                   mac, namespace\u003dNone) -\u003e bool:"},{"line_number":807,"context_line":"    \"\"\"Return True if the device with the given IP addresses and MAC address"},{"line_number":808,"context_line":"    exists in the namespace."},{"line_number":809,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"6ecdabc8_94bd501f","side":"PARENT","line":806,"in_reply_to":"a4b53153_2389919d","updated":"2024-11-07 18:24:07.000000000","message":"No it\u0027s not. It\u0027s the same name but different function. I also was confused. 😊","commit_id":"0e134fc352d98432ffb4211bd2e238a715e50b0e"}]}