)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2cb3ec4043e08c05c52cdbc34f37286489f5ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"03641262_19fb4866","updated":"2024-11-18 17:58:20.000000000","message":"I\u0027m fine with the functional test change, just a question on tox.ini","commit_id":"882cbedc9a831203213cd8adaabee48769444b97"}],"tox.ini":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2cb3ec4043e08c05c52cdbc34f37286489f5ccd","unresolved":true,"context_lines":[{"line_number":8,"context_line":"description \u003d"},{"line_number":9,"context_line":"    Run unit tests."},{"line_number":10,"context_line":"basepython \u003d {env:TOX_PYTHON:python3}"},{"line_number":11,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"         OS_LOG_CAPTURE\u003d{env:OS_LOG_CAPTURE:true}"},{"line_number":13,"context_line":"         OS_STDOUT_CAPTURE\u003d{env:OS_STDOUT_CAPTURE:true}"},{"line_number":14,"context_line":"         OS_STDERR_CAPTURE\u003d{env:OS_STDERR_CAPTURE:true}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5495ffbc_40751c7f","side":"PARENT","line":11,"updated":"2024-11-18 17:58:20.000000000","message":"I\u0027m torn on this since it doesn\u0027t really affect anything, and every other project is still doing it regardless of it being used. Shouldn\u0027t need to move OS_LOG_CAPTURE up a line I think ?","commit_id":"09633b700889a5f0257f6ed4c297e8b375991891"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"71e1fc4d495bd9951a7766dec4ab84b602224716","unresolved":true,"context_lines":[{"line_number":8,"context_line":"description \u003d"},{"line_number":9,"context_line":"    Run unit tests."},{"line_number":10,"context_line":"basepython \u003d {env:TOX_PYTHON:python3}"},{"line_number":11,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"         OS_LOG_CAPTURE\u003d{env:OS_LOG_CAPTURE:true}"},{"line_number":13,"context_line":"         OS_STDOUT_CAPTURE\u003d{env:OS_STDOUT_CAPTURE:true}"},{"line_number":14,"context_line":"         OS_STDERR_CAPTURE\u003d{env:OS_STDERR_CAPTURE:true}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"8409e3b7_91576d6b","side":"PARENT","line":11,"in_reply_to":"5495ffbc_40751c7f","updated":"2024-11-18 18:20:11.000000000","message":"Every other project like nova, cinder, glance? Keystone doesn\u0027t use it. I will revert this change, though it\u0027s not used anywhere. AFAIU only nova has a script that reads the variable, others just adopted the variable since ~2013 but never cleaned it up.","commit_id":"09633b700889a5f0257f6ed4c297e8b375991891"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6d2ffcd45eefa4410dc14c3412f00b31a9ddf04b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"description \u003d"},{"line_number":9,"context_line":"    Run unit tests."},{"line_number":10,"context_line":"basepython \u003d {env:TOX_PYTHON:python3}"},{"line_number":11,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"         OS_LOG_CAPTURE\u003d{env:OS_LOG_CAPTURE:true}"},{"line_number":13,"context_line":"         OS_STDOUT_CAPTURE\u003d{env:OS_STDOUT_CAPTURE:true}"},{"line_number":14,"context_line":"         OS_STDERR_CAPTURE\u003d{env:OS_STDERR_CAPTURE:true}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"a87fb3f4_2c873390","side":"PARENT","line":11,"in_reply_to":"8409e3b7_91576d6b","updated":"2024-11-18 18:20:47.000000000","message":"Done","commit_id":"09633b700889a5f0257f6ed4c297e8b375991891"}]}