)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3012e9cbf22f85497ad4275035b1f3c15a3a0370","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3ad1bef_24427ce6","updated":"2024-12-10 01:49:26.000000000","message":"Since the test case of DVR migrations in this commit\nhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318\nhad passed many times. So I think this is ready to go.","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"adbec70866323c1b01a232c10ba9a1ffb0ebb2ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81a02332_df71b935","updated":"2024-11-27 10:10:39.000000000","message":"check experimental","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5734385ebc2faba05f7f162944bbdb513c3b795a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73b1a764_a1b101e4","updated":"2024-11-27 10:07:38.000000000","message":"recheck experimental","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3c47391ab638f9c7ceba3d0ed99ca47ab5b1d6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f78ba2c5_9e3e511c","in_reply_to":"3d5d8de8_711b08d7","updated":"2024-12-02 16:17:00.000000000","message":"Originally I thought there might be something in the irrelevant-files section of the yaml not triggering the test, but it looks correct. Maybe reach out to Yatin as he might be able to help with CI","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"27b0fa1eca923f5e37472a5de296b49763a50520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d5d8de8_711b08d7","in_reply_to":"81a02332_df71b935","updated":"2024-11-28 00:52:04.000000000","message":"Why this check has no jobs of \"neutron-tempest-plugin-dvr-multinode-scenario\"?","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d883cd09d032df63c1b98b9e15d07a0ae8948b7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd234e5a_f39cd475","in_reply_to":"f78ba2c5_9e3e511c","updated":"2024-12-03 00:58:08.000000000","message":"Yes, the job has something wrong, I update the zuul yaml in this patch: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e5383dbfe27488ad39df9d284ffc51797848a22c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44750279_9bad7a3e","updated":"2024-12-20 00:52:35.000000000","message":"recheck","commit_id":"6fc0e3f86fb7ed321d5c4e58532c7023e6fd0d5a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c28ae6137ba02524a57b88e98947a5dfc90c6c6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0dad67bd_50d6f166","updated":"2024-12-26 16:54:27.000000000","message":"This did not get two +2\u0027s from reviewers, please don\u0027t approve patches without them.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fe431662470a7f0f40f35577472e46fc3042dcfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d703b6fd_e3f9defe","updated":"2025-01-15 08:56:15.000000000","message":"This patch deserves a release note and some explanations, apart from the comments in-line.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fec70fb4cbc885a08634bb692a06faf8ca053aef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f4a9b92_5b72adbb","in_reply_to":"0dad67bd_50d6f166","updated":"2024-12-27 07:59:44.000000000","message":"Hi Brian, since the follow-up patches got +2s, so I think this should be ready to go.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e339a5646de48abdd174bd8cb04f133034ce2e7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e75a40f5_d6fcc1c9","in_reply_to":"48a3b47a_ffd75a23","updated":"2025-01-06 08:22:54.000000000","message":"There are still reviewers and committers for OVS backend, but be patient as the last few weeks were the year holiday season, so most of the people just coming back to work","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6f859ae75b3e17f857f8097b49050cee6d6cd9ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48a3b47a_ffd75a23","in_reply_to":"9f4a9b92_5b72adbb","updated":"2024-12-27 08:10:36.000000000","message":"Hi Brain, once again about the Neutron code merge workflow or progress. If Redhat guys are not mainly focused on the ml2/ovs related works, so in order make the project more active in ml2/ovs like making the fixes get merged quickly, pushing the new features move on iteratively, what should we do for changing such situation? Since there are 8/11 of cores from Redhat, if no activities on these reviews, some fixes or features will stand there for monthes or years. What do you think? Thank you.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1bd13cb7d439fc9af2ec74afe3446f61d5c6d2aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a0411eb7_a9c5d384","in_reply_to":"d703b6fd_e3f9defe","updated":"2025-02-02 11:02:23.000000000","message":"Sorry for the late reply, it\u0027s the Chinese Spring Festival holiday recently.I will upload it soon.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1ddb355e0c4876993c7814e9d8b0dc998fa641c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"24e0b851_3e67a08f","in_reply_to":"e75a40f5_d6fcc1c9","updated":"2025-01-10 21:31:58.000000000","message":"Hi Liu,\n\nYou still have to get the +2\u0027s on the patch. Around the end of the year most of the other cores are not working for the Christmas/New Year holidays, but we do eventually get back to reviews.\n\nI have put this patch series on the meeting wiki since the last time you asked, and try to have others review (thanks Lajos!) but people forget. The best thing to do would be to ping people on IRC when they are online, which I know is an issue with the timezones.\n\nSo one question to you - is there anyone in your timezone (or company) that wants to start contributing more, and potentially become a core reviewer? That would be a great way to get more eyes on these changes and move them along quicker.\n\nI know Rodolfo had some concerns about this change, I will have him comment here so they can be addressed, I do not know what they were as I was out.\n\n-Brian","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"}],"neutron/agent/resource_cache.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d39fa425ce5f08a2edbe2eda2b6d6d720ffb611","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                self._satisfied_server_queries.remove(i)"},{"line_number":210,"context_line":"            except KeyError:"},{"line_number":211,"context_line":"                continue"},{"line_number":212,"context_line":"        LOG.info(\"Remove resource cache for resource %s: %s\","},{"line_number":213,"context_line":"                 rtype, resource_id)"},{"line_number":214,"context_line":"        self._type_cache(rtype).pop(resource_id, None)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b8aa772d_74efdd29","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":16},"updated":"2024-12-06 13:25:15.000000000","message":"nit: debug perhaps enough here","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f1eae3d68f2d2436280b325883b54603980cea56","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                self._satisfied_server_queries.remove(i)"},{"line_number":210,"context_line":"            except KeyError:"},{"line_number":211,"context_line":"                continue"},{"line_number":212,"context_line":"        LOG.info(\"Remove resource cache for resource %s: %s\","},{"line_number":213,"context_line":"                 rtype, resource_id)"},{"line_number":214,"context_line":"        self._type_cache(rtype).pop(resource_id, None)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"991c942b_9f16ad1c","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":16},"in_reply_to":"756adb28_1cb8971e","updated":"2024-12-16 02:46:40.000000000","message":"Done","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"93f0adec5b51958ba09c3c50078f201e4c723eac","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                self._satisfied_server_queries.remove(i)"},{"line_number":210,"context_line":"            except KeyError:"},{"line_number":211,"context_line":"                continue"},{"line_number":212,"context_line":"        LOG.info(\"Remove resource cache for resource %s: %s\","},{"line_number":213,"context_line":"                 rtype, resource_id)"},{"line_number":214,"context_line":"        self._type_cache(rtype).pop(resource_id, None)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e851f338_257830d1","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":16},"in_reply_to":"b8aa772d_74efdd29","updated":"2024-12-10 07:57:38.000000000","message":"agree","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f3550733a7c2afe6ee8daf9928d3fa0aaa86e826","unresolved":true,"context_lines":[{"line_number":209,"context_line":"                self._satisfied_server_queries.remove(i)"},{"line_number":210,"context_line":"            except KeyError:"},{"line_number":211,"context_line":"                continue"},{"line_number":212,"context_line":"        LOG.info(\"Remove resource cache for resource %s: %s\","},{"line_number":213,"context_line":"                 rtype, resource_id)"},{"line_number":214,"context_line":"        self._type_cache(rtype).pop(resource_id, None)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"756adb28_1cb8971e","line":212,"range":{"start_line":212,"start_character":12,"end_line":212,"end_character":16},"in_reply_to":"e851f338_257830d1","updated":"2024-12-14 23:41:36.000000000","message":"If we update this think it can merge and un-block some other changes.","commit_id":"b42aef0a157c06c1b925b8bbcde5230fba51e489"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fe431662470a7f0f40f35577472e46fc3042dcfe","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                             resource_id\u003dresource.id,"},{"line_number":203,"context_line":"                             states\u003d(existing, resource)))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def record_resource_remove(self, rtype, resource_id):"},{"line_number":206,"context_line":"        filters \u003d {\u0027id\u0027: (resource_id, )}"},{"line_number":207,"context_line":"        for i in self._get_query_ids(rtype, filters):"},{"line_number":208,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"37db01ab_30ac1121","line":205,"range":{"start_line":205,"start_character":8,"end_line":205,"end_character":30},"updated":"2025-01-15 08:56:15.000000000","message":"What is wrong with the ``record_resource_delete`` method? Why is not used instead of implementing this one?\n\nActually if one of the problems of a delete resource is the pending queries, why don\u0027t add the invalidation of ``_satisfied_server_queries`` to ``record_resource_delete``?","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1bd13cb7d439fc9af2ec74afe3446f61d5c6d2aa","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                             resource_id\u003dresource.id,"},{"line_number":203,"context_line":"                             states\u003d(existing, resource)))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def record_resource_remove(self, rtype, resource_id):"},{"line_number":206,"context_line":"        filters \u003d {\u0027id\u0027: (resource_id, )}"},{"line_number":207,"context_line":"        for i in self._get_query_ids(rtype, filters):"},{"line_number":208,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f1a4de8_bbed13b0","line":205,"range":{"start_line":205,"start_character":8,"end_line":205,"end_character":30},"in_reply_to":"37db01ab_30ac1121","updated":"2025-02-02 11:02:23.000000000","message":"``record_resource_delete`` is for PORT delete event, it is not the same work of port unplug. And if call ``record_resource_delete``， it may come into a loop call, because a port AFTER_DELETE event will publish again.\n\nFor you sencond question, I do not get the real point of it. For my understanding ``_satisfied_server_queries `` is used to avoid same cache query to neutron-server. But here we need to remove the check to make sure the agent must get the port information from neutron-server next time, so we remove query ids from ``_satisfied_server_queries``.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fe431662470a7f0f40f35577472e46fc3042dcfe","unresolved":true,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"        self._deferred_delete_direct_flows(self.deleted_ports)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"        rcache_rpc \u003d self.plugin_rpc.remote_resource_cache"},{"line_number":777,"context_line":"        while self.deleted_ports:"},{"line_number":778,"context_line":"            port_id \u003d self.deleted_ports.pop()"},{"line_number":779,"context_line":"            port \u003d self.int_br.get_vif_port_by_id(port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e85c1b65_82572a54","line":776,"range":{"start_line":776,"start_character":8,"end_line":776,"end_character":58},"updated":"2025-01-15 08:56:15.000000000","message":"Worth mentioning that we reach this method, ``process_deleted_ports``, because we see how the port is deleted from OVS. That doesn\u0027t mean the port has been deleted from the Neutron DB (thus we haven\u0027t received yet a resource deletion event).","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1bd13cb7d439fc9af2ec74afe3446f61d5c6d2aa","unresolved":true,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"        self._deferred_delete_direct_flows(self.deleted_ports)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"        rcache_rpc \u003d self.plugin_rpc.remote_resource_cache"},{"line_number":777,"context_line":"        while self.deleted_ports:"},{"line_number":778,"context_line":"            port_id \u003d self.deleted_ports.pop()"},{"line_number":779,"context_line":"            port \u003d self.int_br.get_vif_port_by_id(port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"377693c1_4b2390a5","line":776,"range":{"start_line":776,"start_character":8,"end_line":776,"end_character":58},"in_reply_to":"e85c1b65_82572a54","updated":"2025-02-02 11:02:23.000000000","message":"Yes, then we remove the resource cache to ensure that next time the port pluged again the agent can retrieve the right information.","commit_id":"6f06d8fa6684b6cbd41502163acaffc17f98cc8c"}]}