)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7ff0b5163b00b6e96fa0f0679b45462887f4cb62","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 07:54:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2639ff6432a13320adcadbcc0841319a99ce8c24"},{"line_number":10,"context_line":"Closes-Bug: #1318261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_0a541cc8","line":7,"updated":"2014-05-19 21:36:09.000000000","message":"Vivek, can you put more information from the bug in the commit message so it\u0027s more obvious what the change is for?","commit_id":"639a8d706e719636b9e7234cfb55adb5af9ea530"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"22d85faa8bb1ce97d16c6d1791954ad8b3c796df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 07:54:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2639ff6432a13320adcadbcc0841319a99ce8c24"},{"line_number":10,"context_line":"Closes-Bug: #1318261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_ab47754a","line":7,"in_reply_to":"7adec928_08ddcf42","updated":"2014-05-21 15:36:06.000000000","message":"I agree with Carl and Brian, please update the commit message so it\u0027s easier to understand for reviewers and for people looking at commit history.","commit_id":"639a8d706e719636b9e7234cfb55adb5af9ea530"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"0e144314b34d7bb3097878f6eb41f7298b900606","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 07:54:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2639ff6432a13320adcadbcc0841319a99ce8c24"},{"line_number":10,"context_line":"Closes-Bug: #1318261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_f65b5951","line":7,"in_reply_to":"7adec928_0a541cc8","updated":"2014-05-20 02:20:44.000000000","message":"When tunnel ports to a specific node are cleaned up on other cloud nodes because of unavailability of VMs on that specific node, the rules in table 0 of br-tun on other cloud nodes continue to still carry the stale (or unavailable TEP) tunnel port ofnumber as in_port\u003d in the rules.\r\n\r\nNext time, I will ensure more info is added to the commit msg for every bug I commit.","commit_id":"639a8d706e719636b9e7234cfb55adb5af9ea530"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e45852ff5c789f512bf271a2e9d7d0ae68e31c69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-16 07:54:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2639ff6432a13320adcadbcc0841319a99ce8c24"},{"line_number":10,"context_line":"Closes-Bug: #1318261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_08ddcf42","line":7,"in_reply_to":"7adec928_f65b5951","updated":"2014-05-21 15:19:54.000000000","message":"+1 for adding a little more information to the commit message.\n\nThe commit message, as it is, seems to be missing the context needed to understand what it is all about.","commit_id":"639a8d706e719636b9e7234cfb55adb5af9ea530"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f43218adefe2e8957615a6d8d47fdda5bb571e42","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-21 10:05:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When l2-pop is turned ON, the tunnels towards a"},{"line_number":10,"context_line":"specific node are created and torn down by other nodes,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_0c887ce6","line":7,"updated":"2014-05-21 18:44:32.000000000","message":"Just a final nit on this first line, perhaps:\n\n\"When l2-pop is ON, clean up ports from table 0 of br-tun\"","commit_id":"92d3183836d322651a57e2859b4e519589129389"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"3ebec93d41c392779c38962e2ba9ef0ce1c2efdc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-21 10:05:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When l2-pop is turned ON, the tunnels towards a"},{"line_number":10,"context_line":"specific node are created and torn down by other nodes,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_73e2b804","line":7,"in_reply_to":"7adec928_0c887ce6","updated":"2014-05-21 23:42:16.000000000","message":"A minor variation:\r\nWhen l2-pop ON, cleaned up ports remain in table 0 of br-tun.\r\n\r\nIs this OK?","commit_id":"92d3183836d322651a57e2859b4e519589129389"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"b1a824aa1fe0a76f8aab6a3a5ce840e1f3051004","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vivekanandan Narasimhan \u003cvivekanandan.narasimhan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-21 10:05:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2-pop on, cleaned up ports come in br-tun table 0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When l2-pop is turned ON, the tunnels towards a"},{"line_number":10,"context_line":"specific node are created and torn down by other nodes,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_7649c68a","line":7,"in_reply_to":"7adec928_73e2b804","updated":"2014-05-22 00:44:09.000000000","message":"The one i posted states the problem and not the fix.  So here is updated:\r\n\r\nWhen l2-pop ON, remove stale ports from table 0 of br-tun\r\n\r\nPlease let me know if this looks ok?","commit_id":"92d3183836d322651a57e2859b4e519589129389"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eb8906e0f555e8785736c53dd254fecd6f815d47","unresolved":false,"context_lines":[{"line_number":17,"context_line":"number is not used in any of the OVS rules in the OVS"},{"line_number":18,"context_line":"bridges (just br-tun at this point of time)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This fix ensures to clean up only those OVS rules"},{"line_number":21,"context_line":"in br-tun, that still continue to use removed tunnel port"},{"line_number":22,"context_line":"OFPORT numbers. Specifically, this fix removes rules"},{"line_number":23,"context_line":"with \u0027in_port\u003d\u003cremoved tunnel port\u003e\u0027 in br-tun table 0,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7adec928_197995fc","line":20,"updated":"2014-05-22 01:41:24.000000000","message":"I appreciate that you went in great detail here, this was helpful; at the same time I felt like such a short fix (we all love those ;) didn\u0027t really need such a long commit message.\n\nI would suggest to trim this message to a point where it\u0027s clear what the issue is (explosion of flows due to proper lack of cleanup), and the way this has been addressed (adding clean-up logic).\n\nI would then refer more details (such as steps for reproducing the observed behavior, plugins affected, system requirements, relevant pastes of info, etc) in the LP bug report.","commit_id":"94de450d799f9c31ce2ddfdb591769c97190a650"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"95d3265b32c37c5771d8d343b786cb1580403683","unresolved":false,"context_lines":[{"line_number":12,"context_line":"specific networks. This generally reclaims the resources"},{"line_number":13,"context_line":"used for such tunnels in all the nodes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"When l2-pop is turned ON, the tunnels towards a"},{"line_number":16,"context_line":"specific node are created and torn down by other nodes,"},{"line_number":17,"context_line":"based on availability of ports on that specific node in"},{"line_number":18,"context_line":"specific networks. This generally reclaims the resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_67e519a3","line":15,"updated":"2014-06-12 06:15:56.000000000","message":"Probably a typo..can remove this paragraph","commit_id":"b053fc0743b6de9d5a060cfea4667f86f672cbcf"}],"neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py":[{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"f7834ee73294455c457d5cba19629799a2a4b35e","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        with contextlib.nested("},{"line_number":578,"context_line":"            mock.patch.object(self.agent.tun_br, \u0027mod_flow\u0027),"},{"line_number":579,"context_line":"            mock.patch.object(self.agent.tun_br, \u0027delete_flows\u0027),"},{"line_number":580,"context_line":"            mock.patch.object(self.agent, \"cleanup_tunnel_port\")"},{"line_number":581,"context_line":"        ) as (mod_flow_fn, del_flow_fn, cleanup_tun_fn):"},{"line_number":582,"context_line":"            self.agent.fdb_remove(None, fdb_entry)"},{"line_number":583,"context_line":"            del_flow_fn.assert_called_with(table\u003dconstants.UCAST_TO_TUN,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_f1ebd275","line":580,"updated":"2014-05-15 04:57:29.000000000","message":"You don\u0027t test the fix with this change. You are mocking the method you just updated ?","commit_id":"62392423887ca4cc79d7612f9892affb5fb80a96"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"65bb9a22e8062475ee0b27514b49146b60968137","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            self.agent.fdb_remove(None, fdb_entry)"},{"line_number":582,"context_line":"            del_flow_fn.assert_called_with(table\u003dconstants.UCAST_TO_TUN,"},{"line_number":583,"context_line":"                                           dl_vlan\u003d\u0027vlan2\u0027,"},{"line_number":584,"context_line":"                                           dl_dst\u003d\u0027mac\u0027)"},{"line_number":585,"context_line":"            mod_flow_fn.assert_called_with(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":586,"context_line":"                                           dl_vlan\u003d\u0027vlan2\u0027,"},{"line_number":587,"context_line":"                                           actions\u003d\u0027strip_vlan,\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_9c5377e1","side":"PARENT","line":584,"updated":"2014-05-15 20:21:02.000000000","message":"I think this has not to be removed.","commit_id":"ff22dc1a7c3803634288fdd4da66c51a22593c2e"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"319dd79cc06f17fb87a624ed80040880a1999c49","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            self.agent.fdb_remove(None, fdb_entry)"},{"line_number":582,"context_line":"            del_flow_fn.assert_called_with(table\u003dconstants.UCAST_TO_TUN,"},{"line_number":583,"context_line":"                                           dl_vlan\u003d\u0027vlan2\u0027,"},{"line_number":584,"context_line":"                                           dl_dst\u003d\u0027mac\u0027)"},{"line_number":585,"context_line":"            mod_flow_fn.assert_called_with(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":586,"context_line":"                                           dl_vlan\u003d\u0027vlan2\u0027,"},{"line_number":587,"context_line":"                                           actions\u003d\u0027strip_vlan,\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_fc339ba8","side":"PARENT","line":584,"in_reply_to":"7adec928_9c5377e1","updated":"2014-05-15 20:28:45.000000000","message":"The assert_called_with for tun_br, checks for the last call made to method delete_flows on tun_br.  Here the last call will be from cleanup_tunnel_port .\r\n\r\nAnd in that its removing the VTEP port.  \r\nWhile the above line does get executed, it is not possible to catch it as it gets run over by delete_flows() call in cleanup_tunnel_port().\r\n\r\nPlease feel free to let me know which one you want to presever, either the above one (and then mock cleanup_tunnel_port along) [OR] leave the patch set 2 as is so that it really tests the line we inserted to cleanup the tunnel VTEP port.","commit_id":"ff22dc1a7c3803634288fdd4da66c51a22593c2e"}]}