)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"563a155707918055f5a17f23d7f1fb0cabe97460","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kien Nguyen Tuan \u003ckiennt2609@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-04 11:16:00 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(ovn-agent): wrong key type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The key [1] is a list which is unhashable, therefore,"},{"line_number":10,"context_line":"it can not be passed as dict key [2]. It causes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b331bb3d_992d47a9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"updated":"2024-12-05 07:01:16.000000000","message":"There is no need to use this \"fix\" suffix. Or just add a normal sentence. Something like \"Use the correct input for OVN agent deletion\"","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"47f94159322f6bd11714681d39e3efe21a1661eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kien Nguyen Tuan \u003ckiennt2609@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-04 11:16:00 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(ovn-agent): wrong key type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The key [1] is a list which is unhashable, therefore,"},{"line_number":10,"context_line":"it can not be passed as dict key [2]. It causes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c9a67f15_005a6cd9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"in_reply_to":"b331bb3d_992d47a9","updated":"2024-12-10 11:34:38.000000000","message":"Done","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"bf8afcaacbd460045414f9a7d683788f2a04699d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The key [1] is a list which is unhashable, therefore,"},{"line_number":10,"context_line":"it can not be passed as dict key [2]. It causes"},{"line_number":11,"context_line":"TypeError: unhashable type: \u0027list\u0027 exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332"},{"line_number":14,"context_line":"[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9b8484d3_a71e02e9","line":12,"updated":"2024-12-08 17:10:33.000000000","message":"You also need to refer to the bug filed in Launchpad like this:\n\nCloses-bug: #2091071","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"47f94159322f6bd11714681d39e3efe21a1661eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The key [1] is a list which is unhashable, therefore,"},{"line_number":10,"context_line":"it can not be passed as dict key [2]. It causes"},{"line_number":11,"context_line":"TypeError: unhashable type: \u0027list\u0027 exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332"},{"line_number":14,"context_line":"[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"76c2fa7b_3ae0f727","line":12,"in_reply_to":"9b8484d3_a71e02e9","updated":"2024-12-10 11:34:38.000000000","message":"Done","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"563a155707918055f5a17f23d7f1fb0cabe97460","unresolved":true,"context_lines":[{"line_number":10,"context_line":"it can not be passed as dict key [2]. It causes"},{"line_number":11,"context_line":"TypeError: unhashable type: \u0027list\u0027 exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332"},{"line_number":14,"context_line":"[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I064d9b3e6cb72562a16030e1b31de45ddc8f487c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"64a295fa_a4efd697","line":14,"range":{"start_line":13,"start_character":4,"end_line":14,"end_character":112},"updated":"2024-12-05 07:01:16.000000000","message":"This links, that are not strictly needed, should be permalink, aka: use an exact hash. If not, these will be gone in some months and will point to nothing.","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"47f94159322f6bd11714681d39e3efe21a1661eb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"it can not be passed as dict key [2]. It causes"},{"line_number":11,"context_line":"TypeError: unhashable type: \u0027list\u0027 exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332"},{"line_number":14,"context_line":"[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I064d9b3e6cb72562a16030e1b31de45ddc8f487c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ceae0cd_5cd04c95","line":14,"range":{"start_line":13,"start_character":4,"end_line":14,"end_character":112},"in_reply_to":"64a295fa_a4efd697","updated":"2024-12-10 11:34:38.000000000","message":"Done","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"47749d59de800570f7864be21700687458aa0254","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332"},{"line_number":14,"context_line":"[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I064d9b3e6cb72562a16030e1b31de45ddc8f487c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"148d3732_5e25dec5","line":15,"updated":"2024-12-05 16:08:23.000000000","message":"As Rodolfo mentioned, please either add the hash of the change I linked, or the change itself.\n\nPlease also add this here as well:\n\nCloses-bug: #2091071","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"47f94159322f6bd11714681d39e3efe21a1661eb","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332"},{"line_number":14,"context_line":"[2] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I064d9b3e6cb72562a16030e1b31de45ddc8f487c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8e09391d_c06dc46a","line":15,"in_reply_to":"148d3732_5e25dec5","updated":"2024-12-10 11:34:38.000000000","message":"Done","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c3a29f779be4830cbe48c90560477eab5a794354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b002daa_570a95ed","updated":"2024-12-04 19:14:42.000000000","message":"Oh, this was broken by me in:\n\nhttps://review.opendev.org/c/openstack/neutron/+/883607\n\nSo this change will need to be cherry-picked back to 2023.2\n\nCan you file a bug since we will need that to track things. Also, if you have seen this happen please add the log.\n\nThanks for finding it.","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"563a155707918055f5a17f23d7f1fb0cabe97460","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0238baa9_be3247a9","updated":"2024-12-05 07:01:16.000000000","message":"This fix is correct. But at the same time, in order to prevent this problem again (regression) you should add tests.","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"e1e76fa94bccf50e49ea8e6439a4e2db9fd26a06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"107e6048_e45387fa","updated":"2024-12-04 16:17:27.000000000","message":"recheck","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"1447b8b511583ff9ee3a5010a639d7f3a0453f54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ef10130_31c52f93","in_reply_to":"5b002daa_570a95ed","updated":"2024-12-05 06:50:50.000000000","message":"@v-brianhaley@microsoft.com: I\u0027ve filed a bug: https://bugs.launchpad.net/neutron/+bug/2091071","commit_id":"03a3f7397ad6fbdfa05bb9114babe408fb68fb9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"62da33d47d89494b121d08367e428028600a3608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca00a9ea_e162ac13","updated":"2024-12-13 18:45:41.000000000","message":"Not sure if the plan still assumes adding test cases here; the change is self evident, so maybe it can go as-is if the author doesn\u0027t have cycles. I\u0027ll let others to +2/-1.","commit_id":"ce6e2d87c52a11ec76a0f6fb7deb25a3dc26cf86"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f7edafea1d3b88643eebf7d480fc2cd19bab0e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17282723_45f53e40","updated":"2024-12-17 08:46:46.000000000","message":"What about the tests?? Next time I\u0027ll -2 the patch.","commit_id":"ce6e2d87c52a11ec76a0f6fb7deb25a3dc26cf86"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fe659fe8ee73e456c7bb56b803de24a785e379bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02be7e57_8e30de47","updated":"2024-12-14 23:18:23.000000000","message":"Yeah, I\u0027m fine merging this without a test as it\u0027s obvious.","commit_id":"ce6e2d87c52a11ec76a0f6fb7deb25a3dc26cf86"}]}