)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2815993793dbee22705f6a514257b3f6afc427c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f00b8111_8b940f06","updated":"2024-12-13 11:59:22.000000000","message":"looks, ok thanks","commit_id":"7c8be3ccbc4c51126a3efccfd5b7c3dd57e7ac40"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"51cfd24e2d841e334aacd5e7cf8a79eb527516e7","unresolved":true,"context_lines":[{"line_number":1715,"context_line":"                LOG.debug(\"Router %s not found\", port[\u0027device_id\u0027])"},{"line_number":1716,"context_line":"            else:"},{"line_number":1717,"context_line":"                network_ids \u003d {port[\u0027network_id\u0027] for port in router_ports}"},{"line_number":1718,"context_line":"                networks \u003d None"},{"line_number":1719,"context_line":"                if ovn_conf.is_ovn_emit_need_to_frag_enabled():"},{"line_number":1720,"context_line":"                    networks \u003d self._plugin.get_networks("},{"line_number":1721,"context_line":"                        admin_context, filters\u003d{\u0027id\u0027: network_ids})"}],"source_content_type":"text/x-python","patch_set":5,"id":"340f53e2_71566af6","line":1718,"updated":"2024-12-10 09:19:22.000000000","message":"```\nnetwork \u003d None\nif ovn_conf.is_ovn_emit_need_to_frag_enabled() or ovn_conf.is_ovn_distributed_floating_ip():\n    networks \u003d self._plugin.get_networks(admin_context, filters\u003d{\u0027id\u0027: network_ids})\n```\n\nIf both of the options are enable it looks like you call two times get_networks, no?","commit_id":"7c8be3ccbc4c51126a3efccfd5b7c3dd57e7ac40"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f8c693aa550061e465634ee337ea5da710fe3f87","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"                LOG.debug(\"Router %s not found\", port[\u0027device_id\u0027])"},{"line_number":1716,"context_line":"            else:"},{"line_number":1717,"context_line":"                network_ids \u003d {port[\u0027network_id\u0027] for port in router_ports}"},{"line_number":1718,"context_line":"                networks \u003d None"},{"line_number":1719,"context_line":"                if ovn_conf.is_ovn_emit_need_to_frag_enabled():"},{"line_number":1720,"context_line":"                    networks \u003d self._plugin.get_networks("},{"line_number":1721,"context_line":"                        admin_context, filters\u003d{\u0027id\u0027: network_ids})"}],"source_content_type":"text/x-python","patch_set":5,"id":"75c141a7_ec9551d6","line":1718,"in_reply_to":"340f53e2_71566af6","updated":"2024-12-10 09:40:53.000000000","message":"I\u0027m not calling the method twice. In the second section (DVR) if the \"networks\" variable is populated, we don\u0027t retrieve it again.","commit_id":"7c8be3ccbc4c51126a3efccfd5b7c3dd57e7ac40"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8affaa70446f423fb2a8b03fd684b2ee56e3b729","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"                LOG.debug(\"Router %s not found\", port[\u0027device_id\u0027])"},{"line_number":1716,"context_line":"            else:"},{"line_number":1717,"context_line":"                network_ids \u003d {port[\u0027network_id\u0027] for port in router_ports}"},{"line_number":1718,"context_line":"                networks \u003d None"},{"line_number":1719,"context_line":"                if ovn_conf.is_ovn_emit_need_to_frag_enabled():"},{"line_number":1720,"context_line":"                    networks \u003d self._plugin.get_networks("},{"line_number":1721,"context_line":"                        admin_context, filters\u003d{\u0027id\u0027: network_ids})"}],"source_content_type":"text/x-python","patch_set":5,"id":"6ea13962_a35411d0","line":1718,"in_reply_to":"75c141a7_ec9551d6","updated":"2024-12-10 11:05:19.000000000","message":"Oh yes sorry, at least it would have been less confusing to have used get_networks only one times, but it\u0027s just a personal preference.\n\nThank you !","commit_id":"7c8be3ccbc4c51126a3efccfd5b7c3dd57e7ac40"}]}