)]}'
{"neutron/db/migration/alembic_migrations/versions/10cd28e692e9_nuage_extraroute.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3c757abf86b0d2a1b27cf472ee8cf805bb4b83c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_5666cd2a","line":2,"updated":"2014-05-20 02:17:40.000000000","message":"you probably want to attribute the right affiliation here","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"3696625aefb3add0981e4f734cfdc1f21634b96d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_bc1c1dc3","line":2,"in_reply_to":"7adec928_5666cd2a","updated":"2014-05-21 17:24:11.000000000","message":"Hi Sumit,\nNot sure what you are asking here. This is autogenerated file and I referred to few down revision files and they did not change the affiliation so I thought I should keep it that way for consistency. Let me know.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"14a8903882c18adeee18ccd72701f97edc31f7c5","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    op.create_table("},{"line_number":45,"context_line":"        \u0027routerroutes_mapping\u0027,"},{"line_number":46,"context_line":"        sa.Column(\u0027destination\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":47,"context_line":"        sa.Column(\u0027nexthop\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":48,"context_line":"        sa.Column(\u0027router_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027nuage_route_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_5d78702b","line":46,"updated":"2014-05-21 20:53:30.000000000","message":"Why is there some duplication of data here? It sounds unnecessary. Could you explain?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"1ab0df53c9743cda3a5570aa1f2c5e82a63b1c9a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    op.create_table("},{"line_number":45,"context_line":"        \u0027routerroutes_mapping\u0027,"},{"line_number":46,"context_line":"        sa.Column(\u0027destination\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":47,"context_line":"        sa.Column(\u0027nexthop\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":48,"context_line":"        sa.Column(\u0027router_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027nuage_route_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_ae8e9825","line":46,"in_reply_to":"7adec928_18cfd6b1","updated":"2014-05-21 22:24:09.000000000","message":"Please disregard my prev comment. I understood the problem.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"a8cfb7a5bad07e1886f6971c1d2f175213a9958c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    op.create_table("},{"line_number":45,"context_line":"        \u0027routerroutes_mapping\u0027,"},{"line_number":46,"context_line":"        sa.Column(\u0027destination\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":47,"context_line":"        sa.Column(\u0027nexthop\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":48,"context_line":"        sa.Column(\u0027router_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"        sa.Column(\u0027nuage_route_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_18cfd6b1","line":46,"in_reply_to":"7adec928_5d78702b","updated":"2014-05-21 21:17:48.000000000","message":"Are you suggesting destination and nexthop to be foreignkeys in this table? If yes, I can change that. If no, can you elaborate please?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"}],"neutron/plugins/nuage/nuage_models.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"7f11f75399c383d0f184a8493524436ac5ac1b1c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    router_id \u003d Column(String(36),"},{"line_number":80,"context_line":"                       ForeignKey(\u0027routers.id\u0027,"},{"line_number":81,"context_line":"                                  ondelete\u003d\"CASCADE\"),"},{"line_number":82,"context_line":"                       primary_key\u003dTrue)"},{"line_number":83,"context_line":"    nuage_route_id \u003d Column(String(36))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_37ca3fa1","line":82,"updated":"2014-05-19 07:51:26.000000000","message":"It is better to add parameter nullable\u003dFalse for router_id in this model for clear synchronization of models and migrations.","commit_id":"6c27d4c3a8630c4f7133bd0e1ba7ba1311210379"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"023bcb1042ef94f16c78153edfbe172ddf869fb5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    router_id \u003d Column(String(36),"},{"line_number":80,"context_line":"                       ForeignKey(\u0027routers.id\u0027,"},{"line_number":81,"context_line":"                                  ondelete\u003d\"CASCADE\"),"},{"line_number":82,"context_line":"                       primary_key\u003dTrue)"},{"line_number":83,"context_line":"    nuage_route_id \u003d Column(String(36))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_ea237002","line":82,"in_reply_to":"7adec928_37ca3fa1","updated":"2014-05-19 21:50:45.000000000","message":"Sure. Done. \n\nI was just trying to be consistent with RouterRoute table snippet @ extraroute_db.py","commit_id":"6c27d4c3a8630c4f7133bd0e1ba7ba1311210379"}],"neutron/plugins/nuage/nuagedb.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f05ff262cee0ab303fe81faa239600294f4b6927","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    return query"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def delete_static_route(session, static_route):"},{"line_number":137,"context_line":"    session.delete(static_route)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_f6d8b9f0","line":136,"updated":"2014-05-20 02:11:10.000000000","message":"would it not be better to this in a subtransaction?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"f818a5a9be0c1bcd4f4473b356677c604700bcbf","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    return query"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def delete_static_route(session, static_route):"},{"line_number":137,"context_line":"    session.delete(static_route)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_044901d0","line":136,"in_reply_to":"7adec928_04e74141","updated":"2014-05-23 06:06:08.000000000","message":"I dont think its a bad idea. \n\nI was trying to keep consistency of the code through out the file. This was my original thought process: These functions are only going to get used from nuage plugin code base. Whoever is trying to access this functions, should be aware of the transaction scheme and can chose subtransaction rather than enforcing it by putting it here. \n\nIn next release of VSP, its very much likely that this whole file will disappear as I will not need to keep mapping. It is possible that it will happen in J3 timeframe itself.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"79354d006a0983f1959f81019a94e43d55ba4af9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    return query"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def delete_static_route(session, static_route):"},{"line_number":137,"context_line":"    session.delete(static_route)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_04e74141","line":136,"in_reply_to":"7adec928_dc5f2974","updated":"2014-05-23 05:49:35.000000000","message":"But why is it not a good idea to include this in a sub-transaction here? That way the caller would not have to care, right? Your plugin.py is probably the only module using this, but that could change in the future, right?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"3696625aefb3add0981e4f734cfdc1f21634b96d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    return query"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def delete_static_route(session, static_route):"},{"line_number":137,"context_line":"    session.delete(static_route)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_dc5f2974","line":136,"in_reply_to":"7adec928_f6d8b9f0","updated":"2014-05-21 17:24:11.000000000","message":"It is done in subtransaction. The way I am managing functions in this file, it is caller\u0027s (plugin.py\u0027s method in most cases) responsibility to make it part of subtransaction if he decides to do so. \n\nIn this particular case, I am handling that in subtransaction.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"}],"neutron/plugins/nuage/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"14a8903882c18adeee18ccd72701f97edc31f7c5","unresolved":false,"context_lines":[{"line_number":619,"context_line":"            ip \u003d netaddr.IPNetwork(route[\u0027destination\u0027])"},{"line_number":620,"context_line":"            matching \u003d netaddr.all_matching_cidrs(ip.ip, cidrs)"},{"line_number":621,"context_line":"            if matching:"},{"line_number":622,"context_line":"                msg \u003d (\u0027for same subnet, multiple static routes not allowed\u0027)"},{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":624,"context_line":"            cidrs.append(ip)"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_bd0414c7","line":622,"updated":"2014-05-21 20:53:30.000000000","message":"this should be enclosed by _","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"a8cfb7a5bad07e1886f6971c1d2f175213a9958c","unresolved":false,"context_lines":[{"line_number":619,"context_line":"            ip \u003d netaddr.IPNetwork(route[\u0027destination\u0027])"},{"line_number":620,"context_line":"            matching \u003d netaddr.all_matching_cidrs(ip.ip, cidrs)"},{"line_number":621,"context_line":"            if matching:"},{"line_number":622,"context_line":"                msg \u003d (\u0027for same subnet, multiple static routes not allowed\u0027)"},{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":624,"context_line":"            cidrs.append(ip)"},{"line_number":625,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_98ba0609","line":622,"in_reply_to":"7adec928_bd0414c7","updated":"2014-05-21 21:17:48.000000000","message":"ok. will take care of it.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"14a8903882c18adeee18ccd72701f97edc31f7c5","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":624,"context_line":"            cidrs.append(ip)"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def update_router(self, context, id, router):"},{"line_number":627,"context_line":"        r \u003d router[\u0027router\u0027]"},{"line_number":628,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":629,"context_line":"            if \u0027routes\u0027 in r:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_5d2150b3","line":626,"updated":"2014-05-21 20:53:30.000000000","message":"Can you walk me through why you\u0027re keeping the mappings and you\u0027re doing extra steps here? I am failing to grasp it. Keeping the routes in two places sounds like an inconsistency problem waiting to happen, besides the extra cost hit.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dbf9451d1b159563f38bb5007382d326e8e18fe9","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":624,"context_line":"            cidrs.append(ip)"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def update_router(self, context, id, router):"},{"line_number":627,"context_line":"        r \u003d router[\u0027router\u0027]"},{"line_number":628,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":629,"context_line":"            if \u0027routes\u0027 in r:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_d029ac38","line":626,"in_reply_to":"7adec928_387bb22a","updated":"2014-05-22 14:58:07.000000000","message":"I understand, but what about destination and nexthop? Are these uuid\u0027s?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"a8cfb7a5bad07e1886f6971c1d2f175213a9958c","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":624,"context_line":"            cidrs.append(ip)"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def update_router(self, context, id, router):"},{"line_number":627,"context_line":"        r \u003d router[\u0027router\u0027]"},{"line_number":628,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":629,"context_line":"            if \u0027routes\u0027 in r:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_387bb22a","line":626,"in_reply_to":"7adec928_5d2150b3","updated":"2014-05-21 21:17:48.000000000","message":"UUIDs of resources such as routers, routes etc in VSD (nuage controller) are different from that of the corresponding one in neutron. Current version of VSD APIs must use those UUIDs (nuage\u0027s) in the URI to perform CRUD operations on those resources. Next gen API will take this limitation of and I will not need to have the mapping.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"14a8903882c18adeee18ccd72701f97edc31f7c5","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                ent_rtr_mapping \u003d nuagedb.get_ent_rtr_mapping_by_rtrid("},{"line_number":636,"context_line":"                    context.session, id)"},{"line_number":637,"context_line":"                if not ent_rtr_mapping:"},{"line_number":638,"context_line":"                    msg \u003d (\"Router %s does not hold net-partition \""},{"line_number":639,"context_line":"                           \"assoc on VSD. extra-route failed\" % id)"},{"line_number":640,"context_line":"                    raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":641,"context_line":"                # Let it do internal checks first and verify it."}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_1d1428f4","line":638,"updated":"2014-05-21 20:53:30.000000000","message":"same comment as 622","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"a8cfb7a5bad07e1886f6971c1d2f175213a9958c","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                ent_rtr_mapping \u003d nuagedb.get_ent_rtr_mapping_by_rtrid("},{"line_number":636,"context_line":"                    context.session, id)"},{"line_number":637,"context_line":"                if not ent_rtr_mapping:"},{"line_number":638,"context_line":"                    msg \u003d (\"Router %s does not hold net-partition \""},{"line_number":639,"context_line":"                           \"assoc on VSD. extra-route failed\" % id)"},{"line_number":640,"context_line":"                    raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":641,"context_line":"                # Let it do internal checks first and verify it."}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_384ad227","line":638,"in_reply_to":"7adec928_1d1428f4","updated":"2014-05-21 21:17:48.000000000","message":"Ok. will take care of it.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"033095b4d3169608d703afc039ec0c10e2336298","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                        \u0027net\u0027: netaddr.IPNetwork(route[\u0027destination\u0027]),"},{"line_number":658,"context_line":"                        \u0027nexthop\u0027: route[\u0027nexthop\u0027]"},{"line_number":659,"context_line":"                    }"},{"line_number":660,"context_line":"                    nuage_rt_id \u003d self.nuageclient.create_nuage_staticroute("},{"line_number":661,"context_line":"                        params)"},{"line_number":662,"context_line":"                    nuagedb.add_static_route(context.session,"},{"line_number":663,"context_line":"                                             id, nuage_rt_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_d6273dc8","line":660,"updated":"2014-05-20 02:22:17.000000000","message":"Is it possible for this to fail and raise an exception (e.g. due to network connectivity being out)? If so, it will cause all db transactions to be rolled back up to line 628. However, other nuageclient calls have already been made so the operation is partially finished on the backend. \n\nI\u0027m not very familiar with the nuage client. Is there a process in place to handle these inconsistencies?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"74c5087c4942f93ad45b84af0af936cdf8302859","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                        \u0027net\u0027: netaddr.IPNetwork(route[\u0027destination\u0027]),"},{"line_number":658,"context_line":"                        \u0027nexthop\u0027: route[\u0027nexthop\u0027]"},{"line_number":659,"context_line":"                    }"},{"line_number":660,"context_line":"                    nuage_rt_id \u003d self.nuageclient.create_nuage_staticroute("},{"line_number":661,"context_line":"                        params)"},{"line_number":662,"context_line":"                    nuagedb.add_static_route(context.session,"},{"line_number":663,"context_line":"                                             id, nuage_rt_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_372bc631","line":660,"in_reply_to":"7adec928_37aae6d4","updated":"2014-05-21 17:29:00.000000000","message":"got it. thanks","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"3696625aefb3add0981e4f734cfdc1f21634b96d","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                        \u0027net\u0027: netaddr.IPNetwork(route[\u0027destination\u0027]),"},{"line_number":658,"context_line":"                        \u0027nexthop\u0027: route[\u0027nexthop\u0027]"},{"line_number":659,"context_line":"                    }"},{"line_number":660,"context_line":"                    nuage_rt_id \u003d self.nuageclient.create_nuage_staticroute("},{"line_number":661,"context_line":"                        params)"},{"line_number":662,"context_line":"                    nuagedb.add_static_route(context.session,"},{"line_number":663,"context_line":"                                             id, nuage_rt_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_37aae6d4","line":660,"in_reply_to":"7adec928_d6273dc8","updated":"2014-05-21 17:24:11.000000000","message":"There is a provision in nuagenetlib for a retry for x time for temporary outage/connectivity issue. After that I am out of luck currently. I am working on synchronization mechanism and will propose the change sometime later in Juno to take care of many such inconsistencies.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"}],"neutron/tests/unit/nuage/fake_nuageclient.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"14a8903882c18adeee18ccd72701f97edc31f7c5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def delete_vms(self, params):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def create_nuage_staticroute(self, params):"},{"line_number":88,"context_line":"        pass"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def delete_nuage_staticroute(self, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_3dcd6487","line":87,"updated":"2014-05-21 20:53:30.000000000","message":"if these are straight passes and you derive the testcase from the base class without customization, it sounds like there\u0027s very little coverage introduced by this patch. I would urge you to revise your UT\u0027s strategy and introduce cover your code a little more.","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":7962,"name":"Ronak Shah","email":"ronak.malav.shah@gmail.com","username":"ronak"},"change_message_id":"a8cfb7a5bad07e1886f6971c1d2f175213a9958c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def delete_vms(self, params):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def create_nuage_staticroute(self, params):"},{"line_number":88,"context_line":"        pass"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def delete_nuage_staticroute(self, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_58c6be4a","line":87,"in_reply_to":"7adec928_3dcd6487","updated":"2014-05-21 21:17:48.000000000","message":"Hmm. I see what you are saying. I probably need to do for testcases that I am covering. Ok. Can I create a seperate bug and track that change there? Will it be ok with you if I take that route and keep this particular patch as is?","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dbf9451d1b159563f38bb5007382d326e8e18fe9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def delete_vms(self, params):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def create_nuage_staticroute(self, params):"},{"line_number":88,"context_line":"        pass"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def delete_nuage_staticroute(self, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_f0cdc887","line":87,"in_reply_to":"7adec928_58c6be4a","updated":"2014-05-22 14:58:07.000000000","message":"I don\u0027t see why it should be tracked as a bug fix. If you are concerned about patch size, then you could stack two patches (this one and the tests one) on top of each other and they\u0027d be targeting the same blueprint. But at this point the size of this patch is pretty manageable :)","commit_id":"253a77fc704eeccf5d540684c101ecbe418cde1d"}]}
