)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b3d40a1392a5481f3e99579795ee2f53da5dec81","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Finally this patch adds all the necessary bits to store value of the new"},{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related: #1915151"},{"line_number":20,"context_line":"Change-Id: I427edfd580eb06aa4f6904f90ff28cf8b5267397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"195bbb35_17ca8451","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":1},"updated":"2024-12-11 08:13:16.000000000","message":"It is worth mentioning the n-lib patch and the n-lib library bump.","commit_id":"907b4b6ab4e5b95228ffb1c6d39c31f084664a4a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8862b800834a06c61dbc69278ef2069b0e6eac86","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Finally this patch adds all the necessary bits to store value of the new"},{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related: #1915151"},{"line_number":20,"context_line":"Change-Id: I427edfd580eb06aa4f6904f90ff28cf8b5267397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"90accec5_11ac636e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":1},"in_reply_to":"195bbb35_17ca8451","updated":"2024-12-11 11:19:55.000000000","message":"I added extension definition to the neutron temporary so I don\u0027t need to wait for the neutron-lib release and bump.","commit_id":"907b4b6ab4e5b95228ffb1c6d39c31f084664a4a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b3d40a1392a5481f3e99579795ee2f53da5dec81","unresolved":true,"context_lines":[{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related: #1915151"},{"line_number":20,"context_line":"Change-Id: I427edfd580eb06aa4f6904f90ff28cf8b5267397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"40c03310_0bfa9e4e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"updated":"2024-12-11 08:13:16.000000000","message":"Related-Bug (to make gerrit to create the link)","commit_id":"907b4b6ab4e5b95228ffb1c6d39c31f084664a4a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8862b800834a06c61dbc69278ef2069b0e6eac86","unresolved":false,"context_lines":[{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related: #1915151"},{"line_number":20,"context_line":"Change-Id: I427edfd580eb06aa4f6904f90ff28cf8b5267397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"32a6355d_50be02ff","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"40c03310_0bfa9e4e","updated":"2024-12-11 11:19:55.000000000","message":"Done","commit_id":"907b4b6ab4e5b95228ffb1c6d39c31f084664a4a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the network dict and returned through the API."},{"line_number":12,"context_line":"This patch also adds validation that both \"vlan_transparent\" and \"qinq\""},{"line_number":13,"context_line":"aren\u0027t enabled for the same network at the same time as this is not"},{"line_number":14,"context_line":"suppoorted."},{"line_number":15,"context_line":"This patch adds all the necessary bits to store value of the new"},{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f599ef3_03b19cd5","line":14,"updated":"2024-12-18 22:10:51.000000000","message":"nit: supported","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the network dict and returned through the API."},{"line_number":12,"context_line":"This patch also adds validation that both \"vlan_transparent\" and \"qinq\""},{"line_number":13,"context_line":"aren\u0027t enabled for the same network at the same time as this is not"},{"line_number":14,"context_line":"suppoorted."},{"line_number":15,"context_line":"This patch adds all the necessary bits to store value of the new"},{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a42351a0_d410cc3b","line":14,"in_reply_to":"3f599ef3_03b19cd5","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."},{"line_number":18,"context_line":"Finally it also adds check_vlan_qinq() method to all mechanism drivers"},{"line_number":19,"context_line":"which are in-tree. For now all of them declares that QinQ vlans are not"},{"line_number":20,"context_line":"supported."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1915151"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"d28eb107_27b7ee3f","line":19,"updated":"2024-12-18 22:10:51.000000000","message":"nit: declares -\u003e declare","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":16,"context_line":"attribute in the Neutron DB and to add support for it to the Network"},{"line_number":17,"context_line":"OVO."},{"line_number":18,"context_line":"Finally it also adds check_vlan_qinq() method to all mechanism drivers"},{"line_number":19,"context_line":"which are in-tree. For now all of them declares that QinQ vlans are not"},{"line_number":20,"context_line":"supported."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1915151"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"b6927b2b_a6186d7d","line":19,"in_reply_to":"d28eb107_27b7ee3f","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b3d40a1392a5481f3e99579795ee2f53da5dec81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4adfbb9b_7e647a45","updated":"2024-12-11 08:13:16.000000000","message":"-1 just for visibility","commit_id":"907b4b6ab4e5b95228ffb1c6d39c31f084664a4a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"420187c1_9500d30d","updated":"2024-12-18 22:10:51.000000000","message":"Add release note?","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bf60368041465f9a4bdd8332784560fcc2ed5128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"586b74b2_46adebc8","updated":"2024-12-16 09:36:46.000000000","message":"recheck - unrelated failures in scenario and functional jobs","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"255560f86172a7cc372297397b2de9071dbbfba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aeeab6ea_95554798","updated":"2024-12-19 13:58:53.000000000","message":"You could add a release note.","commit_id":"b2228535930726ac02ecc17277304cfa32872db7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eb541e742cbbd8cb4c9591994b112065dfb57a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9a7ba369_78db9250","updated":"2025-01-27 22:59:57.000000000","message":"The neutron-ovs-grenade-multinode job has failed 5 times in row, not sure if that\u0027s a coincidence.","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"762cb5e372fe4aa80aaab85abb9206d68d945a9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0fdb9e4b_3f867b17","updated":"2025-01-23 15:37:58.000000000","message":"recheck - seems like unrelated error from the neutron api while creating router","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c3100ce02b1094a90f775b7c36a91027d7f93d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1eedafee_cc77cfbb","updated":"2025-01-27 09:17:25.000000000","message":"recheck - timeout while waiting for VM to become active in one of the scenario tests","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0b994c6dff6917f50f26a880dcda2da8a3ab93a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dc05b094_b00434b9","updated":"2025-01-22 08:31:32.000000000","message":"recheck - unrelated long spawning servers issue in the ovs grenade job","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40edd633a08618d30695cdb175ee10ddc5dd4ec3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"224f0aa3_3c1fc539","updated":"2025-01-27 15:55:54.000000000","message":"recheck - unrelated ovs grenade job failure","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c8889c0d52a31590711583d499e42fe7544100f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b1a6bc47_2ec2cddb","updated":"2025-01-21 09:16:38.000000000","message":"recheck - unrelated ping failure in the grenade job","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2e422a016061fd375e3e120ffff8c9cb0cb6fbba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"df2ad6d8_de79a529","updated":"2025-01-24 09:19:00.000000000","message":"recheck - yet another unrelated grenade failure","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"371549548c5034ac48be98f5991e303565e3ad5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d66380b6_75b14b87","in_reply_to":"9a7ba369_78db9250","updated":"2025-01-28 18:35:35.000000000","message":"damn, it indeed is related. Sorry for those rechecks. I will fix it","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"25b445ba3c5b32e900c8751b79af869d9df4a16d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a08b8680_38804137","in_reply_to":"d66380b6_75b14b87","updated":"2025-01-29 11:23:01.000000000","message":"so I checked and actually it is not that this patch is broken in any way but the grenade job is broken. I\u0027ve opened a new bug https://bugs.launchpad.net/neutron/+bug/2096912 for this.","commit_id":"5d6910b420cac20ca08f7d311fb19ffc1d319d39"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"76d42bcefaebd5e636094c3d3d4a9f2520f92f04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d96ca0c7_d49d9e10","updated":"2025-02-03 08:58:41.000000000","message":"recheck\ngrenade and functional failuresare not related","commit_id":"b4b56036435db85242d88a7920939e1ed5c3039b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"98ce7239f59baa7a44a6078d93c83a1f8ebe4960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3e7d5a9b_85868657","in_reply_to":"d96ca0c7_d49d9e10","updated":"2025-02-03 11:53:26.000000000","message":"actually grenade failure is kind of related to this patch as this patch exposed issue in our grenade jobs. I just rebased it on top of the fix for the grenade jobs so now it should pass finally 😊","commit_id":"b4b56036435db85242d88a7920939e1ed5c3039b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"89aecbf100eb40ab8576bf9f947180d15c5c2daa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ef9de11f_20ea1217","updated":"2025-02-04 08:17:47.000000000","message":"recheck - this time it was really unrelated issue in the ovn-grenade job (missing router interface)","commit_id":"e20ef3fa86cd61c20559441fb47eba62515885f2"}],"neutron/conf/common.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":125,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":126,"context_line":"                      \"By default, the reference implementation of the \""},{"line_number":127,"context_line":"                      \"Neutron IPAM driver is used.\")),"},{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027vlan_transparent\u0027, default\u003dFalse,"},{"line_number":129,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"},{"line_number":130,"context_line":"                       \u0027create VLAN transparent networks.\u0027)),"},{"line_number":131,"context_line":"    cfg.BoolOpt(\u0027vlan_qinq\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"edf73925_8d877b99","line":128,"updated":"2024-12-18 22:10:51.000000000","message":"I\u0027m not sure what the rationale to have this flag (and the newly added one) as a config option in a file. Shouldn\u0027t neutron allow to create these networks as long as RBAC rules allow and drivers support? Is there a good reason, or are you just trying to stay consistent with `vlan_transparent` implementation here? (Wondering if we should.)","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c721d9d73e76b0523622b874686592de8fb1d65","unresolved":true,"context_lines":[{"line_number":125,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":126,"context_line":"                      \"By default, the reference implementation of the \""},{"line_number":127,"context_line":"                      \"Neutron IPAM driver is used.\")),"},{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027vlan_transparent\u0027, default\u003dFalse,"},{"line_number":129,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"},{"line_number":130,"context_line":"                       \u0027create VLAN transparent networks.\u0027)),"},{"line_number":131,"context_line":"    cfg.BoolOpt(\u0027vlan_qinq\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"862061ba_5ccc0e73","line":128,"in_reply_to":"1b5ebd43_bf3a46ac","updated":"2025-01-10 08:35:33.000000000","message":"+1 for the proposal, let\u0027s merge this patch is now (to be consistent) and then remove both config options.","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"27f0f236caf8be3bad880e1b18ab518f4a1ddbc9","unresolved":false,"context_lines":[{"line_number":125,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":126,"context_line":"                      \"By default, the reference implementation of the \""},{"line_number":127,"context_line":"                      \"Neutron IPAM driver is used.\")),"},{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027vlan_transparent\u0027, default\u003dFalse,"},{"line_number":129,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"},{"line_number":130,"context_line":"                       \u0027create VLAN transparent networks.\u0027)),"},{"line_number":131,"context_line":"    cfg.BoolOpt(\u0027vlan_qinq\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"a5ae20fd_2318e1bb","line":128,"in_reply_to":"862061ba_5ccc0e73","updated":"2025-02-01 02:41:40.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":true,"context_lines":[{"line_number":125,"context_line":"               help\u003d_(\"Neutron IPAM (IP address management) driver to use. \""},{"line_number":126,"context_line":"                      \"By default, the reference implementation of the \""},{"line_number":127,"context_line":"                      \"Neutron IPAM driver is used.\")),"},{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027vlan_transparent\u0027, default\u003dFalse,"},{"line_number":129,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"},{"line_number":130,"context_line":"                       \u0027create VLAN transparent networks.\u0027)),"},{"line_number":131,"context_line":"    cfg.BoolOpt(\u0027vlan_qinq\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1b5ebd43_bf3a46ac","line":128,"in_reply_to":"edf73925_8d877b99","updated":"2024-12-19 09:58:07.000000000","message":"I am trying to be consistent with what we had so far for now. But I would be happy to deprecate those options e.g. in next cycle and let simply mech_drivers to decide if those extensions should be available or not.\nI opened https://bugs.launchpad.net/neutron/+bug/2092174 for this and will raise this topic during next drivers meeting to see what others thinks about it.","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    cfg.BoolOpt(\u0027vlan_qinq\u0027, default\u003dFalse,"},{"line_number":132,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"},{"line_number":133,"context_line":"                       \u0027create VLAN transparent networks using 0x8a88 \u0027"},{"line_number":134,"context_line":"                       \u0027ethertype. \u0027)),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027filter_validation\u0027, default\u003dTrue,"},{"line_number":136,"context_line":"                help\u003d_(\u0027If True, then allow plugins to decide \u0027"},{"line_number":137,"context_line":"                       \u0027whether to perform validations on filter parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"7ec51223_695bd690","line":134,"updated":"2024-12-18 22:10:51.000000000","message":"nit: unnecessary trailing space","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    cfg.BoolOpt(\u0027vlan_qinq\u0027, default\u003dFalse,"},{"line_number":132,"context_line":"                help\u003d_(\u0027If True, then allow plugins that support it to \u0027"},{"line_number":133,"context_line":"                       \u0027create VLAN transparent networks using 0x8a88 \u0027"},{"line_number":134,"context_line":"                       \u0027ethertype. \u0027)),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027filter_validation\u0027, default\u003dTrue,"},{"line_number":136,"context_line":"                help\u003d_(\u0027If True, then allow plugins to decide \u0027"},{"line_number":137,"context_line":"                       \u0027whether to perform validations on filter parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"4a61244d_fb8da2b3","line":134,"in_reply_to":"7ec51223_695bd690","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}],"neutron/db/migration/alembic_migrations/versions/2025.1/expand/ad80a9f07c5c_add_vlan_qinq_column_to_the_network_.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"import sqlalchemy as sa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Add vlan_qinq column to the Network table"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# Revision ID: ad80a9f07c5c"},{"line_number":23,"context_line":"# Revises: 5bcb7b31ec7d"}],"source_content_type":"text/x-python","patch_set":11,"id":"ed52bd24_e94019cc","line":20,"updated":"2024-12-18 22:10:51.000000000","message":"nit: the column is `qinq`, not `vlan_qinq`","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import sqlalchemy as sa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Add vlan_qinq column to the Network table"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# Revision ID: ad80a9f07c5c"},{"line_number":23,"context_line":"# Revises: 5bcb7b31ec7d"}],"source_content_type":"text/x-python","patch_set":11,"id":"5c759e65_c8f5b50a","line":20,"in_reply_to":"ed52bd24_e94019cc","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}],"neutron/extensions/qinq.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f351cdef25726e796092343723bf8398a1c459d9","unresolved":true,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(slaweq) use api definition from neutron-lib once"},{"line_number":30,"context_line":"# neutron-lib 3.17 will be released and used by Neutron"},{"line_number":31,"context_line":"ALIAS \u003d \u0027qinq\u0027"},{"line_number":32,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":33,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"295d2818_36abaa0b","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":55},"updated":"2025-01-06 09:52:03.000000000","message":"3.17 is out, last week the release patch was merged: https://review.opendev.org/c/openstack/releases/+/938110 (and the req patch was also merged: https://review.opendev.org/c/openstack/requirements/+/938353 )","commit_id":"b2228535930726ac02ecc17277304cfa32872db7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"10e0dca584612bc5bbc20b4927067b72296b1ebe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(slaweq) use api definition from neutron-lib once"},{"line_number":30,"context_line":"# neutron-lib 3.17 will be released and used by Neutron"},{"line_number":31,"context_line":"ALIAS \u003d \u0027qinq\u0027"},{"line_number":32,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":33,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"5e199efb_31778906","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":55},"in_reply_to":"1ab588d1_52fb7070","updated":"2025-01-20 15:27:00.000000000","message":"Done","commit_id":"b2228535930726ac02ecc17277304cfa32872db7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6c721d9d73e76b0523622b874686592de8fb1d65","unresolved":true,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(slaweq) use api definition from neutron-lib once"},{"line_number":30,"context_line":"# neutron-lib 3.17 will be released and used by Neutron"},{"line_number":31,"context_line":"ALIAS \u003d \u0027qinq\u0027"},{"line_number":32,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":33,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"3d569e28_3fc75f0f","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":55},"in_reply_to":"295d2818_36abaa0b","updated":"2025-01-10 08:35:33.000000000","message":"+1, 3.17 is already available.","commit_id":"b2228535930726ac02ecc17277304cfa32872db7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5359f6f970eb5191d09cd9e6fe4d179936a85b1a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(slaweq) use api definition from neutron-lib once"},{"line_number":30,"context_line":"# neutron-lib 3.17 will be released and used by Neutron"},{"line_number":31,"context_line":"ALIAS \u003d \u0027qinq\u0027"},{"line_number":32,"context_line":"IS_SHIM_EXTENSION \u003d False"},{"line_number":33,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ab588d1_52fb7070","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":55},"in_reply_to":"3d569e28_3fc75f0f","updated":"2025-01-13 17:09:27.000000000","message":"This can be done here or in a follow-up I think. I\u0027d rather merge this and clean up later. (Just make sure we do clean up.)\n\nFYI There is a bump patch elsewhere. https://review.opendev.org/c/openstack/neutron/+/936845","commit_id":"b2228535930726ac02ecc17277304cfa32872db7"}],"neutron/plugins/ml2/drivers/linuxbridge/mech_driver/mech_linuxbridge.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        return True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def check_vlan_qinq(self, context):"},{"line_number":68,"context_line":"        \"\"\"Currently Linuxbridge drive rdoesn\u0027t support QinQ vlan.\"\"\""},{"line_number":69,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":11,"id":"24495aba_28a9e53b","line":68,"updated":"2024-12-18 22:10:51.000000000","message":"-\u003e driver doesn\u0027t","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def check_vlan_qinq(self, context):"},{"line_number":68,"context_line":"        \"\"\"Currently Linuxbridge drive rdoesn\u0027t support QinQ vlan.\"\"\""},{"line_number":69,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":11,"id":"439f5f5f_5386c17e","line":68,"in_reply_to":"24495aba_28a9e53b","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        support vlan transparency."},{"line_number":480,"context_line":"        \"\"\""},{"line_number":481,"context_line":"        if context.current.get(\u0027qinq\u0027):"},{"line_number":482,"context_line":"            for driver in self.ordered_mech_drivers:"},{"line_number":483,"context_line":"                if not driver.obj.check_vlan_qinq(context):"},{"line_number":484,"context_line":"                    raise qinq.VlanQinqDriverError()"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4cbe699a_aca195cc","line":482,"updated":"2024-12-18 22:10:51.000000000","message":"(No action required) I find it a bit confusing that we don\u0027t allow a driver to take care of QinQ networks if some other drivers don\u0027t support them (even if they e.g. don\u0027t ever overlap in datapath because e.g. other drivers don\u0027t run on `vlan`.)","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        support vlan transparency."},{"line_number":480,"context_line":"        \"\"\""},{"line_number":481,"context_line":"        if context.current.get(\u0027qinq\u0027):"},{"line_number":482,"context_line":"            for driver in self.ordered_mech_drivers:"},{"line_number":483,"context_line":"                if not driver.obj.check_vlan_qinq(context):"},{"line_number":484,"context_line":"                    raise qinq.VlanQinqDriverError()"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7e5e778f_7ce390d0","line":482,"in_reply_to":"4cbe699a_aca195cc","updated":"2024-12-19 09:58:07.000000000","message":"here also I just wanted to be consistent with the way how vlan_transparent is implemented. I think it is like that because this is called on the create_network_precommit and at that point we can\u0027t say which driver will be used to bound ports later.","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"27f0f236caf8be3bad880e1b18ab518f4a1ddbc9","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        support vlan transparency."},{"line_number":480,"context_line":"        \"\"\""},{"line_number":481,"context_line":"        if context.current.get(\u0027qinq\u0027):"},{"line_number":482,"context_line":"            for driver in self.ordered_mech_drivers:"},{"line_number":483,"context_line":"                if not driver.obj.check_vlan_qinq(context):"},{"line_number":484,"context_line":"                    raise qinq.VlanQinqDriverError()"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5ec21c21_db0d54d4","line":482,"in_reply_to":"7e5e778f_7ce390d0","updated":"2025-02-01 02:41:40.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":1217,"context_line":"            self.type_manager.extend_network_dict_provider(context, result)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"            # Update the transparent vlan if configured"},{"line_number":1220,"context_line":"            vlt \u003d None"},{"line_number":1221,"context_line":"            if extensions.is_extension_supported(self, \u0027vlan-transparent\u0027):"},{"line_number":1222,"context_line":"                vlt \u003d vlan_apidef.get_vlan_transparent(net_data)"},{"line_number":1223,"context_line":"                net_db[\u0027vlan_transparent\u0027] \u003d vlt"}],"source_content_type":"text/x-python","patch_set":11,"id":"124c6f1a_d9b65d46","line":1220,"updated":"2024-12-18 22:10:51.000000000","message":"nit: I find the name of the variable confusing, and now its scope increased... Maybe rename into `is_vlan_transparent` or smth as explicit?","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"            self.type_manager.extend_network_dict_provider(context, result)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"            # Update the transparent vlan if configured"},{"line_number":1220,"context_line":"            vlt \u003d None"},{"line_number":1221,"context_line":"            if extensions.is_extension_supported(self, \u0027vlan-transparent\u0027):"},{"line_number":1222,"context_line":"                vlt \u003d vlan_apidef.get_vlan_transparent(net_data)"},{"line_number":1223,"context_line":"                net_db[\u0027vlan_transparent\u0027] \u003d vlt"}],"source_content_type":"text/x-python","patch_set":11,"id":"bb591d34_10a16e8e","line":1220,"in_reply_to":"124c6f1a_d9b65d46","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}],"neutron/tests/unit/extensions/test_qinq.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7414b4dbf5e0da038074df76c1241c8c2e7cd72b","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                            ctx_manager.exception.code)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # In any other case it should works fine"},{"line_number":112,"context_line":"        with self.network(name\u003d\u0027net1\u0027, as_admin\u003dTrue,"},{"line_number":113,"context_line":"                          arg_list\u003darg_list, **net_kwargs) as net:"},{"line_number":114,"context_line":"            req \u003d self.new_show_request(\u0027networks\u0027, net[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"4e870486_415ba082","line":111,"updated":"2024-12-18 22:10:51.000000000","message":"nit: should work","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac43456ff80f99d0b7ab74ac379cbe0ade534506","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                            ctx_manager.exception.code)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # In any other case it should works fine"},{"line_number":112,"context_line":"        with self.network(name\u003d\u0027net1\u0027, as_admin\u003dTrue,"},{"line_number":113,"context_line":"                          arg_list\u003darg_list, **net_kwargs) as net:"},{"line_number":114,"context_line":"            req \u003d self.new_show_request(\u0027networks\u0027, net[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"47110122_5169c139","line":111,"in_reply_to":"4e870486_415ba082","updated":"2024-12-19 09:58:07.000000000","message":"Done","commit_id":"823657223426b003bfe6797a52e03807c6e4efea"}]}