)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"833511f72c600c6f47b3ef53df6ab0c3144f79fe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-31 10:02:28 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"common: add is_monked_patched as helper to eventlet_utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is adding to module eventlet_utils a function which will help to"},{"line_number":10,"context_line":"identify whether libraries are mocked_matched by eventlet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"60a9b7a0_83164a4a","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":29},"updated":"2025-01-06 09:35:02.000000000","message":"nit: is_monkey_patched","commit_id":"9b7a48eabae4888da05241c297210a5bb96cf749"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2ad5360c80607b5ef79136b27c13cf2bd0824fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e54d71c2_a431072f","updated":"2025-01-06 08:49:13.000000000","message":"The idea looks ok, I checked the follow-up patches but can\u0027t find where you use this helper methos","commit_id":"9b7a48eabae4888da05241c297210a5bb96cf749"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d45038647d397113ee1273bad0844e1ce1e48a2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a1fcd30_0613d48d","updated":"2025-01-06 14:47:51.000000000","message":"Yes, thankyou Lajos I used it previously but I\u0027m not quite sure it will be useful now..","commit_id":"9b7a48eabae4888da05241c297210a5bb96cf749"}],"neutron/common/eventlet_utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9ca5d3ef3bae06024ba497ccb220c20fb7ef4da2","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        IS_MONKEY_PATCHED \u003d True"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def is_monkey_patched(library):"},{"line_number":35,"context_line":"    # pylint: disable\u003dimport-outside-toplevel"},{"line_number":36,"context_line":"    from oslo_utils import eventletutils"},{"line_number":37,"context_line":"    from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":5,"id":"b586af16_25dd98ff","line":34,"updated":"2025-01-06 14:56:08.000000000","message":"this shoudl just return the value of IS_MONKEY_PATCHED\n\nthe call to eventlet.monkey_patch() will monkey patch all supproted modules by default so we shoudl not be checking on a per module basis","commit_id":"42ce8db52f6e4ef8dc8f42c3750951a308eae455"}],"neutron/tests/unit/common/test_eventlet_utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33e4c7ec5b11d7590c97a08303417bc20faf263b","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @mock.patch(\u0027oslo_utils.importutils.try_import\u0027, return_value\u003dFalse)"},{"line_number":24,"context_line":"    def test_is_monkey_patched_eventlet_notfound(self, mocked_try_import):"},{"line_number":25,"context_line":"        self.assertFalse(eventlet_utils.is_monkey_patched(\u0027threading\u0027))"},{"line_number":26,"context_line":"        mocked_try_import.assert_called_once()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(\u0027oslo_utils.eventletutils.is_monkey_patched\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9e7c4eb9_841b2ff3","line":25,"range":{"start_line":25,"start_character":59,"end_line":25,"end_character":68},"updated":"2025-01-06 14:58:57.000000000","message":"if you were to test this its better to use the thread module not threading.\n\nthread act weriedly as in some contest it can return false even if monkey patchting has been enabeld.\n\ni was warned explictly not to rely on eventlet_utils.is_monkey_patched(\u0027threading\u0027) to determin if the curent thead/interpertr is eventlet monkey patched.\n\nthis is what we plan to do for nova and what i have done in watcher\n\nhttps://review.opendev.org/c/openstack/nova/+/922425/5/nova/monkey_patch.py","commit_id":"42ce8db52f6e4ef8dc8f42c3750951a308eae455"}]}