)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9f9182da4883e90e3a6fecc3be8a0f9f1237988c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"It may be useful to disable, or change, the activation strategy used for"},{"line_number":10,"context_line":"live migrated ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes: #2092250"},{"line_number":13,"context_line":"Reported: https://issues.redhat.com/browse/OSPRH-12571"},{"line_number":14,"context_line":"Change-Id: Ifa95157c24efab27898b70032aaa657365603f9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"604f6c1e_b3834091","line":12,"updated":"2024-12-20 15:56:40.000000000","message":"`Closes-Bug:` to make it linked to the LP","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f33aa086b96dffa76e3d20c472e74ffac470569c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It may be useful to disable, or change, the activation strategy used for"},{"line_number":10,"context_line":"live migrated ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes: #2092250"},{"line_number":13,"context_line":"Reported: https://issues.redhat.com/browse/OSPRH-12571"},{"line_number":14,"context_line":"Change-Id: Ifa95157c24efab27898b70032aaa657365603f9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"52214aa7_bfdc032a","line":12,"in_reply_to":"604f6c1e_b3834091","updated":"2024-12-20 16:42:00.000000000","message":"Done","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eb59ddb1adc3d6ded5099f07980abffa430a703b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2bab658e_23f50b81","updated":"2024-12-20 15:55:32.000000000","message":"LGTM, some suggestions regarding the config option.","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"148ee9131217eb972c89b8b0431d8ffa59c1834e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe7daa1e_83a4315f","updated":"2024-12-23 07:59:50.000000000","message":"recheck neutron-tempest-plugin-ovn tempest repo issue","commit_id":"978e804721765d3314955a6b890b6cac5a8b5f89"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1c82f398685cdf593ebacc2cff6a6ab15c74e708","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45faff26_3a58c42e","updated":"2025-01-13 16:23:18.000000000","message":"Resolved a conflict.","commit_id":"1597602ff0d1431a96a15ac4c9045e5a18ab9f8d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"13d217c1b738fbc845ce800818153d1333015791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fcc3fa90_711093d9","updated":"2025-01-17 15:10:07.000000000","message":"recheck another instance of hash ring losing ovn events","commit_id":"1597602ff0d1431a96a15ac4c9045e5a18ab9f8d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05a8f5eb392758243421d0232f6f638cb6d9f2cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f1e176b_37695311","updated":"2025-01-14 18:41:30.000000000","message":"recheck bug 2094846","commit_id":"1597602ff0d1431a96a15ac4c9045e5a18ab9f8d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ed078d9a78aabb508ef900e0ba937c4136b318d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"077cb63a_1869d01d","updated":"2025-01-17 18:58:15.000000000","message":"recheck bug 2095196","commit_id":"949b098626b7df409c7dac4c16295e47ac105437"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f2e2a962b4d702cb7411776714621b7bd58d48d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0dbec55_6463ee16","updated":"2025-01-16 06:39:03.000000000","message":"recheck openstack-tox-cover","commit_id":"949b098626b7df409c7dac4c16295e47ac105437"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eb59ddb1adc3d6ded5099f07980abffa430a703b","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                       \u0027similar to the default ML2/OVS behavior. Defaults to \u0027"},{"line_number":232,"context_line":"                       \u0027\"False\".\u0027)),"},{"line_number":233,"context_line":"    cfg.StrOpt(\u0027live_migration_activation_strategy\u0027,"},{"line_number":234,"context_line":"               default\u003d\"rarp\","},{"line_number":235,"context_line":"               help\u003d_(\u0027Activation strategy to use for live migration. \u0027"},{"line_number":236,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":237,"context_line":"                      \u0027activated on the destination host.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"50c680dd_662100d7","line":234,"updated":"2024-12-20 15:55:32.000000000","message":"Shall we limit allowed values here with the `choices` parameter and then describe in the help what each parameter means?","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"86eb532c2098f1c2912e4e527ba392b6ed4903ef","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                       \u0027similar to the default ML2/OVS behavior. Defaults to \u0027"},{"line_number":232,"context_line":"                       \u0027\"False\".\u0027)),"},{"line_number":233,"context_line":"    cfg.StrOpt(\u0027live_migration_activation_strategy\u0027,"},{"line_number":234,"context_line":"               default\u003d\"rarp\","},{"line_number":235,"context_line":"               help\u003d_(\u0027Activation strategy to use for live migration. \u0027"},{"line_number":236,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":237,"context_line":"                      \u0027activated on the destination host.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"69f92d96_84171892","line":234,"in_reply_to":"50c680dd_662100d7","updated":"2024-12-20 16:33:35.000000000","message":"We\u0027ll need another patch once OVN adds a new strategy (to handle GARPs). But yeah I think you are right, better tighten it up.","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f33aa086b96dffa76e3d20c472e74ffac470569c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                       \u0027similar to the default ML2/OVS behavior. Defaults to \u0027"},{"line_number":232,"context_line":"                       \u0027\"False\".\u0027)),"},{"line_number":233,"context_line":"    cfg.StrOpt(\u0027live_migration_activation_strategy\u0027,"},{"line_number":234,"context_line":"               default\u003d\"rarp\","},{"line_number":235,"context_line":"               help\u003d_(\u0027Activation strategy to use for live migration. \u0027"},{"line_number":236,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":237,"context_line":"                      \u0027activated on the destination host.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5dbbcf0_c32df6de","line":234,"in_reply_to":"69f92d96_84171892","updated":"2024-12-20 16:42:00.000000000","message":"Done","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92f5be4bb775901433902b2bd6efb15ac5107847","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                      \u0027The default `rarp` strategy expects the hypervisor to \u0027"},{"line_number":238,"context_line":"                      \u0027send a Reverse ARP request through the migrated port \u0027"},{"line_number":239,"context_line":"                      \u0027after migration is complete. \u0027"},{"line_number":240,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":241,"context_line":"                      \u0027activated on the destination host.\u0027)),"},{"line_number":242,"context_line":"]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7c4c673a_e9552f67","line":240,"updated":"2025-01-14 08:47:17.000000000","message":"Not sure if we should mention this here somewhere that nova implements similar functionality https://github.com/openstack/nova/blob/77e9ec0a6534ea3a377e39b17027e5c573166974/nova/conf/workarounds.py#L364","commit_id":"1597602ff0d1431a96a15ac4c9045e5a18ab9f8d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0ee1df01b8b86b8d4557e9be3563ed5e41814090","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                      \u0027The default `rarp` strategy expects the hypervisor to \u0027"},{"line_number":238,"context_line":"                      \u0027send a Reverse ARP request through the migrated port \u0027"},{"line_number":239,"context_line":"                      \u0027after migration is complete. \u0027"},{"line_number":240,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":241,"context_line":"                      \u0027activated on the destination host.\u0027)),"},{"line_number":242,"context_line":"]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f659a74a_0682fc42","line":240,"in_reply_to":"64452a97_3f5b9ebd","updated":"2025-01-14 18:09:20.000000000","message":"Done","commit_id":"1597602ff0d1431a96a15ac4c9045e5a18ab9f8d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5f2f38b9793bddaa5e189a4542175abb4a887c0f","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                      \u0027The default `rarp` strategy expects the hypervisor to \u0027"},{"line_number":238,"context_line":"                      \u0027send a Reverse ARP request through the migrated port \u0027"},{"line_number":239,"context_line":"                      \u0027after migration is complete. \u0027"},{"line_number":240,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":241,"context_line":"                      \u0027activated on the destination host.\u0027)),"},{"line_number":242,"context_line":"]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"64452a97_3f5b9ebd","line":240,"in_reply_to":"7c4c673a_e9552f67","updated":"2025-01-14 16:02:52.000000000","message":"I think this nova workaround will not send RARP either because the same code path in qemu will be used to trigger announcements through announce-self command as when qemu is driving live migration. Sadly we\u0027ll have to wait for qemu, ovn, and/or kernel to fix this.","commit_id":"1597602ff0d1431a96a15ac4c9045e5a18ab9f8d"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eb59ddb1adc3d6ded5099f07980abffa430a703b","unresolved":true,"context_lines":[{"line_number":506,"context_line":"                           )"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def _configure_requested_chassis_options(self, options, port):"},{"line_number":509,"context_line":"        options \u003d copy.deepcopy(options)"},{"line_number":510,"context_line":"        chassis \u003d utils.determine_bind_host(self._sb_idl, port)"},{"line_number":511,"context_line":"        if chassis:"},{"line_number":512,"context_line":"            # If OVN supports multi-chassis port bindings, use it for live"}],"source_content_type":"text/x-python","patch_set":1,"id":"95f75e1b_dccd6d3d","line":509,"updated":"2024-12-20 15:55:32.000000000","message":"Do we need to make a copy here? Since it is overwriting the original on L493 perhaps it is not necessary and can be just updated with a reference (not returning the `options` at all)?","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b99190e8d30031f4df22dea5e37b99e015d5220e","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                           )"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def _configure_requested_chassis_options(self, options, port):"},{"line_number":509,"context_line":"        options \u003d copy.deepcopy(options)"},{"line_number":510,"context_line":"        chassis \u003d utils.determine_bind_host(self._sb_idl, port)"},{"line_number":511,"context_line":"        if chassis:"},{"line_number":512,"context_line":"            # If OVN supports multi-chassis port bindings, use it for live"}],"source_content_type":"text/x-python","patch_set":1,"id":"11a80aae_efefafc3","line":509,"in_reply_to":"5c3b6609_e72483f6","updated":"2024-12-20 16:51:53.000000000","message":"Done","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"86eb532c2098f1c2912e4e527ba392b6ed4903ef","unresolved":true,"context_lines":[{"line_number":506,"context_line":"                           )"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def _configure_requested_chassis_options(self, options, port):"},{"line_number":509,"context_line":"        options \u003d copy.deepcopy(options)"},{"line_number":510,"context_line":"        chassis \u003d utils.determine_bind_host(self._sb_idl, port)"},{"line_number":511,"context_line":"        if chassis:"},{"line_number":512,"context_line":"            # If OVN supports multi-chassis port bindings, use it for live"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c3b6609_e72483f6","line":509,"in_reply_to":"95f75e1b_dccd6d3d","updated":"2024-12-20 16:33:35.000000000","message":"It\u0027s defensive copying. In this case, both would work but I\u0027m trying to write my functions so that they don\u0027t modify passed arguments unless the caller wants to. Since it\u0027s the only caller right now and we control it, we could avoid copying too, but it\u0027s a style choice.","commit_id":"dd131f3d0945d2428a7bc1bb25bbb66ea0ede00a"}]}