)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e57c21673f579c02ea9b656e34227c1f08277614","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-03-07 13:54:28 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If OVS Manager creation failes retry to set values"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2093433"},{"line_number":10,"context_line":"Change-Id: Idf9d8247631e20b446728945244a861e2ec9d93f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"53d2e96a_40a3c883","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":30},"updated":"2025-03-14 15:54:53.000000000","message":"nit: fails","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"83d6807e39711b7476f3107acd20a3cb4d3e9018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6728db2_1442f47f","updated":"2025-01-17 09:31:31.000000000","message":"recheck\nOVN test failure is not related","commit_id":"44086086c28297077cf8cc3fdfc72946d8f3a1fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6141dd2539389e5aa33feb6bb82e4dd387ff863a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1cba290c_18434a56","updated":"2025-01-27 07:51:07.000000000","message":"recheck\nfailures are not related (i.e.: pagination issue in tempest)","commit_id":"bd69e04a31fb7a50eff93821e997dc16d6dcf7db"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a50934f78b17615b588cae5face8e6ccadb7a4c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b44b69e_929c72fe","updated":"2025-01-24 13:23:38.000000000","message":"recheck\novn-tempest failure is not related, image build issue: \"Failure prepping block device\"","commit_id":"bd69e04a31fb7a50eff93821e997dc16d6dcf7db"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"de9b299acca5716a965d6795868230663e4bb284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b73ca673_cab5996e","updated":"2025-01-28 09:26:36.000000000","message":"That is a great change, I have noticed that issue several time when trying to update inactivity_probe.\n\nCan you perhaps articulate the change with some tests to assert the behavior?","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bca0ec9be260c3a3ad8016ee87cf9d2d95db44cd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16ef2787_82aab8a3","in_reply_to":"78aa714d_79e26f91","updated":"2025-02-25 13:24:11.000000000","message":"I added a new functional, but I am not proud of it. It can check that the first call of enable_connection_uri returns a uuid, the 2nd as that is a ovs-vsctl set not a create returns nothing.","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cd14cd1f843eb01c0595266436a662de343c7ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f6d9b630_1231cf5e","in_reply_to":"7dc8d741_a0f0f8d2","updated":"2025-02-04 17:42:24.000000000","message":"I checked the functional test you mentioned, but it creates Managers (https://opendev.org/openstack/neutron/src/branch/master/neutron/tests/functional/agent/ovsdb/native/test_helpers.py#L34 ) and with ovsdb I can list managers after creating them, (the output is like : \u0027ptcp:6640:127.0.0.1\u0027) and can\u0027t mock it to create manager without inactivity probe or with wrong value.\nSo testing this part of Neutron with the current frameworks is not easy.","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"563650c6e420c4226f6c2e5fd69937a14157412d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c19375ba_d7d84b7d","in_reply_to":"b73ca673_cab5996e","updated":"2025-01-30 13:38:43.000000000","message":"I checked and actually I start to understand better why there are no unit tests for this module. As there is a decorator on the method (@privileged.ovs_vsctl_cmd.entrypoint which points to oslo_provsep.Provcontext.entrypoint) I don\u0027t know how this should be tested. If you see a way to test this I am very interested.","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e17197db19fb2d4cc2202d62f2bae7ace44ec9db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7dc8d741_a0f0f8d2","in_reply_to":"c19375ba_d7d84b7d","updated":"2025-01-31 16:25:32.000000000","message":"There is a functional test that articulate that part, isn\u0027t that possible to update it to validate change regarding inactivity probe?","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fa99028042cd09c31e2c51dea842c1580bc73cbf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78aa714d_79e26f91","in_reply_to":"f6d9b630_1231cf5e","updated":"2025-02-21 09:08:56.000000000","message":"I understand your point that does not look easy... But do you feel confident to merge a change like that without something to articulate it a bit? honestly I feel a bit scary even if I\u0027m sure you have tested it locally.\n\nIf you create a new class EnableConnectionUriTestCase without the creation?","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6ac4e76d96d4f7fea259028ed40232b15c3e2476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"525a3571_237d5b8f","updated":"2025-02-19 13:40:00.000000000","message":"recheck\nfullstack failure is not related","commit_id":"d60af16d9938ce8f0a88f6514e28493668ae04da"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d829e4b288c779bdcc45ac84b2fcea3d3dd571f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d6a1e6c5_bd548d93","updated":"2025-03-03 12:44:52.000000000","message":"recheck\nfailures are not related","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8725bbf622a972f28e22d111a70ba6985acfb8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23843308_42800b3c","updated":"2025-03-03 09:14:27.000000000","message":"recheck\ngreande failure is not realted","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8834409bc053d8f9838554bacd66fe996f621bab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bcb29224_d47537f8","updated":"2025-03-04 09:45:58.000000000","message":"recheck\novs and ovn tempest job failures are not related","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f23367ea137decec6958ac7393e401bbeee07cfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87f8f998_4b1d2cde","updated":"2025-02-28 12:51:15.000000000","message":"recheck\ntest_vlan_transparent_allowed_address_pairs in neutron-tempest-plugin-ovn-ubuntu-jammy is not related","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fac6c0699c89fce9a9886790a3864c8f683402da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9c1737a3_8ebb9863","updated":"2025-03-06 11:04:41.000000000","message":"recheck\nfunctional failure is not related (test_ovn_sb_sync_add_new_host)","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c6ef0a78436d7b9a2306c254d52084c71cad2e36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d319c66e_84d14a3b","updated":"2025-03-10 07:22:52.000000000","message":"recheck\nneutron-tempest-plugin-openvswitch job failure is not related (test_ipv6_hotplug_dhcpv6stateless )","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab3df5ecf8fcd70af97b6ce706520559b6835f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c20d8fc1_f1b5adec","updated":"2025-03-18 15:07:07.000000000","message":"Can probably mark some of the comments resolved as well","commit_id":"4a2c02a98062a5e48daf6b26e26214483a2cf50b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"437665657d64eece0e611d708c2f298a18a90be0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f08e7f3f_0df0c8f5","updated":"2025-03-26 17:01:15.000000000","message":"You don\u0027t want to highlight your change with a release note, it\u0027s a really good improvement for operators that are struggling with configure the value?\n\nI remember that it was complicated to update the manager value for all the hosts. \n\nThanks !","commit_id":"b5c912d090b74c204404f8a434cd5d24c41b46eb"}],"neutron/privileged/agent/ovsdb/native/helpers.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e17197db19fb2d4cc2202d62f2bae7ace44ec9db","unresolved":true,"context_lines":[{"line_number":49,"context_line":"           \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027, \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":50,"context_line":"    if probe is not None:"},{"line_number":51,"context_line":"        cmd +\u003d [\u0027--\u0027, \u0027set\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        return processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c8106d6_0f753ee8","line":52,"updated":"2025-01-31 16:25:32.000000000","message":"Perhaps we could check first if the manager already exist, remove it, and in all cases and create a new one?","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cd14cd1f843eb01c0595266436a662de343c7ea","unresolved":true,"context_lines":[{"line_number":49,"context_line":"           \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027, \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":50,"context_line":"    if probe is not None:"},{"line_number":51,"context_line":"        cmd +\u003d [\u0027--\u0027, \u0027set\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        return processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a56d500c_e753fd70","line":52,"in_reply_to":"4c8106d6_0f753ee8","updated":"2025-02-04 17:42:24.000000000","message":"I was thinking on it if that is faster perhaps, but I don\u0027t think so, and anyway deleting it after agent restart for example can have more side effects, what do you think?","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"aeabe70f42dcbd305ffe9bf24a4ca78d20ec1f2c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"           \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027, \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":50,"context_line":"    if probe is not None:"},{"line_number":51,"context_line":"        cmd +\u003d [\u0027--\u0027, \u0027set\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        return processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"}],"source_content_type":"text/x-python","patch_set":3,"id":"44aeddbf_3a320bfe","line":52,"in_reply_to":"894a65cc_4af3f14d","updated":"2025-03-04 17:05:02.000000000","message":"Done","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fa99028042cd09c31e2c51dea842c1580bc73cbf","unresolved":true,"context_lines":[{"line_number":49,"context_line":"           \u0027--\u0027, \u0027add\u0027, \u0027Open_vSwitch\u0027, \u0027.\u0027, \u0027manager_options\u0027, \u0027@manager\u0027]"},{"line_number":50,"context_line":"    if probe is not None:"},{"line_number":51,"context_line":"        cmd +\u003d [\u0027--\u0027, \u0027set\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":52,"context_line":"    try:"},{"line_number":53,"context_line":"        return processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"}],"source_content_type":"text/x-python","patch_set":3,"id":"894a65cc_4af3f14d","line":52,"in_reply_to":"a56d500c_e753fd70","updated":"2025-02-21 09:08:56.000000000","message":"You made a good point but normally that should not creat any problem. But I can\u0027t be totally sure so I won\u0027t push too much :-)","commit_id":"d9973c8205943ef1a3305aca3a020f3757054c02"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"744901e979f9727ae83ecf2a4d8aad84cdbe34ce","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, %s, probably the Manager \""},{"line_number":57,"context_line":"                    \"already exists\", pe.exit_code)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"65279523_e981c431","line":57,"range":{"start_line":57,"start_character":37,"end_line":57,"end_character":50},"updated":"2025-03-04 22:58:56.000000000","message":"So is this just a return code, like -1 ? Want to make sure we show something useful. Also, I would change to have the error at the end, something like:\n\n\"OVS Manager creation failed, it might already exist (%s)\"","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"58ff906384b35d584243030c7614ec5b7d32f586","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, %s, probably the Manager \""},{"line_number":57,"context_line":"                    \"already exists\", pe.exit_code)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"6a677a3d_6790121b","line":57,"range":{"start_line":57,"start_character":37,"end_line":57,"end_character":50},"in_reply_to":"65279523_e981c431","updated":"2025-03-05 13:34:58.000000000","message":"yes return code is like 0 or 1, perhaps I add also like  (exit code: %s)","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89585cfa2ce3fa820442ca502ae3a1d6f6e572f4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, %s, probably the Manager \""},{"line_number":57,"context_line":"                    \"already exists\", pe.exit_code)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf174ece_2d6d23c7","line":57,"range":{"start_line":57,"start_character":37,"end_line":57,"end_character":50},"in_reply_to":"6a677a3d_6790121b","updated":"2025-03-20 13:42:32.000000000","message":"Done","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"744901e979f9727ae83ecf2a4d8aad84cdbe34ce","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"},{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"}],"source_content_type":"text/x-python","patch_set":6,"id":"543dfe7d_932f3e97","line":62,"range":{"start_line":62,"start_character":45,"end_line":62,"end_character":54},"updated":"2025-03-04 22:58:56.000000000","message":"missing space before log_errors, surprised pep8 job didn\u0027t complain.","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"58ff906384b35d584243030c7614ec5b7d32f586","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"},{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"}],"source_content_type":"text/x-python","patch_set":6,"id":"6eaab5b6_c14d9198","line":62,"range":{"start_line":62,"start_character":45,"end_line":62,"end_character":54},"in_reply_to":"543dfe7d_932f3e97","updated":"2025-03-05 13:34:58.000000000","message":"Done","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"744901e979f9727ae83ecf2a4d8aad84cdbe34ce","unresolved":true,"context_lines":[{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"}],"source_content_type":"text/x-python","patch_set":6,"id":"07a8f2c7_bd2760ac","line":64,"updated":"2025-03-04 22:58:56.000000000","message":"probe can be None, right? So this will compare againts \u0027None\u0027 is that correct?","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"58ff906384b35d584243030c7614ec5b7d32f586","unresolved":true,"context_lines":[{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d104e28_8cf302e2","line":64,"in_reply_to":"07a8f2c7_bd2760ac","updated":"2025-03-05 13:34:58.000000000","message":"yes, for that an extra if after the except can make this whole thing conditional, on the other hand we always set the inactivity probe to some default value as I remember","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89585cfa2ce3fa820442ca502ae3a1d6f6e572f4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"}],"source_content_type":"text/x-python","patch_set":6,"id":"91d9ad25_3c025415","line":64,"in_reply_to":"8d104e28_8cf302e2","updated":"2025-03-20 13:42:32.000000000","message":"Done","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"744901e979f9727ae83ecf2a4d8aad84cdbe34ce","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":68,"context_line":"        return processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"}],"source_content_type":"text/x-python","patch_set":6,"id":"db51f7ba_bb6f506d","line":65,"updated":"2025-03-04 22:58:56.000000000","message":"One thing I notice is returning here and below is that we already printed a Warning message, but did not print any follow-up message. I think we should log something.","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"58ff906384b35d584243030c7614ec5b7d32f586","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":68,"context_line":"        return processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"}],"source_content_type":"text/x-python","patch_set":6,"id":"044c3401_add3be1f","line":65,"in_reply_to":"db51f7ba_bb6f506d","updated":"2025-03-05 13:34:58.000000000","message":"Done","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"744901e979f9727ae83ecf2a4d8aad84cdbe34ce","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":68,"context_line":"        return processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":69,"context_line":"                                    check_exit_code\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"130a60b7_1bb5145f","line":68,"range":{"start_line":68,"start_character":41,"end_line":68,"end_character":51},"updated":"2025-03-04 22:58:56.000000000","message":"Same as above.","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"58ff906384b35d584243030c7614ec5b7d32f586","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            return in_probe"},{"line_number":66,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":67,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":68,"context_line":"        return processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":69,"context_line":"                                    check_exit_code\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fc644332_07faa282","line":68,"range":{"start_line":68,"start_character":41,"end_line":68,"end_character":51},"in_reply_to":"130a60b7_1bb5145f","updated":"2025-03-05 13:34:58.000000000","message":"Done","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"537d7d6193448d9d6d123ff104dd8b70c9cec508","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (%s).\", pe.exit_code)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1e02db76_3b699a9d","line":57,"range":{"start_line":57,"start_character":35,"end_line":57,"end_character":47},"updated":"2025-03-06 19:01:50.000000000","message":"Just a follow-on from my last comment, but is it better to just print the whole string, i.e. use \u0027pe\u0027 here?","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d19e77667eba560b96cddb2deaa2b383d8607fd","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (%s).\", pe.exit_code)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"97521041_2550fbdb","line":57,"range":{"start_line":57,"start_character":35,"end_line":57,"end_character":47},"in_reply_to":"1e02db76_3b699a9d","updated":"2025-03-07 13:18:44.000000000","message":"stderr is something like: \"multiple rows in Manager match .....\", so that is really more informative","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89585cfa2ce3fa820442ca502ae3a1d6f6e572f4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (%s).\", pe.exit_code)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"e894270d_b0074e62","line":57,"range":{"start_line":57,"start_character":35,"end_line":57,"end_character":47},"in_reply_to":"97521041_2550fbdb","updated":"2025-03-20 13:42:32.000000000","message":"Done","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"537d7d6193448d9d6d123ff104dd8b70c9cec508","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":69,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":70,"context_line":"        ret_val \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":71,"context_line":"                                       check_exit_code\u003dTrue)"},{"line_number":72,"context_line":"        LOG.info(\"OVS Manager was set with new inactivity_probe value %s.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"ab02a8a8_715cdac6","line":69,"range":{"start_line":69,"start_character":59,"end_line":69,"end_character":64},"updated":"2025-03-06 19:01:50.000000000","message":"Is it Ok to use None for probe? It might not be set.","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"89585cfa2ce3fa820442ca502ae3a1d6f6e572f4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":69,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":70,"context_line":"        ret_val \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":71,"context_line":"                                       check_exit_code\u003dTrue)"},{"line_number":72,"context_line":"        LOG.info(\"OVS Manager was set with new inactivity_probe value %s.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"41d74a69_7b1025a3","line":69,"range":{"start_line":69,"start_character":59,"end_line":69,"end_character":64},"in_reply_to":"91a97557_b204cf8b","updated":"2025-03-20 13:42:32.000000000","message":"Done","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d19e77667eba560b96cddb2deaa2b383d8607fd","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":69,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":70,"context_line":"        ret_val \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":71,"context_line":"                                       check_exit_code\u003dTrue)"},{"line_number":72,"context_line":"        LOG.info(\"OVS Manager was set with new inactivity_probe value %s.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"91a97557_b204cf8b","line":69,"range":{"start_line":69,"start_character":59,"end_line":69,"end_character":64},"in_reply_to":"ab02a8a8_715cdac6","updated":"2025-03-07 13:18:44.000000000","message":"if we have a Manager already and probe value is empty (I don\u0027t think that can happen) the whole part after with set is not necessary, so I added an if for that","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"537d7d6193448d9d6d123ff104dd8b70c9cec508","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":69,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":70,"context_line":"        ret_val \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":71,"context_line":"                                       check_exit_code\u003dTrue)"},{"line_number":72,"context_line":"        LOG.info(\"OVS Manager was set with new inactivity_probe value %s.\","},{"line_number":73,"context_line":"                 probe)"}],"source_content_type":"text/x-python","patch_set":7,"id":"40bdd7c7_5fc9fa45","line":70,"range":{"start_line":70,"start_character":44,"end_line":70,"end_character":54},"updated":"2025-03-06 19:01:50.000000000","message":"missing space here","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d19e77667eba560b96cddb2deaa2b383d8607fd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":69,"context_line":"               \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"},{"line_number":70,"context_line":"        ret_val \u003d processutils.execute(*cmd,log_errors\u003dlog_fail_as_error,"},{"line_number":71,"context_line":"                                       check_exit_code\u003dTrue)"},{"line_number":72,"context_line":"        LOG.info(\"OVS Manager was set with new inactivity_probe value %s.\","},{"line_number":73,"context_line":"                 probe)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fdf0cbcb_3ecbfd1c","line":70,"range":{"start_line":70,"start_character":44,"end_line":70,"end_character":54},"in_reply_to":"40bdd7c7_5fc9fa45","updated":"2025-03-07 13:18:44.000000000","message":"Done","commit_id":"0c903acf75de1c80934ab88dcedc51a70aee0b0b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e57c21673f579c02ea9b656e34227c1f08277614","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (stderr: %s).\", pe.stderr)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f145419_2c1dc5dc","line":57,"updated":"2025-03-14 15:54:53.000000000","message":"From here down, if probe is None there is nothing to be done. I think you should add that check here:\n\nif probe is None:\n    return\n\nThen you can remove the checks below","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1de89cbbcc0f984332ebb52746279b85502244b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                    check_exit_code\u003dcheck_exit_code)"},{"line_number":55,"context_line":"    except processutils.ProcessExecutionError as pe:"},{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (stderr: %s).\", pe.stderr)"},{"line_number":58,"context_line":"        # Try to fetch Manager table as it is already exists and see if"},{"line_number":59,"context_line":"        # inactivity_probe is already the desired value"},{"line_number":60,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--id\u003d@manager\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4e11af97_0498d2ff","line":57,"in_reply_to":"7f145419_2c1dc5dc","updated":"2025-03-17 16:42:32.000000000","message":"Done","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e57c21673f579c02ea9b656e34227c1f08277614","unresolved":true,"context_lines":[{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if probe is not None and in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            LOG.info(\"OVS Manager is already created and inactivity_probe \""},{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"}],"source_content_type":"text/x-python","patch_set":8,"id":"8247cfe0_bfcc9799","line":64,"updated":"2025-03-14 15:54:53.000000000","message":"Should this check in_probe is valid?","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5c54ffea4fdd6724969031a1a88af52e7f85aa64","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if probe is not None and in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            LOG.info(\"OVS Manager is already created and inactivity_probe \""},{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"}],"source_content_type":"text/x-python","patch_set":8,"id":"c9cda85c_c3eb90c3","line":64,"in_reply_to":"5e4beb2d_4300f6da","updated":"2025-03-20 09:09:49.000000000","message":"Done","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1de89cbbcc0f984332ebb52746279b85502244b","unresolved":true,"context_lines":[{"line_number":61,"context_line":"               \u0027--\u0027, \u0027get\u0027, \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u0027]"},{"line_number":62,"context_line":"        in_probe \u003d processutils.execute(*cmd, log_errors\u003dlog_fail_as_error,"},{"line_number":63,"context_line":"                                        check_exit_code\u003dTrue)"},{"line_number":64,"context_line":"        if probe is not None and in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            LOG.info(\"OVS Manager is already created and inactivity_probe \""},{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"}],"source_content_type":"text/x-python","patch_set":8,"id":"5e4beb2d_4300f6da","line":64,"in_reply_to":"8247cfe0_bfcc9799","updated":"2025-03-17 16:42:32.000000000","message":"yes, processutils.execute returns a tuple (stdout, stderr)\nhttps://opendev.org/openstack/oslo.concurrency/src/commit/71698aa516b6fac563e251d5e878b5b5290788ff/oslo_concurrency/processutils.py#L249","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e57c21673f579c02ea9b656e34227c1f08277614","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        if probe is not None and in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            LOG.info(\"OVS Manager is already created and inactivity_probe \""},{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        if probe is not None:"},{"line_number":69,"context_line":"            cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":70,"context_line":"                   \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5c278989_e89be95c","line":67,"updated":"2025-03-14 15:54:53.000000000","message":"From looking at callers, no one uses the return value from this method. If that\u0027s true we don\u0027t need it here or below, or even on L53 I guess","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5c54ffea4fdd6724969031a1a88af52e7f85aa64","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        if probe is not None and in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            LOG.info(\"OVS Manager is already created and inactivity_probe \""},{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        if probe is not None:"},{"line_number":69,"context_line":"            cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":70,"context_line":"                   \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"}],"source_content_type":"text/x-python","patch_set":8,"id":"0a32804a_4393b7c1","line":67,"in_reply_to":"470107ee_ce9ba2f4","updated":"2025-03-20 09:09:49.000000000","message":"Done","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1de89cbbcc0f984332ebb52746279b85502244b","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        if probe is not None and in_probe[0].strip() \u003d\u003d str(probe):"},{"line_number":65,"context_line":"            LOG.info(\"OVS Manager is already created and inactivity_probe \""},{"line_number":66,"context_line":"                     \"is set to %s.\", in_probe[0].strip())"},{"line_number":67,"context_line":"            return in_probe"},{"line_number":68,"context_line":"        if probe is not None:"},{"line_number":69,"context_line":"            cmd \u003d [\u0027ovs-vsctl\u0027, \u0027--timeout\u003d%d\u0027 % timeout, \u0027--\u0027, \u0027set\u0027,"},{"line_number":70,"context_line":"                   \u0027Manager\u0027, man_uri, \u0027inactivity_probe\u003d%s\u0027 % probe]"}],"source_content_type":"text/x-python","patch_set":8,"id":"470107ee_ce9ba2f4","line":67,"in_reply_to":"5c278989_e89be95c","updated":"2025-03-17 16:42:32.000000000","message":"yeah, that was more out of habit to return, but true no actual callers use the return value now","commit_id":"6af2f2ad8791712cb3b5bf4e58afb41bfd0196f4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c271fd86b1bec16ac2b4634deab7b8f221c992c3","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (stderr: %s).\", pe.stderr)"},{"line_number":58,"context_line":"        if probe is None:"},{"line_number":59,"context_line":"            LOG.debug(\"No new value for inactivity_probe re-creation of \""},{"line_number":60,"context_line":"                      \"Manager is not necessary\")"},{"line_number":61,"context_line":"            return"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Try to fetch Manager table as it is already exists and see if"}],"source_content_type":"text/x-python","patch_set":9,"id":"4a47d39f_2b2e3b2f","line":60,"range":{"start_line":59,"start_character":23,"end_line":60,"end_character":47},"updated":"2025-03-17 20:48:01.000000000","message":"Missing OVS and comma:\n\n\"No new value for inactivity_probe, re-creation of OVS Manager is not necessary\"","commit_id":"9f9f5d0f18f4e18109bb36fc643c62293c7785ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aec0734f2360271ebbff39a05646b0cd52b5c460","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        LOG.warning(\"OVS Manager creation failed, it might already \""},{"line_number":57,"context_line":"                    \"exist (stderr: %s).\", pe.stderr)"},{"line_number":58,"context_line":"        if probe is None:"},{"line_number":59,"context_line":"            LOG.debug(\"No new value for inactivity_probe re-creation of \""},{"line_number":60,"context_line":"                      \"Manager is not necessary\")"},{"line_number":61,"context_line":"            return"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Try to fetch Manager table as it is already exists and see if"}],"source_content_type":"text/x-python","patch_set":9,"id":"52e8264b_c8da06ce","line":60,"range":{"start_line":59,"start_character":23,"end_line":60,"end_character":47},"in_reply_to":"4a47d39f_2b2e3b2f","updated":"2025-03-20 09:09:02.000000000","message":"Done","commit_id":"9f9f5d0f18f4e18109bb36fc643c62293c7785ef"}],"neutron/tests/functional/agent/ovsdb/native/test_helpers.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"aeabe70f42dcbd305ffe9bf24a4ca78d20ec1f2c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                                                inactivity_probe\u003d100)"},{"line_number":82,"context_line":"            self.assertEqual(0, len(res[0]))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            self.assertIn(manager_connections[index],"},{"line_number":85,"context_line":"                          ovs.ovsdb.get_manager().execute())"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        for remove in manager_removal:"}],"source_content_type":"text/x-python","patch_set":6,"id":"c44a662c_700eb34a","line":84,"updated":"2025-03-04 17:05:02.000000000","message":"Any chance that we check the new value of inactivity probe?","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f8f5017d3dba04a5b7641a86904b3bac587fead6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                inactivity_probe\u003d100)"},{"line_number":82,"context_line":"            self.assertEqual(0, len(res[0]))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            self.assertIn(manager_connections[index],"},{"line_number":85,"context_line":"                          ovs.ovsdb.get_manager().execute())"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        for remove in manager_removal:"}],"source_content_type":"text/x-python","patch_set":6,"id":"c98cba81_387f5f86","line":84,"in_reply_to":"7e6018ec_36aed671","updated":"2025-03-10 10:41:06.000000000","message":"Done","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"58ff906384b35d584243030c7614ec5b7d32f586","unresolved":true,"context_lines":[{"line_number":81,"context_line":"                                                inactivity_probe\u003d100)"},{"line_number":82,"context_line":"            self.assertEqual(0, len(res[0]))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            self.assertIn(manager_connections[index],"},{"line_number":85,"context_line":"                          ovs.ovsdb.get_manager().execute())"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        for remove in manager_removal:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e6018ec_36aed671","line":84,"in_reply_to":"c44a662c_700eb34a","updated":"2025-03-05 13:34:58.000000000","message":"get_manager just returns a list of managers, sadly, perhaps there\u0027s a way to add this method to ovsdbapp, but not sure.","commit_id":"844ab693e1a54ca218bcbe0ae7f49270c110e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c271fd86b1bec16ac2b4634deab7b8f221c992c3","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for index, conn_uri in enumerate(ovsdb_cfg_connections):"},{"line_number":69,"context_line":"            res \u003d helpers.enable_connection_uri(conn_uri,"},{"line_number":70,"context_line":"                                                inactivity_probe\u003d10)"},{"line_number":71,"context_line":"            manager_removal.append(ovs.ovsdb.remove_manager("},{"line_number":72,"context_line":"                manager_connections[index]))"},{"line_number":73,"context_line":"            self.addCleanup(manager_removal[index].execute)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c4ebd140_50ce14fc","line":70,"updated":"2025-03-17 20:48:01.000000000","message":"enable_connection_uri() no longer returns a value, so the checks below fail","commit_id":"9f9f5d0f18f4e18109bb36fc643c62293c7785ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"aec0734f2360271ebbff39a05646b0cd52b5c460","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for index, conn_uri in enumerate(ovsdb_cfg_connections):"},{"line_number":69,"context_line":"            res \u003d helpers.enable_connection_uri(conn_uri,"},{"line_number":70,"context_line":"                                                inactivity_probe\u003d10)"},{"line_number":71,"context_line":"            manager_removal.append(ovs.ovsdb.remove_manager("},{"line_number":72,"context_line":"                manager_connections[index]))"},{"line_number":73,"context_line":"            self.addCleanup(manager_removal[index].execute)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4124307c_3d7a7916","line":70,"in_reply_to":"a310c47c_8f5fa58a","updated":"2025-03-20 09:09:02.000000000","message":"Done","commit_id":"9f9f5d0f18f4e18109bb36fc643c62293c7785ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c9fc88a29bc742ddbda8457bb487f308be9e5c4d","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        for index, conn_uri in enumerate(ovsdb_cfg_connections):"},{"line_number":69,"context_line":"            res \u003d helpers.enable_connection_uri(conn_uri,"},{"line_number":70,"context_line":"                                                inactivity_probe\u003d10)"},{"line_number":71,"context_line":"            manager_removal.append(ovs.ovsdb.remove_manager("},{"line_number":72,"context_line":"                manager_connections[index]))"},{"line_number":73,"context_line":"            self.addCleanup(manager_removal[index].execute)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a310c47c_8f5fa58a","line":70,"in_reply_to":"c4ebd140_50ce14fc","updated":"2025-03-18 11:41:54.000000000","message":"the worse is that I added this test 🤦‍♂️","commit_id":"9f9f5d0f18f4e18109bb36fc643c62293c7785ef"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ab3df5ecf8fcd70af97b6ce706520559b6835f87","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        my_mans \u003d ovs.ovsdb.get_manager().execute()"},{"line_number":79,"context_line":"        self.assertIn(manager_connection, my_mans)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        ovs.ovsdb.remove_manager(manager_connection).execute()"}],"source_content_type":"text/x-python","patch_set":10,"id":"e866351d_68c9b8f4","line":81,"updated":"2025-03-18 15:07:07.000000000","message":"Is this necessary with L67?","commit_id":"4a2c02a98062a5e48daf6b26e26214483a2cf50b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3d4f11b6a801d947a53a1cc50225062e15e44f45","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        my_mans \u003d ovs.ovsdb.get_manager().execute()"},{"line_number":79,"context_line":"        self.assertIn(manager_connection, my_mans)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        ovs.ovsdb.remove_manager(manager_connection).execute()"}],"source_content_type":"text/x-python","patch_set":10,"id":"61fd7e41_76b7aac4","line":81,"in_reply_to":"e866351d_68c9b8f4","updated":"2025-03-20 09:07:43.000000000","message":"yeah, can be removed","commit_id":"4a2c02a98062a5e48daf6b26e26214483a2cf50b"}]}