)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b009a9a2f4d56feae1109bacf59a5b899bf212bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e7778f4_76734e00","updated":"2025-01-14 16:12:55.000000000","message":"looks good, just pep8 issue","commit_id":"6121b27c015e60849d665416324dee26285bae9d"}],"neutron/tests/unit/notifiers/test_nova.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3f160ddf687c7d005394e24bf88d770da90b38fb","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                # At this point, the Nova Notifier should have updated the"},{"line_number":428,"context_line":"                # \"enable\" flag."},{"line_number":429,"context_line":"                _queue.put(new_enable \u003d\u003d nova._notifier_store.enable)"},{"line_number":430,"context_line":"                time.sleep(0)  # Next thread execution."},{"line_number":431,"context_line":"                _queue.put(new_enable \u003d\u003d nova._notifier_store.enable)"},{"line_number":432,"context_line":"            _queue.put(nova.NOTIFIER_ENABLE_DEFAULT \u003d\u003d"},{"line_number":433,"context_line":"                       nova._notifier_store.enable)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e54e605b_6c0b0e47","line":430,"updated":"2025-01-17 07:56:51.000000000","message":"This does not make any different when using native threads,we can perhaps add a comment to note to remove them when we will finish to remove the support of eventlet, especially the monkey patching","commit_id":"366b0e3be20fbeb5b5b8efe105476d710720cb25"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b607a06eb88080c67d23c90e9b8720985d248478","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                # At this point, the Nova Notifier should have updated the"},{"line_number":428,"context_line":"                # \"enable\" flag."},{"line_number":429,"context_line":"                _queue.put(new_enable \u003d\u003d nova._notifier_store.enable)"},{"line_number":430,"context_line":"                time.sleep(0)  # Next thread execution."},{"line_number":431,"context_line":"                _queue.put(new_enable \u003d\u003d nova._notifier_store.enable)"},{"line_number":432,"context_line":"            _queue.put(nova.NOTIFIER_ENABLE_DEFAULT \u003d\u003d"},{"line_number":433,"context_line":"                       nova._notifier_store.enable)"}],"source_content_type":"text/x-python","patch_set":3,"id":"20a2a620_d9071a5a","line":430,"in_reply_to":"e54e605b_6c0b0e47","updated":"2025-01-17 08:12:40.000000000","message":"All the sleep(0) in the code need to be revisited when the eventlet deprecation finishes. There are more of them in the code, but this is an after deprecation task.","commit_id":"366b0e3be20fbeb5b5b8efe105476d710720cb25"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4e820426f6b82406adffe596f70063716a593583","unresolved":true,"context_lines":[{"line_number":436,"context_line":"        num_threads \u003d 20"},{"line_number":437,"context_line":"        threads \u003d []"},{"line_number":438,"context_line":"        for idx in range(num_threads):"},{"line_number":439,"context_line":"            t \u003d threading.Thread(target\u003d_local_executor, args\u003d(idx,))"},{"line_number":440,"context_line":"            t.start()"},{"line_number":441,"context_line":"            threads.append(t)"},{"line_number":442,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f45aa4c_62591cc9","line":439,"updated":"2025-01-23 15:47:36.000000000","message":"I would have argue to use threadpool but it\u0027s a test :-)","commit_id":"e0c9f4c20078cf269027cda8e1f152c8911f9fdb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"116b8839497cb97f4b894a90a708393e26787e36","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        num_threads \u003d 20"},{"line_number":437,"context_line":"        threads \u003d []"},{"line_number":438,"context_line":"        for idx in range(num_threads):"},{"line_number":439,"context_line":"            t \u003d threading.Thread(target\u003d_local_executor, args\u003d(idx,))"},{"line_number":440,"context_line":"            t.start()"},{"line_number":441,"context_line":"            threads.append(t)"},{"line_number":442,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"967b1719_a80c3068","line":439,"in_reply_to":"3f45aa4c_62591cc9","updated":"2025-01-23 16:03:50.000000000","message":"Yes, actually with a ``pool_executor.shutdown()`` I can wait for all threads to stop, but I\u0027m not sure about the API of this class. And it also adds an extra load registering and monitoring the thread, that I don\u0027t want here.","commit_id":"e0c9f4c20078cf269027cda8e1f152c8911f9fdb"}]}