)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a7926ea321b229740818603049cbd93f45461c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ceecc1ce_d234b513","updated":"2025-01-20 08:20:53.000000000","message":"thanks","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"}],"neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bdda83d95391c5b7cc51bd0c046639657abf17b5","unresolved":true,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_agent_metadata_port_dhcp_reenable_event(self):"},{"line_number":365,"context_line":"        # Test the Port_Binding update event triggered by reenable DHCP after"},{"line_number":366,"context_line":"        # disable DHCP on the subnet where the metadata\u0027s port is located."},{"line_number":367,"context_line":"        lswitch_name \u003d \u0027ovn-\u0027 + uuidutils.generate_uuid()"},{"line_number":368,"context_line":"        mdt_port_name \u003d \u0027ovn-mdt-\u0027 + uuidutils.generate_uuid()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"804d14d1_329ce86a","line":366,"updated":"2025-01-17 21:39:29.000000000","message":"Guess the above comment doesn\u0027t fit anymore, but code lgtm","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"08af8c526a45019f8bd20fbf4d65b2aa122286f9","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_agent_metadata_port_dhcp_reenable_event(self):"},{"line_number":365,"context_line":"        # Test the Port_Binding update event triggered by reenable DHCP after"},{"line_number":366,"context_line":"        # disable DHCP on the subnet where the metadata\u0027s port is located."},{"line_number":367,"context_line":"        lswitch_name \u003d \u0027ovn-\u0027 + uuidutils.generate_uuid()"},{"line_number":368,"context_line":"        mdt_port_name \u003d \u0027ovn-mdt-\u0027 + uuidutils.generate_uuid()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"504f3e9d_1e282298","line":366,"in_reply_to":"2ede2cfa_c0a4d6a6","updated":"2025-01-17 22:02:46.000000000","message":"Done","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10caa1ec751e8dbb983cce0549bdf26303a341f3","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_agent_metadata_port_dhcp_reenable_event(self):"},{"line_number":365,"context_line":"        # Test the Port_Binding update event triggered by reenable DHCP after"},{"line_number":366,"context_line":"        # disable DHCP on the subnet where the metadata\u0027s port is located."},{"line_number":367,"context_line":"        lswitch_name \u003d \u0027ovn-\u0027 + uuidutils.generate_uuid()"},{"line_number":368,"context_line":"        mdt_port_name \u003d \u0027ovn-mdt-\u0027 + uuidutils.generate_uuid()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cd886402_54770c6a","line":366,"in_reply_to":"504f3e9d_1e282298","updated":"2025-01-17 22:12:59.000000000","message":"Well, it\u0027s just starting to look like the test above this, except for the external_ids part","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e9fa3aa078f36207a5b7e4392bdb433d881da96","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_agent_metadata_port_dhcp_reenable_event(self):"},{"line_number":365,"context_line":"        # Test the Port_Binding update event triggered by reenable DHCP after"},{"line_number":366,"context_line":"        # disable DHCP on the subnet where the metadata\u0027s port is located."},{"line_number":367,"context_line":"        lswitch_name \u003d \u0027ovn-\u0027 + uuidutils.generate_uuid()"},{"line_number":368,"context_line":"        mdt_port_name \u003d \u0027ovn-mdt-\u0027 + uuidutils.generate_uuid()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"12998099_bd0a6eb7","line":366,"in_reply_to":"795e3e9b_65368dda","updated":"2025-01-17 23:38:44.000000000","message":"No, I\u0027m just rambling, change looks good after looking again.","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f6b4d54a91d8ef74f15240d67e55c5eabf50513c","unresolved":true,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_agent_metadata_port_dhcp_reenable_event(self):"},{"line_number":365,"context_line":"        # Test the Port_Binding update event triggered by reenable DHCP after"},{"line_number":366,"context_line":"        # disable DHCP on the subnet where the metadata\u0027s port is located."},{"line_number":367,"context_line":"        lswitch_name \u003d \u0027ovn-\u0027 + uuidutils.generate_uuid()"},{"line_number":368,"context_line":"        mdt_port_name \u003d \u0027ovn-mdt-\u0027 + uuidutils.generate_uuid()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2ede2cfa_c0a4d6a6","line":366,"in_reply_to":"804d14d1_329ce86a","updated":"2025-01-17 22:02:35.000000000","message":"I think it refers to the later update in line 400?","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85e1cf8312b9ee96cad942304451c74fe4352a86","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def test_agent_metadata_port_dhcp_reenable_event(self):"},{"line_number":365,"context_line":"        # Test the Port_Binding update event triggered by reenable DHCP after"},{"line_number":366,"context_line":"        # disable DHCP on the subnet where the metadata\u0027s port is located."},{"line_number":367,"context_line":"        lswitch_name \u003d \u0027ovn-\u0027 + uuidutils.generate_uuid()"},{"line_number":368,"context_line":"        mdt_port_name \u003d \u0027ovn-mdt-\u0027 + uuidutils.generate_uuid()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"795e3e9b_65368dda","line":366,"in_reply_to":"cd886402_54770c6a","updated":"2025-01-17 23:30:02.000000000","message":"I think that\u0027s the culprit - setting cidrs\u003d[] disables dhcp; then the test case enables it back? Or do you mean there\u0027s space to refactor? If so, yeah. Not in this patch.","commit_id":"47718064b70bf2f09b23e294fd5ec04851aa7b67"}]}