)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"01a333a7afe150e495fed4773bc02dde40b0aa68","unresolved":true,"context_lines":[{"line_number":22,"context_line":"_update_trunk_metadata()."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #2095000"},{"line_number":25,"context_line":"Related-Bug: #1869244"},{"line_number":26,"context_line":"Change-Id: I2b9202ddf653c0755c2aacb6b88ce8c983bb29dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7319a22c_c83cf1a2","line":25,"updated":"2025-01-24 08:54:14.000000000","message":"perhaps worth to mention https://bugs.launchpad.net/neutron/+bug/1997025 also as perhaps the last bug report","commit_id":"72cc3c7e6e46b7098fa1d7c23720872637ee8539"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"90dc2dc373740a70379a7a3f0ad3c12c25b40c20","unresolved":false,"context_lines":[{"line_number":22,"context_line":"_update_trunk_metadata()."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #2095000"},{"line_number":25,"context_line":"Related-Bug: #1869244"},{"line_number":26,"context_line":"Change-Id: I2b9202ddf653c0755c2aacb6b88ce8c983bb29dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"451b0572_51a5e3e3","line":25,"in_reply_to":"7319a22c_c83cf1a2","updated":"2025-01-24 14:02:29.000000000","message":"Done","commit_id":"72cc3c7e6e46b7098fa1d7c23720872637ee8539"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"7f0f19530aad5135fdd7fdc89b4faba71f90d4cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"46538f06_bef08a21","updated":"2025-01-27 09:29:16.000000000","message":"recheck https://bugs.launchpad.net/nova/+bug/2096757","commit_id":"e41f30642d292c5e0afa481802a4f4201ff12841"}],"neutron/services/trunk/drivers/openvswitch/agent/ovsdb_handler.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"01a333a7afe150e495fed4773bc02dde40b0aa68","unresolved":true,"context_lines":[{"line_number":456,"context_line":"            LOG.info("},{"line_number":457,"context_line":"                \"Could not update trunk metadata in a non-existent bridge \""},{"line_number":458,"context_line":"                \"(likely already deleted by nova/os-vif): %s\", bridge_name)"},{"line_number":459,"context_line":"            return"},{"line_number":460,"context_line":"        port \u003d port or self._get_parent_port(trunk_bridge)"},{"line_number":461,"context_line":"        _port_id, _trunk_id, old_subports \u003d self._get_trunk_metadata(port)"},{"line_number":462,"context_line":"        if wire:"}],"source_content_type":"text/x-python","patch_set":1,"id":"17c818d1_d5b1de27","line":459,"updated":"2025-01-24 08:54:14.000000000","message":"could you please check if tests should be updated? Here for example: https://opendev.org/openstack/neutron/src/commit/6147ffc94f342afd26479284f28a4cb87a8009a3/neutron/tests/unit/services/trunk/drivers/openvswitch/agent/test_ovsdb_handler.py#L303","commit_id":"72cc3c7e6e46b7098fa1d7c23720872637ee8539"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"90dc2dc373740a70379a7a3f0ad3c12c25b40c20","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            LOG.info("},{"line_number":457,"context_line":"                \"Could not update trunk metadata in a non-existent bridge \""},{"line_number":458,"context_line":"                \"(likely already deleted by nova/os-vif): %s\", bridge_name)"},{"line_number":459,"context_line":"            return"},{"line_number":460,"context_line":"        port \u003d port or self._get_parent_port(trunk_bridge)"},{"line_number":461,"context_line":"        _port_id, _trunk_id, old_subports \u003d self._get_trunk_metadata(port)"},{"line_number":462,"context_line":"        if wire:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b49eb28f_7ee7524d","line":459,"in_reply_to":"17c818d1_d5b1de27","updated":"2025-01-24 14:02:29.000000000","message":"Done","commit_id":"72cc3c7e6e46b7098fa1d7c23720872637ee8539"}],"neutron/tests/unit/services/trunk/drivers/openvswitch/agent/test_ovsdb_handler.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea7ebb2bd235bab331ff6ba18590f99583b54fc8","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        mock_br.configure_mock(**{\u0027bridge_exists.return_value\u0027: False})"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            self.ovsdb_handler._update_trunk_metadata("},{"line_number":346,"context_line":"                mock_br, None, self.trunk_id, [\u0027foo_subport_1\u0027], wire\u003dFalse)"},{"line_number":347,"context_line":"        except RuntimeError:"},{"line_number":348,"context_line":"            self.fail("},{"line_number":349,"context_line":"                \"_update_trunk_metadata() should not raise RuntimeError \""}],"source_content_type":"text/x-python","patch_set":2,"id":"054c8b60_df3afef0","line":346,"range":{"start_line":346,"start_character":65,"end_line":346,"end_character":75},"updated":"2025-01-24 15:46:22.000000000","message":"nit: this argument isn\u0027t needed as the code never gets to where it\u0027s used (would need to change function name here to match)","commit_id":"e41f30642d292c5e0afa481802a4f4201ff12841"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"8773c5a604d8a221040fe1c5016fcf6efd3dce7a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        mock_br.configure_mock(**{\u0027bridge_exists.return_value\u0027: False})"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            self.ovsdb_handler._update_trunk_metadata("},{"line_number":346,"context_line":"                mock_br, None, self.trunk_id, [\u0027foo_subport_1\u0027], wire\u003dFalse)"},{"line_number":347,"context_line":"        except RuntimeError:"},{"line_number":348,"context_line":"            self.fail("},{"line_number":349,"context_line":"                \"_update_trunk_metadata() should not raise RuntimeError \""}],"source_content_type":"text/x-python","patch_set":2,"id":"402dad34_89fd8f22","line":346,"range":{"start_line":346,"start_character":65,"end_line":346,"end_character":75},"in_reply_to":"054c8b60_df3afef0","updated":"2025-01-29 09:59:00.000000000","message":"Done","commit_id":"e41f30642d292c5e0afa481802a4f4201ff12841"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea7ebb2bd235bab331ff6ba18590f99583b54fc8","unresolved":true,"context_lines":[{"line_number":347,"context_line":"        except RuntimeError:"},{"line_number":348,"context_line":"            self.fail("},{"line_number":349,"context_line":"                \"_update_trunk_metadata() should not raise RuntimeError \""},{"line_number":350,"context_line":"                \"when the trunk bridge does not exist\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3b1453df_d6d69225","line":350,"updated":"2025-01-24 15:46:22.000000000","message":"This works, the other option would just be to assertIsNone(...) I think","commit_id":"e41f30642d292c5e0afa481802a4f4201ff12841"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"8773c5a604d8a221040fe1c5016fcf6efd3dce7a","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        except RuntimeError:"},{"line_number":348,"context_line":"            self.fail("},{"line_number":349,"context_line":"                \"_update_trunk_metadata() should not raise RuntimeError \""},{"line_number":350,"context_line":"                \"when the trunk bridge does not exist\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"0873f878_6927900a","line":350,"in_reply_to":"3b1453df_d6d69225","updated":"2025-01-29 09:59:00.000000000","message":"Acknowledged","commit_id":"e41f30642d292c5e0afa481802a4f4201ff12841"}]}