)]}'
{"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"659046f19e0e6674888dbbbee088a5118e1f71f2","unresolved":true,"context_lines":[{"line_number":799,"context_line":"            return sync_state_orig(*args, **kwargs)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        with mock.patch.object(dhcp, \u0027sync_state\u0027, side_effect\u003dsync_state):"},{"line_number":802,"context_line":"            with mock.patch.object(dhcp.plugin_rpc, \u0027get_active_networks_info\u0027,"},{"line_number":803,"context_line":"                                   side_effect\u003dException):"},{"line_number":804,"context_line":"                with testtools.ExpectedException(RuntimeError):"},{"line_number":805,"context_line":"                    dhcp._periodic_resync_helper()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b766a3c_ed70f8c0","line":802,"range":{"start_line":802,"start_character":53,"end_line":802,"end_character":77},"updated":"2025-01-23 14:47:05.000000000","message":"This method in inside sync_state. You can just raise another exception from you own ``sync_state``, because this is what actually L799 of this patch will do.","commit_id":"b43f426e1a241f48411d85473c87e82c9aca5c13"},{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"0586843e0dacf6c22098d530f15d462b870ab526","unresolved":false,"context_lines":[{"line_number":799,"context_line":"            return sync_state_orig(*args, **kwargs)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        with mock.patch.object(dhcp, \u0027sync_state\u0027, side_effect\u003dsync_state):"},{"line_number":802,"context_line":"            with mock.patch.object(dhcp.plugin_rpc, \u0027get_active_networks_info\u0027,"},{"line_number":803,"context_line":"                                   side_effect\u003dException):"},{"line_number":804,"context_line":"                with testtools.ExpectedException(RuntimeError):"},{"line_number":805,"context_line":"                    dhcp._periodic_resync_helper()"}],"source_content_type":"text/x-python","patch_set":1,"id":"aeca6077_76612299","line":802,"range":{"start_line":802,"start_character":53,"end_line":802,"end_character":77},"in_reply_to":"6b766a3c_ed70f8c0","updated":"2025-01-24 11:23:34.000000000","message":"I reworked the test case a bit","commit_id":"b43f426e1a241f48411d85473c87e82c9aca5c13"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"659046f19e0e6674888dbbbee088a5118e1f71f2","unresolved":true,"context_lines":[{"line_number":804,"context_line":"                with testtools.ExpectedException(RuntimeError):"},{"line_number":805,"context_line":"                    dhcp._periodic_resync_helper()"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"        self.assertGreater(timestamps[1] - timestamps[0],"},{"line_number":808,"context_line":"                           cfg.CONF.resync_throttle)"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def test_populate_cache_on_start_without_active_networks_support(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"88b1375c_b694768b","line":807,"range":{"start_line":807,"start_character":13,"end_line":807,"end_character":26},"updated":"2025-01-23 14:47:05.000000000","message":"Why assertGreater? Should be timestamps[1] - timestamps[0] around ``resync_throttle``? If resync_throttle\u003d1, you can just:\nself.asserEqual(resync_throttle, round(timestamps[1] - timestamps[0]))","commit_id":"b43f426e1a241f48411d85473c87e82c9aca5c13"},{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"0586843e0dacf6c22098d530f15d462b870ab526","unresolved":false,"context_lines":[{"line_number":804,"context_line":"                with testtools.ExpectedException(RuntimeError):"},{"line_number":805,"context_line":"                    dhcp._periodic_resync_helper()"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"        self.assertGreater(timestamps[1] - timestamps[0],"},{"line_number":808,"context_line":"                           cfg.CONF.resync_throttle)"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def test_populate_cache_on_start_without_active_networks_support(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"64c0782e_004ac11a","line":807,"range":{"start_line":807,"start_character":13,"end_line":807,"end_character":26},"in_reply_to":"88b1375c_b694768b","updated":"2025-01-24 11:23:34.000000000","message":"good approach. I did it like this. Thx","commit_id":"b43f426e1a241f48411d85473c87e82c9aca5c13"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bc42ccd915f998274bc58bbb1ad56d7369947579","unresolved":true,"context_lines":[{"line_number":801,"context_line":"                dhcp._periodic_resync_helper()"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        with mock.patch.object(dhcp, \u0027sync_state\u0027, side_effect\u003dsync_state):"},{"line_number":804,"context_line":"            gthr \u003d eventlet.spawn(safe_periodic_resync_helper)"},{"line_number":805,"context_line":"            dhcp.schedule_resync(\u0027reason1\u0027, \u0027a\u0027)"},{"line_number":806,"context_line":"            dhcp.schedule_resync(\u0027reason2\u0027, \u0027b\u0027)"},{"line_number":807,"context_line":"            gthr.wait()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c96cbce9_4f287ae9","line":804,"updated":"2025-01-30 19:53:07.000000000","message":"My only issue here is that we are adding an eventlet call, when we are trying to remove eventlet from the source code.","commit_id":"83daeafb774d72f1d24032e1e5dd18411c0567ea"}]}