)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ecdcb58a226d243e201ae00b9e4c490f8f9d381a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87aa5881_7a78f706","updated":"2025-02-07 16:11:38.000000000","message":"Just one nit","commit_id":"58e83cf61075ffd1781fa4e706e562927a796fd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cf32532750d70b6f1ce73302f39abd13c8c596c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a4636ba_2a28f37e","updated":"2025-02-09 13:42:10.000000000","message":"recheck","commit_id":"8a74d953c2030ab65d2599c3f50cc1f5a8c92560"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1c2192235752343851818877666e95dbc1dfe32a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec6a9f04_4838aafe","updated":"2025-02-10 13:06:58.000000000","message":"recheck\nrally and tempest neutron-ovs-tempest-multinode-full failures are not related","commit_id":"8a74d953c2030ab65d2599c3f50cc1f5a8c92560"}],"neutron/conf/agent/l3/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ecdcb58a226d243e201ae00b9e4c490f8f9d381a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                         \"Use this mode if you do not want to adopt DVR.\"),"},{"line_number":38,"context_line":"                        (constants.L3_AGENT_MODE_DVR_NO_EXTERNAL,"},{"line_number":39,"context_line":"                         \"Enable only East/West DVR routing functionality for \""},{"line_number":40,"context_line":"                         \"an L3 agent that runs on a compute host, while\""},{"line_number":41,"context_line":"                         \"the North/South functionality such as DNAT and SNAT \""},{"line_number":42,"context_line":"                         \"will be provided by the centralized network node \""},{"line_number":43,"context_line":"                         \"that is running in \u0027dvr_snat\u0027 mode. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dbf7f33f_b49c93c9","line":40,"range":{"start_line":40,"start_character":67,"end_line":40,"end_character":72},"updated":"2025-02-07 16:11:38.000000000","message":"missing trailing space\n\nAnd I never knew this formatting was an option, good to know.","commit_id":"58e83cf61075ffd1781fa4e706e562927a796fd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"73fd6f137984ec96b070a774709e2a1018394011","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                         \"Use this mode if you do not want to adopt DVR.\"),"},{"line_number":38,"context_line":"                        (constants.L3_AGENT_MODE_DVR_NO_EXTERNAL,"},{"line_number":39,"context_line":"                         \"Enable only East/West DVR routing functionality for \""},{"line_number":40,"context_line":"                         \"an L3 agent that runs on a compute host, while\""},{"line_number":41,"context_line":"                         \"the North/South functionality such as DNAT and SNAT \""},{"line_number":42,"context_line":"                         \"will be provided by the centralized network node \""},{"line_number":43,"context_line":"                         \"that is running in \u0027dvr_snat\u0027 mode. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"544ffa57_7d9b9ff4","line":40,"range":{"start_line":40,"start_character":67,"end_line":40,"end_character":72},"in_reply_to":"dbf7f33f_b49c93c9","updated":"2025-02-07 17:00:36.000000000","message":"Done","commit_id":"58e83cf61075ffd1781fa4e706e562927a796fd1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1d37797d7a6d8113f53321b89693ac2fd14e68d7","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                         \"that is running in \u0027dvr_snat\u0027 mode. \""},{"line_number":44,"context_line":"                         \"This mode should be used when there is no \""},{"line_number":45,"context_line":"                         \"external network connectivity on the compute host.\")"},{"line_number":46,"context_line":"               ],"},{"line_number":47,"context_line":"               help\u003d_(\"The working mode for the agent.\")),"},{"line_number":48,"context_line":"    cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":49,"context_line":"                default\u003d9697,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b9ca6d5_63f2e569","line":46,"updated":"2025-02-07 17:14:31.000000000","message":"pep8 is also complaining about this indentation","commit_id":"d971fd06cf93355fd4a0134a3f89a7ecfc33be08"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"86d3a86c479aea174970b0dc44b3a766d83fd517","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                         \"that is running in \u0027dvr_snat\u0027 mode. \""},{"line_number":44,"context_line":"                         \"This mode should be used when there is no \""},{"line_number":45,"context_line":"                         \"external network connectivity on the compute host.\")"},{"line_number":46,"context_line":"               ],"},{"line_number":47,"context_line":"               help\u003d_(\"The working mode for the agent.\")),"},{"line_number":48,"context_line":"    cfg.PortOpt(\u0027metadata_port\u0027,"},{"line_number":49,"context_line":"                default\u003d9697,"}],"source_content_type":"text/x-python","patch_set":3,"id":"06d40ed4_5dce8480","line":46,"in_reply_to":"1b9ca6d5_63f2e569","updated":"2025-02-08 07:30:18.000000000","message":"Done","commit_id":"d971fd06cf93355fd4a0134a3f89a7ecfc33be08"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ecdcb58a226d243e201ae00b9e4c490f8f9d381a","unresolved":true,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027log\u0027,"},{"line_number":101,"context_line":"               choices\u003d[(\u0027off\u0027,"},{"line_number":102,"context_line":"                         \"Synchronization is off.\"),"},{"line_number":103,"context_line":"                        (\u0027log\u0027,"},{"line_number":104,"context_line":"                         \"During neutron-server startup, check to see if OVN \""},{"line_number":105,"context_line":"                         \"is in sync with the Neutron database. \""},{"line_number":106,"context_line":"                         \"Log warnings for any inconsistencies found so that \""}],"source_content_type":"text/x-python","patch_set":1,"id":"a90116f0_613ef20c","line":103,"updated":"2025-02-07 16:11:38.000000000","message":"These are actually defined elsewhere, but should really be in the OVN constants file. I\u0027ll move them in a follow-on.","commit_id":"58e83cf61075ffd1781fa4e706e562927a796fd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"86d3a86c479aea174970b0dc44b3a766d83fd517","unresolved":true,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027log\u0027,"},{"line_number":101,"context_line":"               choices\u003d[(\u0027off\u0027,"},{"line_number":102,"context_line":"                         \"Synchronization is off.\"),"},{"line_number":103,"context_line":"                        (\u0027log\u0027,"},{"line_number":104,"context_line":"                         \"During neutron-server startup, check to see if OVN \""},{"line_number":105,"context_line":"                         \"is in sync with the Neutron database. \""},{"line_number":106,"context_line":"                         \"Log warnings for any inconsistencies found so that \""}],"source_content_type":"text/x-python","patch_set":1,"id":"d8df4668_4ba39e4d","line":103,"in_reply_to":"a90116f0_613ef20c","updated":"2025-02-08 07:30:18.000000000","message":"+1 and I hope https://review.opendev.org/c/openstack/neutron/+/941018 looks good to you. I\u0027ll also propose a follow-up to use constants for `[ovn] ovn_l3_scheduler`, too","commit_id":"58e83cf61075ffd1781fa4e706e562927a796fd1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d4f105ef436fbb8ecfb35d66074e4b35d9f668da","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027log\u0027,"},{"line_number":101,"context_line":"               choices\u003d[(\u0027off\u0027,"},{"line_number":102,"context_line":"                         \"Synchronization is off.\"),"},{"line_number":103,"context_line":"                        (\u0027log\u0027,"},{"line_number":104,"context_line":"                         \"During neutron-server startup, check to see if OVN \""},{"line_number":105,"context_line":"                         \"is in sync with the Neutron database. \""},{"line_number":106,"context_line":"                         \"Log warnings for any inconsistencies found so that \""}],"source_content_type":"text/x-python","patch_set":1,"id":"54336202_c5258194","line":103,"in_reply_to":"d8df4668_4ba39e4d","updated":"2025-02-10 15:25:22.000000000","message":"Ack, I had a similar change ready to push as well, but that one works 😊","commit_id":"58e83cf61075ffd1781fa4e706e562927a796fd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"521dac1e513aff8d66682e3dcbe04a489c44514b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                        (\"\","},{"line_number":242,"context_line":"                         \"A migrated port is immediately activated on \""},{"line_number":243,"context_line":"                         \"the destination host.\")],"},{"line_number":244,"context_line":"               help\u003d_(\u0027Activation strategy to use for live migration. \u0027"},{"line_number":245,"context_line":"                      \u0027The default `rarp` strategy expects the hypervisor to \u0027"},{"line_number":246,"context_line":"                      \u0027send a Reverse ARP request through the migrated port \u0027"},{"line_number":247,"context_line":"                      \u0027after migration is complete. \u0027"},{"line_number":248,"context_line":"                      \u0027An empty value means a migrated port is immediately \u0027"},{"line_number":249,"context_line":"                      \u0027activated on the destination host.\u0027)),"},{"line_number":250,"context_line":"]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"nb_global_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"fba07767_c404abd8","line":249,"range":{"start_line":244,"start_character":69,"end_line":249,"end_character":57},"updated":"2025-02-07 17:04:56.000000000","message":"The same is now explained in help text for each choice, so this should be removed.","commit_id":"d9f571b6d5fc0edfc496498327325365518a1aa2"}]}