)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"023a90058905bd52e284c171016146da731e3774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3b6eca8_785bdb9e","updated":"2025-02-19 09:42:16.000000000","message":"That creates a huge amount of logs, What is the purpose of enabling it by defaut?\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d94/942157/1/check/neutron-tempest-plugin-openvswitch/d946982/controller/logs/screen-q-agt.txt","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"737e4ac0ed0ec9d109c3268013d58b6e0394bcfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f9f5c22_180d6026","updated":"2025-02-19 02:59:54.000000000","message":"recheck","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bdd74eddd0fd85743a8d21631d9f8ced394a31a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2584448b_796c2d41","updated":"2025-02-25 17:04:03.000000000","message":"recheck\n\nunrelated service restart issue in functional test","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b36312e44954e8b1ae9246de6efc7c3489006046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"067f2006_5826a747","updated":"2025-03-10 13:06:20.000000000","message":"recheck unrelated failure","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"92f5c548dedc4790d4601a0cd4dd2d3e2df146c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8366447_1b547d4a","updated":"2025-03-03 00:31:30.000000000","message":"recheck unrelated failure","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7908c996ee203422b762db0399cf2d917e5441cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49fd720c_701508aa","updated":"2025-02-24 10:23:10.000000000","message":"thanks","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ee6e54c3549f8d4d9488ffca34f2296f3d2b1269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6e03cd40_efb24cb3","in_reply_to":"152e1cc2_50e047aa","updated":"2025-02-21 08:49:41.000000000","message":"No worries I feel it\u0027s a bit too verbose and not so often used to be really useful all the time I would have prefered something to enable it easily when needed. But I don\u0027t want to block for such on change :-) I can for sure habit myself to see them.","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0c5bb5592b60f80477fc6754dd1726e1beb13b1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"499c157f_ba52c49a","in_reply_to":"164c7d76_2b1d6e07","updated":"2025-02-20 20:55:33.000000000","message":"So which logs will it increase logging in? And if it\u0027s going to help find issues faster I think it\u0027s worthwhile.","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ff1deafa4d241b4b5c896231c1b13a713c2dd4dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"152e1cc2_50e047aa","in_reply_to":"499c157f_ba52c49a","updated":"2025-02-20 21:52:48.000000000","message":"Definitely the dsvm-functional logs, and maybe the dsvm-fullstack logs (both of which are tarred/gzipped).\n\nBut looking at other patches\u0027 fullstack logs, they are already getting ovsdbapp logs (and getting them with the chatty POLLIN messages in ovs-agent). So I don\u0027t think this patch is affecting that (and looking at neutron/tests/fullstack/base.py, it doesn\u0027t inherit from the neutron test tree). So as part of another patch, we could look at reducing how much loggging fullstack produces, but this doesn\u0027t appear to affect it.","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2d7165077966a33567c663d86d7d20008c8ea273","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6237491_507f1254","in_reply_to":"c7c60381_4567b161","updated":"2025-02-20 16:45:11.000000000","message":"Any chance that you share the rational? It is related to specific thing that you tried to debug? Perhaps we could provide a mechanism to enable it via a env or something else?","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"57091e7680b110027f9b2909780886b0e33ea548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7c60381_4567b161","in_reply_to":"d3b6eca8_785bdb9e","updated":"2025-02-19 16:33:37.000000000","message":"Looking at that output, the only logs I see added look like:\n```Feb 19 03:16:40.908448 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d1): DbAddCommand(_result\u003dNone, table\u003dBridge, record\u003dbr-int, column\u003dprotocols, values\u003d(\u0027OpenFlow10\u0027, \u0027OpenFlow13\u0027, \u0027OpenFlow14\u0027)) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:40.909069 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d2): DbSetCommand(_result\u003dNone, table\u003dBridge, record\u003dbr-int, col_values\u003d((\u0027other_config\u0027, {\u0027mac-table-size\u0027: \u002750000\u0027}),), if_exists\u003dTrue) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:40.913414 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d0): SetFailModeCommand(_result\u003dNone, bridge\u003dbr-int, mode\u003dsecure) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:40.916492 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d0): DbSetCommand(_result\u003dNone, table\u003dBridge, record\u003dbr-int, col_values\u003d((\u0027other_config\u0027, {\u0027disable-in-band\u0027: \u0027true\u0027}),), if_exists\u003dTrue) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:40.919180 np0039899270 neutron-openvswitch-agent[63932]: DEBUG neutron.plugins.ml2.drivers.openvswitch.agent.openflow.native.ovs_bridge [-] Setting controller tcp:127.0.0.1:6633 for bridge br-int. {{(pid\u003d63932) setup_controllers /opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge.py:103}}\nFeb 19 03:16:40.919737 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d0): SetControllerCommand(_result\u003dNone, bridge\u003dbr-int, targets\u003d[\u0027tcp:127.0.0.1:6633\u0027]) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:41.927725 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d0): DbSetCommand(_result\u003dNone, table\u003dController, record\u003da500305b-7138-4e4a-88b8-8a96f2aef57a, col_values\u003d((\u0027inactivity_probe\u0027, 10000),), if_exists\u003dTrue) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:41.933836 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d0): DbSetCommand(_result\u003dNone, table\u003dBridge, record\u003dbr-int, col_values\u003d((\u0027mcast_snooping_enable\u0027, False),), if_exists\u003dTrue) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}\nFeb 19 03:16:41.933836 np0039899270 neutron-openvswitch-agent[63932]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n\u003d1 command(idx\u003d1): DbSetCommand(_result\u003dNone, table\u003dBridge, record\u003dbr-int, col_values\u003d((\u0027other_config\u0027, {\u0027mcast-snooping-disable-flood-unregistered\u0027: \u0027true\u0027}),), if_exists\u003dTrue) {{(pid\u003d63932) do_commit /opt/stack/data/venv/lib/python3.12/site-packages/ovsdbapp/backend/ovs_idl/transaction.py:89}}```\n\nAnd those logs are showing what commands are actually running. It\u0027s data that is, in my experience, imperative for actually knowing what is being executed when there is a failure. Both ml2/ovs and ml2/ovn are built on reading/writing information from ovsdb-server. It\u0027s pretty important data to have.","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"af908766ea462bbdb3146062c6436199c23101e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"164c7d76_2b1d6e07","in_reply_to":"f6237491_507f1254","updated":"2025-02-20 18:35:21.000000000","message":"The last patch of mine that you approved took me an extra hour to debug because I didn\u0027t realize the ovsdbapp logs were being suppressed and the log message would have included the Command being passed None as an external_id value, for example.\n\nIn addition, the patch that added the removal (https://review.opendev.org/c/openstack/neutron/+/577383) was in relation to https://bugs.launchpad.net/cinder/+bug/1728640 and there are no subunit.parser errors in the output of the CI tests that were run.\n\nAlso, it\u0027s not nearly as much logging as there used to be, since we added ovsdb_log_level and defaulted it to INFO, which gets rid of a bunch of the messages that used to come from python-ovs itself (POLLIN messages, etc.)\n\nAlso, the logs you linked were for tempest, which already log this information and are unaffected by this patch.\n\nAlso, if you look at the dsvm-functional logs, it adds about 10% overhead. Given that these are the logs that actually show what operations are being executed on the ovsdb-server (which is ultimately the entire point of the drivers (to configure OVS/OVN), I\u0027d say that it is more than worth it.","commit_id":"7a980b1533a6e8e1a9abf49146d06c8943fd969e"}]}