)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3df2bfb7e4333d3319e1cabadfee80ca877f8ec7","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/ovn-org/ovn/commit/1622526ff"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/942367"},{"line_number":19,"context_line":"Related-Issue: https://issues.redhat.com/browse/OSPRH-10758"},{"line_number":20,"context_line":"Related-Bug: #2059405"},{"line_number":21,"context_line":"Change-Id: Ia645e8539753c03eb6ead9a868ba5bf194e9a724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2cab4b86_012cab42","line":18,"updated":"2025-02-20 19:04:34.000000000","message":"I don\u0027t think this will work and actually pull-in the ovsdbapp change, we\u0027d need to release a new version and move requirements forward.","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"de66386b5747c5e4ddb88ffe076b9c43909b2d15","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/ovn-org/ovn/commit/1622526ff"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/942367"},{"line_number":19,"context_line":"Related-Issue: https://issues.redhat.com/browse/OSPRH-10758"},{"line_number":20,"context_line":"Related-Bug: #2059405"},{"line_number":21,"context_line":"Change-Id: Ia645e8539753c03eb6ead9a868ba5bf194e9a724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6188a824_7320bf9d","line":18,"in_reply_to":"2cab4b86_012cab42","updated":"2025-02-24 13:34:08.000000000","message":"yeap will do request a new release once that merges and update minimal version requirements.txt here once u-c updated.","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3a89af3e8efabc5618fd0e6e9a17d44f43601201","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/ovn-org/ovn/commit/1622526ff"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/942367"},{"line_number":19,"context_line":"Related-Issue: https://issues.redhat.com/browse/OSPRH-10758"},{"line_number":20,"context_line":"Related-Bug: #2059405"},{"line_number":21,"context_line":"Change-Id: Ia645e8539753c03eb6ead9a868ba5bf194e9a724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a0da3099_c6d2b19c","line":18,"in_reply_to":"6188a824_7320bf9d","updated":"2025-03-01 12:32:25.000000000","message":"Requirements patch merged.","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d01c75307534480e529b66bfbed332cca6ed4ed4","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/ovn-org/ovn/commit/1622526ff"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ovsdbapp/+/942367"},{"line_number":19,"context_line":"Related-Issue: https://issues.redhat.com/browse/OSPRH-10758"},{"line_number":20,"context_line":"Related-Bug: #2059405"},{"line_number":21,"context_line":"Change-Id: Ia645e8539753c03eb6ead9a868ba5bf194e9a724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8f906051_853cb754","line":18,"in_reply_to":"a0da3099_c6d2b19c","updated":"2025-03-03 15:29:43.000000000","message":"Done","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5744d3924b9980db03fdc827c302feca83e49a84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4306e239_6452cd00","updated":"2025-02-24 08:06:33.000000000","message":"Code looks OK, we\u0027ll need a new ovsdbapp release (and bump the requirements). We proposed 2.10.1 one week ago but I don\u0027t mind releasing a new one after https://review.opendev.org/c/openstack/ovsdbapp/+/942367","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3df2bfb7e4333d3319e1cabadfee80ca877f8ec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"022e8dfa_c76a70ff","updated":"2025-02-20 19:04:34.000000000","message":"So the one thing this change will not do is update anything if the config option is changed and neutron-server restarted. Something should be added in the ovsdb maintenance code for that [0]\n\nAlso, does this DNS option apply to all versions of OVN or is it newer? Stating the version in the help message and release note would be helpful.\n\n[0] neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"de66386b5747c5e4ddb88ffe076b9c43909b2d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e66b6d3_d10bb06e","in_reply_to":"022e8dfa_c76a70ff","updated":"2025-02-24 13:34:08.000000000","message":"Done","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"af8db24e836a3bd96f14ecb2a053f322a72d4bd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f4d301a8_53e93f35","updated":"2025-03-03 21:02:26.000000000","message":"recheck neutron-functional","commit_id":"cde5580bf1f2850c90733eea2a6a7e3b46e22b63"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3bffb5c9d2176a90809403a4f10ba19e927bef1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e651dca5_c61740a1","updated":"2025-03-03 15:42:13.000000000","message":"thanks Yatin","commit_id":"cde5580bf1f2850c90733eea2a6a7e3b46e22b63"}],"neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3df2bfb7e4333d3319e1cabadfee80ca877f8ec7","unresolved":true,"context_lines":[{"line_number":160,"context_line":"                       \"If this option is set to True dns records will be \""},{"line_number":161,"context_line":"                       \"treated local to ovn and ovn will respond to the dns \""},{"line_number":162,"context_line":"                       \"queries for the records and record types known to it \""},{"line_number":163,"context_line":"                       \"else it forwards them to the configured dns servers\")),"},{"line_number":164,"context_line":"    cfg.DictOpt(\u0027ovn_dhcp4_global_options\u0027,"},{"line_number":165,"context_line":"                default\u003d{},"},{"line_number":166,"context_line":"                help\u003d_(\"Dictionary of global DHCPv4 options which will be \""}],"source_content_type":"text/x-python","patch_set":1,"id":"e1e9aa80_592b7ba7","line":163,"updated":"2025-02-20 19:04:34.000000000","message":"Instead of making a lot of typographical comments, I\u0027ll just post what I\u0027d write for this help message:\n\n\"Whether to consider DNS records local to OVN or not.\n If this option is set to True, DNS records will be\n treated local to the OVN controller and it will respond\n to the queries for the records and record types known to it,\n else it will forward them to the configured DNS server(s).\"","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"de66386b5747c5e4ddb88ffe076b9c43909b2d15","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                       \"If this option is set to True dns records will be \""},{"line_number":161,"context_line":"                       \"treated local to ovn and ovn will respond to the dns \""},{"line_number":162,"context_line":"                       \"queries for the records and record types known to it \""},{"line_number":163,"context_line":"                       \"else it forwards them to the configured dns servers\")),"},{"line_number":164,"context_line":"    cfg.DictOpt(\u0027ovn_dhcp4_global_options\u0027,"},{"line_number":165,"context_line":"                default\u003d{},"},{"line_number":166,"context_line":"                help\u003d_(\"Dictionary of global DHCPv4 options which will be \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ef8200d7_d199d3b6","line":163,"in_reply_to":"e1e9aa80_592b7ba7","updated":"2025-02-24 13:34:08.000000000","message":"Done","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61713e3a9d96676ccee58db019b122e0252befed","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    cfg.BoolOpt(\u0027dns_records_ovn_owned\u0027,"},{"line_number":158,"context_line":"                default\u003dFalse,"},{"line_number":159,"context_line":"                help\u003d_(\"Whether to consider DNS records local to OVN or not. \""},{"line_number":160,"context_line":"                       \"For OVN version 24.03 if this option is set to True, \""},{"line_number":161,"context_line":"                       \"DNS records will be treated local to the OVN \""},{"line_number":162,"context_line":"                       \"controller and it will respond to the queries for the \""},{"line_number":163,"context_line":"                       \"records and record types known to it, else it will \""}],"source_content_type":"text/x-python","patch_set":5,"id":"caf2f3f8_d265f4cc","line":160,"range":{"start_line":160,"start_character":40,"end_line":160,"end_character":45},"updated":"2025-03-03 00:38:04.000000000","message":"s/24.03 and above\n\nto match the release note","commit_id":"75f2faf9313eecb1bd1de47198c80ffd60fe0d5c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e7c3a9dbd9a2026b36a297dd6fd40a138f25e244","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    cfg.BoolOpt(\u0027dns_records_ovn_owned\u0027,"},{"line_number":158,"context_line":"                default\u003dFalse,"},{"line_number":159,"context_line":"                help\u003d_(\"Whether to consider DNS records local to OVN or not. \""},{"line_number":160,"context_line":"                       \"For OVN version 24.03 if this option is set to True, \""},{"line_number":161,"context_line":"                       \"DNS records will be treated local to the OVN \""},{"line_number":162,"context_line":"                       \"controller and it will respond to the queries for the \""},{"line_number":163,"context_line":"                       \"records and record types known to it, else it will \""}],"source_content_type":"text/x-python","patch_set":5,"id":"a60638da_83d16ff1","line":160,"range":{"start_line":160,"start_character":40,"end_line":160,"end_character":45},"in_reply_to":"caf2f3f8_d265f4cc","updated":"2025-03-03 14:15:49.000000000","message":"Done","commit_id":"75f2faf9313eecb1bd1de47198c80ffd60fe0d5c"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61713e3a9d96676ccee58db019b122e0252befed","unresolved":true,"context_lines":[{"line_number":2893,"context_line":""},{"line_number":2894,"context_line":"        ovn_owned \u003d (\u0027true\u0027 if ovn_conf.is_dns_records_ovn_owned()"},{"line_number":2895,"context_line":"                     else \u0027false\u0027)"},{"line_number":2896,"context_line":"        dns_options \u003d {ovn_const.OVN_OWNED: ovn_owned}"},{"line_number":2897,"context_line":""},{"line_number":2898,"context_line":"        # Only run when options column is available"},{"line_number":2899,"context_line":"        if hasattr(ls_dns_record, \u0027options\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f01b0a4_7791468f","line":2896,"updated":"2025-03-03 00:38:04.000000000","message":"I guess these should be under the \u0027if\u0027 below?","commit_id":"75f2faf9313eecb1bd1de47198c80ffd60fe0d5c"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e7c3a9dbd9a2026b36a297dd6fd40a138f25e244","unresolved":false,"context_lines":[{"line_number":2893,"context_line":""},{"line_number":2894,"context_line":"        ovn_owned \u003d (\u0027true\u0027 if ovn_conf.is_dns_records_ovn_owned()"},{"line_number":2895,"context_line":"                     else \u0027false\u0027)"},{"line_number":2896,"context_line":"        dns_options \u003d {ovn_const.OVN_OWNED: ovn_owned}"},{"line_number":2897,"context_line":""},{"line_number":2898,"context_line":"        # Only run when options column is available"},{"line_number":2899,"context_line":"        if hasattr(ls_dns_record, \u0027options\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bdccddab_f8abd50a","line":2896,"in_reply_to":"7f01b0a4_7791468f","updated":"2025-03-03 14:15:49.000000000","message":"yes better there.","commit_id":"75f2faf9313eecb1bd1de47198c80ffd60fe0d5c"}],"releasenotes/notes/add-dns_records_ovn_owned-config-120ef08d5cf659f2.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3df2bfb7e4333d3319e1cabadfee80ca877f8ec7","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    If this option is set to True dns records will be treated local to ovn"},{"line_number":7,"context_line":"    and ovn will respond to the dns queries for the records and record types"},{"line_number":8,"context_line":"    known to it else it forwards them to the configured dns servers."},{"line_number":9,"context_line":"    Default is False."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9abb2fa9_ec1a3b32","line":9,"updated":"2025-02-20 19:04:34.000000000","message":"Same as help message, here\u0027s my re-write:\n\n\"For OVN you can now configure DNS records to be local to OVN by setting\n the new configuration option ``[ovn] dns_records_ovn_owned``.\n If this option is set to True, DNS records will be treated local to the OVN\n controller and it will respond to the queries for the records and record\n types known to it, else it will forward them to the configured DNS server(s).\n For more information, see bug\n `2059405 \u003chttps://bugs.launchpad.net/neutron/+bug/2059405\u003e`_.\n Default is False.","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"de66386b5747c5e4ddb88ffe076b9c43909b2d15","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    If this option is set to True dns records will be treated local to ovn"},{"line_number":7,"context_line":"    and ovn will respond to the dns queries for the records and record types"},{"line_number":8,"context_line":"    known to it else it forwards them to the configured dns servers."},{"line_number":9,"context_line":"    Default is False."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a53f816f_d2e57c7d","line":9,"in_reply_to":"9abb2fa9_ec1a3b32","updated":"2025-02-24 13:34:08.000000000","message":"Done","commit_id":"cbc0884e54e425c5551b989a899f8a4fa4d3cca8"}]}
