)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19109dfbc57b00f7b636418786ebdaa1af47746d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[S-RBAC] Fix policies for the SG rules API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes default policies for the Security Group Rules API so"},{"line_number":10,"context_line":"that user of the project who isn\u0027t owner of the SG rule but only sees SG"},{"line_number":11,"context_line":"as shared one, can\u0027t now create or delete rules in such SG."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #2101150"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b11f35af_fb8dfb2a","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":55},"updated":"2025-03-11 14:01:45.000000000","message":"``owner of the SG rule``?? I think this should be ``owner of the SG``, right?","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0fb6cf98f8cb65c241b393b9afdf7e50ef52476c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[S-RBAC] Fix policies for the SG rules API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes default policies for the Security Group Rules API so"},{"line_number":10,"context_line":"that user of the project who isn\u0027t owner of the SG rule but only sees SG"},{"line_number":11,"context_line":"as shared one, can\u0027t now create or delete rules in such SG."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #2101150"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aa677587_33413da5","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":55},"in_reply_to":"b11f35af_fb8dfb2a","updated":"2025-03-11 14:56:56.000000000","message":"Done","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4ca37af7a35598a255aada9e3cb2a7f631b6f58a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f54ca5db_fec42b13","updated":"2025-03-12 18:59:21.000000000","message":"recheck non-voting change merged","commit_id":"dfea81a4bf6aa62f56d101f8a0cb168a02338d5c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f87b7e34e07562ee26f461c3c24cc5722ffd65b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ebbadf02_aded9791","updated":"2025-03-12 22:56:43.000000000","message":"recheck zuul blip","commit_id":"dfea81a4bf6aa62f56d101f8a0cb168a02338d5c"}],"neutron/tests/unit/conf/policies/test_security_group.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19109dfbc57b00f7b636418786ebdaa1af47746d","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        self.sg \u003d {"},{"line_number":391,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":392,"context_line":"            \u0027project_id\u0027: self.project_id,"},{"line_number":393,"context_line":"            \u0027tenant_id\u0027: self.project_id}"},{"line_number":394,"context_line":"        self.alt_sg \u003d {"},{"line_number":395,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":396,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3299af88_19e735c4","line":393,"range":{"start_line":393,"start_character":13,"end_line":393,"end_character":22},"updated":"2025-03-11 14:01:45.000000000","message":"Do we need ``tenant_id``? Can\u0027t we use only ``project_id``? Maybe this is related to ``get_security_group``. If that is the case, then disregard this comment.","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0fb6cf98f8cb65c241b393b9afdf7e50ef52476c","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        self.sg \u003d {"},{"line_number":391,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":392,"context_line":"            \u0027project_id\u0027: self.project_id,"},{"line_number":393,"context_line":"            \u0027tenant_id\u0027: self.project_id}"},{"line_number":394,"context_line":"        self.alt_sg \u003d {"},{"line_number":395,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":396,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7068eeab_b769975e","line":393,"range":{"start_line":393,"start_character":13,"end_line":393,"end_character":22},"in_reply_to":"3299af88_19e735c4","updated":"2025-03-11 14:56:56.000000000","message":"I think we still need tenant_id here. I will add task for myself to check that and to switch it to the project_id everywhere but in next cycle if that\u0027s fine for you","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1ab14d19f85e404efae814aee7e5dc230b6cd880","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.sg \u003d {"},{"line_number":391,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":392,"context_line":"            \u0027project_id\u0027: self.project_id,"},{"line_number":393,"context_line":"            \u0027tenant_id\u0027: self.project_id}"},{"line_number":394,"context_line":"        self.alt_sg \u003d {"},{"line_number":395,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":396,"context_line":"            \u0027project_id\u0027: self.alt_project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"43388d37_72072265","line":393,"range":{"start_line":393,"start_character":13,"end_line":393,"end_character":22},"in_reply_to":"7068eeab_b769975e","updated":"2025-03-11 14:59:46.000000000","message":"For sure, this can be done later if that implies changing the API methods.","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19109dfbc57b00f7b636418786ebdaa1af47746d","unresolved":true,"context_lines":[{"line_number":559,"context_line":"        # Test for the SG_OWNER different then current user case:"},{"line_number":560,"context_line":"        target \u003d copy.copy(self.target)"},{"line_number":561,"context_line":"        target[\u0027security_group_id\u0027] \u003d self.alt_sg[\u0027id\u0027]"},{"line_number":562,"context_line":"        target[\u0027ext_parent:tenant_id\u0027] \u003d self.alt_sg[\u0027tenant_id\u0027]"},{"line_number":563,"context_line":"        target[\u0027ext_parent_security_group_id\u0027] \u003d self.alt_sg[\u0027id\u0027]"},{"line_number":564,"context_line":"        self.plugin_mock.get_security_group.return_value \u003d self.alt_sg"},{"line_number":565,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"02759d5f_80a06c9a","line":562,"range":{"start_line":562,"start_character":27,"end_line":562,"end_character":36},"updated":"2025-03-11 14:01:45.000000000","message":"Same comment here about ``tenant_id``","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0fb6cf98f8cb65c241b393b9afdf7e50ef52476c","unresolved":true,"context_lines":[{"line_number":559,"context_line":"        # Test for the SG_OWNER different then current user case:"},{"line_number":560,"context_line":"        target \u003d copy.copy(self.target)"},{"line_number":561,"context_line":"        target[\u0027security_group_id\u0027] \u003d self.alt_sg[\u0027id\u0027]"},{"line_number":562,"context_line":"        target[\u0027ext_parent:tenant_id\u0027] \u003d self.alt_sg[\u0027tenant_id\u0027]"},{"line_number":563,"context_line":"        target[\u0027ext_parent_security_group_id\u0027] \u003d self.alt_sg[\u0027id\u0027]"},{"line_number":564,"context_line":"        self.plugin_mock.get_security_group.return_value \u003d self.alt_sg"},{"line_number":565,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"4fa25921_ae1c20dd","line":562,"range":{"start_line":562,"start_character":27,"end_line":562,"end_character":36},"in_reply_to":"02759d5f_80a06c9a","updated":"2025-03-11 14:56:56.000000000","message":"see my comment above","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b443654475ca536329d10ca94e80072e5048bbc9","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        # Test for the SG_OWNER different then current user case:"},{"line_number":560,"context_line":"        target \u003d copy.copy(self.target)"},{"line_number":561,"context_line":"        target[\u0027security_group_id\u0027] \u003d self.alt_sg[\u0027id\u0027]"},{"line_number":562,"context_line":"        target[\u0027ext_parent:tenant_id\u0027] \u003d self.alt_sg[\u0027tenant_id\u0027]"},{"line_number":563,"context_line":"        target[\u0027ext_parent_security_group_id\u0027] \u003d self.alt_sg[\u0027id\u0027]"},{"line_number":564,"context_line":"        self.plugin_mock.get_security_group.return_value \u003d self.alt_sg"},{"line_number":565,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"60438251_ecb712f1","line":562,"range":{"start_line":562,"start_character":27,"end_line":562,"end_character":36},"in_reply_to":"4fa25921_ae1c20dd","updated":"2025-03-12 12:34:04.000000000","message":"Done","commit_id":"ec28e1d63ae5068ef7bd7c020fc6f0ef6f07202c"}]}