)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3664f5b000c0390decd7527839f738ab0849bb06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80a751d9_fc78f973","updated":"2025-03-17 10:11:08.000000000","message":"Please fill a LP bug (https://bugs.launchpad.net/neutron/) describing what the issue is.","commit_id":"5aaf400947992f4df4bfe21b3381c99037f8ba27"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"2c86d05c54a1cbef53867cf8257467a3a3362b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"208b300c_a6639f10","in_reply_to":"80a751d9_fc78f973","updated":"2025-03-17 10:23:34.000000000","message":"This is the LP bug, thank you.\nhttps://bugs.launchpad.net/neutron/+bug/2103408","commit_id":"5aaf400947992f4df4bfe21b3381c99037f8ba27"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a3c2a27361a03cf4870774ac875b12f5a113a9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"447a60dc_11c82c12","updated":"2025-03-17 11:39:40.000000000","message":"Your patch is doing exactly the opposite of what is documented in the commit message. Now if we pass an empty list, we\u0027ll retrieve the ``min_bw_rules`` or ``segments`` or ``min_pps_rules``","commit_id":"5a0b150ffae81ea0a31913a9195fb12ffc6f280b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cbc8034950813f759492498af6e3a96d6c39bf8d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24f7efd8_0795c047","in_reply_to":"1c37d21c_0062db22","updated":"2025-03-18 12:30:03.000000000","message":"Ok, now I get the point (my bad). In this case, you need to add at least one test for ``_extend_port_resource_request_bulk``, that is the method that calls it with passing ``min_bw_rules`` parameter.","commit_id":"5a0b150ffae81ea0a31913a9195fb12ffc6f280b"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"21556a3ac35bfec16035f0f1ea2d9e38d48e7ac4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f834528_ba20c6bc","in_reply_to":"24f7efd8_0795c047","updated":"2025-03-20 06:36:58.000000000","message":"I added a test passing empty list to the method.","commit_id":"5a0b150ffae81ea0a31913a9195fb12ffc6f280b"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"8389b2c8e7972cd14bf6a4a5337682030159ed27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c37d21c_0062db22","in_reply_to":"447a60dc_11c82c12","updated":"2025-03-17 11:47:26.000000000","message":"When min_bw_rules is empty list ([]),\n  if not min_bw_rules: --\u003e this is True and make db call,\n  if min_bw_rules is None: --\u003e this is False and doesn\u0027t make db call.","commit_id":"5a0b150ffae81ea0a31913a9195fb12ffc6f280b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cbc8034950813f759492498af6e3a96d6c39bf8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4b8d83d_578edd8d","updated":"2025-03-18 12:30:03.000000000","message":"Please, add a unit test for ``_extend_port_resource_request_bulk``","commit_id":"a8bd3e20c695ea200ab295024c2b981e3f715410"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"257c08e97f2062e18f5473d3317d8f59df416c2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"11e4d6d0_ba923bf2","updated":"2025-03-26 05:33:57.000000000","message":"recheck openstack-tox-py312","commit_id":"74bd78eafd3704bd34b50493d7378fb852b95e66"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"db93eef3bf124ec3f520cbe6c18139531ed4b40a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f17f9858_9befddea","updated":"2025-04-04 10:12:33.000000000","message":"I need to backport this change to 2024.1 branch. Should I make a CR for it?","commit_id":"2fd51371ec95a712300707623f77ced6969d54fc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db1b21686ac0d6f4b1db3348bfd1668e485c5e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"941728bf_b174f2f3","updated":"2025-03-28 09:50:21.000000000","message":"Waiting for the CI, but looks ok","commit_id":"2fd51371ec95a712300707623f77ced6969d54fc"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"b2391cf07d0e6ff66f0364c9844a548689d66a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f81a9bbb_c8539675","updated":"2025-03-28 09:05:56.000000000","message":"Wrapped commit message lines.","commit_id":"2fd51371ec95a712300707623f77ced6969d54fc"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"3fd802da355a28d433816f4045bf5be8e9674658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c2d00127_9bd07869","updated":"2025-03-31 05:49:03.000000000","message":"recheck openstack-tox-cover","commit_id":"2fd51371ec95a712300707623f77ced6969d54fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a80e1a690a7029608f4e1d729ae01f532801f051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9d75b114_8cc2dd3a","updated":"2025-04-02 11:33:15.000000000","message":"thanks","commit_id":"2fd51371ec95a712300707623f77ced6969d54fc"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4c54cf030996d2b1409185f3b53b9547b9536d5f","unresolved":true,"context_lines":[{"line_number":475,"context_line":"        ports \u003d self._create_and_extend_ports([], [])"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        for port in ports:"},{"line_number":478,"context_line":"            self.assertIsNone(port.get(\u0027resource_request\u0027))"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def test__extend_port_resource_request_no_qos_policy(self):"},{"line_number":481,"context_line":"        port \u003d self._create_and_extend_port([], physical_network\u003d\u0027public\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ccd83af_a6a56033","line":478,"range":{"start_line":478,"start_character":17,"end_line":478,"end_character":29},"updated":"2025-03-20 07:28:23.000000000","message":"please extend this with check that get_objects is not actually called when passing empty lists.","commit_id":"315ac1105a5f22181b97b937c584dec43994d822"},{"author":{"_account_id":36760,"name":"Jimin Shin","display_name":"Jimin Shin","email":"jimin3.shin@samsung.com","username":"Jimin"},"change_message_id":"5fec31e4e3c81769b855052d200b8bd64640f2a9","unresolved":true,"context_lines":[{"line_number":475,"context_line":"        ports \u003d self._create_and_extend_ports([], [])"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        for port in ports:"},{"line_number":478,"context_line":"            self.assertIsNone(port.get(\u0027resource_request\u0027))"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def test__extend_port_resource_request_no_qos_policy(self):"},{"line_number":481,"context_line":"        port \u003d self._create_and_extend_port([], physical_network\u003d\u0027public\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fbbb950_4a57404a","line":478,"range":{"start_line":478,"start_character":17,"end_line":478,"end_character":29},"in_reply_to":"9ccd83af_a6a56033","updated":"2025-03-21 01:39:49.000000000","message":"I added code checking QosMinimumBandwidthRule.get_objects and QosMinimumPacketRateRule.get_objects are not called.","commit_id":"315ac1105a5f22181b97b937c584dec43994d822"}]}