)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6e83f9ff3e7348c7edb8946bda1ff6099a27f82c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a597f77_70567d37","updated":"2025-03-17 20:54:14.000000000","message":"I would like first to see a Kolla patch with a full CI execution. [1] is just executing only 3 arch64 tests.\n\n[1]https://review.opendev.org/c/openstack/kolla-ansible/+/944776","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"df9d82477253683e823998d258df6c07159a4d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e670e32_da5fb87c","updated":"2025-03-17 17:53:25.000000000","message":"recheck neutron-fullstack","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d46eba7dff0e92bbb2531c1eed571b4a24915ff0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56d5694a_b6061848","updated":"2025-03-17 20:06:53.000000000","message":"recheck random py39 failure","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"10edc10f5ba7cf6fc35f03f5c307820b1aac3e0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"579387f8_52730cbb","in_reply_to":"59e9af39_b2f1ded5","updated":"2025-03-18 07:08:12.000000000","message":"I didn\u0027t see that zuul was still working. The results are good, this patch should be merged.","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3c814227708e8b11db034e2288e4906a90f0bb8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59e9af39_b2f1ded5","in_reply_to":"6a597f77_70567d37","updated":"2025-03-18 06:36:37.000000000","message":"That patch has returned full execution, it’s failing only because of docs job. Is that enough now? It fixes ipv4 jobs (and ipv6 jobs pass as well).","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d8361af7ff35803064f694eb26cb73badcebcf85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"909eed21_a6c238b3","updated":"2025-03-18 14:55:47.000000000","message":"++","commit_id":"57b9c3cb00660bec66fae889013b087ca31ec862"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"be444c9a5919237005c15e2810e3cc2801641e74","unresolved":true,"context_lines":[{"line_number":785,"context_line":"        need_ipv6_metadata \u003d False"},{"line_number":786,"context_line":"        for subnet in network.subnets:"},{"line_number":787,"context_line":"            if subnet.ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":788,"context_line":"                need_ipv6_metadata \u003d True"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if need_ipv6_metadata and netutils.is_ipv6_enabled():"},{"line_number":791,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f7bcdc30_d9f6d96e","line":788,"updated":"2025-03-18 13:24:49.000000000","message":"You can break the loop for the first match","commit_id":"ba03283ff1f2c48bdc03a061ae9704048a9d5c0d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"50e8c101b84bc5e2bb9b497eabd90ffe682eb818","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        need_ipv6_metadata \u003d False"},{"line_number":786,"context_line":"        for subnet in network.subnets:"},{"line_number":787,"context_line":"            if subnet.ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":788,"context_line":"                need_ipv6_metadata \u003d True"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if need_ipv6_metadata and netutils.is_ipv6_enabled():"},{"line_number":791,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bdb3507f_9cb41607","line":788,"in_reply_to":"e60a09b2_caea1d00","updated":"2025-03-18 14:52:29.000000000","message":"Done","commit_id":"ba03283ff1f2c48bdc03a061ae9704048a9d5c0d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ca50fbadd3496a52b1ffea182452ebb0bc0bf11c","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        need_ipv6_metadata \u003d False"},{"line_number":786,"context_line":"        for subnet in network.subnets:"},{"line_number":787,"context_line":"            if subnet.ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":788,"context_line":"                need_ipv6_metadata \u003d True"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if need_ipv6_metadata and netutils.is_ipv6_enabled():"},{"line_number":791,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"e46daca9_0a2bf1f4","line":788,"in_reply_to":"e60a09b2_caea1d00","updated":"2025-03-18 14:52:13.000000000","message":"Done","commit_id":"ba03283ff1f2c48bdc03a061ae9704048a9d5c0d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"490c5261507c6f32f91da126f08babc03af6d93c","unresolved":true,"context_lines":[{"line_number":785,"context_line":"        need_ipv6_metadata \u003d False"},{"line_number":786,"context_line":"        for subnet in network.subnets:"},{"line_number":787,"context_line":"            if subnet.ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":788,"context_line":"                need_ipv6_metadata \u003d True"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if need_ipv6_metadata and netutils.is_ipv6_enabled():"},{"line_number":791,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a4f95e07_5bba6a43","line":788,"in_reply_to":"f7bcdc30_d9f6d96e","updated":"2025-03-18 13:50:38.000000000","message":"Right. In any case, the cost is small. I\u0027ll +2 the patch. If you can respin it, perfect","commit_id":"ba03283ff1f2c48bdc03a061ae9704048a9d5c0d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dd1d9012529d9201bf1b752723242b13b2037de6","unresolved":true,"context_lines":[{"line_number":785,"context_line":"        need_ipv6_metadata \u003d False"},{"line_number":786,"context_line":"        for subnet in network.subnets:"},{"line_number":787,"context_line":"            if subnet.ip_version \u003d\u003d constants.IP_VERSION_6:"},{"line_number":788,"context_line":"                need_ipv6_metadata \u003d True"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if need_ipv6_metadata and netutils.is_ipv6_enabled():"},{"line_number":791,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"e60a09b2_caea1d00","line":788,"in_reply_to":"f7bcdc30_d9f6d96e","updated":"2025-03-18 13:54:14.000000000","message":"or this? same result\n\nneed_ipv6_metadata \u003d any(subnet.ip_version \u003d\u003d constants.IP_VERSION_6\n                         for subnet in network.subnets)\n\nMy original patch did other work in loop so it wasn\u0027t needed.","commit_id":"ba03283ff1f2c48bdc03a061ae9704048a9d5c0d"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fb9731d03a4af0168eaec7553ddc40bbb07fb124","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"    def test_enable_isolated_metadata_proxy_with_dist_network(self):"},{"line_number":1131,"context_line":"        self._test_enable_isolated_metadata_proxy(fake_dist_network)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def _test_enable_isolated_metadata_proxy_ipv4(self, network):"},{"line_number":1134,"context_line":"        cfg.CONF.set_override(\u0027enable_metadata_network\u0027, True)"},{"line_number":1135,"context_line":"        cfg.CONF.set_override(\u0027debug\u0027, True)"},{"line_number":1136,"context_line":"        cfg.CONF.set_override(\u0027log_file\u0027, \u0027test.log\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"886be7c9_c47c69e4","line":1133,"updated":"2025-03-18 07:44:19.000000000","message":"We should not adjust these, as then it will be mostly same as above tests and miss coverage. We should instead make this compatible with the change,\nneed to use/define another fake network with both ipv4 and ipv6 subnets instead of fake_meta_network","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"559223ec8241409e4216a2cba3da9abf3bdb9587","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"    def test_enable_isolated_metadata_proxy_with_dist_network(self):"},{"line_number":1131,"context_line":"        self._test_enable_isolated_metadata_proxy(fake_dist_network)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def _test_enable_isolated_metadata_proxy_ipv4(self, network):"},{"line_number":1134,"context_line":"        cfg.CONF.set_override(\u0027enable_metadata_network\u0027, True)"},{"line_number":1135,"context_line":"        cfg.CONF.set_override(\u0027debug\u0027, True)"},{"line_number":1136,"context_line":"        cfg.CONF.set_override(\u0027log_file\u0027, \u0027test.log\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"88d7394f_8000ac49","line":1133,"in_reply_to":"886be7c9_c47c69e4","updated":"2025-03-18 10:21:32.000000000","message":"Can you please check the updated patch?","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"86ad2124aed70960c139b3046985fd287603488f","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"    def test_enable_isolated_metadata_proxy_with_dist_network(self):"},{"line_number":1131,"context_line":"        self._test_enable_isolated_metadata_proxy(fake_dist_network)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def _test_enable_isolated_metadata_proxy_ipv4(self, network):"},{"line_number":1134,"context_line":"        cfg.CONF.set_override(\u0027enable_metadata_network\u0027, True)"},{"line_number":1135,"context_line":"        cfg.CONF.set_override(\u0027debug\u0027, True)"},{"line_number":1136,"context_line":"        cfg.CONF.set_override(\u0027log_file\u0027, \u0027test.log\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2315d14e_caa481f9","line":1133,"in_reply_to":"88d7394f_8000ac49","updated":"2025-03-18 12:27:27.000000000","message":"thx lgtm","commit_id":"e463462d13a9c3f5360b2cfbd6ec4702349a05f3"}]}