)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6bf3f6f24fa76af7f941f4bf7ba849e83003abf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"204e4c43_b0d3c360","updated":"2025-04-09 08:47:15.000000000","message":"This approach is incorrect. I need to refactor it","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"b2ce9a124c98358120df28008789d2b649e5289e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a5bcaa9d_04e8657c","updated":"2025-04-08 19:54:13.000000000","message":"lgtm, just one comment","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b048a417731fb53eeadbe07893359c03d0931f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fae862a9_3b06898a","updated":"2025-04-09 19:46:52.000000000","message":"lgtm","commit_id":"e700853c0a0fc095ebae3852ec16e57726b571f3"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"0f6276101263fe65643efdf091b0a2e5e21d2576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"856bf5aa_b660e032","updated":"2025-04-09 20:46:03.000000000","message":"thanks for the simplification","commit_id":"e700853c0a0fc095ebae3852ec16e57726b571f3"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"6c49e5f655996e7f0ceaedec760521af7dd9c6e6","unresolved":true,"context_lines":[{"line_number":501,"context_line":"        ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":502,"context_line":"        ls \u003d self._nb_idl.ls_get(ls_name).execute(check_error\u003dTrue)"},{"line_number":503,"context_line":"        network_type \u003d ls.external_ids[ovn_const.OVN_NETTYPE_EXT_ID_KEY]"},{"line_number":504,"context_line":"        qos_options \u003d self._qos_driver.lsp_options_qos_fields(context, 1,"},{"line_number":505,"context_line":"                                                              network_type)"},{"line_number":506,"context_line":"        options.update(qos_options)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d02b286c_02c0c3bf","line":504,"range":{"start_line":504,"start_character":71,"end_line":504,"end_character":73},"updated":"2025-04-08 19:53:19.000000000","message":"sorry this 1 is not clear to me. Is that some default policy_id? \nConsider: defining a variable which will describe this number and then pass that variable.","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"daf195d35c9d91c71041fafcdab629118405e0e1","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":502,"context_line":"        ls \u003d self._nb_idl.ls_get(ls_name).execute(check_error\u003dTrue)"},{"line_number":503,"context_line":"        network_type \u003d ls.external_ids[ovn_const.OVN_NETTYPE_EXT_ID_KEY]"},{"line_number":504,"context_line":"        qos_options \u003d self._qos_driver.lsp_options_qos_fields(context, 1,"},{"line_number":505,"context_line":"                                                              network_type)"},{"line_number":506,"context_line":"        options.update(qos_options)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"03b00598_cafe6252","line":504,"range":{"start_line":504,"start_character":71,"end_line":504,"end_character":73},"in_reply_to":"397a34c2_b1a0847e","updated":"2025-04-09 11:17:43.000000000","message":"I\u0027ve changed the approach. Now we are just reading the current LSP.options QoS fields and adding to the options dict.","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a912d310bf0b2fe0e3a68b1f3bedc54b182de21","unresolved":true,"context_lines":[{"line_number":501,"context_line":"        ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":502,"context_line":"        ls \u003d self._nb_idl.ls_get(ls_name).execute(check_error\u003dTrue)"},{"line_number":503,"context_line":"        network_type \u003d ls.external_ids[ovn_const.OVN_NETTYPE_EXT_ID_KEY]"},{"line_number":504,"context_line":"        qos_options \u003d self._qos_driver.lsp_options_qos_fields(context, 1,"},{"line_number":505,"context_line":"                                                              network_type)"},{"line_number":506,"context_line":"        options.update(qos_options)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"397a34c2_b1a0847e","line":504,"range":{"start_line":504,"start_character":71,"end_line":504,"end_character":73},"in_reply_to":"d02b286c_02c0c3bf","updated":"2025-04-09 08:34:41.000000000","message":"I really don\u0027t know what this \"1\" is doing here... I need to recheck what the FT are doing.","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b048a417731fb53eeadbe07893359c03d0931f7e","unresolved":true,"context_lines":[{"line_number":500,"context_line":"        sg_ids \u003d \u0027 \u0027.join(utils.get_lsp_security_groups(port))"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        lsp_options_qos \u003d self._qos_driver.get_lsp_options_qos(port[\u0027id\u0027])"},{"line_number":503,"context_line":"        options.update(lsp_options_qos)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        return OvnPortInfo(port_type, options, addresses, port_security,"},{"line_number":506,"context_line":"                           parent_name, tag, dhcpv4_options, dhcpv6_options,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e22de002_1a634839","line":503,"updated":"2025-04-09 19:46:52.000000000","message":"Is there a chance that will update options that","commit_id":"e700853c0a0fc095ebae3852ec16e57726b571f3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b3a838c5295324a431466acf699e19ab28ee8339","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        sg_ids \u003d \u0027 \u0027.join(utils.get_lsp_security_groups(port))"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        lsp_options_qos \u003d self._qos_driver.get_lsp_options_qos(port[\u0027id\u0027])"},{"line_number":503,"context_line":"        options.update(lsp_options_qos)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        return OvnPortInfo(port_type, options, addresses, port_security,"},{"line_number":506,"context_line":"                           parent_name, tag, dhcpv4_options, dhcpv6_options,"}],"source_content_type":"text/x-python","patch_set":3,"id":"57b1178a_555ae449","line":503,"in_reply_to":"e22de002_1a634839","updated":"2025-04-09 20:03:51.000000000","message":"Done, accidentally included a draft that I answered myself by reading. 😄","commit_id":"e700853c0a0fc095ebae3852ec16e57726b571f3"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"b048a417731fb53eeadbe07893359c03d0931f7e","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            lsp \u003d self.nb_api.lookup(\u0027Logical_Switch_Port\u0027, port_id)"},{"line_number":322,"context_line":"            if max_kbps:"},{"line_number":323,"context_line":"                self.assertEqual("},{"line_number":324,"context_line":"                    \u0027{}\u0027.format(max_kbps * 1000),"},{"line_number":325,"context_line":"                    lsp.options[ovn_const.LSP_OPTIONS_QOS_MAX_RATE])"},{"line_number":326,"context_line":"            else:"},{"line_number":327,"context_line":"                self.assertNotIn(ovn_const.LSP_OPTIONS_QOS_MAX_RATE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d8fe1b59_099e61df","line":324,"range":{"start_line":324,"start_character":20,"end_line":324,"end_character":48},"updated":"2025-04-09 19:46:52.000000000","message":"This isn\u0027t for review, just asking for my own learning. Is there a reason this format would be preferable to just `str(max_kbps * 1000)` or `f\u0027{maxkbps * 1000}\u0027`?","commit_id":"e700853c0a0fc095ebae3852ec16e57726b571f3"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7e28b11c5df983e0b156939eba71dba4336eb2e4","unresolved":true,"context_lines":[{"line_number":3223,"context_line":"        p \u003d mock.patch.object(ovn_utils, \u0027get_revision_number\u0027, return_value\u003d1)"},{"line_number":3224,"context_line":"        p.start()"},{"line_number":3225,"context_line":"        self.addCleanup(p.stop)"},{"line_number":3226,"context_line":"        self.addCleanup(p.stop)"},{"line_number":3227,"context_line":"        ext_ids \u003d {ovn_const.OVN_NETTYPE_EXT_ID_KEY: const.TYPE_GENEVE}"},{"line_number":3228,"context_line":"        self.mech_driver.nb_ovn.ls_get.return_value.execute.return_value \u003d ("},{"line_number":3229,"context_line":"            mock.Mock(external_ids\u003dext_ids))"}],"source_content_type":"text/x-python","patch_set":2,"id":"6aa9034f_ab042017","line":3226,"updated":"2025-04-08 16:53:37.000000000","message":"Duplicate call","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a912d310bf0b2fe0e3a68b1f3bedc54b182de21","unresolved":false,"context_lines":[{"line_number":3223,"context_line":"        p \u003d mock.patch.object(ovn_utils, \u0027get_revision_number\u0027, return_value\u003d1)"},{"line_number":3224,"context_line":"        p.start()"},{"line_number":3225,"context_line":"        self.addCleanup(p.stop)"},{"line_number":3226,"context_line":"        self.addCleanup(p.stop)"},{"line_number":3227,"context_line":"        ext_ids \u003d {ovn_const.OVN_NETTYPE_EXT_ID_KEY: const.TYPE_GENEVE}"},{"line_number":3228,"context_line":"        self.mech_driver.nb_ovn.ls_get.return_value.execute.return_value \u003d ("},{"line_number":3229,"context_line":"            mock.Mock(external_ids\u003dext_ids))"}],"source_content_type":"text/x-python","patch_set":2,"id":"efb71737_06ac30fa","line":3226,"in_reply_to":"6aa9034f_ab042017","updated":"2025-04-09 08:34:41.000000000","message":"Done","commit_id":"3f79bd50bd8a1527af64959eec4a01e3b998ead7"}]}