)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d6b231801ed79514defd44ed7598c419ae5bfd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c776b9c_84cdd767","updated":"2025-04-15 00:51:07.000000000","message":"Still have some pep8 errors","commit_id":"c8343ced1f1f763ab883665e889a4ca9cabef88a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5e968d1862020fd4b6dc764e38c42793da616364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22afd949_6cc00fd9","updated":"2025-04-15 09:25:59.000000000","message":"++","commit_id":"6699134f3e722958fcf91eb8051317a358b6841a"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d6b231801ed79514defd44ed7598c419ae5bfd4","unresolved":true,"context_lines":[{"line_number":79,"context_line":"RELATED_ACTION_MAP \u003d {DELETE_ROUTER: DELETE_RELATED_ROUTER,"},{"line_number":80,"context_line":"                      ADD_UPDATE_ROUTER: ADD_UPDATE_RELATED_ROUTER}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"ROUTER_PROCESS \u003d 32"},{"line_number":83,"context_line":"ROUTER_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"173e5ed1_312d3f3a","line":82,"updated":"2025-04-15 00:51:07.000000000","message":"nit: should this be ROUTER_PROCESS_THREADS ?","commit_id":"c8343ced1f1f763ab883665e889a4ca9cabef88a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44afa9b8dbb2961ffec739cb853809988cd53bcc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"RELATED_ACTION_MAP \u003d {DELETE_ROUTER: DELETE_RELATED_ROUTER,"},{"line_number":80,"context_line":"                      ADD_UPDATE_ROUTER: ADD_UPDATE_RELATED_ROUTER}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"ROUTER_PROCESS \u003d 32"},{"line_number":83,"context_line":"ROUTER_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e8459d59_4cc0423a","line":82,"in_reply_to":"173e5ed1_312d3f3a","updated":"2025-04-15 10:49:59.000000000","message":"Done","commit_id":"c8343ced1f1f763ab883665e889a4ca9cabef88a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d6b231801ed79514defd44ed7598c419ae5bfd4","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                      ADD_UPDATE_ROUTER: ADD_UPDATE_RELATED_ROUTER}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"ROUTER_PROCESS \u003d 32"},{"line_number":83,"context_line":"ROUTER_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def log_verbose_exc(message, router_payload):"}],"source_content_type":"text/x-python","patch_set":2,"id":"84f7a28b_e380a9d5","line":83,"updated":"2025-04-15 00:51:07.000000000","message":"Is this used any more?","commit_id":"c8343ced1f1f763ab883665e889a4ca9cabef88a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44afa9b8dbb2961ffec739cb853809988cd53bcc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      ADD_UPDATE_ROUTER: ADD_UPDATE_RELATED_ROUTER}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"ROUTER_PROCESS \u003d 32"},{"line_number":83,"context_line":"ROUTER_PROCESS_GREENLET_MIN \u003d 8"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def log_verbose_exc(message, router_payload):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f098ed04_1e079547","line":83,"in_reply_to":"84f7a28b_e380a9d5","updated":"2025-04-15 10:49:59.000000000","message":"No, removed.","commit_id":"c8343ced1f1f763ab883665e889a4ca9cabef88a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e084e122578ccb4ddf62b0052151dec360c731d8","unresolved":true,"context_lines":[{"line_number":316,"context_line":"            self.metadata_driver)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # L3 agent router processing green pool"},{"line_number":319,"context_line":"        self._pool \u003d eventlet.GreenPool(size\u003dROUTER_PROCESS_THREADS)"},{"line_number":320,"context_line":"        self._queue \u003d queue.ResourceProcessingQueue()"},{"line_number":321,"context_line":"        super().__init__(host\u003dself.conf.host)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"26979a30_230c21b9","line":319,"updated":"2025-04-15 09:29:58.000000000","message":"Hum I guess you prefer to keep the max number (32) to limit the change. The default limit et GreenPool(size\u003d1000)","commit_id":"6699134f3e722958fcf91eb8051317a358b6841a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44afa9b8dbb2961ffec739cb853809988cd53bcc","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            self.metadata_driver)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # L3 agent router processing green pool"},{"line_number":319,"context_line":"        self._pool \u003d eventlet.GreenPool(size\u003dROUTER_PROCESS_THREADS)"},{"line_number":320,"context_line":"        self._queue \u003d queue.ResourceProcessingQueue()"},{"line_number":321,"context_line":"        super().__init__(host\u003dself.conf.host)"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bd9f4b77_77025844","line":319,"in_reply_to":"26979a30_230c21b9","updated":"2025-04-15 10:49:59.000000000","message":"The default limit of ``GreenPool`` is indeed 1000 but it was limited to 8 in the L3 agent, up to 32. We never used up to 1000 threads, this scenario is not tested and most probably could be dangerous in resources usage and prone to timeouts.","commit_id":"6699134f3e722958fcf91eb8051317a358b6841a"}]}