)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a25cfa366c334de4318b7b2da6569804b986686c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove project_id filter from log resource query for consistent updates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When retrieving log resources to update logging settings, a project_is"},{"line_number":10,"context_line":"filter is applied based on the request context. This causes inconsistent"},{"line_number":11,"context_line":"behavior where identical requests result in different logging outcomes"},{"line_number":12,"context_line":"depending on the project associated with the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"214311a5_017a5a28","line":9,"range":{"start_line":9,"start_character":60,"end_line":9,"end_character":70},"updated":"2025-04-16 18:49:12.000000000","message":"nit: project_id","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"05633da2779b2cf49da5cc914584d3632bd9be53","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove project_id filter from log resource query for consistent updates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When retrieving log resources to update logging settings, a project_is"},{"line_number":10,"context_line":"filter is applied based on the request context. This causes inconsistent"},{"line_number":11,"context_line":"behavior where identical requests result in different logging outcomes"},{"line_number":12,"context_line":"depending on the project associated with the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"52eb6dee_a35df987","line":9,"range":{"start_line":9,"start_character":60,"end_line":9,"end_character":70},"in_reply_to":"214311a5_017a5a28","updated":"2025-06-18 04:18:38.000000000","message":"I fixed the typo. Thank you.","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a25cfa366c334de4318b7b2da6569804b986686c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec531e34_63493ba6","updated":"2025-04-16 18:49:12.000000000","message":"-1 just due to my question","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bd1b4d0c83609577a17cd3e903192b5c02a3dfcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9165907e_ed17d674","updated":"2025-04-17 11:44:13.000000000","message":"I tried to reproduce your bug on master and for me logging worked as expected, at least the OVN ACL setting was correct, are you sure that this fix is necessary?\nPlease see my comment on the bug: https://bugs.launchpad.net/neutron/+bug/2107446/comments/4","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"cc63796c22dd7d317e23242371d391a8f4dd470d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18275596_27891896","updated":"2025-06-18 06:34:00.000000000","message":"recheck neutron-functional-with-uwsgi, neutron-ovs-rally-task","commit_id":"477ba98958c8d94ae18a09caf2670f8a41059bfb"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"7b6a73142b6ce0d70ca721d2418bb91c495b82c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ba53a4b_3cbd7cb8","updated":"2025-06-18 09:07:38.000000000","message":"recheck openstack-tox-pep8","commit_id":"09558b46e4595f45adae1ef8d0178611c61e9cd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13b51c71551a41e380f560972037296a63df525f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bc3416a8_90241a5c","updated":"2025-07-31 10:39:24.000000000","message":"This patch is superseded by https://review.opendev.org/c/openstack/neutron/+/956094","commit_id":"801be0a574a018e170cc2bb12e3b56720e403fc9"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"93634bb59b574fa1222cfd48e22e0381df536319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9ea1b467_511ae51b","updated":"2025-06-19 01:59:53.000000000","message":"recheck openstack-tox-pep8","commit_id":"801be0a574a018e170cc2bb12e3b56720e403fc9"}],"neutron/services/logapi/common/sg_callback.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a25cfa366c334de4318b7b2da6569804b986686c","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            sg_id \u003d payload.resource_id"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        log_resources \u003d db_api.get_logs_bound_sg("},{"line_number":33,"context_line":"            context, sg_id\u003dsg_id)"},{"line_number":34,"context_line":"        if log_resources:"},{"line_number":35,"context_line":"            self.resource_push_api("},{"line_number":36,"context_line":"                log_const.RESOURCE_UPDATE, context, log_resources)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5b59128_3ceb45f6","line":33,"updated":"2025-04-16 18:49:12.000000000","message":"I maybe haven\u0027t thought about it much, but if we found the SG above, should we be using it\u0027s project_id here? Else use the context project_id? This argument was added in 7f063223553a18345891bf42e88989edb67038e7 for https://bugs.launchpad.net/neutron/+bug/1939558 and I don\u0027t want to regress that.","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"711801d9da5261f403ba43f40b458397297341c8","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            sg_id \u003d payload.resource_id"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        log_resources \u003d db_api.get_logs_bound_sg("},{"line_number":33,"context_line":"            context, sg_id\u003dsg_id)"},{"line_number":34,"context_line":"        if log_resources:"},{"line_number":35,"context_line":"            self.resource_push_api("},{"line_number":36,"context_line":"                log_const.RESOURCE_UPDATE, context, log_resources)"}],"source_content_type":"text/x-python","patch_set":1,"id":"438723e3_800aa49e","line":33,"in_reply_to":"3c1e0690_16b7664a","updated":"2025-06-18 04:13:36.000000000","message":"Sorry for the late reply.\n\nI think there are four possible options here:\n(1) Use the project ID from the context (current implementation)\n(2) Use the project ID from the Security Group (as Brian suggested)\n(3) Use the project ID from the Security Group Rule\n(4) Do not apply any project ID filtering (my suggestion)\n\nAs Rodolfo pointed out, the Security Group and the logs can belong to different projects. To ensure all related resources are updated consistently, I believe skipping the project ID filter is the most appropriate choice.\n\nI also reviewed the bug #1939558 Brian mentioned. It seems that the issue was about ensuring logs are deleted along with the Security Group. For that, its sufficient to register the _clean_security_group_logs() function on the SG\u0027s AFTER_DELETE event. The get_logs_bound_sg() function doesn\u0027t need a project ID filter. Also, my current code does not reproduce the issue described in that bug report.","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4218b23c6773019e2ef0f0a046ad1f8e16454874","unresolved":true,"context_lines":[{"line_number":30,"context_line":"            sg_id \u003d payload.resource_id"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        log_resources \u003d db_api.get_logs_bound_sg("},{"line_number":33,"context_line":"            context, sg_id\u003dsg_id)"},{"line_number":34,"context_line":"        if log_resources:"},{"line_number":35,"context_line":"            self.resource_push_api("},{"line_number":36,"context_line":"                log_const.RESOURCE_UPDATE, context, log_resources)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c1e0690_16b7664a","line":33,"in_reply_to":"d5b59128_3ceb45f6","updated":"2025-05-20 10:31:59.000000000","message":"Actually I think that makes sense, at least for the update command. The logs, SG and SG rules can have, all of them, different project owners. We can also make this call from a different project too (as long as this is being made by the admin, using the default policies).\n\nA SG can have Logs associated from different projects. All of them should be updated when a new SG rule is added to the SG; this command implies adding a new ACL rule per log resource.\n\nNOTE: this change deserves proper testing for any event.","commit_id":"63118198a87d3e12594e023490dbe619cb4437df"}]}