)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"c77f47a6a63212738f7e4802c4229d5c0b90362f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e01abfa_84dc4522","updated":"2025-04-29 02:34:27.000000000","message":"recheck","commit_id":"ac2c9424e79601967660e512a7695824eb287219"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"bd4969ca222f34f1da670ac41f098d1246235095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8e2b9cdb_31846449","updated":"2025-05-15 13:31:58.000000000","message":"This moved back in https://review.opendev.org/c/openstack/neutron/+/948053","commit_id":"506f4899e2b78aa10b5250b817e0a8ae4f688db7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"8ddb3ccdaa521e3c845f8ddc5f5eaf95dfd5ec34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f5ea51b_4139f9bf","updated":"2025-05-15 13:32:36.000000000","message":"as the issue is also relate to log resources anyway","commit_id":"506f4899e2b78aa10b5250b817e0a8ae4f688db7"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"4a3f2548b3921976274d33653923ffbb8edd99a0","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                            ).randrange(1, log_driver.MAX_INT_LABEL)"},{"line_number":369,"context_line":"                        log_attrs[\u0027options\u0027] \u003d acl_options"},{"line_number":370,"context_line":"                else:"},{"line_number":371,"context_line":"                    log_attrs \u003d {\"label\": 0, \"options\": {}} if ("},{"line_number":372,"context_line":"                        is_support_label) else {}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"                # allow reuse existing acl"}],"source_content_type":"text/x-python","patch_set":3,"id":"03c6b5a2_248c8b9f","line":371,"range":{"start_line":371,"start_character":20,"end_line":371,"end_character":59},"updated":"2025-04-29 14:41:42.000000000","message":"Tried this chain of 2 patches on my local env. When running dbsync, label of neutron_pg_drop is changed from the previous rand int to 0. We should preserve the value to keep logging related traffic. The best option would be to really avoid ovn-db-sync from deleting the neutron_pg_drop acl.","commit_id":"ac2c9424e79601967660e512a7695824eb287219"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"d2c5431f8bc5090409d99430a042c27088edf5a8","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                            ).randrange(1, log_driver.MAX_INT_LABEL)"},{"line_number":369,"context_line":"                        log_attrs[\u0027options\u0027] \u003d acl_options"},{"line_number":370,"context_line":"                else:"},{"line_number":371,"context_line":"                    log_attrs \u003d {\"label\": 0, \"options\": {}} if ("},{"line_number":372,"context_line":"                        is_support_label) else {}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"                # allow reuse existing acl"}],"source_content_type":"text/x-python","patch_set":3,"id":"aae27376_73d6130b","line":371,"range":{"start_line":371,"start_character":20,"end_line":371,"end_character":59},"in_reply_to":"03c6b5a2_248c8b9f","updated":"2025-04-29 15:37:48.000000000","message":"\u003e The best option would be to really avoid ovn-db-sync from deleting the neutron_pg_drop acl.\n\nSorry!! I saw that with this new patch ACL are indeed not getting deleted. I forgot the most important part on the last sentence 😊\n\nThe best option would be to really avoid ovn-db-sync from deleting the neutron_pg_drop acl label.","commit_id":"ac2c9424e79601967660e512a7695824eb287219"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"cf5d686f0f8250581d9526707cfa4b5e0721b3b5","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                            ).randrange(1, log_driver.MAX_INT_LABEL)"},{"line_number":369,"context_line":"                        log_attrs[\u0027options\u0027] \u003d acl_options"},{"line_number":370,"context_line":"                else:"},{"line_number":371,"context_line":"                    log_attrs \u003d {\"label\": 0, \"options\": {}} if ("},{"line_number":372,"context_line":"                        is_support_label) else {}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"                # allow reuse existing acl"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ccdf61d_a63061a2","line":371,"range":{"start_line":371,"start_character":20,"end_line":371,"end_character":59},"in_reply_to":"43ce9a37_a0abc2ca","updated":"2025-04-30 12:13:27.000000000","message":"Sure! First of all, thanks a lot for your effort on this, I know it is an intrincate topic.\n\nWhen setting drop log object:\nhttps://paste.opendev.org/show/bPxtuyb5Edu9RO5rSh2b/\nWe see the ACL is still being modified, which is not desired if the ACL was in a correct state to begin with. With this and the previous patch, we end up in a mixed situation. Even if it\u0027s true that both patchs help avoiding the pg_drop ACL from being deleted, I don\u0027t think it is currently a proper solution.\n\nWe would need to only modify ACLs when an improper state is present. And this would also include re-setting logging options when they are manually disabled or similar. Although I understand that the most critical thing right now is just avoiding this from deleting the drop ACL.\n\nAnother example of bad behaviour with these patches is here when creating an ACCEPT log object and it removes and update the ACLs:\n\nhttps://paste.opendev.org/show/beZx5GtlW19eEaGTmDyp/\n\nAnd another example of what I mean by restoring ACLs if modified (although this would be for a perfect solution and might be doable as follow up, best solution might be handling all of this as one single logical approach:\n\nhttps://paste.opendev.org/show/bU0agBuZGju6QYdTsGS0/","commit_id":"ac2c9424e79601967660e512a7695824eb287219"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"aa631a921b00c8412a7a35d4c3798aa0066b6fcf","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                            ).randrange(1, log_driver.MAX_INT_LABEL)"},{"line_number":369,"context_line":"                        log_attrs[\u0027options\u0027] \u003d acl_options"},{"line_number":370,"context_line":"                else:"},{"line_number":371,"context_line":"                    log_attrs \u003d {\"label\": 0, \"options\": {}} if ("},{"line_number":372,"context_line":"                        is_support_label) else {}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"                # allow reuse existing acl"}],"source_content_type":"text/x-python","patch_set":3,"id":"070a72b2_90dda4a0","line":371,"range":{"start_line":371,"start_character":20,"end_line":371,"end_character":59},"in_reply_to":"9ccdf61d_a63061a2","updated":"2025-05-06 16:50:42.000000000","message":"The issue is now fixed with https://review.opendev.org/c/openstack/neutron/+/948053/5..6/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py\nPlease try again to see if I missed anything.\nWill keep checking other scenarios to see if I missed anything.","commit_id":"ac2c9424e79601967660e512a7695824eb287219"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"933185244d23be5e70a3f19ec8a4532fb0358b9e","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                            ).randrange(1, log_driver.MAX_INT_LABEL)"},{"line_number":369,"context_line":"                        log_attrs[\u0027options\u0027] \u003d acl_options"},{"line_number":370,"context_line":"                else:"},{"line_number":371,"context_line":"                    log_attrs \u003d {\"label\": 0, \"options\": {}} if ("},{"line_number":372,"context_line":"                        is_support_label) else {}"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"                # allow reuse existing acl"}],"source_content_type":"text/x-python","patch_set":3,"id":"43ce9a37_a0abc2ca","line":371,"range":{"start_line":371,"start_character":20,"end_line":371,"end_character":59},"in_reply_to":"aae27376_73d6130b","updated":"2025-04-30 00:57:48.000000000","message":"neutron_pg_drop only assigns label to 0 in https://review.opendev.org/c/openstack/neutron/+/948215/3/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py#497\n\nand that means \nsg_logs \u003d log_db_api.get_logs_bound_sg(ctx, sg_id\u003dsg[\u0027id\u0027], exclusive\u003dTrue) is empty\n\nwhat\u0027s your `openstack network log list` shows?\n\nIf you don\u0027t mind to provide me your step by step doc, it would be helpful for me to reproduce the issue. :)","commit_id":"ac2c9424e79601967660e512a7695824eb287219"}]}