)]}'
{"neutron/openstack/common/middleware/notifier.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"497394fe906a7b96b96e3a1cc5087620297e845c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            return fn(*args, **kwargs)"},{"line_number":39,"context_line":"        except Exception as e:"},{"line_number":40,"context_line":"            LOG.exception(_LE(\u0027An exception occurred processing \u0027"},{"line_number":41,"context_line":"                              \u0027the API call: %s \u0027) % e)"},{"line_number":42,"context_line":"    return wrapped"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3c1c6dc1","line":41,"updated":"2014-06-01 13:37:53.000000000","message":"can you please use a , instead of %","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"68c620e354337cbf861d6dbaa4a93882ac4397ab","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            return fn(*args, **kwargs)"},{"line_number":39,"context_line":"        except Exception as e:"},{"line_number":40,"context_line":"            LOG.exception(_LE(\u0027An exception occurred processing \u0027"},{"line_number":41,"context_line":"                              \u0027the API call: %s \u0027) % e)"},{"line_number":42,"context_line":"    return wrapped"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8a96a03d","line":41,"in_reply_to":"1ae5cdf2_3c1c6dc1","updated":"2014-06-04 17:31:04.000000000","message":"this is a sync from oslo-incubator. this nit should be applied to original.","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8f032da26705fabee0ffddd10f102df400bd23d6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            return fn(*args, **kwargs)"},{"line_number":39,"context_line":"        except Exception as e:"},{"line_number":40,"context_line":"            LOG.exception(_LE(\u0027An exception occurred processing \u0027"},{"line_number":41,"context_line":"                              \u0027the API call: %s \u0027) % e)"},{"line_number":42,"context_line":"    return wrapped"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ea6e442e","line":41,"in_reply_to":"1ae5cdf2_8a96a03d","updated":"2014-06-04 17:41:26.000000000","message":"I agree that changing to a \u0027,\u0027 is out of the scope of this patch.","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"29279fda4865460fdee3ef56312b57fdd96cf7dd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        super(RequestNotifier, self).__init__(app)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def environ_to_dict(environ):"},{"line_number":66,"context_line":"        \"\"\"Following PEP 333, server variables are lower case, so don\u0027t"},{"line_number":67,"context_line":"        include them."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_31e2cf01","line":65,"updated":"2014-05-22 17:55:01.000000000","message":"I know it\u0027s legacy, but \"environ\" seems to be already dict. \nWould it make sense to rename to _filter_non_server_environ or get_client_environ, or something more descriptive?","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"660cdbad238211ffe9213c383e29543ec4624f8a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        super(RequestNotifier, self).__init__(app)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def environ_to_dict(environ):"},{"line_number":66,"context_line":"        \"\"\"Following PEP 333, server variables are lower case, so don\u0027t"},{"line_number":67,"context_line":"        include them."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_eb8fdd73","line":65,"in_reply_to":"3ae8d1ca_2b2625bb","updated":"2014-05-27 04:38:57.000000000","message":"Thanks Henry for educating me :-) \nI just learned that this is actually a sync commit of the one that has already merged in oslo-incubator repo.","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"86134f9168d95a342a4ce810799bbcaf0cceaad6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        super(RequestNotifier, self).__init__(app)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def environ_to_dict(environ):"},{"line_number":66,"context_line":"        \"\"\"Following PEP 333, server variables are lower case, so don\u0027t"},{"line_number":67,"context_line":"        include them."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_2b2625bb","line":65,"in_reply_to":"3ae8d1ca_f01fc8b5","updated":"2014-05-27 04:32:27.000000000","message":"Currently that is how neutron uses oslo: the code is copied from the oslo-incubator repo. The files under neutron/openstack/common are oslo files.","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1d30285034535bb9c3eaa798c701d1a502b16ff1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        super(RequestNotifier, self).__init__(app)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def environ_to_dict(environ):"},{"line_number":66,"context_line":"        \"\"\"Following PEP 333, server variables are lower case, so don\u0027t"},{"line_number":67,"context_line":"        include them."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_497dd96d","line":65,"in_reply_to":"7adec928_31e2cf01","updated":"2014-05-23 12:23:55.000000000","message":"This module is from oslo. You can discuss or file bugs with the oslo team about this.","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"57ad45974cc3ed9bd6ff0f53f265ae6a0e6ea83e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        super(RequestNotifier, self).__init__(app)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def environ_to_dict(environ):"},{"line_number":66,"context_line":"        \"\"\"Following PEP 333, server variables are lower case, so don\u0027t"},{"line_number":67,"context_line":"        include them."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_f01fc8b5","line":65,"in_reply_to":"7adec928_497dd96d","updated":"2014-05-27 04:06:02.000000000","message":"Sorry for my ignorance, removing -1. \n\nBut the fact that I see modification here means that it\u0027s now in neutron\u0027s code (originally copied from oslo?) , right? Or am I missing something?","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"change_message_id":"29279fda4865460fdee3ef56312b57fdd96cf7dd","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        return dict((k, v) for k, v in six.iteritems(environ)"},{"line_number":71,"context_line":"                    if k.isupper() and k !\u003d \u0027HTTP_X_AUTH_TOKEN\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @log_and_ignore_error"},{"line_number":74,"context_line":"    def process_request(self, request):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_71ed37b7","line":71,"updated":"2014-05-22 17:55:01.000000000","message":"Adding a specific filtering with the method name above seems a bit hacky. May want to move out to the caller side or maybe it\u0027d be better to change the name to something like _filter_environ_for_notification()?","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1d30285034535bb9c3eaa798c701d1a502b16ff1","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        return dict((k, v) for k, v in six.iteritems(environ)"},{"line_number":71,"context_line":"                    if k.isupper() and k !\u003d \u0027HTTP_X_AUTH_TOKEN\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @log_and_ignore_error"},{"line_number":74,"context_line":"    def process_request(self, request):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_a991fd9b","line":71,"in_reply_to":"7adec928_71ed37b7","updated":"2014-05-23 12:23:55.000000000","message":"ditto","commit_id":"bb4f44654f6765c4e1fbcf92375c273494151099"}]}