)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"401609d3c8ede93ba345c59b35b28d8588aca564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea46fce7_795ce385","updated":"2025-06-02 10:43:56.000000000","message":"We also need to consider the case of the metadata extension resync, that is done in [1]. You should add the call to this method there too.\n\n[1]https://github.com/openstack/neutron/blob/master/neutron/agent/ovn/extensions/metadata.py#L163","commit_id":"05c0163f2337f91e9b45c00d69ed2c5935e028fe"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"cfe1955980efea7fe700eefa2eb6642895998bbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e5bb2bfe_a6da570c","updated":"2025-06-04 05:23:18.000000000","message":"couldn\u0027t find any related code, want to try a recheck for test_floatingip_mac_bindings again","commit_id":"3bf7f8ec80072c70396a60dc78b065c3c47eaf2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6320a0eccc910c57b96cb8147ab472ce8e88f55b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"439fdaa2_96af10a6","updated":"2025-06-04 10:44:24.000000000","message":"recheck\nfunctional test_floatingip_mac_bindings failure seems not related","commit_id":"3bf7f8ec80072c70396a60dc78b065c3c47eaf2c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"84e8847b85a4ed296a11addb80b028b3c546dbbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"445c379c_64b030d9","updated":"2025-06-03 14:15:43.000000000","message":"recheck test_floatingip_mac_bindings","commit_id":"3bf7f8ec80072c70396a60dc78b065c3c47eaf2c"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"96b4e61af363f00f98a4e49ebdf8d5fc2d07096c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2581107d_3c055c4a","in_reply_to":"2903af1b_b3f97089","updated":"2025-06-03 16:53:52.000000000","message":"Well, there should be something wrong, will check why it fails","commit_id":"3bf7f8ec80072c70396a60dc78b065c3c47eaf2c"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"031e243e49f31fce50d169a372964cebd36d2f5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2903af1b_b3f97089","in_reply_to":"445c379c_64b030d9","updated":"2025-06-03 15:54:37.000000000","message":"Thanks, I\u0027m a bit confused about why the change caused an unrelated test to fail.","commit_id":"3bf7f8ec80072c70396a60dc78b065c3c47eaf2c"}],"neutron/agent/ovn/extensions/metadata.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ca6fde1277410138476f90590c04c734ff474f7","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":180,"context_line":"        self.register_metadata_agent()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Start the metadata server."},{"line_number":183,"context_line":"        proxy_thread \u003d threading.Thread(target\u003dself._proxy.wait)"},{"line_number":184,"context_line":"        proxy_thread.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"19c601f4_16a993bd","line":181,"updated":"2025-06-02 11:22:05.000000000","message":"Well, maybe I didn\u0027t mention that in my previous comment, but this is also needed here, same as in the metadata agent.","commit_id":"643d419305eafec71bdf3fdb17c88e9effc2f956"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"961f3054b0f6ca0b48edadbf57c627c6f835cd4a","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":180,"context_line":"        self.register_metadata_agent()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Start the metadata server."},{"line_number":183,"context_line":"        proxy_thread \u003d threading.Thread(target\u003dself._proxy.wait)"},{"line_number":184,"context_line":"        proxy_thread.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e88f611_5e127329","line":181,"in_reply_to":"19c601f4_16a993bd","updated":"2025-06-02 12:18:55.000000000","message":"And we may also need _update_metadata_sb_cfg_key here?","commit_id":"643d419305eafec71bdf3fdb17c88e9effc2f956"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"d70302555b5f070b30adb34f0e6d00bb9862a741","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":180,"context_line":"        self.register_metadata_agent()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Start the metadata server."},{"line_number":183,"context_line":"        proxy_thread \u003d threading.Thread(target\u003dself._proxy.wait)"},{"line_number":184,"context_line":"        proxy_thread.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"0c26db53_b903fe91","line":181,"in_reply_to":"8e88f611_5e127329","updated":"2025-06-02 12:19:09.000000000","message":"Done","commit_id":"643d419305eafec71bdf3fdb17c88e9effc2f956"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e826669c67b1b997320d00e5c506437f7fbf4d78","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        Reload the configuration and sync the agent again."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        self.agent_api.load_config()"},{"line_number":164,"context_line":"        self._update_chassis_private_config()"},{"line_number":165,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":166,"context_line":"        self.sync()"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d8172496_4c8f1ed1","line":164,"range":{"start_line":164,"start_character":13,"end_line":164,"end_character":43},"updated":"2025-06-02 12:44:17.000000000","message":"No no, hold on. This is not in the scope of this patch. I\u0027ve already created a LP bug and pushed a patch before this new PS: https://review.opendev.org/c/openstack/neutron/+/951512","commit_id":"0f48679fca1150c511b4d1d5fffc0f407732491d"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"88a6a74c5b965d499ac5076ac101a6fd5916d487","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        Reload the configuration and sync the agent again."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        self.agent_api.load_config()"},{"line_number":164,"context_line":"        self._update_chassis_private_config()"},{"line_number":165,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":166,"context_line":"        self.sync()"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"74d33106_8a200b14","line":164,"range":{"start_line":164,"start_character":13,"end_line":164,"end_character":43},"in_reply_to":"85c77e36_3e0b6971","updated":"2025-06-02 12:53:05.000000000","message":"As the same, we need another patch for _update_metadata_sb_cfg_key here?","commit_id":"0f48679fca1150c511b4d1d5fffc0f407732491d"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"228169942c3356fa3ab6986412751b37068fea55","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        Reload the configuration and sync the agent again."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        self.agent_api.load_config()"},{"line_number":164,"context_line":"        self._update_chassis_private_config()"},{"line_number":165,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":166,"context_line":"        self.sync()"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"85c77e36_3e0b6971","line":164,"range":{"start_line":164,"start_character":13,"end_line":164,"end_character":43},"in_reply_to":"d8172496_4c8f1ed1","updated":"2025-06-02 12:50:45.000000000","message":"Got, let me remove these","commit_id":"0f48679fca1150c511b4d1d5fffc0f407732491d"}]}