)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"708c5a83ee1f26065d7968b8d7bd7a9e48dbd772","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class DictModel(object):"},{"line_number":81,"context_line":"    \"\"\"Convert dict into an object that provides attribute access to values.\"\"\""},{"line_number":82,"context_line":"    def __init__(self, d):"},{"line_number":83,"context_line":"        for key, value in six.iteritems(d):"},{"line_number":84,"context_line":"            if isinstance(value, list):"},{"line_number":85,"context_line":"                value \u003d [DictModel(item) if isinstance(item, dict) else item"},{"line_number":86,"context_line":"                         for item in value]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_4e90d5ec","line":83,"updated":"2014-05-27 12:31:37.000000000","message":"Suggestion: How about instead of using six module in cases where iterator is not explicitly needed (like this case), use d.items() instead.","commit_id":"55f200d48cfab27dbb428b3ca2a4c8b0cc49774a"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d9e3b0a89d3f6f4956748a24cfa7c78fb7f62800","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class DictModel(object):"},{"line_number":81,"context_line":"    \"\"\"Convert dict into an object that provides attribute access to values.\"\"\""},{"line_number":82,"context_line":"    def __init__(self, d):"},{"line_number":83,"context_line":"        for key, value in six.iteritems(d):"},{"line_number":84,"context_line":"            if isinstance(value, list):"},{"line_number":85,"context_line":"                value \u003d [DictModel(item) if isinstance(item, dict) else item"},{"line_number":86,"context_line":"                         for item in value]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_144f8cbe","line":83,"in_reply_to":"3ae8d1ca_4e90d5ec","updated":"2014-05-28 13:58:12.000000000","message":"+1.\nPersonally I think it\u0027s not good to use a library to emulate language built-in constructs. Unless it\u0027s strictly required, items and iteritems are interchangeble, so I\u0027d avoid using six for iteritems.","commit_id":"55f200d48cfab27dbb428b3ca2a4c8b0cc49774a"}]}
