)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"cc6c8611f7a44c18ab813363b0645f68efbfb940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"032af283_d399bdd0","updated":"2025-07-30 15:56:56.000000000","message":"I have checked this on my environment and after applying the patch and restarting the services, I see:\nbinary | neutron-ovn-agent \nas expected.\n\nFound nothing to highlight codewise.\n\nLGTM!","commit_id":"89b4b88846955d4bf40c15d06648a5ace76b3d22"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0d5d513bbf5d8164da8da4f5862f687adc31345b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65fc528b_6f7515ad","updated":"2025-07-30 05:22:31.000000000","message":"recheck functional sqlite","commit_id":"89b4b88846955d4bf40c15d06648a5ace76b3d22"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ca47e650e8ccdcb01aa632ffba5928c8ac38d275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a8bc5fa_96868954","updated":"2025-07-28 13:21:39.000000000","message":"recheck mysql functional","commit_id":"89b4b88846955d4bf40c15d06648a5ace76b3d22"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8cd998f50ad3b2d9b0399d1feaa607ebb113ecc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f7b0c1d_23d0bc13","updated":"2025-07-28 14:16:04.000000000","message":"recheck neutron-functional","commit_id":"89b4b88846955d4bf40c15d06648a5ace76b3d22"}],"neutron/agent/ovn/extensions/metadata.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89affaa0543fa7577c816f8c3276292febb79092","unresolved":true,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":181,"context_line":"        self._update_chassis_private_config()"},{"line_number":182,"context_line":"        self.agent_api.register_ovn_agent()"},{"line_number":183,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":184,"context_line":"        self.register_metadata_agent()"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b045d35f_052b1b10","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":43},"updated":"2025-07-28 06:58:11.000000000","message":"This should be done at the OVN agent level, not this extension.","commit_id":"f308d35c23f524b195fe26864ba82f2c5e783e72"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a48c557447a89bbedaf4f150e957b5f9252f7dd4","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # Register the agent with its corresponding Chassis"},{"line_number":181,"context_line":"        self._update_chassis_private_config()"},{"line_number":182,"context_line":"        self.agent_api.register_ovn_agent()"},{"line_number":183,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":184,"context_line":"        self.register_metadata_agent()"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a63d1583_d1f13a0b","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":43},"in_reply_to":"b045d35f_052b1b10","updated":"2025-07-28 10:53:30.000000000","message":"Done","commit_id":"f308d35c23f524b195fe26864ba82f2c5e783e72"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89affaa0543fa7577c816f8c3276292febb79092","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        self._update_chassis_private_config()"},{"line_number":182,"context_line":"        self.agent_api.register_ovn_agent()"},{"line_number":183,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":184,"context_line":"        self.register_metadata_agent()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Start the metadata server."},{"line_number":187,"context_line":"        proxy_thread \u003d threading.Thread(target\u003dself._proxy.wait)"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa4da33e_7b339ef1","line":184,"updated":"2025-07-28 06:58:11.000000000","message":"We are already registering the OVN agent in the previous line","commit_id":"f308d35c23f524b195fe26864ba82f2c5e783e72"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a48c557447a89bbedaf4f150e957b5f9252f7dd4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self._update_chassis_private_config()"},{"line_number":182,"context_line":"        self.agent_api.register_ovn_agent()"},{"line_number":183,"context_line":"        self.agent_api.update_neutron_sb_cfg_key()"},{"line_number":184,"context_line":"        self.register_metadata_agent()"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Start the metadata server."},{"line_number":187,"context_line":"        proxy_thread \u003d threading.Thread(target\u003dself._proxy.wait)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3000c219_9a6724b5","line":184,"in_reply_to":"aa4da33e_7b339ef1","updated":"2025-07-28 10:53:30.000000000","message":"Done","commit_id":"f308d35c23f524b195fe26864ba82f2c5e783e72"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89affaa0543fa7577c816f8c3276292febb79092","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        if ovn_sb_cfg:"},{"line_number":389,"context_line":"            return int(ovn_sb_cfg)"},{"line_number":390,"context_line":"        return int("},{"line_number":391,"context_line":"            external_ids.get(ovn_const.OVN_AGENT_METADATA_SB_CFG_KEY, \u0027-1\u0027))"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @staticmethod"},{"line_number":394,"context_line":"    def agent_id(row):"}],"source_content_type":"text/x-python","patch_set":1,"id":"44812da2_f1588df3","line":391,"range":{"start_line":391,"start_character":70,"end_line":391,"end_character":74},"updated":"2025-07-28 06:58:11.000000000","message":"nit: not necessary, we are already converting to int","commit_id":"637e30e12b61ae9dc66d159f8cd47ad050006f9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a48c557447a89bbedaf4f150e957b5f9252f7dd4","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        if ovn_sb_cfg:"},{"line_number":389,"context_line":"            return int(ovn_sb_cfg)"},{"line_number":390,"context_line":"        return int("},{"line_number":391,"context_line":"            external_ids.get(ovn_const.OVN_AGENT_METADATA_SB_CFG_KEY, \u0027-1\u0027))"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    @staticmethod"},{"line_number":394,"context_line":"    def agent_id(row):"}],"source_content_type":"text/x-python","patch_set":1,"id":"06cc8eb7_16a3a48b","line":391,"range":{"start_line":391,"start_character":70,"end_line":391,"end_character":74},"in_reply_to":"44812da2_f1588df3","updated":"2025-07-28 10:53:30.000000000","message":"Done","commit_id":"637e30e12b61ae9dc66d159f8cd47ad050006f9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89affaa0543fa7577c816f8c3276292febb79092","unresolved":true,"context_lines":[{"line_number":418,"context_line":"            row_sb_cfg \u003d self._agent_sb_cfg(row)"},{"line_number":419,"context_line":"            old_sb_cfg \u003d self._agent_sb_cfg(old)"},{"line_number":420,"context_line":"            return row_sb_cfg !\u003d old_sb_cfg"},{"line_number":421,"context_line":"        except (AttributeError, KeyError, ValueError, TypeError):"},{"line_number":422,"context_line":"            return False"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def run(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c0df042_ecab1e25","line":421,"range":{"start_line":421,"start_character":42,"end_line":421,"end_character":63},"updated":"2025-07-28 06:58:11.000000000","message":"I understand `TypeError` that could happen if this is not a dict. When `ValueError` could happen?","commit_id":"637e30e12b61ae9dc66d159f8cd47ad050006f9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a48c557447a89bbedaf4f150e957b5f9252f7dd4","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            row_sb_cfg \u003d self._agent_sb_cfg(row)"},{"line_number":419,"context_line":"            old_sb_cfg \u003d self._agent_sb_cfg(old)"},{"line_number":420,"context_line":"            return row_sb_cfg !\u003d old_sb_cfg"},{"line_number":421,"context_line":"        except (AttributeError, KeyError, ValueError, TypeError):"},{"line_number":422,"context_line":"            return False"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def run(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d57252e0_43acd8d2","line":421,"range":{"start_line":421,"start_character":42,"end_line":421,"end_character":63},"in_reply_to":"0c0df042_ecab1e25","updated":"2025-07-28 10:53:30.000000000","message":"Done","commit_id":"637e30e12b61ae9dc66d159f8cd47ad050006f9a"}]}