)]}'
{"neutron/plugins/ml2/drivers/macvtap/agent/macvtap_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bf35ba8ecb83107428335cce6bb1aad6eb78d66a","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class MacvtapRPCCallBack(sg_rpc.SecurityGroupAgentRpcCallbackMixin,"},{"line_number":46,"context_line":"                         amb.CommonAgentManagerRpcCallBackBase):"},{"line_number":47,"context_line":"    # Set RPC API version to 1.0 by default."},{"line_number":48,"context_line":"    # history"},{"line_number":49,"context_line":"    #   1.1 Support Security Group RPC"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fdc78ea_616fc313","side":"PARENT","line":46,"range":{"start_line":46,"start_character":25,"end_line":46,"end_character":62},"updated":"2025-08-26 09:38:35.000000000","message":"I have some questions about this removal. This is expected to be used in ``CommonAgentLoop._validate_rpc_endpoints`` [1]. This should be failing now because the RPC callbacks do not inherit from CommonAgentManagerRpcCallBackBase. **We need some testing, if possible, of this ``setup_rpc`` method**.\n\nAnother comment, out of scope, is the usage of ``CommonAgentManagerRpcCallBackBase`` and ``CommonAgentLoop``. These classes were implemented to be used by all agents, but at this point only MACvTAP agent is using it.\n\n[1]https://github.com/openstack/neutron/blob/1baf3b462d6c2adc3b8bdd098e0ca9de33575e7d/neutron/plugins/ml2/drivers/agent/_common_agent.py#L174-L177","commit_id":"ca7e4793429f7e394632cfd9f006bfc8a2388798"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f55c95f6971b7d84e2780d8818116916c700816d","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class MacvtapRPCCallBack(sg_rpc.SecurityGroupAgentRpcCallbackMixin,"},{"line_number":46,"context_line":"                         amb.CommonAgentManagerRpcCallBackBase):"},{"line_number":47,"context_line":"    # Set RPC API version to 1.0 by default."},{"line_number":48,"context_line":"    # history"},{"line_number":49,"context_line":"    #   1.1 Support Security Group RPC"}],"source_content_type":"text/x-python","patch_set":1,"id":"a59b63fb_10ca941d","side":"PARENT","line":46,"range":{"start_line":46,"start_character":25,"end_line":46,"end_character":62},"in_reply_to":"5fdc78ea_616fc313","updated":"2025-08-28 07:38:57.000000000","message":"yes, true, I started to setup/fetch an env for macvtap to see how it works.\nFor the 2nd comment exactly it is used only here and in one out of tree driver ( https://codesearch.openstack.org/?q\u003dCommonAgentManagerRpcCallBackBase\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d )","commit_id":"ca7e4793429f7e394632cfd9f006bfc8a2388798"}]}