)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b61c7cbae5d950cca044cbc933ba0ad5b34666e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a92c5cf4_581f0257","updated":"2025-08-29 08:09:57.000000000","message":"good catch, much better really","commit_id":"d75df43bb6d486170045dbc60fce5bf543c66768"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"da9428242e5af4587ba3c3d8ee1b228ff5010fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53f67e3f_8294d335","updated":"2025-09-09 07:52:43.000000000","message":"thanks","commit_id":"4b74594a29ac0d1dcb79ca23fcc5d8c1f72cb1ff"}],"tools/coding-checks.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4e465863caef936cfaad191b11e6dcc0571306d","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    echo \"Running pylint...\""},{"line_number":41,"context_line":"    echo \"You can speed this up by running it on \u0027HEAD~[0-9]\u0027 (e.g. HEAD~1, this change only)...\""},{"line_number":42,"context_line":"    echo \"\""},{"line_number":43,"context_line":"    echo \"Consider using the \u0027pre-commit\u0027 tool instead.\""},{"line_number":44,"context_line":"    echo \"\""},{"line_number":45,"context_line":"    echo \"    pip install --user pre-commit\""},{"line_number":46,"context_line":"    echo \"    pre-commit install --allow-missing-config\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ad8df5e0_9ce7b3de","side":"PARENT","line":43,"updated":"2025-09-03 21:15:15.000000000","message":"I think we can leave the pre-commit message in case someone doesn\u0027t know about it.","commit_id":"f9067a719084710ee4f46fa31edb6a938e0dbbb0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5eabdec630b51a0a0b712d568c074e0a5da5f874","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    echo \"Running pylint...\""},{"line_number":41,"context_line":"    echo \"You can speed this up by running it on \u0027HEAD~[0-9]\u0027 (e.g. HEAD~1, this change only)...\""},{"line_number":42,"context_line":"    echo \"\""},{"line_number":43,"context_line":"    echo \"Consider using the \u0027pre-commit\u0027 tool instead.\""},{"line_number":44,"context_line":"    echo \"\""},{"line_number":45,"context_line":"    echo \"    pip install --user pre-commit\""},{"line_number":46,"context_line":"    echo \"    pre-commit install --allow-missing-config\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"de3f03cd_e2fcf4ad","side":"PARENT","line":43,"in_reply_to":"a1df8320_21941047","updated":"2025-09-08 19:32:27.000000000","message":"Done","commit_id":"f9067a719084710ee4f46fa31edb6a938e0dbbb0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e85e1f054723ae477d5e477526bb8df5e64d6b00","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    echo \"Running pylint...\""},{"line_number":41,"context_line":"    echo \"You can speed this up by running it on \u0027HEAD~[0-9]\u0027 (e.g. HEAD~1, this change only)...\""},{"line_number":42,"context_line":"    echo \"\""},{"line_number":43,"context_line":"    echo \"Consider using the \u0027pre-commit\u0027 tool instead.\""},{"line_number":44,"context_line":"    echo \"\""},{"line_number":45,"context_line":"    echo \"    pip install --user pre-commit\""},{"line_number":46,"context_line":"    echo \"    pre-commit install --allow-missing-config\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"f67f0e4a_42306fa2","side":"PARENT","line":43,"in_reply_to":"ad8df5e0_9ce7b3de","updated":"2025-09-08 18:34:40.000000000","message":"I thought this is now run automatically https://review.opendev.org/c/openstack/neutron/+/958782/1/tox.ini#145\n\nOr do you mean if someone invokes the coding-checks.sh manually outside of the tox -epep8 ?","commit_id":"f9067a719084710ee4f46fa31edb6a938e0dbbb0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2e3cfe8be7200c5aea5097badba05501f162c0ae","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    echo \"Running pylint...\""},{"line_number":41,"context_line":"    echo \"You can speed this up by running it on \u0027HEAD~[0-9]\u0027 (e.g. HEAD~1, this change only)...\""},{"line_number":42,"context_line":"    echo \"\""},{"line_number":43,"context_line":"    echo \"Consider using the \u0027pre-commit\u0027 tool instead.\""},{"line_number":44,"context_line":"    echo \"\""},{"line_number":45,"context_line":"    echo \"    pip install --user pre-commit\""},{"line_number":46,"context_line":"    echo \"    pre-commit install --allow-missing-config\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"a1df8320_21941047","side":"PARENT","line":43,"in_reply_to":"b9ada0ec_88b8ed97","updated":"2025-09-08 19:30:26.000000000","message":"I see what you mean, I misunderstood the L145 I\u0027m referring to, I thought this message was here before we started using pre-commit. Thanks for explanation","commit_id":"f9067a719084710ee4f46fa31edb6a938e0dbbb0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"29fab2ffdb79ba06b642946e30be25996d233bdb","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    echo \"Running pylint...\""},{"line_number":41,"context_line":"    echo \"You can speed this up by running it on \u0027HEAD~[0-9]\u0027 (e.g. HEAD~1, this change only)...\""},{"line_number":42,"context_line":"    echo \"\""},{"line_number":43,"context_line":"    echo \"Consider using the \u0027pre-commit\u0027 tool instead.\""},{"line_number":44,"context_line":"    echo \"\""},{"line_number":45,"context_line":"    echo \"    pip install --user pre-commit\""},{"line_number":46,"context_line":"    echo \"    pre-commit install --allow-missing-config\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"b9ada0ec_88b8ed97","side":"PARENT","line":43,"in_reply_to":"f67f0e4a_42306fa2","updated":"2025-09-08 19:24:32.000000000","message":"On a newly cloned repo, if I make a change and commit, it goes right to the commit message.\n\nIf I then run \u0027pre-commit install --allow-missing-config\u0027, make a change and commit again it runs all the pre-commit checks, then goes to the commit message.\n\nI think this message was a reminder that you don\u0027t need to run \u0027tox -e pep8\u0027 at all if you just install the pre-commit hooks, it will run it and pass/fail accordingly.","commit_id":"f9067a719084710ee4f46fa31edb6a938e0dbbb0"}]}
