)]}'
{"neutron/common/metadata.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1e2d32fcf1180eeacb22a30e056e879c03c7aee4","unresolved":true,"context_lines":[{"line_number":267,"context_line":"            if network_id and router_id:"},{"line_number":268,"context_line":"                title \u003d \u0027400 Bad Request\u0027"},{"line_number":269,"context_line":"                msg \u003d _(\u0027Both network %s and router %s \u0027"},{"line_number":270,"context_line":"                        \u0027defined.\u0027) % (network_id, router_id)"},{"line_number":271,"context_line":"            elif network_id:"},{"line_number":272,"context_line":"                title \u003d \u0027404 Not Found\u0027"},{"line_number":273,"context_line":"                msg \u003d _(\u0027Instance was not found on network %s.\u0027) % network_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"06bb573e_ec93bb0d","line":270,"updated":"2025-09-05 14:46:40.000000000","message":"I just noticed there is no LOG.warning(msg) here as in the others, there wasn\u0027t in the original either. Did we just miss it or do we only need to set it to pass to encode_http_response() ?","commit_id":"9ef882034a3cbf9fb724e3a6b7fb97fdb1bd47ec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"94cda8d101a88dc7fc8bdddfd9ef1d5adb98de15","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            if network_id and router_id:"},{"line_number":268,"context_line":"                title \u003d \u0027400 Bad Request\u0027"},{"line_number":269,"context_line":"                msg \u003d _(\u0027Both network %s and router %s \u0027"},{"line_number":270,"context_line":"                        \u0027defined.\u0027) % (network_id, router_id)"},{"line_number":271,"context_line":"            elif network_id:"},{"line_number":272,"context_line":"                title \u003d \u0027404 Not Found\u0027"},{"line_number":273,"context_line":"                msg \u003d _(\u0027Instance was not found on network %s.\u0027) % network_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"51549f4d_7336a54e","line":270,"in_reply_to":"06bb573e_ec93bb0d","updated":"2025-09-08 07:29:16.000000000","message":"Actually this is missing from the original patch [1]. However, in the original patch that was a debug log message [2]. I would use warning instead, same as when we return 404.\n\n[1]https://review.opendev.org/q/Id6c103b7bcebe441c27c6049d349d84ba7fd15a6\n[2]https://review.opendev.org/c/openstack/neutron/+/710458/4/neutron/agent/metadata/agent.py#161","commit_id":"9ef882034a3cbf9fb724e3a6b7fb97fdb1bd47ec"}]}
