)]}'
{"neutron/tests/functional/agent/linux/test_utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d49f408087869d77bcc790036cdd192efc1ed3fa","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from oslo_log import log as logging"},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TestPIDHelpers(test_async_process.AsyncProcessTestFramework):"}],"source_content_type":"text/x-python","patch_set":3,"id":"8be5db01_f61fa23b","line":33,"updated":"2025-11-05 12:49:13.000000000","message":"Seems unused","commit_id":"47a63fb994a1b82221270f302c70b3923a0ae01e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6b7ec2f67d7f654b9a9327e1a709d94c465dbb3","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from oslo_log import log as logging"},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TestPIDHelpers(test_async_process.AsyncProcessTestFramework):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7c1c4e9b_eff0dde9","line":33,"in_reply_to":"8be5db01_f61fa23b","updated":"2025-11-05 13:46:22.000000000","message":"My bad, I used that for debugging","commit_id":"47a63fb994a1b82221270f302c70b3923a0ae01e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d49f408087869d77bcc790036cdd192efc1ed3fa","unresolved":true,"context_lines":[{"line_number":184,"context_line":"        common_utils.wait_until_true(lambda: process._process.pid,"},{"line_number":185,"context_line":"                                     sleep\u003d0.5, timeout\u003d10)"},{"line_number":186,"context_line":"        self.addCleanup(self._stop_process, process)"},{"line_number":187,"context_line":"        _check \u003d functools.partial(self._check_child_pids, pid)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_find_non_existing_process(self):"},{"line_number":190,"context_line":"        with open(\u0027/proc/sys/kernel/pid_max\u0027) as fd:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f6009568_482ae5b2","line":187,"updated":"2025-11-05 12:49:13.000000000","message":"Is there a missing wait here?\n\ncommon_utils.wait_until_true(_check, timeout\u003d10)\n\nAnd do we need to re-assign _check? The value of pid has not changed.","commit_id":"47a63fb994a1b82221270f302c70b3923a0ae01e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6b7ec2f67d7f654b9a9327e1a709d94c465dbb3","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        common_utils.wait_until_true(lambda: process._process.pid,"},{"line_number":185,"context_line":"                                     sleep\u003d0.5, timeout\u003d10)"},{"line_number":186,"context_line":"        self.addCleanup(self._stop_process, process)"},{"line_number":187,"context_line":"        _check \u003d functools.partial(self._check_child_pids, pid)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_find_non_existing_process(self):"},{"line_number":190,"context_line":"        with open(\u0027/proc/sys/kernel/pid_max\u0027) as fd:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce66cfbd_6c4f548c","line":187,"in_reply_to":"f6009568_482ae5b2","updated":"2025-11-05 13:46:22.000000000","message":"Pffff of course there is a missing one.\n\nWe need to reassign it because the second time we need to pass the process ID (base PS, L173)","commit_id":"47a63fb994a1b82221270f302c70b3923a0ae01e"}]}