)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b81a15b9d2a8e3d07500e0ec6623995a6aa0899a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- The contrail_plugin_core.py is the main interface for neutron common"},{"line_number":13,"context_line":"  infrastructure. It relays API requests to the opencontrail controller"},{"line_number":14,"context_line":"- This commit also includes minor fixes for unit testing"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note: The previous review https://review.openstack.org/#/c/43793/"},{"line_number":17,"context_line":"      has been abandoned as the owner is on a long leave"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1ae5cdf2_3a0fb63a","line":14,"updated":"2014-06-18 22:35:03.000000000","message":"Could you describe why changes for neutron/tests/unit/test_db_plugin.py needed?","commit_id":"fc71a70dd7e654515693b00e8f42e92105484381"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Opencontrail plug-in implementation for core resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds Opencontrail plug-in implementation with unit tests"},{"line_number":10,"context_line":"This patch has no dependency on any other blueprints"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- The contrail_plugin_core.py is the main interface for neutron common"},{"line_number":13,"context_line":"  infrastructure. It relays API requests to the opencontrail controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"baada198_4ae9f1e1","line":10,"updated":"2014-07-25 17:54:00.000000000","message":"Please, remove this line and indicate the patch for the vRouter VIF driver\nOnce, you have the devstack patch, you should also include it here","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Opencontrail plug-in implementation for core resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds Opencontrail plug-in implementation with unit tests"},{"line_number":10,"context_line":"This patch has no dependency on any other blueprints"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- The contrail_plugin_core.py is the main interface for neutron common"},{"line_number":13,"context_line":"  infrastructure. It relays API requests to the opencontrail controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"baada198_53bb6574","line":10,"in_reply_to":"baada198_4ae9f1e1","updated":"2014-07-25 21:47:37.000000000","message":"Our VIF driver is provided through the contrail-nova-driver package.  I will update the commit message to point to the VIF driver installation link. It is configured in nova.conf. We will include devstack instructions once we have upstreamed the devstack patch.","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  infrastructure. It relays API requests to the opencontrail controller"},{"line_number":14,"context_line":"- This commit also includes a minor fix for unit testing"},{"line_number":15,"context_line":"  in test_db_plugin.py line 2420 where there was a missing return."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: The previous review https://review.openstack.org/#/c/43793/"},{"line_number":18,"context_line":"      has been abandoned as the owner is on a long leave"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"baada198_6ad23535","line":16,"updated":"2014-07-25 17:54:00.000000000","message":"Include DocImpact","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  infrastructure. It relays API requests to the opencontrail controller"},{"line_number":14,"context_line":"- This commit also includes a minor fix for unit testing"},{"line_number":15,"context_line":"  in test_db_plugin.py line 2420 where there was a missing return."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Note: The previous review https://review.openstack.org/#/c/43793/"},{"line_number":18,"context_line":"      has been abandoned as the owner is on a long leave"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"baada198_b6f3cf07","line":16,"in_reply_to":"baada198_6ad23535","updated":"2014-07-25 21:47:37.000000000","message":"Can you please elaborate on it. Also is there an example you can point me to.","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"a5e4e609c3f41acb3b86f6b9d69ad071ed25257c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The link below describes how to install VIF driver for opencontrail"},{"line_number":12,"context_line":"https://github.com/Juniper/contrail-controller/wiki/"},{"line_number":13,"context_line":"OpenContrail-bring-up-and-provisioning"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- The contrail_plugin_core.py is the main interface for neutron common"},{"line_number":16,"context_line":"  infrastructure. It relays API requests to the opencontrail controller"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"7ac7a964_efa16caa","line":14,"updated":"2014-08-14 22:56:02.000000000","message":"I forgot to mention this before.. DocImpact is needed here!","commit_id":"b04df955890145998604ab7e1d7759e7bb57449b"}],"etc/neutron/plugins/opencontrail/contrailplugin.ini":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"73e713cda698fafaea2e44a68ff2f83aafe1d2b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1ae5cdf2_c8bf62cf","line":4,"updated":"2014-05-30 20:34:41.000000000","message":"Is this configuration file required if its going to be empty?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d5499e0af0c460973b7c3b6477057c0af0e6cdf3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1ae5cdf2_34d9f857","line":4,"in_reply_to":"1ae5cdf2_914bbe2a","updated":"2014-05-30 23:44:58.000000000","message":"could you add sample configuration with comment out here?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1ae5cdf2_914bbe2a","line":4,"in_reply_to":"1ae5cdf2_c8bf62cf","updated":"2014-05-30 23:17:30.000000000","message":"its a placeholder for configuration. we will need it when we add extensions","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4b9f994a97a76b9f9ccd5b352d6ad8fa0bec71d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1ae5cdf2_a0e3d403","line":4,"updated":"2014-06-02 18:20:28.000000000","message":"I think there should be examples specified here, and not just an empty section header.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# JunosVContrail specifc configuration for plugin"},{"line_number":4,"context_line":"[JunosVContrail]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1ae5cdf2_6b5fed72","line":4,"in_reply_to":"1ae5cdf2_a0e3d403","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"32b8f6cc0b603988c6b0d241e59371c9dd5464d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# max_retries\u003d-1"},{"line_number":14,"context_line":"# Retry Interval in seconds to connect to VNC Server\u0027),"},{"line_number":15,"context_line":"# retry_interval\u003d3"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"1ae5cdf2_69ccf989","line":16,"updated":"2014-06-04 23:04:47.000000000","message":"This blank line isn\u0027t needed","commit_id":"dc67db73b709e646ed7ed4d0b7d4c65ebe1cd8f1"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"},{"line_number":8,"context_line":"# Enable multi-tenancy support"},{"line_number":9,"context_line":"# multi_tenancy\u003dFalse"},{"line_number":10,"context_line":"# Enable Contrail extensions"},{"line_number":11,"context_line":"# contrail_extensions\u003dneutron.plugins.juniper.contrail.contrail_plugin_policy.NeutronPluginContrailPolicy"},{"line_number":12,"context_line":"# Maximum retries to VNC Server(-1 for no limit)\u0027),"}],"source_content_type":"text/x-properties","patch_set":13,"id":"1ae5cdf2_f0478175","line":9,"updated":"2014-06-10 02:48:10.000000000","message":"as a cloud platform, why use false as default value of multi_tenancy?","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"},{"line_number":8,"context_line":"# Enable multi-tenancy support"},{"line_number":9,"context_line":"# multi_tenancy\u003dFalse"},{"line_number":10,"context_line":"# Enable Contrail extensions"},{"line_number":11,"context_line":"# contrail_extensions\u003dneutron.plugins.juniper.contrail.contrail_plugin_policy.NeutronPluginContrailPolicy"},{"line_number":12,"context_line":"# Maximum retries to VNC Server(-1 for no limit)\u0027),"}],"source_content_type":"text/x-properties","patch_set":13,"id":"1ae5cdf2_2b74179b","line":9,"in_reply_to":"1ae5cdf2_f0478175","updated":"2014-06-11 04:37:42.000000000","message":"Done","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Enable multi-tenancy support"},{"line_number":9,"context_line":"# multi_tenancy\u003dFalse"},{"line_number":10,"context_line":"# Enable Contrail extensions"},{"line_number":11,"context_line":"# contrail_extensions\u003dneutron.plugins.juniper.contrail.contrail_plugin_policy.NeutronPluginContrailPolicy"},{"line_number":12,"context_line":"# Maximum retries to VNC Server(-1 for no limit)\u0027),"},{"line_number":13,"context_line":"# max_retries\u003d-1"},{"line_number":14,"context_line":"# Retry Interval in seconds to connect to VNC Server\u0027),"}],"source_content_type":"text/x-properties","patch_set":13,"id":"1ae5cdf2_06dd9770","line":11,"updated":"2014-06-10 02:48:10.000000000","message":"I cannot find neutron.plugins.juniper.contrail.contrail_plugin_policy.NeutronPluginContrailP\nolicy at all","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Enable multi-tenancy support"},{"line_number":9,"context_line":"# multi_tenancy\u003dFalse"},{"line_number":10,"context_line":"# Enable Contrail extensions"},{"line_number":11,"context_line":"# contrail_extensions\u003dneutron.plugins.juniper.contrail.contrail_plugin_policy.NeutronPluginContrailPolicy"},{"line_number":12,"context_line":"# Maximum retries to VNC Server(-1 for no limit)\u0027),"},{"line_number":13,"context_line":"# max_retries\u003d-1"},{"line_number":14,"context_line":"# Retry Interval in seconds to connect to VNC Server\u0027),"}],"source_content_type":"text/x-properties","patch_set":13,"id":"1ae5cdf2_eb614fd4","line":11,"in_reply_to":"1ae5cdf2_06dd9770","updated":"2014-06-11 04:37:42.000000000","message":"I will remove it, This extension is not yet supported and it will be in the future in an upcoming review.","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[JunosVContrail]"},{"line_number":4,"context_line":"# IP address to connect to VNC controller"},{"line_number":5,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"}],"source_content_type":"text/x-properties","patch_set":14,"id":"1ae5cdf2_31cc5889","line":4,"updated":"2014-06-11 05:50:46.000000000","message":"These config options need to be specified this way.\n\n#(StrOpt) IP address to connect to VNC controller\n# e.g.: api_server_ip\u003d\u0027127.0.0.1\u0027\n#\n# api_server_ip \u003d \n\nThis applies for all the below config options.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"e8e3aa28e5ac25f9027c46b5fc7a0fb54cda193a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[JunosVContrail]"},{"line_number":4,"context_line":"# IP address to connect to VNC controller"},{"line_number":5,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"}],"source_content_type":"text/x-properties","patch_set":14,"id":"1ae5cdf2_ac8e0a77","line":4,"in_reply_to":"1ae5cdf2_04a7f850","updated":"2014-06-12 21:15:41.000000000","message":"I like what you suggest. But for now I will keep it this way as it is same as other config files format","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[JunosVContrail]"},{"line_number":4,"context_line":"# IP address to connect to VNC controller"},{"line_number":5,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"}],"source_content_type":"text/x-properties","patch_set":14,"id":"1ae5cdf2_8cc18131","line":4,"in_reply_to":"1ae5cdf2_31cc5889","updated":"2014-06-11 19:05:39.000000000","message":"I would like to keep it this way. Its just a comment and as long as it is meaningful, it should be ok.\n\nHere is an example from neutron.conf. \n\n# Address to bind the API server to\n# bind_host \u003d 0.0.0.0","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"3cd92d01f4dd7a326642bc2c5de6584bb70e718c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[JunosVContrail]"},{"line_number":4,"context_line":"# IP address to connect to VNC controller"},{"line_number":5,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"}],"source_content_type":"text/x-properties","patch_set":14,"id":"1ae5cdf2_04a7f850","line":4,"in_reply_to":"1ae5cdf2_8cc18131","updated":"2014-06-12 01:47:09.000000000","message":"we received complains from some packagers that this kind of specification of sample values in some cases might make more complex the creation of default \"sample\" config files.\n\n#(StrOpt) IP address to connect to VNC controller \n# e.g.: api_server_ip\u003d\u0027127.0.0.1\u0027 \n# \n# api_server_ip \u003d","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"052a34dab1513083b24d719a0fd21a94ee136701","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[JunosVContrail]"},{"line_number":4,"context_line":"# IP address to connect to VNC controller"},{"line_number":5,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"}],"source_content_type":"text/x-properties","patch_set":15,"id":"1ae5cdf2_b38487d3","line":4,"updated":"2014-06-13 19:07:54.000000000","message":"Example .ini files usually have more meat in them. For instance, look at the OVS plugin here:\n\nhttps://github.com/openstack/neutron/blob/master/etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini","commit_id":"4370df71eb1ea14ffde1c792758ee877f6170c24"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"52c32af917f8af7e6b6f35ab976b3e5107212a4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Juniper plugin specific configuration"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[JunosVContrail]"},{"line_number":4,"context_line":"# IP address to connect to VNC controller"},{"line_number":5,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"# Port to connect to VNC controller"},{"line_number":7,"context_line":"# api_server_port\u003d\u00278082\u0027"}],"source_content_type":"text/x-properties","patch_set":15,"id":"1ae5cdf2_86810bc5","line":4,"in_reply_to":"1ae5cdf2_b38487d3","updated":"2014-06-13 19:40:47.000000000","message":"ok, let me fix it.","commit_id":"4370df71eb1ea14ffde1c792758ee877f6170c24"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# For more information visit: http://opencontrail.org"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Opencontrail plugin specific configuration"},{"line_number":8,"context_line":"[APISERVER]"},{"line_number":9,"context_line":"# (StrOpt) IP address to connect to opencontrail controller."},{"line_number":10,"context_line":"# Uncomment this line for the specifying the IP address of the opencontrail"},{"line_number":11,"context_line":"# Api-Server."}],"source_content_type":"text/x-properties","patch_set":20,"id":"1ae5cdf2_8b3f07b5","line":8,"updated":"2014-06-17 03:13:50.000000000","message":"Can we call this section [CONTRAIL]?  That way a consolidate config file is more readable to deployers.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0ccae8d0797c401c675460a3fec501f767c42886","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# For more information visit: http://opencontrail.org"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Opencontrail plugin specific configuration"},{"line_number":8,"context_line":"[APISERVER]"},{"line_number":9,"context_line":"# (StrOpt) IP address to connect to opencontrail controller."},{"line_number":10,"context_line":"# Uncomment this line for the specifying the IP address of the opencontrail"},{"line_number":11,"context_line":"# Api-Server."}],"source_content_type":"text/x-properties","patch_set":20,"id":"1ae5cdf2_ee8df42b","line":8,"in_reply_to":"1ae5cdf2_8b3f07b5","updated":"2014-06-17 07:37:30.000000000","message":"totally agreed.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# For more information visit: http://opencontrail.org"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Opencontrail plugin specific configuration"},{"line_number":8,"context_line":"[APISERVER]"},{"line_number":9,"context_line":"# (StrOpt) IP address to connect to opencontrail controller."},{"line_number":10,"context_line":"# Uncomment this line for the specifying the IP address of the opencontrail"},{"line_number":11,"context_line":"# Api-Server."}],"source_content_type":"text/x-properties","patch_set":20,"id":"1ae5cdf2_35571b28","line":8,"in_reply_to":"1ae5cdf2_ee8df42b","updated":"2014-06-17 22:40:45.000000000","message":"Will change it to CONTRAIL.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# these extensions can be configured as shown below. Plugin will then"},{"line_number":24,"context_line":"# load the specified extensions."},{"line_number":25,"context_line":"# Default value is None, it wont load any extension"},{"line_number":26,"context_line":"# contrail_extensions\u003d"}],"source_content_type":"text/x-properties","patch_set":24,"id":"baada198_ea23a5bb","line":26,"updated":"2014-07-25 17:54:00.000000000","message":"Include a realistic example:\ncontrail_extensions\u003dipam:\u003cclasspath\u003e,policy:\u003cclasspath","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# these extensions can be configured as shown below. Plugin will then"},{"line_number":24,"context_line":"# load the specified extensions."},{"line_number":25,"context_line":"# Default value is None, it wont load any extension"},{"line_number":26,"context_line":"# contrail_extensions\u003d"}],"source_content_type":"text/x-properties","patch_set":24,"id":"baada198_4050ed2b","line":26,"in_reply_to":"baada198_ea23a5bb","updated":"2014-07-25 21:47:37.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Opencontrail plugin specific configuration"},{"line_number":8,"context_line":"[CONTRAIL]"},{"line_number":9,"context_line":"# (StrOpt) IP address to connect to opencontrail controller."},{"line_number":10,"context_line":"# Uncomment this line for the specifying the IP address of the opencontrail"},{"line_number":11,"context_line":"# Api-Server."},{"line_number":12,"context_line":"# Default value is local host(127.0.0.1)."},{"line_number":13,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"}],"source_content_type":"text/x-properties","patch_set":28,"id":"baada198_d10af4cf","line":10,"updated":"2014-08-04 10:44:02.000000000","message":"I can\u0027t speak or write in proper english but perhaps \"the\" should be removed in the line above","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Opencontrail plugin specific configuration"},{"line_number":8,"context_line":"[CONTRAIL]"},{"line_number":9,"context_line":"# (StrOpt) IP address to connect to opencontrail controller."},{"line_number":10,"context_line":"# Uncomment this line for the specifying the IP address of the opencontrail"},{"line_number":11,"context_line":"# Api-Server."},{"line_number":12,"context_line":"# Default value is local host(127.0.0.1)."},{"line_number":13,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"}],"source_content_type":"text/x-properties","patch_set":28,"id":"baada198_b8871c11","line":10,"in_reply_to":"baada198_d10af4cf","updated":"2014-08-04 21:51:10.000000000","message":"Done","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Default value is local host(127.0.0.1)."},{"line_number":13,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# (StrOpt) port to connect to opencontrail controller."},{"line_number":16,"context_line":"# Uncomment this line for the specifying the Port of the opencontrail"},{"line_number":17,"context_line":"# Api-Server."},{"line_number":18,"context_line":"# Default value is 8082"}],"source_content_type":"text/x-properties","patch_set":28,"id":"baada198_31f330e8","line":15,"updated":"2014-08-04 10:44:02.000000000","message":"Any particular reason for which a port number should be a string?","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Default value is local host(127.0.0.1)."},{"line_number":13,"context_line":"# api_server_ip\u003d\u0027127.0.0.1\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# (StrOpt) port to connect to opencontrail controller."},{"line_number":16,"context_line":"# Uncomment this line for the specifying the Port of the opencontrail"},{"line_number":17,"context_line":"# Api-Server."},{"line_number":18,"context_line":"# Default value is 8082"}],"source_content_type":"text/x-properties","patch_set":28,"id":"baada198_1881e8f9","line":15,"in_reply_to":"baada198_31f330e8","updated":"2014-08-04 21:51:10.000000000","message":"I will change it to IntOpt","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"}],"neutron/plugins/opencontrail/contrail_plugin.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":20,"context_line":"from neutron.common import exceptions as exc"},{"line_number":21,"context_line":"from neutron.db import portbindings_base"},{"line_number":22,"context_line":"from neutron.db import quota_db  # noqa"},{"line_number":23,"context_line":"from neutron.extensions import external_net"},{"line_number":24,"context_line":"from neutron.extensions import portbindings"},{"line_number":25,"context_line":"from neutron.extensions import securitygroup"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_2b074a82","line":22,"updated":"2014-08-04 05:40:01.000000000","message":"This is only needed if the plugin uses the DB layer which si not the case of this one. In that case remove this import.","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":20,"context_line":"from neutron.common import exceptions as exc"},{"line_number":21,"context_line":"from neutron.db import portbindings_base"},{"line_number":22,"context_line":"from neutron.db import quota_db  # noqa"},{"line_number":23,"context_line":"from neutron.extensions import external_net"},{"line_number":24,"context_line":"from neutron.extensions import portbindings"},{"line_number":25,"context_line":"from neutron.extensions import securitygroup"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_0660bb33","line":22,"in_reply_to":"baada198_2b074a82","updated":"2014-08-04 07:00:35.000000000","message":"Done","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return binding"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":83,"context_line":"        # This method is implemented so that horizon is happy"},{"line_number":84,"context_line":"        return []"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _request_api_server(self, url, data\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_6b406206","line":83,"updated":"2014-08-04 05:40:01.000000000","message":"I would ask for a better explanation that just saying that you want to make Horizon happy. If there is a bug in Horizon you should report it and add it here.","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        return binding"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":83,"context_line":"        # This method is implemented so that horizon is happy"},{"line_number":84,"context_line":"        return []"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _request_api_server(self, url, data\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_46cd532f","line":83,"in_reply_to":"baada198_6b406206","updated":"2014-08-04 07:00:35.000000000","message":"This horizon bug is fixed now. https://bugs.launchpad.net/horizon/+bug/1331032\nI will remove the code.","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            url, data\u003ddata, headers\u003d{\u0027Content-type\u0027: \u0027application/json\u0027})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _request_backend(self, context, data_dict, obj_name, action):"},{"line_number":100,"context_line":"        context_dict \u003d self._encode_context(context, action, obj_name)"},{"line_number":101,"context_line":"        data \u003d json.dumps({\u0027context\u0027: context_dict, \u0027data\u0027: data_dict})"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        url_path \u003d \"%s/%s\" % (self.PLUGIN_URL_PREFIX, obj_name)"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_8bc3f688","line":100,"updated":"2014-08-04 05:40:01.000000000","message":"Some of the functions in this file have \"docstring\" but not all of the, please add the ones missing.","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            url, data\u003ddata, headers\u003d{\u0027Content-type\u0027: \u0027application/json\u0027})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _request_backend(self, context, data_dict, obj_name, action):"},{"line_number":100,"context_line":"        context_dict \u003d self._encode_context(context, action, obj_name)"},{"line_number":101,"context_line":"        data \u003d json.dumps({\u0027context\u0027: context_dict, \u0027data\u0027: data_dict})"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        url_path \u003d \"%s/%s\" % (self.PLUGIN_URL_PREFIX, obj_name)"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_a10d3937","line":100,"in_reply_to":"baada198_8bc3f688","updated":"2014-08-04 07:00:35.000000000","message":"Done","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _count_resource(self, res_type, context, filters):"},{"line_number":239,"context_line":"        res_dict \u003d self._encode_resource(filters\u003dfilters)"},{"line_number":240,"context_line":"        status_code, res_count \u003d self._request_backend(context, res_dict,"},{"line_number":241,"context_line":"                                                       res_type, \u0027READCOUNT\u0027)"},{"line_number":242,"context_line":"        LOG.debug(\"get_%(res_type)s_count(): %(res_count)r\","},{"line_number":243,"context_line":"                  {\u0027res_type\u0027: res_type, \u0027res_count\u0027: res_count})"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_6b5782c9","line":240,"updated":"2014-08-04 05:40:01.000000000","message":"Unused variable \u0027status_code\u0027","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _count_resource(self, res_type, context, filters):"},{"line_number":239,"context_line":"        res_dict \u003d self._encode_resource(filters\u003dfilters)"},{"line_number":240,"context_line":"        status_code, res_count \u003d self._request_backend(context, res_dict,"},{"line_number":241,"context_line":"                                                       res_type, \u0027READCOUNT\u0027)"},{"line_number":242,"context_line":"        LOG.debug(\"get_%(res_type)s_count(): %(res_count)r\","},{"line_number":243,"context_line":"                  {\u0027res_type\u0027: res_type, \u0027res_count\u0027: res_count})"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_c1b94d17","line":240,"in_reply_to":"baada198_6b5782c9","updated":"2014-08-04 07:00:35.000000000","message":"Done","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        port \u003d self._get_resource(\u0027port\u0027, context, id, fields)"},{"line_number":362,"context_line":"        return self._make_port_dict(port, fields)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _update_ips_for_port(self, context, network_id, port_id, original_ips,"},{"line_number":365,"context_line":"                             new_ips):"},{"line_number":366,"context_line":"        \"\"\"Add or remove IPs from the port.\"\"\""},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_2bd66a27","line":364,"updated":"2014-08-04 05:40:01.000000000","message":"context, network_id and port_id are not bring used here, please remove them","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        port \u003d self._get_resource(\u0027port\u0027, context, id, fields)"},{"line_number":362,"context_line":"        return self._make_port_dict(port, fields)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _update_ips_for_port(self, context, network_id, port_id, original_ips,"},{"line_number":365,"context_line":"                             new_ips):"},{"line_number":366,"context_line":"        \"\"\"Add or remove IPs from the port.\"\"\""},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_41545dc5","line":364,"in_reply_to":"baada198_2bd66a27","updated":"2014-08-04 07:00:35.000000000","message":"Done","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":35,"context_line":"               help\u003d\u0027IP address to connect to opencontrail controller\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Port to connect to opencontrail controller\u0027),"},{"line_number":38,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":39,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_f197f836","line":37,"updated":"2014-08-04 10:44:02.000000000","message":"already commented elsewhere: Is there a reason for not using intopt?","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":35,"context_line":"               help\u003d\u0027IP address to connect to opencontrail controller\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Port to connect to opencontrail controller\u0027),"},{"line_number":38,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":39,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_d87690a2","line":37,"in_reply_to":"baada198_f197f836","updated":"2014-08-04 21:51:10.000000000","message":"Yeah we can use IntOpt, Will use that","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Port to connect to opencontrail controller\u0027),"},{"line_number":38,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":39,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"cfg.CONF.register_opts(opencontrail_opts, \u0027CONTRAIL\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_b1b820c8","line":39,"updated":"2014-08-04 10:44:02.000000000","message":"I would prefer that options for \"future use\" are not added until they\u0027re actually used. Unless this is, for some, reason, a necessary placeholder.\n\nIn which case, I would kindly ask an explanation for it.","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Port to connect to opencontrail controller\u0027),"},{"line_number":38,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":39,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"cfg.CONF.register_opts(opencontrail_opts, \u0027CONTRAIL\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_98589826","line":39,"in_reply_to":"baada198_b1b820c8","updated":"2014-08-04 21:51:10.000000000","message":"I will remove them.","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        context_dict \u003d self._encode_context(context, action, obj_name)"},{"line_number":104,"context_line":"        data \u003d json.dumps({\u0027context\u0027: context_dict, \u0027data\u0027: data_dict})"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        url_path \u003d \"%s/%s\" % (self.PLUGIN_URL_PREFIX, obj_name)"},{"line_number":107,"context_line":"        response \u003d self._relay_request(url_path, data\u003ddata)"},{"line_number":108,"context_line":"        if response.content:"},{"line_number":109,"context_line":"            return response.status_code, response.json()"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_d1559452","line":106,"updated":"2014-08-04 10:44:02.000000000","message":"clever.","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        context_dict \u003d self._encode_context(context, action, obj_name)"},{"line_number":104,"context_line":"        data \u003d json.dumps({\u0027context\u0027: context_dict, \u0027data\u0027: data_dict})"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        url_path \u003d \"%s/%s\" % (self.PLUGIN_URL_PREFIX, obj_name)"},{"line_number":107,"context_line":"        response \u003d self._relay_request(url_path, data\u003ddata)"},{"line_number":108,"context_line":"        if response.content:"},{"line_number":109,"context_line":"            return response.status_code, response.json()"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_b8cf1cb2","line":106,"in_reply_to":"baada198_d1559452","updated":"2014-08-04 21:51:10.000000000","message":"thanks","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def _extend_port_dict_security_group(self, port_res, port_db):"},{"line_number":370,"context_line":"        # Security group bindings will be retrieved from the sqlalchemy"},{"line_number":371,"context_line":"        # model. As they\u0027re loaded eagerly with ports because of the"},{"line_number":372,"context_line":"        # joined load they will not cause an extra query."},{"line_number":373,"context_line":"        port_res[securitygroup.SECURITYGROUPS] \u003d port_db.get("},{"line_number":374,"context_line":"            \u0027security_groups\u0027, []) or []"},{"line_number":375,"context_line":"        return port_res"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_11af0c2c","line":372,"updated":"2014-08-04 10:44:02.000000000","message":"I think this method is somehow \"vestigial\"...","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def _extend_port_dict_security_group(self, port_res, port_db):"},{"line_number":370,"context_line":"        # Security group bindings will be retrieved from the sqlalchemy"},{"line_number":371,"context_line":"        # model. As they\u0027re loaded eagerly with ports because of the"},{"line_number":372,"context_line":"        # joined load they will not cause an extra query."},{"line_number":373,"context_line":"        port_res[securitygroup.SECURITYGROUPS] \u003d port_db.get("},{"line_number":374,"context_line":"            \u0027security_groups\u0027, []) or []"},{"line_number":375,"context_line":"        return port_res"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_533b41c7","line":372,"in_reply_to":"baada198_11af0c2c","updated":"2014-08-04 21:51:10.000000000","message":"you are right.","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bba5d6e3c0ba10500358fa27428aac7ff84fe515","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        return res_dicts"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _get_resource(self, res_type, context, id, fields):"},{"line_number":192,"context_line":"        \"\"\"Get a resource from API server."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        This method gets a resource from the contrail api server"}],"source_content_type":"text/x-python","patch_set":29,"id":"baada198_bf770607","line":191,"updated":"2014-08-11 23:36:30.000000000","message":"can you avoid shadowing python built-in \"id\" throughout this module?","commit_id":"cfb51fb89b87cfb1890f2d7b3c12efb9512d93e1"},{"author":{"_account_id":8306,"name":"Rudra Rugge","email":"rrugge@juniper.net","username":"rudrarugge"},"change_message_id":"cf55ee540d75f1131f061c0626440ae45b262720","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        return res_dicts"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def _get_resource(self, res_type, context, id, fields):"},{"line_number":192,"context_line":"        \"\"\"Get a resource from API server."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        This method gets a resource from the contrail api server"}],"source_content_type":"text/x-python","patch_set":29,"id":"baada198_526c1833","line":191,"in_reply_to":"baada198_bf770607","updated":"2014-08-12 04:57:21.000000000","message":"Done","commit_id":"cfb51fb89b87cfb1890f2d7b3c12efb9512d93e1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bba5d6e3c0ba10500358fa27428aac7ff84fe515","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                                     network)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def delete_network(self, context, network_id):"},{"line_number":286,"context_line":"        \"\"\"Creates a new Virtual Network."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        Deletes the network with the specified network identifier"},{"line_number":289,"context_line":"        belonging to the specified tenant."}],"source_content_type":"text/x-python","patch_set":29,"id":"baada198_1f81d2c1","line":286,"updated":"2014-08-11 23:36:30.000000000","message":"this docstring seems wrong.","commit_id":"cfb51fb89b87cfb1890f2d7b3c12efb9512d93e1"},{"author":{"_account_id":8306,"name":"Rudra Rugge","email":"rrugge@juniper.net","username":"rudrarugge"},"change_message_id":"cf55ee540d75f1131f061c0626440ae45b262720","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                                     network)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def delete_network(self, context, network_id):"},{"line_number":286,"context_line":"        \"\"\"Creates a new Virtual Network."},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        Deletes the network with the specified network identifier"},{"line_number":289,"context_line":"        belonging to the specified tenant."}],"source_content_type":"text/x-python","patch_set":29,"id":"baada198_d2b3c896","line":286,"in_reply_to":"baada198_1f81d2c1","updated":"2014-08-12 04:57:21.000000000","message":"Done","commit_id":"cfb51fb89b87cfb1890f2d7b3c12efb9512d93e1"}],"neutron/plugins/opencontrail/contrail_plugin_core.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d508fc2f","line":1,"updated":"2014-05-30 00:16:35.000000000","message":"Now this line ins\u0027t needed","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2014 Juniper Networks.  All rights reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_61e589a7","line":1,"in_reply_to":"1ae5cdf2_d508fc2f","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"vnc_opts \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027VNC IP address to connect to\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027VNC port to connect to\u0027),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_fc85d3ad","line":40,"updated":"2014-05-30 13:10:47.000000000","message":"to connect to contrail? VNC server?\n\nThis and next one end in preposition. Try to clarify.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"vnc_opts \u003d ["},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027VNC IP address to connect to\u0027),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027VNC port to connect to\u0027),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e1b6f989","line":40,"in_reply_to":"1ae5cdf2_fc85d3ad","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027VNC port to connect to\u0027),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Multi Tenancy support\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Contrail extensions support\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3c901bec","line":44,"updated":"2014-05-30 13:10:47.000000000","message":"Enable multi-tenancy support?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027VNC port to connect to\u0027),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Multi Tenancy support\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Contrail extensions support\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_01bcc568","line":44,"in_reply_to":"1ae5cdf2_3c901bec","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Multi Tenancy support\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Contrail extensions support\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":48,"context_line":"               help\u003d\u0027Maximum retries to connect to VNC Server\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_bc726be3","line":46,"updated":"2014-05-30 13:10:47.000000000","message":"Help message isn\u0027t clear to me as to what this option means. Clarify.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Multi Tenancy support\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Contrail extensions support\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":48,"context_line":"               help\u003d\u0027Maximum retries to connect to VNC Server\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_21b0e18a","line":46,"in_reply_to":"1ae5cdf2_bc726be3","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Contrail extensions support\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":48,"context_line":"               help\u003d\u0027Maximum retries to connect to VNC Server\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":50,"context_line":"               help\u003d\u0027Retry Interval to connect to VNC Server\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_07acecec","line":48,"updated":"2014-05-30 13:10:47.000000000","message":"Indicate that -1 for no limit?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027Contrail extensions support\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":48,"context_line":"               help\u003d\u0027Maximum retries to connect to VNC Server\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":50,"context_line":"               help\u003d\u0027Retry Interval to connect to VNC Server\u0027),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_41aded30","line":48,"in_reply_to":"1ae5cdf2_07acecec","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":48,"context_line":"               help\u003d\u0027Maximum retries to connect to VNC Server\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":50,"context_line":"               help\u003d\u0027Retry Interval to connect to VNC Server\u0027),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_dc7657d8","line":50,"updated":"2014-05-30 13:10:47.000000000","message":"units seconds?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":48,"context_line":"               help\u003d\u0027Maximum retries to connect to VNC Server\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":50,"context_line":"               help\u003d\u0027Retry Interval to connect to VNC Server\u0027),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_61aae91a","line":50,"in_reply_to":"1ae5cdf2_dc7657d8","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _parse_class_args(self):"},{"line_number":68,"context_line":"        self._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # contrail extension format:"},{"line_number":71,"context_line":"        #  contrail_extensions\u003dipam:\u003cclasspath\u003e,policy:\u003cclasspath\u003e"},{"line_number":72,"context_line":"        ext_aliases \u003d NeutronPluginContrailCoreV2.supported_extension_aliases"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5504ec14","line":69,"updated":"2014-05-30 00:16:35.000000000","message":"Could you add more description here?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _parse_class_args(self):"},{"line_number":68,"context_line":"        self._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # contrail extension format:"},{"line_number":71,"context_line":"        #  contrail_extensions\u003dipam:\u003cclasspath\u003e,policy:\u003cclasspath\u003e"},{"line_number":72,"context_line":"        ext_aliases \u003d NeutronPluginContrailCoreV2.supported_extension_aliases"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_dcd56044","line":69,"in_reply_to":"1ae5cdf2_5504ec14","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if contrail_exts_conf:"},{"line_number":76,"context_line":"            supp_exts \u003d contrail_exts_conf.split(\",\")"},{"line_number":77,"context_line":"            for supp_ext in supp_exts:"},{"line_number":78,"context_line":"                ext_vars \u003d supp_ext.split(\":\")"},{"line_number":79,"context_line":"                ext_aliases.append(ext_vars[0])"},{"line_number":80,"context_line":"                ext_class \u003d importutils.import_class(ext_vars[1])"},{"line_number":81,"context_line":"                ext_instance \u003d ext_class()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_87a0fcf5","line":78,"updated":"2014-05-30 13:10:47.000000000","message":"You can use str.partition() and then descriptive names vs array access.\nYou can also test that split was successful. For example (use better names that foo, bar though):\n\n    foo, colon, bar \u003d supp_ext.partition(\u0027:\u0027)\n    if not bar:\n        LOG.debug(\u0027Malformed extension...\u0027)\n        continue\n    ext_aliases.append(foo)\n    ext_class \u003d imortutils.import_class(bar)","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if contrail_exts_conf:"},{"line_number":76,"context_line":"            supp_exts \u003d contrail_exts_conf.split(\",\")"},{"line_number":77,"context_line":"            for supp_ext in supp_exts:"},{"line_number":78,"context_line":"                ext_vars \u003d supp_ext.split(\":\")"},{"line_number":79,"context_line":"                ext_aliases.append(ext_vars[0])"},{"line_number":80,"context_line":"                ext_class \u003d importutils.import_class(ext_vars[1])"},{"line_number":81,"context_line":"                ext_instance \u003d ext_class()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_bcba54df","line":78,"in_reply_to":"1ae5cdf2_87a0fcf5","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            response, content \u003d Http().request(self._tenants_api,"},{"line_number":105,"context_line":"                                               method\u003d\"GET\","},{"line_number":106,"context_line":"                                               headers\u003dheaders)"},{"line_number":107,"context_line":"            if response.status !\u003d 200:"},{"line_number":108,"context_line":"                return"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_aa530f6b","line":107,"updated":"2014-05-30 00:16:35.000000000","message":"Why we don\u0027t need to raise exception here?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            response, content \u003d Http().request(self._tenants_api,"},{"line_number":105,"context_line":"                                               method\u003d\"GET\","},{"line_number":106,"context_line":"                                               headers\u003dheaders)"},{"line_number":107,"context_line":"            if response.status !\u003d 200:"},{"line_number":108,"context_line":"                return"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3713bf5d","line":107,"in_reply_to":"1ae5cdf2_aa530f6b","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                               headers\u003dheaders)"},{"line_number":107,"context_line":"            if response.status !\u003d 200:"},{"line_number":108,"context_line":"                return"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            return"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # transform needed for python compatibility"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4a652b44","line":109,"updated":"2014-05-30 00:16:35.000000000","message":"Why can we ignore this exception?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                               headers\u003dheaders)"},{"line_number":107,"context_line":"            if response.status !\u003d 200:"},{"line_number":108,"context_line":"                return"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            return"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # transform needed for python compatibility"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_771d4766","line":109,"in_reply_to":"1ae5cdf2_4a652b44","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # create a dictionary for id-\u003ename and name-\u003eid mapping"},{"line_number":120,"context_line":"        for tenant in content[\u0027tenants\u0027]:"},{"line_number":121,"context_line":"            print \u0027Adding tenant %s:%s to cache\u0027 % (tenant[\u0027name\u0027],"},{"line_number":122,"context_line":"                                                    tenant[\u0027id\u0027])"},{"line_number":123,"context_line":"            self._tenant_id_dict[tenant[\u0027id\u0027]] \u003d tenant[\u0027name\u0027]"},{"line_number":124,"context_line":"            self._tenant_name_dict[tenant[\u0027name\u0027]] \u003d tenant[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4a9a8b15","line":121,"updated":"2014-05-30 00:16:35.000000000","message":"use openstack logging module here.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # create a dictionary for id-\u003ename and name-\u003eid mapping"},{"line_number":120,"context_line":"        for tenant in content[\u0027tenants\u0027]:"},{"line_number":121,"context_line":"            print \u0027Adding tenant %s:%s to cache\u0027 % (tenant[\u0027name\u0027],"},{"line_number":122,"context_line":"                                                    tenant[\u0027id\u0027])"},{"line_number":123,"context_line":"            self._tenant_id_dict[tenant[\u0027id\u0027]] \u003d tenant[\u0027name\u0027]"},{"line_number":124,"context_line":"            self._tenant_name_dict[tenant[\u0027name\u0027]] \u003d tenant[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d72b7b80","line":121,"in_reply_to":"1ae5cdf2_4a9a8b15","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for tenant in content[\u0027tenants\u0027]:"},{"line_number":121,"context_line":"            print \u0027Adding tenant %s:%s to cache\u0027 % (tenant[\u0027name\u0027],"},{"line_number":122,"context_line":"                                                    tenant[\u0027id\u0027])"},{"line_number":123,"context_line":"            self._tenant_id_dict[tenant[\u0027id\u0027]] \u003d tenant[\u0027name\u0027]"},{"line_number":124,"context_line":"            self._tenant_name_dict[tenant[\u0027name\u0027]] \u003d tenant[\u0027id\u0027]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e725400b","line":123,"updated":"2014-05-30 13:10:47.000000000","message":"Is the intent for these to be class variables (L63, L64)?\n\nA little misleading to access class variable with instance.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for tenant in content[\u0027tenants\u0027]:"},{"line_number":121,"context_line":"            print \u0027Adding tenant %s:%s to cache\u0027 % (tenant[\u0027name\u0027],"},{"line_number":122,"context_line":"                                                    tenant[\u0027id\u0027])"},{"line_number":123,"context_line":"            self._tenant_id_dict[tenant[\u0027id\u0027]] \u003d tenant[\u0027name\u0027]"},{"line_number":124,"context_line":"            self._tenant_name_dict[tenant[\u0027name\u0027]] \u003d tenant[\u0027id\u0027]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f720779d","line":123,"in_reply_to":"1ae5cdf2_e725400b","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def __init__(self):"},{"line_number":127,"context_line":"        cfg.CONF.register_opts(vnc_opts, \u0027APISERVER\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._parse_class_args()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        self._tenant_list_from_keystone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8a72d3e3","line":128,"updated":"2014-05-30 00:16:35.000000000","message":"this line isn\u0027t needed","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def __init__(self):"},{"line_number":127,"context_line":"        cfg.CONF.register_opts(vnc_opts, \u0027APISERVER\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._parse_class_args()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        self._tenant_list_from_keystone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b7826f50","line":128,"in_reply_to":"1ae5cdf2_8a72d3e3","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def __init__(self):"},{"line_number":127,"context_line":"        cfg.CONF.register_opts(vnc_opts, \u0027APISERVER\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._parse_class_args()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        self._tenant_list_from_keystone()"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_aa76afd6","line":129,"updated":"2014-05-30 00:16:35.000000000","message":"this line isn\u0027t needed","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def __init__(self):"},{"line_number":127,"context_line":"        cfg.CONF.register_opts(vnc_opts, \u0027APISERVER\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self._parse_class_args()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        self._tenant_list_from_keystone()"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d787fb5f","line":129,"in_reply_to":"1ae5cdf2_aa76afd6","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        raise AttributeError()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def tenant_id_to_name(self, id):"},{"line_number":143,"context_line":"        # bail if we never built the list successfully"},{"line_number":144,"context_line":"        if len(self._tenant_id_dict) \u003d\u003d 0:"},{"line_number":145,"context_line":"            return id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b5ae10e6","line":142,"updated":"2014-05-30 00:16:35.000000000","message":"Where we are using this method?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        raise AttributeError()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def tenant_id_to_name(self, id):"},{"line_number":143,"context_line":"        # bail if we never built the list successfully"},{"line_number":144,"context_line":"        if len(self._tenant_id_dict) \u003d\u003d 0:"},{"line_number":145,"context_line":"            return id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_978d737e","line":142,"in_reply_to":"1ae5cdf2_b5ae10e6","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def tenant_id_to_name(self, id):"},{"line_number":143,"context_line":"        # bail if we never built the list successfully"},{"line_number":144,"context_line":"        if len(self._tenant_id_dict) \u003d\u003d 0:"},{"line_number":145,"context_line":"            return id"},{"line_number":146,"context_line":"        # check cache"},{"line_number":147,"context_line":"        if id in self._tenant_id_dict:"},{"line_number":148,"context_line":"            return self._tenant_id_dict[id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1548a45a","line":145,"updated":"2014-05-30 00:16:35.000000000","message":"I\u0027m not sure why L144, L145 is needed..\nIn case, we should fail otherwise this method don\u0027t act as consistent way","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def tenant_id_to_name(self, id):"},{"line_number":143,"context_line":"        # bail if we never built the list successfully"},{"line_number":144,"context_line":"        if len(self._tenant_id_dict) \u003d\u003d 0:"},{"line_number":145,"context_line":"            return id"},{"line_number":146,"context_line":"        # check cache"},{"line_number":147,"context_line":"        if id in self._tenant_id_dict:"},{"line_number":148,"context_line":"            return self._tenant_id_dict[id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_77e70741","line":145,"in_reply_to":"1ae5cdf2_1548a45a","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return self._tenant_id_dict[id] if id in self._tenant_id_dict else id"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def tenant_name_to_id(self, name):"},{"line_number":155,"context_line":"        # bail if we never built the list successfully"},{"line_number":156,"context_line":"        if len(self._tenant_name_dict) \u003d\u003d 0:"},{"line_number":157,"context_line":"            return name"},{"line_number":158,"context_line":"        # check cache"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d5ab9cd4","line":155,"updated":"2014-05-30 00:16:35.000000000","message":"Where we are using this method?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return self._tenant_id_dict[id] if id in self._tenant_id_dict else id"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def tenant_name_to_id(self, name):"},{"line_number":155,"context_line":"        # bail if we never built the list successfully"},{"line_number":156,"context_line":"        if len(self._tenant_name_dict) \u003d\u003d 0:"},{"line_number":157,"context_line":"            return name"},{"line_number":158,"context_line":"        # check cache"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_17d0834f","line":155,"in_reply_to":"1ae5cdf2_d5ab9cd4","updated":"2014-05-30 23:17:30.000000000","message":"This code is not needed, removed it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"73e713cda698fafaea2e44a68ff2f83aafe1d2b7","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # Return empty list of agents."},{"line_number":170,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":171,"context_line":"        agents \u003d []"},{"line_number":172,"context_line":"        return agents"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1edb40ee","line":171,"updated":"2014-05-30 20:34:41.000000000","message":"this seems odd, why have a function to return an empty list?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    # Return empty list of agents."},{"line_number":170,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":171,"context_line":"        agents \u003d []"},{"line_number":172,"context_line":"        return agents"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9752d3db","line":171,"in_reply_to":"1ae5cdf2_1edb40ee","updated":"2014-05-30 23:17:30.000000000","message":"agent extension is added to avoid return 404 for get_agents","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        agents \u003d []"},{"line_number":172,"context_line":"        return agents"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"},{"line_number":175,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":176,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":177,"context_line":"            return requests.get(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1569848b","line":174,"updated":"2014-05-30 00:16:35.000000000","message":"IMO, L174 - L290 can sit in contrail lib side","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        agents \u003d []"},{"line_number":172,"context_line":"        return agents"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"},{"line_number":175,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":176,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":177,"context_line":"            return requests.get(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b7050fc4","line":174,"in_reply_to":"1ae5cdf2_1569848b","updated":"2014-05-30 23:17:30.000000000","message":"We don\u0027t use the contrail-api-lib now, the plugin is now passthrough to the controller.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d5499e0af0c460973b7c3b6477057c0af0e6cdf3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        agents \u003d []"},{"line_number":172,"context_line":"        return agents"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"},{"line_number":175,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":176,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":177,"context_line":"            return requests.get(url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f4e4f03c","line":174,"in_reply_to":"1ae5cdf2_b7050fc4","updated":"2014-05-30 23:44:58.000000000","message":"I got it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"},{"line_number":175,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":176,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":177,"context_line":"            return requests.get(url)"},{"line_number":178,"context_line":"        if method \u003d\u003d \u0027POST\u0027:"},{"line_number":179,"context_line":"            return requests.post(url, data\u003ddata, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_07ff8c35","line":176,"updated":"2014-05-30 13:10:47.000000000","message":"I think you can just do:\n\n    return requests.request(method, url, data, headers)\n\nAlso, what about when there are errors?\nAny reporting or exceptions raised?\nWhat about timeouts?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # Helper routines"},{"line_number":175,"context_line":"    def _request_api_server(self, url, method, data\u003dNone, headers\u003dNone):"},{"line_number":176,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":177,"context_line":"            return requests.get(url)"},{"line_number":178,"context_line":"        if method \u003d\u003d \u0027POST\u0027:"},{"line_number":179,"context_line":"            return requests.post(url, data\u003ddata, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_77762740","line":176,"in_reply_to":"1ae5cdf2_07ff8c35","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _relay_request(self, method, url_path, data\u003dNone):"},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        Send received request to api server"},{"line_number":186,"context_line":"        \"\"\""},{"line_number":187,"context_line":"        # make url, add api server address/port"},{"line_number":188,"context_line":"        url \u003d \"http://%s:%s%s\" % (cfg.CONF.APISERVER.api_server_ip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4790b4ec","line":185,"updated":"2014-05-30 13:10:47.000000000","message":"Nit: PEP8, single line doc string put all on one line (including quotes) and end sentence with a period.\n\nMake sure you run \u0027tox -e pep8\u0027 on your changeset.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _relay_request(self, method, url_path, data\u003dNone):"},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        Send received request to api server"},{"line_number":186,"context_line":"        \"\"\""},{"line_number":187,"context_line":"        # make url, add api server address/port"},{"line_number":188,"context_line":"        url \u003d \"http://%s:%s%s\" % (cfg.CONF.APISERVER.api_server_ip,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_92e4a13c","line":185,"in_reply_to":"1ae5cdf2_4790b4ec","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            return response.status_code, json.loads(response.content)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _encode_context(self, context, operation, apitype):"},{"line_number":206,"context_line":"        cdict \u003d {}"},{"line_number":207,"context_line":"        cdict[\u0027user_id\u0027] \u003d getattr(context, \u0027user_id\u0027, \u0027\u0027)"},{"line_number":208,"context_line":"        if context.roles:"},{"line_number":209,"context_line":"            cdict[\u0027roles\u0027] \u003d context.roles"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a220869c","line":206,"updated":"2014-05-30 13:10:47.000000000","message":"Could do:\n\n    cdict \u003d {\u0027user_id\u0027: getattr(context, \u0027user_id\u0027, \u0027\u0027),\n             \u0027is_admin\u0027: getattr(context, \u0027is_admin\u0027, False)\n             \u0027operation\u0027: operation,\n             \u0027type\u0027: apitype,\n             ...}\n\nand then add two conditional entries.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            return response.status_code, json.loads(response.content)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _encode_context(self, context, operation, apitype):"},{"line_number":206,"context_line":"        cdict \u003d {}"},{"line_number":207,"context_line":"        cdict[\u0027user_id\u0027] \u003d getattr(context, \u0027user_id\u0027, \u0027\u0027)"},{"line_number":208,"context_line":"        if context.roles:"},{"line_number":209,"context_line":"            cdict[\u0027roles\u0027] \u003d context.roles"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b25efde7","line":206,"in_reply_to":"1ae5cdf2_a220869c","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        resource_dict[\u0027fields\u0027] \u003d fields"},{"line_number":227,"context_line":"        return resource_dict"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def _transform_response(self, status_code, info\u003dNone, info_list\u003dNone,"},{"line_number":230,"context_line":"                            fields\u003dNone, obj_name\u003dNone):"},{"line_number":231,"context_line":"        funcname \u003d \"_make_\" + obj_name + \"_dict\""},{"line_number":232,"context_line":"        func \u003d getattr(self, funcname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_62959ee3","line":229,"updated":"2014-05-30 13:10:47.000000000","message":"Rather than have info and info_list, could use just one parameter and always take a list. Callers with only one element, can pass in [item].","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        resource_dict[\u0027fields\u0027] \u003d fields"},{"line_number":227,"context_line":"        return resource_dict"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def _transform_response(self, status_code, info\u003dNone, info_list\u003dNone,"},{"line_number":230,"context_line":"                            fields\u003dNone, obj_name\u003dNone):"},{"line_number":231,"context_line":"        funcname \u003d \"_make_\" + obj_name + \"_dict\""},{"line_number":232,"context_line":"        func \u003d getattr(self, funcname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_32caed4f","line":229,"in_reply_to":"1ae5cdf2_62959ee3","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if entry[\u0027type\u0027] \u003d\u003d \u0027InvalidSharedSetting\u0027:"},{"line_number":299,"context_line":"            raise exc.InvalidSharedSetting(network\u003dentry[\u0027name\u0027])"},{"line_number":300,"context_line":"        if entry[\u0027type\u0027] \u003d\u003d \u0027NetworkInUse\u0027:"},{"line_number":301,"context_line":"            raise exc.NetworkInUse(net_id\u003dentry[\u0027id\u0027])"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _get_network(self, context, id):"},{"line_number":304,"context_line":"        network_dict \u003d self._get_resource(\u0027network\u0027, context, id, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a2440675","line":301,"updated":"2014-05-30 13:10:47.000000000","message":"Are the two if\u0027s above catching all failure cases?\nIf not, this will return None, is that what is desired (versus empty dict)?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if entry[\u0027type\u0027] \u003d\u003d \u0027InvalidSharedSetting\u0027:"},{"line_number":299,"context_line":"            raise exc.InvalidSharedSetting(network\u003dentry[\u0027name\u0027])"},{"line_number":300,"context_line":"        if entry[\u0027type\u0027] \u003d\u003d \u0027NetworkInUse\u0027:"},{"line_number":301,"context_line":"            raise exc.NetworkInUse(net_id\u003dentry[\u0027id\u0027])"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _get_network(self, context, id):"},{"line_number":304,"context_line":"        network_dict \u003d self._get_resource(\u0027network\u0027, context, id, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ad26a0b8","line":301,"in_reply_to":"1ae5cdf2_a2440675","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            raise exc.NetworkInUse(net_id\u003dentry[\u0027id\u0027])"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _get_network(self, context, id):"},{"line_number":304,"context_line":"        network_dict \u003d self._get_resource(\u0027network\u0027, context, id, None)"},{"line_number":305,"context_line":"        return network_dict"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def create_network(self, context, network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2258f655","line":304,"updated":"2014-05-30 13:10:47.000000000","message":"just return here w/o creating temp variable","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            raise exc.NetworkInUse(net_id\u003dentry[\u0027id\u0027])"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _get_network(self, context, id):"},{"line_number":304,"context_line":"        network_dict \u003d self._get_resource(\u0027network\u0027, context, id, None)"},{"line_number":305,"context_line":"        return network_dict"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def create_network(self, context, network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ad4dc074","line":304,"in_reply_to":"1ae5cdf2_2258f655","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":310,"context_line":"        a symbolic name."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        plugin_network \u003d copy.deepcopy(network)"},{"line_number":313,"context_line":"        if network[\u0027network\u0027][\u0027router:external\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":314,"context_line":"            del plugin_network[\u0027network\u0027][\u0027router:external\u0027]"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_952bd42f","line":312,"updated":"2014-05-30 00:16:35.000000000","message":"why this deepcopy is needed?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d5499e0af0c460973b7c3b6477057c0af0e6cdf3","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":310,"context_line":"        a symbolic name."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        plugin_network \u003d copy.deepcopy(network)"},{"line_number":313,"context_line":"        if network[\u0027network\u0027][\u0027router:external\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":314,"context_line":"            del plugin_network[\u0027network\u0027][\u0027router:external\u0027]"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_745e20e8","line":312,"in_reply_to":"1ae5cdf2_8dbba40d","updated":"2014-05-30 23:44:58.000000000","message":"The dict isn\u0027t used anyware except here.\nso you can safely change it","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":310,"context_line":"        a symbolic name."},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        plugin_network \u003d copy.deepcopy(network)"},{"line_number":313,"context_line":"        if network[\u0027network\u0027][\u0027router:external\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":314,"context_line":"            del plugin_network[\u0027network\u0027][\u0027router:external\u0027]"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8dbba40d","line":312,"in_reply_to":"1ae5cdf2_952bd42f","updated":"2014-05-30 23:17:30.000000000","message":"We don\u0027t want to modify which was passed to us. We do change some fields based on ATTR_NOT_SPECIFIED","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        network_dicts \u003d self._create_resource(\u0027network\u0027, context,"},{"line_number":317,"context_line":"                                              plugin_network)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        LOG.debug(\"create_network(): %r\", network_dicts)"},{"line_number":320,"context_line":"        return network_dicts"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def get_network(self, context, network_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9503d472","line":319,"updated":"2014-05-30 00:16:35.000000000","message":"IMO, we can move this debug message to inside _create_resource (the others as well)","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        network_dicts \u003d self._create_resource(\u0027network\u0027, context,"},{"line_number":317,"context_line":"                                              plugin_network)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        LOG.debug(\"create_network(): %r\", network_dicts)"},{"line_number":320,"context_line":"        return network_dicts"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def get_network(self, context, network_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ad1220b2","line":319,"in_reply_to":"1ae5cdf2_9503d472","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        Updates the attributes of a particular Virtual Network."},{"line_number":335,"context_line":"        \"\"\""},{"line_number":336,"context_line":"        plugin_network \u003d copy.deepcopy(network)"},{"line_number":337,"context_line":"        network_dicts \u003d self._update_resource(\u0027network\u0027, context, network_id,"},{"line_number":338,"context_line":"                                              plugin_network)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1546e4bf","line":336,"updated":"2014-05-30 00:16:35.000000000","message":"Why this deep copy needed?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        Updates the attributes of a particular Virtual Network."},{"line_number":335,"context_line":"        \"\"\""},{"line_number":336,"context_line":"        plugin_network \u003d copy.deepcopy(network)"},{"line_number":337,"context_line":"        network_dicts \u003d self._update_resource(\u0027network\u0027, context, network_id,"},{"line_number":338,"context_line":"                                              plugin_network)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8d52c4db","line":336,"in_reply_to":"1ae5cdf2_1546e4bf","updated":"2014-05-30 23:17:30.000000000","message":"We don\u0027t want to modify which was passed to us. We do change some fields based on ATTR_NOT_SPECIFIED","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        LOG.debug(\"delete_network(): %r\", network_id)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if status_code \u003d\u003d 200:"},{"line_number":354,"context_line":"            return"},{"line_number":355,"context_line":"        elif status_code \u003d\u003d 409:"},{"line_number":356,"context_line":"            raise exc.NetworkInUse(net_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f6816f4b","line":353,"updated":"2014-05-30 13:10:47.000000000","message":"Can just test for 409 and raise, otherwise it\u0027ll fall through and return none.\n\nCan there be other status\u0027 returned?\nWould prefer using reqeusts.code.coflict vs 409 for readability. Consider for others.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        LOG.debug(\"delete_network(): %r\", network_id)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if status_code \u003d\u003d 200:"},{"line_number":354,"context_line":"            return"},{"line_number":355,"context_line":"        elif status_code \u003d\u003d 409:"},{"line_number":356,"context_line":"            raise exc.NetworkInUse(net_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0deeb488","line":353,"in_reply_to":"1ae5cdf2_f6816f4b","updated":"2014-05-30 23:17:30.000000000","message":"Done. I changed other hardcoded codes too.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            raise exc.GatewayConflictWithAllocationPools(pool\u003dpool_range,"},{"line_number":391,"context_line":"                                                         ip_address\u003dgateway_ip)"},{"line_number":392,"context_line":"        if entry[\u0027type\u0027] \u003d\u003d \u0027SubnetNotFound\u0027:"},{"line_number":393,"context_line":"            raise exc.SubnetNotFound(subnet_id\u003dentry[\u0027id\u0027])"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def _get_subnet(self, context, id):"},{"line_number":396,"context_line":"        subnet_dict \u003d self._get_resource(\u0027subnet\u0027, context, id, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f6cfafae","line":393,"updated":"2014-05-30 13:10:47.000000000","message":"Are all error codes being handled? Should there be a generic exception raised as default?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            raise exc.GatewayConflictWithAllocationPools(pool\u003dpool_range,"},{"line_number":391,"context_line":"                                                         ip_address\u003dgateway_ip)"},{"line_number":392,"context_line":"        if entry[\u0027type\u0027] \u003d\u003d \u0027SubnetNotFound\u0027:"},{"line_number":393,"context_line":"            raise exc.SubnetNotFound(subnet_id\u003dentry[\u0027id\u0027])"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def _get_subnet(self, context, id):"},{"line_number":396,"context_line":"        subnet_dict \u003d self._get_resource(\u0027subnet\u0027, context, id, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ed9fc801","line":393,"in_reply_to":"1ae5cdf2_f6cfafae","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _get_all_subnets(self, context):"},{"line_number":400,"context_line":"        all_networks \u003d self.get_networks(context)"},{"line_number":401,"context_line":"        all_subnets \u003d []"},{"line_number":402,"context_line":"        for network in all_networks:"},{"line_number":403,"context_line":"            subnets \u003d \\"},{"line_number":404,"context_line":"                [self._get_subnet(context, id) for id in network[\u0027subnets\u0027]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7669df8a","line":401,"updated":"2014-05-30 13:10:47.000000000","message":"You can use a nested list comprehension to build all_subnets.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _get_all_subnets(self, context):"},{"line_number":400,"context_line":"        all_networks \u003d self.get_networks(context)"},{"line_number":401,"context_line":"        all_subnets \u003d []"},{"line_number":402,"context_line":"        for network in all_networks:"},{"line_number":403,"context_line":"            subnets \u003d \\"},{"line_number":404,"context_line":"                [self._get_subnet(context, id) for id in network[\u0027subnets\u0027]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2d2530c2","line":401,"in_reply_to":"1ae5cdf2_7669df8a","updated":"2014-05-30 23:17:30.000000000","message":"yeah I could but its just simpler to read.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        all_networks \u003d self.get_networks(context)"},{"line_number":401,"context_line":"        all_subnets \u003d []"},{"line_number":402,"context_line":"        for network in all_networks:"},{"line_number":403,"context_line":"            subnets \u003d \\"},{"line_number":404,"context_line":"                [self._get_subnet(context, id) for id in network[\u0027subnets\u0027]]"},{"line_number":405,"context_line":"            all_subnets.extend(subnets)"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f576d805","line":403,"updated":"2014-05-30 00:16:35.000000000","message":"(nit) we should avoid to use \\","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        all_networks \u003d self.get_networks(context)"},{"line_number":401,"context_line":"        all_subnets \u003d []"},{"line_number":402,"context_line":"        for network in all_networks:"},{"line_number":403,"context_line":"            subnets \u003d \\"},{"line_number":404,"context_line":"                [self._get_subnet(context, id) for id in network[\u0027subnets\u0027]]"},{"line_number":405,"context_line":"            all_subnets.extend(subnets)"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2d5e1046","line":403,"in_reply_to":"1ae5cdf2_f576d805","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            subnet_ids \u003d network[\u0027subnets\u0027]"},{"line_number":419,"context_line":"            subnet_list \u003d [self._get_subnet(context, id) for id in subnet_ids]"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        for subnet in subnet_list:"},{"line_number":424,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d521dcb5","line":421,"updated":"2014-05-30 00:16:35.000000000","message":"This method is really heavy operation.. IMO, we shouldn\u0027t have this one.\nI\u0027m not sure we need to support this option in contrail. \n(How about log warning in plugin init, when allow_overlapping_ips is False )","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"d5499e0af0c460973b7c3b6477057c0af0e6cdf3","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            subnet_ids \u003d network[\u0027subnets\u0027]"},{"line_number":419,"context_line":"            subnet_list \u003d [self._get_subnet(context, id) for id in subnet_ids]"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        for subnet in subnet_list:"},{"line_number":424,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_94f9ecca","line":421,"in_reply_to":"1ae5cdf2_ad186085","updated":"2014-05-30 23:44:58.000000000","message":"the number of all tenant subnet could be really big.\nI don\u0027t think this code is scalable.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            subnet_ids \u003d network[\u0027subnets\u0027]"},{"line_number":419,"context_line":"            subnet_list \u003d [self._get_subnet(context, id) for id in subnet_ids]"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        for subnet in subnet_list:"},{"line_number":424,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ad186085","line":421,"in_reply_to":"1ae5cdf2_d521dcb5","updated":"2014-05-30 23:17:30.000000000","message":"Can you explain more","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                            \"(CIDR: %(cidr)s)\"),"},{"line_number":434,"context_line":"                          {\u0027new_cidr\u0027: new_subnet_cidr,"},{"line_number":435,"context_line":"                           \u0027subnet_id\u0027: subnet[\u0027id\u0027],"},{"line_number":436,"context_line":"                           \u0027cidr\u0027: subnet[\u0027cidr\u0027]})"},{"line_number":437,"context_line":"                raise exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def create_subnet(self, context, subnet):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_551dcc72","line":436,"updated":"2014-05-30 00:16:35.000000000","message":"Why not just log error?","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                            \"(CIDR: %(cidr)s)\"),"},{"line_number":434,"context_line":"                          {\u0027new_cidr\u0027: new_subnet_cidr,"},{"line_number":435,"context_line":"                           \u0027subnet_id\u0027: subnet[\u0027id\u0027],"},{"line_number":436,"context_line":"                           \u0027cidr\u0027: subnet[\u0027cidr\u0027]})"},{"line_number":437,"context_line":"                raise exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def create_subnet(self, context, subnet):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_2d0c5042","line":436,"in_reply_to":"1ae5cdf2_551dcc72","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":440,"context_line":"        \"\"\""},{"line_number":441,"context_line":"        Creates a new subnet, and assigns it a symbolic name."},{"line_number":442,"context_line":"        \"\"\""},{"line_number":443,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":444,"context_line":"        if subnet[\u0027subnet\u0027][\u0027dns_nameservers\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b631a7a4","line":441,"updated":"2014-05-30 13:10:47.000000000","message":"Nit: PEP8 put quotes on same line for single line docstring. Fix others too.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":440,"context_line":"        \"\"\""},{"line_number":441,"context_line":"        Creates a new subnet, and assigns it a symbolic name."},{"line_number":442,"context_line":"        \"\"\""},{"line_number":443,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":444,"context_line":"        if subnet[\u0027subnet\u0027][\u0027dns_nameservers\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4d099c30","line":441,"in_reply_to":"1ae5cdf2_b631a7a4","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        \"\"\""},{"line_number":441,"context_line":"        Creates a new subnet, and assigns it a symbolic name."},{"line_number":442,"context_line":"        \"\"\""},{"line_number":443,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":444,"context_line":"        if subnet[\u0027subnet\u0027][\u0027dns_nameservers\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":445,"context_line":"            plugin_subnet[\u0027subnet\u0027][\u0027dns_nameservers\u0027] \u003d None"},{"line_number":446,"context_line":"        if subnet[\u0027subnet\u0027][\u0027allocation_pools\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_502b1a82","line":443,"updated":"2014-05-30 00:16:35.000000000","message":"Why deep copy needed?\n\nL443 - L451 can be done by for loop.\nfor key, value in subnet[\u0027subnet\u0027].items():\n   if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:\n      subnet[\u0027subnet\u0027][key] \u003d None","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        \"\"\""},{"line_number":441,"context_line":"        Creates a new subnet, and assigns it a symbolic name."},{"line_number":442,"context_line":"        \"\"\""},{"line_number":443,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":444,"context_line":"        if subnet[\u0027subnet\u0027][\u0027dns_nameservers\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":445,"context_line":"            plugin_subnet[\u0027subnet\u0027][\u0027dns_nameservers\u0027] \u003d None"},{"line_number":446,"context_line":"        if subnet[\u0027subnet\u0027][\u0027allocation_pools\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3153ca18","line":443,"in_reply_to":"1ae5cdf2_502b1a82","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        if status_code \u003d\u003d 200:"},{"line_number":529,"context_line":"            return"},{"line_number":530,"context_line":"        elif status_code \u003d\u003d 409:"},{"line_number":531,"context_line":"            raise exc.SubnetInUse(subnet_id\u003dsubnet_id)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def get_subnets(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":534,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d6e713e3","line":531,"updated":"2014-05-30 13:10:47.000000000","message":"Same question on this and other methods on handling of all failures.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        if status_code \u003d\u003d 200:"},{"line_number":529,"context_line":"            return"},{"line_number":530,"context_line":"        elif status_code \u003d\u003d 409:"},{"line_number":531,"context_line":"            raise exc.SubnetInUse(subnet_id\u003dsubnet_id)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def get_subnets(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":534,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_51585632","line":531,"in_reply_to":"1ae5cdf2_d6e713e3","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        # Security group bindings will be retrieved from the sqlalchemy"},{"line_number":568,"context_line":"        # model. As they\u0027re loaded eagerly with ports because of the"},{"line_number":569,"context_line":"        # joined load they will not cause an extra query."},{"line_number":570,"context_line":"        port_res[securitygroup.SECURITYGROUPS] \u003d \\"},{"line_number":571,"context_line":"            port_db.get(\u0027security_groups\u0027, []) or []"},{"line_number":572,"context_line":"        return port_res"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_56db031b","line":570,"updated":"2014-05-30 13:10:47.000000000","message":"Use paren vs backslash for continuation.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        # Security group bindings will be retrieved from the sqlalchemy"},{"line_number":568,"context_line":"        # model. As they\u0027re loaded eagerly with ports because of the"},{"line_number":569,"context_line":"        # joined load they will not cause an extra query."},{"line_number":570,"context_line":"        port_res[securitygroup.SECURITYGROUPS] \u003d \\"},{"line_number":571,"context_line":"            port_db.get(\u0027security_groups\u0027, []) or []"},{"line_number":572,"context_line":"        return port_res"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1175ee97","line":570,"in_reply_to":"1ae5cdf2_56db031b","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        return port_res"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def _get_port(self, context, id):"},{"line_number":575,"context_line":"        port_dict \u003d self._get_resource(\u0027port\u0027, context, id, None)"},{"line_number":576,"context_line":"        return port_dict"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def _test_fixed_ips_for_port(self, context, network_id, fixed_ips):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9604ab7f","line":575,"updated":"2014-05-30 13:10:47.000000000","message":"return self._get...","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        return port_res"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def _get_port(self, context, id):"},{"line_number":575,"context_line":"        port_dict \u003d self._get_resource(\u0027port\u0027, context, id, None)"},{"line_number":576,"context_line":"        return port_dict"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def _test_fixed_ips_for_port(self, context, network_id, fixed_ips):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_91681ebc","line":575,"in_reply_to":"1ae5cdf2_9604ab7f","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8306,"name":"Rudra Rugge","email":"rrugge@juniper.net","username":"rudrarugge"},"change_message_id":"d44c0e59aa6e32d64cf2b7cc09cfef870b4670f7","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        port_dict \u003d self._get_resource(\u0027port\u0027, context, id, None)"},{"line_number":576,"context_line":"        return port_dict"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def _test_fixed_ips_for_port(self, context, network_id, fixed_ips):"},{"line_number":579,"context_line":"        \"\"\"Test fixed IPs for port."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Check that configured subnets are valid prior to allocating any"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f52ed8a4","line":578,"updated":"2014-05-30 00:16:14.000000000","message":"This looks like validation of information. Can we rename this to _validate instead of _test.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        port_dict \u003d self._get_resource(\u0027port\u0027, context, id, None)"},{"line_number":576,"context_line":"        return port_dict"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def _test_fixed_ips_for_port(self, context, network_id, fixed_ips):"},{"line_number":579,"context_line":"        \"\"\"Test fixed IPs for port."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Check that configured subnets are valid prior to allocating any"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_51a69611","line":578,"in_reply_to":"1ae5cdf2_f52ed8a4","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c815991d759e98cd93cfd080e59392128ab08612","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        configured."},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        :raises: InvalidInput, IpAddressInUse"},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        fixed_ip_set \u003d []"},{"line_number":588,"context_line":"        for fixed in fixed_ips:"},{"line_number":589,"context_line":"            found \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b67e07e3","line":586,"updated":"2014-05-30 13:10:47.000000000","message":"This method is pretty large and will make testing it challenging. Considder breaking parts of it into sub-functions so that they can be tested individually.","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        configured."},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        :raises: InvalidInput, IpAddressInUse"},{"line_number":586,"context_line":"        \"\"\""},{"line_number":587,"context_line":"        fixed_ip_set \u003d []"},{"line_number":588,"context_line":"        for fixed in fixed_ips:"},{"line_number":589,"context_line":"            found \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_51f4d6f1","line":586,"in_reply_to":"1ae5cdf2_b67e07e3","updated":"2014-05-30 23:17:30.000000000","message":"I can take it in the next phase :)","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"49e02d27c36267e25dde9df4333980f37d6d666c","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        \"\"\""},{"line_number":665,"context_line":"        Creates a port on the specified Virtual Network."},{"line_number":666,"context_line":"        \"\"\""},{"line_number":667,"context_line":"        plugin_port \u003d copy.deepcopy(port)"},{"line_number":668,"context_line":"        if port[\u0027port\u0027][\u0027port_security_enabled\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":669,"context_line":"            plugin_port[\u0027port\u0027][\u0027port_security_enabled\u0027] \u003d None"},{"line_number":670,"context_line":"        if port[\u0027port\u0027][\u0027binding:host_id\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f04a6654","line":667,"updated":"2014-05-30 00:16:35.000000000","message":"please see above comment","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        \"\"\""},{"line_number":665,"context_line":"        Creates a port on the specified Virtual Network."},{"line_number":666,"context_line":"        \"\"\""},{"line_number":667,"context_line":"        plugin_port \u003d copy.deepcopy(port)"},{"line_number":668,"context_line":"        if port[\u0027port\u0027][\u0027port_security_enabled\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":669,"context_line":"            plugin_port[\u0027port\u0027][\u0027port_security_enabled\u0027] \u003d None"},{"line_number":670,"context_line":"        if port[\u0027port\u0027][\u0027binding:host_id\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_71f9d2e8","line":667,"in_reply_to":"1ae5cdf2_f04a6654","updated":"2014-05-30 23:17:30.000000000","message":"we don\u0027t want to change what was passed","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.openstack.common import jsonutils as json"},{"line_number":28,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import netaddr"},{"line_number":31,"context_line":"from oslo.config import cfg"},{"line_number":32,"context_line":"import requests"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7a48a387","line":30,"updated":"2014-06-02 13:00:56.000000000","message":"See hacking guides, the third party imports should be before neutron imports.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.openstack.common import jsonutils as json"},{"line_number":28,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import netaddr"},{"line_number":31,"context_line":"from oslo.config import cfg"},{"line_number":32,"context_line":"import requests"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_bdfdbb3c","line":30,"in_reply_to":"1ae5cdf2_7a48a387","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4b9f994a97a76b9f9ccd5b352d6ad8fa0bec71d7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"vnc_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":38,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_00bc88db","line":37,"updated":"2014-06-02 18:20:28.000000000","message":"These are all the options which should be documented in the .ini file.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"vnc_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":38,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4b85d1ce","line":37,"in_reply_to":"1ae5cdf2_00bc88db","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _parse_class_args(self):"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        Opencontrail supports extension such as ipam, policy, these extensions"},{"line_number":65,"context_line":"        can be configured in the plugin configuration file as shown below."},{"line_number":66,"context_line":"        Plugin then loads the specified extensions."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_bac5cb3e","line":64,"updated":"2014-06-02 13:00:56.000000000","message":"Nit: PEP8 for multiline docstring, first line (summary) ends with period and is on same line as quotes, a blank line, and then rest of docstring.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _parse_class_args(self):"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        Opencontrail supports extension such as ipam, policy, these extensions"},{"line_number":65,"context_line":"        can be configured in the plugin configuration file as shown below."},{"line_number":66,"context_line":"        Plugin then loads the specified extensions."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_3db8cb75","line":64,"in_reply_to":"1ae5cdf2_bac5cb3e","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        raise AttributeError()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":105,"context_line":"        \"\"\"agent extension is added to avoid return 404 for get_agents.\"\"\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        agents \u003d []"},{"line_number":108,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7a398340","line":105,"updated":"2014-06-02 13:00:56.000000000","message":"This should describe what the method does. This method doesn\u0027t get a docstring, IMHO.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        raise AttributeError()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":105,"context_line":"        \"\"\"agent extension is added to avoid return 404 for get_agents.\"\"\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        agents \u003d []"},{"line_number":108,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7d7893c4","line":105,"in_reply_to":"1ae5cdf2_7a398340","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def create_network(self, context, network):"},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":242,"context_line":"        a symbolic name."},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1a195f88","line":241,"updated":"2014-06-02 13:00:56.000000000","message":"See PEP8/PEP257 for formatting for docstrings","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def create_network(self, context, network):"},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        Creates a new Virtual Network, and assigns it"},{"line_number":242,"context_line":"        a symbolic name."},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e08cfc81","line":241,"in_reply_to":"1ae5cdf2_1a195f88","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":250,"context_line":"                network[\u0027network\u0027][key] \u003d None"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        network_dicts \u003d self._create_resource(\u0027network\u0027, context, network)"},{"line_number":253,"context_line":"        return network_dicts"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def get_network(self, context, network_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9a0c8f44","line":252,"updated":"2014-06-02 13:00:56.000000000","message":"Can just return w/o temp variable here, L258, L265, ... L878","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":250,"context_line":"                network[\u0027network\u0027][key] \u003d None"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        network_dicts \u003d self._create_resource(\u0027network\u0027, context, network)"},{"line_number":253,"context_line":"        return network_dicts"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def get_network(self, context, network_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_807df81e","line":252,"in_reply_to":"1ae5cdf2_9a0c8f44","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        for subnet in subnet_list:"},{"line_number":341,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"},{"line_number":342,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":343,"context_line":"                LOG.error(_(\"Requested subnet with cidr: %(cidr)s for \""},{"line_number":344,"context_line":"                            \"network: %(network_id)s overlaps with another \""},{"line_number":345,"context_line":"                            \"subnet\") %"},{"line_number":346,"context_line":"                          {\u0027cidr\u0027: new_subnet_cidr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9a02cf3c","line":343,"updated":"2014-06-02 13:00:56.000000000","message":"Combine hese two logs into one?","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        for subnet in subnet_list:"},{"line_number":341,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"},{"line_number":342,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":343,"context_line":"                LOG.error(_(\"Requested subnet with cidr: %(cidr)s for \""},{"line_number":344,"context_line":"                            \"network: %(network_id)s overlaps with another \""},{"line_number":345,"context_line":"                            \"subnet\") %"},{"line_number":346,"context_line":"                          {\u0027cidr\u0027: new_subnet_cidr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_80cb3852","line":343,"in_reply_to":"1ae5cdf2_9a02cf3c","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _make_port_dict(self, entry, status_code\u003dNone, fields\u003dNone):"},{"line_number":442,"context_line":"        if status_code \u003d\u003d requests.codes.ok:"},{"line_number":443,"context_line":"            port_dict \u003d \\"},{"line_number":444,"context_line":"                super(NeutronPluginContrailCoreV2, self)._make_port_dict("},{"line_number":445,"context_line":"                    entry, fields)"},{"line_number":446,"context_line":"            return port_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8e58d433","line":443,"updated":"2014-06-02 13:00:56.000000000","message":"use parens instead of backslashes for continuing lines. Can just return w/o temp variable too.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _make_port_dict(self, entry, status_code\u003dNone, fields\u003dNone):"},{"line_number":442,"context_line":"        if status_code \u003d\u003d requests.codes.ok:"},{"line_number":443,"context_line":"            port_dict \u003d \\"},{"line_number":444,"context_line":"                super(NeutronPluginContrailCoreV2, self)._make_port_dict("},{"line_number":445,"context_line":"                    entry, fields)"},{"line_number":446,"context_line":"            return port_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_603aac37","line":443,"in_reply_to":"1ae5cdf2_8e58d433","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    def _get_port(self, context, id):"},{"line_number":464,"context_line":"        return self._get_resource(\u0027port\u0027, context, id, None)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def _validate_fixed_ips_for_port(self, context, network_id, fixed_ips):"},{"line_number":467,"context_line":"        \"\"\"Test fixed IPs for port."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        Check that configured subnets are valid prior to allocating any"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8ea6140f","line":466,"updated":"2014-06-02 13:00:56.000000000","message":"Break up so it can be unit tested better.","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    def _get_port(self, context, id):"},{"line_number":464,"context_line":"        return self._get_resource(\u0027port\u0027, context, id, None)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def _validate_fixed_ips_for_port(self, context, network_id, fixed_ips):"},{"line_number":467,"context_line":"        \"\"\"Test fixed IPs for port."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        Check that configured subnets are valid prior to allocating any"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4b5cf17e","line":466,"in_reply_to":"1ae5cdf2_8ea6140f","updated":"2014-06-02 23:45:42.000000000","message":"I can take it later along with the Decorators change Nachi suggested","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":807,"context_line":"               \u0027name\u0027: security_group[\u0027name\u0027],"},{"line_number":808,"context_line":"               \u0027tenant_id\u0027: security_group[\u0027tenant_id\u0027],"},{"line_number":809,"context_line":"               \u0027description\u0027: security_group.get(\u0027description\u0027)}"},{"line_number":810,"context_line":"        res[\u0027security_group_rules\u0027] \u003d \\"},{"line_number":811,"context_line":"            [self._make_security_group_rule_dict(r, status_code)"},{"line_number":812,"context_line":"             for r in security_group.get(\u0027rules\u0027, [])]"},{"line_number":813,"context_line":"        return self._fields(res, fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8ef454f3","line":810,"updated":"2014-06-02 13:00:56.000000000","message":"paren vs backslash","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":807,"context_line":"               \u0027name\u0027: security_group[\u0027name\u0027],"},{"line_number":808,"context_line":"               \u0027tenant_id\u0027: security_group[\u0027tenant_id\u0027],"},{"line_number":809,"context_line":"               \u0027description\u0027: security_group.get(\u0027description\u0027)}"},{"line_number":810,"context_line":"        res[\u0027security_group_rules\u0027] \u003d \\"},{"line_number":811,"context_line":"            [self._make_security_group_rule_dict(r, status_code)"},{"line_number":812,"context_line":"             for r in security_group.get(\u0027rules\u0027, [])]"},{"line_number":813,"context_line":"        return self._fields(res, fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_eb1cddc3","line":810,"in_reply_to":"1ae5cdf2_8ef454f3","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d29546cd0802c3a660ee1bb3b4702f8643fb8ecc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class NeutronPluginContrailCoreV2(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":55,"context_line":"                                  securitygroup.SecurityGroupPluginBase,"},{"line_number":56,"context_line":"                                  external_net.External_net):"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_6efeffaf","line":54,"updated":"2014-06-03 12:26:35.000000000","message":"Are there UTs for all the new methods defined here?\n\nSome functions, like _validate_fixed_ips_for_ports() are quite large - as mentioned in the abandoned review, consider breaking up for easier testing of functionality.","commit_id":"bc69cc7cd434fe16450b7936a26603a4fc07e80c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"91846708a9029e29bf52c0ceb6e052a8f5e17f05","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":45,"context_line":"                help\u003d\u0027Enable multi-tenancy support\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":49,"context_line":"               help\u003d\u0027Maximum retries to VNC Server(-1 for no limit)\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_a5929df3","line":46,"updated":"2014-06-05 08:06:19.000000000","message":"I think you want a ListOpt here. Then you will get a list object so you don\u0027t have to manually split on commas.","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"7f61d7a6ba817dfb00f24989a1c79c4fba488b4f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":45,"context_line":"                help\u003d\u0027Enable multi-tenancy support\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027contrail_extensions\u0027, default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":49,"context_line":"               help\u003d\u0027Maximum retries to VNC Server(-1 for no limit)\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_44119fae","line":46,"in_reply_to":"1ae5cdf2_a5929df3","updated":"2014-06-06 17:42:13.000000000","message":"Done","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"91846708a9029e29bf52c0ceb6e052a8f5e17f05","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        contrail_extensions\u003dipam:\u003cclasspath\u003e,policy:\u003cclasspath\u003e"},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        ext_aliases \u003d NeutronPluginContrailCoreV2.supported_extension_aliases"},{"line_number":76,"context_line":"        self._contrail_extensions_class \u003d []"},{"line_number":77,"context_line":"        contrail_exts_conf \u003d cfg.CONF.APISERVER.contrail_extensions"},{"line_number":78,"context_line":"        if contrail_exts_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_a5fb7d45","line":75,"updated":"2014-06-05 08:06:19.000000000","message":"why not self.supported_extension_aliases?","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"7f61d7a6ba817dfb00f24989a1c79c4fba488b4f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        contrail_extensions\u003dipam:\u003cclasspath\u003e,policy:\u003cclasspath\u003e"},{"line_number":73,"context_line":"        \"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        ext_aliases \u003d NeutronPluginContrailCoreV2.supported_extension_aliases"},{"line_number":76,"context_line":"        self._contrail_extensions_class \u003d []"},{"line_number":77,"context_line":"        contrail_exts_conf \u003d cfg.CONF.APISERVER.contrail_extensions"},{"line_number":78,"context_line":"        if contrail_exts_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_64169ba9","line":75,"in_reply_to":"1ae5cdf2_a5fb7d45","updated":"2014-06-06 17:42:13.000000000","message":"Done","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"91846708a9029e29bf52c0ceb6e052a8f5e17f05","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            for supp_ext in supp_exts:"},{"line_number":81,"context_line":"                ext_name, colon, ext_class \u003d supp_ext.partition(\u0027:\u0027)"},{"line_number":82,"context_line":"                if not ext_class:"},{"line_number":83,"context_line":"                    LOG.debug(\u0027Malformed contrail extension...\u0027)"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":"                ext_aliases.append(ext_name)"},{"line_number":86,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_e5666529","line":83,"updated":"2014-06-05 08:06:19.000000000","message":"Shouldn\u0027t this be an error? Seems like something the user would want to be warned about.","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"7f61d7a6ba817dfb00f24989a1c79c4fba488b4f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            for supp_ext in supp_exts:"},{"line_number":81,"context_line":"                ext_name, colon, ext_class \u003d supp_ext.partition(\u0027:\u0027)"},{"line_number":82,"context_line":"                if not ext_class:"},{"line_number":83,"context_line":"                    LOG.debug(\u0027Malformed contrail extension...\u0027)"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":"                ext_aliases.append(ext_name)"},{"line_number":86,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_479a81c6","line":83,"in_reply_to":"1ae5cdf2_e5666529","updated":"2014-06-06 17:42:13.000000000","message":"Done","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"91846708a9029e29bf52c0ceb6e052a8f5e17f05","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    LOG.debug(\u0027Malformed contrail extension...\u0027)"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":"                ext_aliases.append(ext_name)"},{"line_number":86,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"},{"line_number":87,"context_line":"                ext_instance \u003d ext_class()"},{"line_number":88,"context_line":"                ext_instance.set_core(self)"},{"line_number":89,"context_line":"                self._contrail_extensions_class.append(ext_instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_45155947","line":86,"updated":"2014-06-05 08:06:19.000000000","message":"If someone puts a typo in an extension, this will throw an ImportError exception. Do you want to catch it and turn it into a CfgError with a helpful message to explain what they did wrong?","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"7f61d7a6ba817dfb00f24989a1c79c4fba488b4f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    LOG.debug(\u0027Malformed contrail extension...\u0027)"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":"                ext_aliases.append(ext_name)"},{"line_number":86,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"},{"line_number":87,"context_line":"                ext_instance \u003d ext_class()"},{"line_number":88,"context_line":"                ext_instance.set_core(self)"},{"line_number":89,"context_line":"                self._contrail_extensions_class.append(ext_instance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_87a48909","line":86,"in_reply_to":"1ae5cdf2_45155947","updated":"2014-06-06 17:42:13.000000000","message":"Done","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"91846708a9029e29bf52c0ceb6e052a8f5e17f05","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"},{"line_number":87,"context_line":"                ext_instance \u003d ext_class()"},{"line_number":88,"context_line":"                ext_instance.set_core(self)"},{"line_number":89,"context_line":"                self._contrail_extensions_class.append(ext_instance)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":92,"context_line":"        self._max_retries \u003d cfg.CONF.APISERVER.max_retries"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_407c6772","line":89,"updated":"2014-06-05 08:06:19.000000000","message":"maybe this should be _contrail_extensions_instances","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"7f61d7a6ba817dfb00f24989a1c79c4fba488b4f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"},{"line_number":87,"context_line":"                ext_instance \u003d ext_class()"},{"line_number":88,"context_line":"                ext_instance.set_core(self)"},{"line_number":89,"context_line":"                self._contrail_extensions_class.append(ext_instance)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":92,"context_line":"        self._max_retries \u003d cfg.CONF.APISERVER.max_retries"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_a7a985e1","line":89,"in_reply_to":"1ae5cdf2_407c6772","updated":"2014-06-06 17:42:13.000000000","message":"Done","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"91846708a9029e29bf52c0ceb6e052a8f5e17f05","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._parse_class_args()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def __getattr__(self, name):"},{"line_number":101,"context_line":"        for extension_class in self._contrail_extensions_class:"},{"line_number":102,"context_line":"            try:"},{"line_number":103,"context_line":"                return getattr(extension_class, name)"},{"line_number":104,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_80b2ef49","line":101,"updated":"2014-06-05 08:06:19.000000000","message":"What is the expected use of this? It seems fragile. What happens if two extensions have the same attribute? Users then have to worry about order of extensions in the config...","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"7f61d7a6ba817dfb00f24989a1c79c4fba488b4f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._parse_class_args()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def __getattr__(self, name):"},{"line_number":101,"context_line":"        for extension_class in self._contrail_extensions_class:"},{"line_number":102,"context_line":"            try:"},{"line_number":103,"context_line":"                return getattr(extension_class, name)"},{"line_number":104,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_27b57531","line":101,"in_reply_to":"1ae5cdf2_80b2ef49","updated":"2014-06-06 17:42:13.000000000","message":"two extensions won\u0027t have seme attribute","commit_id":"f284c428142706b03585266321afd8db71fe8a28"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b0a3c9d1368da96dbd5fab8d08b6effdbea901ac","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class ContrailNotFoundError(exc.NotFound):"},{"line_number":59,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class ContrailConflictError(exc.Conflict):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_b3162354","line":59,"updated":"2014-06-06 21:14:33.000000000","message":"i18n all the messages. I guess you\u0027re overriding the normal messages, which take additional args.","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"3d160e69f93f0ea1657ee508344e772efef6c82e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class ContrailNotFoundError(exc.NotFound):"},{"line_number":59,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class ContrailConflictError(exc.Conflict):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_f366e6ed","line":59,"in_reply_to":"1ae5cdf2_b3162354","updated":"2014-06-07 01:13:44.000000000","message":"Done","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b0a3c9d1368da96dbd5fab8d08b6effdbea901ac","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                ext_instance.set_core(self)"},{"line_number":125,"context_line":"                self._contrail_extensions_instances.append(ext_instance)"},{"line_number":126,"context_line":"            except Exception:"},{"line_number":127,"context_line":"                LOG.exception()"},{"line_number":128,"context_line":"                raise InvalidContrailExtensionError("},{"line_number":129,"context_line":"                    ext_name\u003dext_name, ext_class\u003dext_class)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_2e19ca79","line":127,"updated":"2014-06-06 21:14:33.000000000","message":"Message for the LOG?\n\nUse neutron.openstack.common.excutils save_and_reraise_exception, when reraising an exception in an exception handler.","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"3d160e69f93f0ea1657ee508344e772efef6c82e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                ext_instance.set_core(self)"},{"line_number":125,"context_line":"                self._contrail_extensions_instances.append(ext_instance)"},{"line_number":126,"context_line":"            except Exception:"},{"line_number":127,"context_line":"                LOG.exception()"},{"line_number":128,"context_line":"                raise InvalidContrailExtensionError("},{"line_number":129,"context_line":"                    ext_name\u003dext_name, ext_class\u003dext_class)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_33612ed4","line":127,"in_reply_to":"1ae5cdf2_2e19ca79","updated":"2014-06-07 01:13:44.000000000","message":"Done","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b0a3c9d1368da96dbd5fab8d08b6effdbea901ac","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                                      res_type, \u0027CREATE\u0027)"},{"line_number":237,"context_line":"        res_dicts \u003d self._transform_response(status_code, info\u003dres_info,"},{"line_number":238,"context_line":"                                             obj_name\u003dres_type)"},{"line_number":239,"context_line":"        LOG.debug(\"create_%s(): %r\", res_type, res_dicts)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        return res_dicts"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_ae807a47","line":239,"updated":"2014-06-06 21:14:33.000000000","message":"For your log messages, if you have more than one parameter for the format string, use named formatters and dict. E.g.\n\n    LOG.debug(\"create %(res_type)s(): %(res_data)r\",\n        {\u0027res_type\u0027: res_type, \u0027res_data\u0027: res_dicts})\n\nCheck all the rest in file.","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"3d160e69f93f0ea1657ee508344e772efef6c82e","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                                      res_type, \u0027CREATE\u0027)"},{"line_number":237,"context_line":"        res_dicts \u003d self._transform_response(status_code, info\u003dres_info,"},{"line_number":238,"context_line":"                                             obj_name\u003dres_type)"},{"line_number":239,"context_line":"        LOG.debug(\"create_%s(): %r\", res_type, res_dicts)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        return res_dicts"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_535eba13","line":239,"in_reply_to":"1ae5cdf2_ae807a47","updated":"2014-06-07 01:13:44.000000000","message":"Done","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b0a3c9d1368da96dbd5fab8d08b6effdbea901ac","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        for subnet in subnet_list:"},{"line_number":366,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"},{"line_number":367,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":368,"context_line":"                err_msg \u003d (_(\"Requested subnet with cidr: %(cidr)s for \""},{"line_number":369,"context_line":"                             \"network: %(network_id)s overlaps with another \""},{"line_number":370,"context_line":"                             \"subnet\") %"},{"line_number":371,"context_line":"                           {\u0027cidr\u0027: new_subnet_cidr,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_8ec9feae","line":368,"updated":"2014-06-06 21:14:33.000000000","message":"Just a nit: Maybe move this down to right before the exception is raised so that we know it goes together.  I like the comment to explain why there are two messages.","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"3d160e69f93f0ea1657ee508344e772efef6c82e","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        for subnet in subnet_list:"},{"line_number":366,"context_line":"            if (netaddr.IPSet([subnet[\u0027cidr\u0027]]) \u0026 new_subnet_ipset):"},{"line_number":367,"context_line":"                # don\u0027t give out details of the overlapping subnet"},{"line_number":368,"context_line":"                err_msg \u003d (_(\"Requested subnet with cidr: %(cidr)s for \""},{"line_number":369,"context_line":"                             \"network: %(network_id)s overlaps with another \""},{"line_number":370,"context_line":"                             \"subnet\") %"},{"line_number":371,"context_line":"                           {\u0027cidr\u0027: new_subnet_cidr,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_739ad6c6","line":368,"in_reply_to":"1ae5cdf2_8ec9feae","updated":"2014-06-07 01:13:44.000000000","message":"Done","commit_id":"4cc79cc3298d5177094ec5c849fbe29a71fbc239"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9bb229b5f2a88e64b2e6285a7aaca71b827f1256","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        \"\"\"Creates a port on the specified Virtual Network.\"\"\""},{"line_number":574,"context_line":"        port_in \u003d port[\u0027port\u0027]"},{"line_number":575,"context_line":"        network_id \u003d port_in[\u0027network_id\u0027]"},{"line_number":576,"context_line":"        if port_in.get(\u0027security_groups\u0027) \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":577,"context_line":"            del port_in[\u0027security_groups\u0027]"},{"line_number":578,"context_line":"        for key, value in port_in.items():"},{"line_number":579,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_b7942fe9","line":576,"updated":"2014-06-09 11:17:06.000000000","message":"Just curious, in this latest updated, why is security group entry deleted, if not set, whereas rest are just set to None?","commit_id":"662f8861298b9d9df7eb7df7ee7655b1dcab28d5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d\u0027Enable multi-tenancy support\u0027),"},{"line_number":48,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":49,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_9018fd85","line":46,"updated":"2014-06-10 02:48:10.000000000","message":"how about use True as the default value?","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d\u0027Enable multi-tenancy support\u0027),"},{"line_number":48,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":49,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_cb457316","line":46,"in_reply_to":"1ae5cdf2_9018fd85","updated":"2014-06-11 04:37:42.000000000","message":"Done","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                  external_net.External_net):"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"router\","},{"line_number":98,"context_line":"                                   \"port-security\", \"binding\", \"agent\","},{"line_number":99,"context_line":"                                   \"quotas\", \"external-net\"]"},{"line_number":100,"context_line":"    _args \u003d None"},{"line_number":101,"context_line":"    PLUGIN_URL_PREFIX \u003d \u0027/neutron\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_ab982c1c","line":98,"updated":"2014-06-10 02:48:10.000000000","message":"do we support agent extension?","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                  external_net.External_net):"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"router\","},{"line_number":98,"context_line":"                                   \"port-security\", \"binding\", \"agent\","},{"line_number":99,"context_line":"                                   \"quotas\", \"external-net\"]"},{"line_number":100,"context_line":"    _args \u003d None"},{"line_number":101,"context_line":"    PLUGIN_URL_PREFIX \u003d \u0027/neutron\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_6b7c5f73","line":98,"in_reply_to":"1ae5cdf2_ab982c1c","updated":"2014-06-11 04:37:42.000000000","message":"This was added for horizon, else it will throw an error.","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":134,"context_line":"        self._max_retries \u003d cfg.CONF.APISERVER.max_retries"},{"line_number":135,"context_line":"        self._retry_interval \u003d cfg.CONF.APISERVER.retry_interval"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def __init__(self):"},{"line_number":138,"context_line":"        super(NeutronPluginContrailCoreV2, self).__init__()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_abf10c6c","line":135,"updated":"2014-06-10 02:48:10.000000000","message":"I cannot see the codes where these configuration options are used.","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self._multi_tenancy \u003d cfg.CONF.APISERVER.multi_tenancy"},{"line_number":134,"context_line":"        self._max_retries \u003d cfg.CONF.APISERVER.max_retries"},{"line_number":135,"context_line":"        self._retry_interval \u003d cfg.CONF.APISERVER.retry_interval"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def __init__(self):"},{"line_number":138,"context_line":"        super(NeutronPluginContrailCoreV2, self).__init__()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_ab958789","line":135,"in_reply_to":"1ae5cdf2_abf10c6c","updated":"2014-06-11 04:37:42.000000000","message":"I will remove them","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        fips_count \u003d self._count_resource(\u0027floatingip\u0027, context, filters)"},{"line_number":758,"context_line":"        return fips_count[\u0027count\u0027]"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def plug_interface(self, tenant_id, net_id, port_id, remote_interface_id):"},{"line_number":761,"context_line":"        \"\"\"Plug an interface."},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        Attaches a remote interface to the specified port on the"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_e60c2b3e","line":760,"updated":"2014-06-10 02:48:10.000000000","message":"where is it called?","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        fips_count \u003d self._count_resource(\u0027floatingip\u0027, context, filters)"},{"line_number":758,"context_line":"        return fips_count[\u0027count\u0027]"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def plug_interface(self, tenant_id, net_id, port_id, remote_interface_id):"},{"line_number":761,"context_line":"        \"\"\"Plug an interface."},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        Attaches a remote interface to the specified port on the"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_cbbe5300","line":760,"in_reply_to":"1ae5cdf2_e60c2b3e","updated":"2014-06-11 04:37:42.000000000","message":"Will remove it","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        if port[\u0027interface_id\u0027]:"},{"line_number":772,"context_line":"            raise exc.PortInUse(net_id\u003dnet_id, port_id\u003dport_id,"},{"line_number":773,"context_line":"                                att_id\u003dport[\u0027interface_id\u0027])"},{"line_number":774,"context_line":"        db.port_set_attachment(port_id, net_id, remote_interface_id)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def unplug_interface(self, tenant_id, net_id, port_id):"},{"line_number":777,"context_line":"        \"\"\"Unplug an interface."}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_4634ffdd","line":774,"updated":"2014-06-10 02:48:10.000000000","message":"do we still need db on neutron server node? I think we are using neutron server as an API proxy only. all state are stored in VNC sides.","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        if port[\u0027interface_id\u0027]:"},{"line_number":772,"context_line":"            raise exc.PortInUse(net_id\u003dnet_id, port_id\u003dport_id,"},{"line_number":773,"context_line":"                                att_id\u003dport[\u0027interface_id\u0027])"},{"line_number":774,"context_line":"        db.port_set_attachment(port_id, net_id, remote_interface_id)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def unplug_interface(self, tenant_id, net_id, port_id):"},{"line_number":777,"context_line":"        \"\"\"Unplug an interface."}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_4b3a4399","line":774,"in_reply_to":"1ae5cdf2_4634ffdd","updated":"2014-06-11 04:37:42.000000000","message":"Will be removed","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                                att_id\u003dport[\u0027interface_id\u0027])"},{"line_number":774,"context_line":"        db.port_set_attachment(port_id, net_id, remote_interface_id)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def unplug_interface(self, tenant_id, net_id, port_id):"},{"line_number":777,"context_line":"        \"\"\"Unplug an interface."},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        Detaches a remote interface from the specified port on the"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_662f3b89","line":776,"updated":"2014-06-10 02:48:10.000000000","message":"the same as plug_interface.","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                                att_id\u003dport[\u0027interface_id\u0027])"},{"line_number":774,"context_line":"        db.port_set_attachment(port_id, net_id, remote_interface_id)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def unplug_interface(self, tenant_id, net_id, port_id):"},{"line_number":777,"context_line":"        \"\"\"Unplug an interface."},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        Detaches a remote interface from the specified port on the"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_6b41bf0a","line":776,"in_reply_to":"1ae5cdf2_662f3b89","updated":"2014-06-11 04:37:42.000000000","message":"Will remove it","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        e.__class__.__name__ \u003d str(info[\u0027type\u0027])"},{"line_number":230,"context_line":"        raise e"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _create_resource(self, res_type, context, res_data):"},{"line_number":233,"context_line":"        res_dict \u003d self._encode_resource(resource\u003dres_data[res_type])"},{"line_number":234,"context_line":"        status_code, res_info \u003d self._request_backend(context, res_dict,"},{"line_number":235,"context_line":"                                                      res_type, \u0027CREATE\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_9189ac28","line":232,"updated":"2014-06-11 05:50:46.000000000","message":"please add a comment to these helping functions to enable what exactly they do.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        e.__class__.__name__ \u003d str(info[\u0027type\u0027])"},{"line_number":230,"context_line":"        raise e"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _create_resource(self, res_type, context, res_data):"},{"line_number":233,"context_line":"        res_dict \u003d self._encode_resource(resource\u003dres_data[res_type])"},{"line_number":234,"context_line":"        status_code, res_info \u003d self._request_backend(context, res_dict,"},{"line_number":235,"context_line":"                                                      res_type, \u0027CREATE\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_31b7e6f6","line":232,"in_reply_to":"1ae5cdf2_9189ac28","updated":"2014-06-11 19:05:39.000000000","message":"Done","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def create_network(self, context, network):"},{"line_number":301,"context_line":"        \"\"\"Creates a new Virtual Network.\"\"\""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if network[\u0027network\u0027][\u0027router:external\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":304,"context_line":"            del network[\u0027network\u0027][\u0027router:external\u0027]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        for key, value in network[\u0027network\u0027].items():"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_317a9824","line":303,"updated":"2014-06-11 05:50:46.000000000","message":"you may add a log message here to showcase, the reason for network delete.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def create_network(self, context, network):"},{"line_number":301,"context_line":"        \"\"\"Creates a new Virtual Network.\"\"\""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if network[\u0027network\u0027][\u0027router:external\u0027] \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":304,"context_line":"            del network[\u0027network\u0027][\u0027router:external\u0027]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        for key, value in network[\u0027network\u0027].items():"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_310fe689","line":303,"in_reply_to":"1ae5cdf2_317a9824","updated":"2014-06-11 19:05:39.000000000","message":"this del is not really needed, I will remove it.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        return new_ips, prev_ips"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def create_port(self, context, port):"},{"line_number":570,"context_line":"        \"\"\"Creates a port on the specified Virtual Network.\"\"\""},{"line_number":571,"context_line":"        port_in \u003d port[\u0027port\u0027]"},{"line_number":572,"context_line":"        network_id \u003d port_in[\u0027network_id\u0027]"},{"line_number":573,"context_line":"        for key, value in port_in.items():"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_31c8d854","line":570,"updated":"2014-06-11 05:50:46.000000000","message":"you might require a \u003center\u003e here after the def comment. all other functions have the same.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        return new_ips, prev_ips"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def create_port(self, context, port):"},{"line_number":570,"context_line":"        \"\"\"Creates a port on the specified Virtual Network.\"\"\""},{"line_number":571,"context_line":"        port_in \u003d port[\u0027port\u0027]"},{"line_number":572,"context_line":"        network_id \u003d port_in[\u0027network_id\u0027]"},{"line_number":573,"context_line":"        for key, value in port_in.items():"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_713faeb4","line":570,"in_reply_to":"1ae5cdf2_31c8d854","updated":"2014-06-11 19:05:39.000000000","message":"Done","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        return self._fields(res, fields)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def create_security_group(self, context, security_group):"},{"line_number":781,"context_line":"        \"\"\"Creates a Security Group.\"\"\""},{"line_number":782,"context_line":"        return self._create_resource(\u0027security_group\u0027, context,"},{"line_number":783,"context_line":"                                     security_group)"},{"line_number":784,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_d1e414e2","line":781,"updated":"2014-06-11 05:50:46.000000000","message":"\u003center\u003e required","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"4806cff50b3f547ff45a9f436a3603fbbe290239","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        return self._fields(res, fields)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def create_security_group(self, context, security_group):"},{"line_number":781,"context_line":"        \"\"\"Creates a Security Group.\"\"\""},{"line_number":782,"context_line":"        return self._create_resource(\u0027security_group\u0027, context,"},{"line_number":783,"context_line":"                                     security_group)"},{"line_number":784,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_e9f58583","line":781,"in_reply_to":"1ae5cdf2_26396ef2","updated":"2014-06-12 00:56:29.000000000","message":"I don\u0027t think so. see db_plugin code","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        return self._fields(res, fields)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def create_security_group(self, context, security_group):"},{"line_number":781,"context_line":"        \"\"\"Creates a Security Group.\"\"\""},{"line_number":782,"context_line":"        return self._create_resource(\u0027security_group\u0027, context,"},{"line_number":783,"context_line":"                                     security_group)"},{"line_number":784,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_26396ef2","line":781,"in_reply_to":"1ae5cdf2_d1e414e2","updated":"2014-06-11 19:05:39.000000000","message":"Done","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":807,"context_line":"                                   filters, fields)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    def create_security_group_rule(self, context, security_group_rule):"},{"line_number":810,"context_line":"        \"\"\"Creates a security group rule.\"\"\""},{"line_number":811,"context_line":"        rule \u003d security_group_rule.get(\u0027security_group_rule\u0027)"},{"line_number":812,"context_line":"        self._validate_port_range(rule)"},{"line_number":813,"context_line":"        self._validate_ip_prefix(rule)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_11d2fcff","line":810,"updated":"2014-06-11 05:50:46.000000000","message":"enter required","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":807,"context_line":"                                   filters, fields)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    def create_security_group_rule(self, context, security_group_rule):"},{"line_number":810,"context_line":"        \"\"\"Creates a security group rule.\"\"\""},{"line_number":811,"context_line":"        rule \u003d security_group_rule.get(\u0027security_group_rule\u0027)"},{"line_number":812,"context_line":"        self._validate_port_range(rule)"},{"line_number":813,"context_line":"        self._validate_ip_prefix(rule)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_513b92d0","line":810,"in_reply_to":"1ae5cdf2_11d2fcff","updated":"2014-06-11 19:05:39.000000000","message":"Done","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ce7a64aba7f550b2de5c277804091c341ae388d4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dTrue,"},{"line_number":46,"context_line":"                help\u003d\u0027Enable multi-tenancy support\u0027),"},{"line_number":47,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":48,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_daa4c0a7","line":45,"updated":"2014-06-13 21:59:44.000000000","message":"This config looks like not used anywhere","commit_id":"61befa308c7381fb2b1ddd4c26e72eee8d51ea97"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ec727a7c55feaa918308ff0f858d2cde839c7a89","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027multi_tenancy\u0027, default\u003dTrue,"},{"line_number":46,"context_line":"                help\u003d\u0027Enable multi-tenancy support\u0027),"},{"line_number":47,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":48,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_dad200ff","line":45,"in_reply_to":"1ae5cdf2_daa4c0a7","updated":"2014-06-13 22:27:44.000000000","message":"will remove it.","commit_id":"61befa308c7381fb2b1ddd4c26e72eee8d51ea97"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ce7a64aba7f550b2de5c277804091c341ae388d4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":48,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":50,"context_line":"               help\u003d\u0027Maximum retries to VNC Server(-1 for no limit)\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d\u0027Retry Interval in seconds to connect to VNC Server\u0027),"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_1aab8875","line":50,"updated":"2014-06-13 21:59:44.000000000","message":"This is not used","commit_id":"61befa308c7381fb2b1ddd4c26e72eee8d51ea97"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ec727a7c55feaa918308ff0f858d2cde839c7a89","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"},{"line_number":48,"context_line":"                help\u003d\u0027Enable Contrail extensions(policy, ipam)\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":50,"context_line":"               help\u003d\u0027Maximum retries to VNC Server(-1 for no limit)\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d\u0027Retry Interval in seconds to connect to VNC Server\u0027),"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_facdfc5d","line":50,"in_reply_to":"1ae5cdf2_1aab8875","updated":"2014-06-13 22:27:44.000000000","message":"will remove it","commit_id":"61befa308c7381fb2b1ddd4c26e72eee8d51ea97"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"ce7a64aba7f550b2de5c277804091c341ae388d4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":50,"context_line":"               help\u003d\u0027Maximum retries to VNC Server(-1 for no limit)\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d\u0027Retry Interval in seconds to connect to VNC Server\u0027),"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_7abbacc3","line":52,"updated":"2014-06-13 21:59:44.000000000","message":"This is not used","commit_id":"61befa308c7381fb2b1ddd4c26e72eee8d51ea97"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ec727a7c55feaa918308ff0f858d2cde839c7a89","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.IntOpt(\u0027max_retries\u0027, default\u003d-1,"},{"line_number":50,"context_line":"               help\u003d\u0027Maximum retries to VNC Server(-1 for no limit)\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry_interval\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d\u0027Retry Interval in seconds to connect to VNC Server\u0027),"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_1ad9c821","line":52,"in_reply_to":"1ae5cdf2_7abbacc3","updated":"2014-06-13 22:27:44.000000000","message":"will remove it","commit_id":"61befa308c7381fb2b1ddd4c26e72eee8d51ea97"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        binding \u003d {"},{"line_number":135,"context_line":"            portbindings.VIF_TYPE: portbindings.VIF_TYPE_VROUTER,"},{"line_number":136,"context_line":"            portbindings.VIF_DETAILS: {"},{"line_number":137,"context_line":"                # TODO(rkukura): Replace with new VIF security details"},{"line_number":138,"context_line":"                portbindings.CAP_PORT_FILTER:"},{"line_number":139,"context_line":"                \u0027security-group\u0027 in self.supported_extension_aliases"},{"line_number":140,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_c83dd5bc","line":137,"updated":"2014-06-14 08:30:00.000000000","message":"rkukura?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        binding \u003d {"},{"line_number":135,"context_line":"            portbindings.VIF_TYPE: portbindings.VIF_TYPE_VROUTER,"},{"line_number":136,"context_line":"            portbindings.VIF_DETAILS: {"},{"line_number":137,"context_line":"                # TODO(rkukura): Replace with new VIF security details"},{"line_number":138,"context_line":"                portbindings.CAP_PORT_FILTER:"},{"line_number":139,"context_line":"                \u0027security-group\u0027 in self.supported_extension_aliases"},{"line_number":140,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_02ea39d7","line":137,"in_reply_to":"1ae5cdf2_c83dd5bc","updated":"2014-06-14 22:41:47.000000000","message":"will fix it.","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def __getattr__(self, name):"},{"line_number":145,"context_line":"        # We design contrail extensions by contract of which"},{"line_number":146,"context_line":"        # the class only have proper method for target extension"},{"line_number":147,"context_line":"        for extension_class in self._contrail_extensions_instances:"},{"line_number":148,"context_line":"            try:"},{"line_number":149,"context_line":"                return getattr(extension_class, name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_c864f5e6","line":146,"updated":"2014-06-14 08:30:00.000000000","message":"I am having a tough time understanding this doc string, may be its just me.","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def __getattr__(self, name):"},{"line_number":145,"context_line":"        # We design contrail extensions by contract of which"},{"line_number":146,"context_line":"        # the class only have proper method for target extension"},{"line_number":147,"context_line":"        for extension_class in self._contrail_extensions_instances:"},{"line_number":148,"context_line":"            try:"},{"line_number":149,"context_line":"                return getattr(extension_class, name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_82b569ee","line":146,"in_reply_to":"1ae5cdf2_c864f5e6","updated":"2014-06-14 22:41:47.000000000","message":"Yeah even I feel the doc string is confusing. What we mean is that no two extensions will have the same method name. Will fix it","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        raise AttributeError()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":156,"context_line":"        return []"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _request_api_server(self, url, data\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_68a3e1ff","line":155,"updated":"2014-06-14 08:30:00.000000000","message":"where is this being used?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        raise AttributeError()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":156,"context_line":"        return []"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _request_api_server(self, url, data\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_e2c1cd2f","line":155,"in_reply_to":"1ae5cdf2_68a3e1ff","updated":"2014-06-14 22:41:47.000000000","message":"The same comment came before. We added it because horizon throws a failure if it is not implemented.","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        for key, value in network[\u0027network\u0027].items():"},{"line_number":317,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":318,"context_line":"                network[\u0027network\u0027][key] \u003d None"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        return self._create_resource(\u0027network\u0027, context, network)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_a8dec96a","line":318,"updated":"2014-06-14 08:30:00.000000000","message":"You are essentially setting the unspecified attributes to None here. However, this block of code is repeated for every resource; can it be potentially factored into the _create_resource() method (since you are passing the resource name anyway)?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        for key, value in network[\u0027network\u0027].items():"},{"line_number":317,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":318,"context_line":"                network[\u0027network\u0027][key] \u003d None"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        return self._create_resource(\u0027network\u0027, context, network)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_658067f7","line":318,"in_reply_to":"1ae5cdf2_a8dec96a","updated":"2014-06-14 22:41:47.000000000","message":"Good point, it would prevent duplicate code. Will fix it","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        return all_subnets"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":367,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_c8d95584","line":366,"updated":"2014-06-14 08:30:00.000000000","message":"how is this different from the implementation in the base class?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        return all_subnets"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":367,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_6233fd61","line":366,"in_reply_to":"1ae5cdf2_c8d95584","updated":"2014-06-14 22:41:47.000000000","message":"Base class has db related code. Opencontrail doesn\u0027t use db","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            NeutronPluginContrailCoreV2,"},{"line_number":402,"context_line":"            self)._make_subnet_dict(subnet, fields)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":405,"context_line":"        \"\"\"Creates a new subnet, and assigns it a symbolic name.\"\"\""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_08e09d24","line":404,"updated":"2014-06-14 08:30:00.000000000","message":"Any particular reason that you are overriding and not using the base class implementation here?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            NeutronPluginContrailCoreV2,"},{"line_number":402,"context_line":"            self)._make_subnet_dict(subnet, fields)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":405,"context_line":"        \"\"\"Creates a new subnet, and assigns it a symbolic name.\"\"\""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_db55981e","line":404,"in_reply_to":"1ae5cdf2_08e09d24","updated":"2014-06-14 22:41:47.000000000","message":"Base class has db related code. Opencontrail doesn\u0027t use db","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    def _get_port(self, context, id, fields\u003dNone):"},{"line_number":490,"context_line":"        return self._get_resource(\u0027port\u0027, context, id, fields)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def _validate_fixed_ips_for_port(self, context, network_id, fixed_ips):"},{"line_number":493,"context_line":"        \"\"\"Test fixed IPs for port."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        Check that configured subnets are valid prior to allocating any"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_68c841a8","line":492,"updated":"2014-06-14 08:30:00.000000000","message":"how is this different from _test_fixed_ips_for_port() in the base class?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    def _get_port(self, context, id, fields\u003dNone):"},{"line_number":490,"context_line":"        return self._get_resource(\u0027port\u0027, context, id, fields)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def _validate_fixed_ips_for_port(self, context, network_id, fixed_ips):"},{"line_number":493,"context_line":"        \"\"\"Test fixed IPs for port."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        Check that configured subnets are valid prior to allocating any"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_0589636e","line":492,"in_reply_to":"1ae5cdf2_68c841a8","updated":"2014-06-14 22:41:47.000000000","message":"ok, I  will use the one from base class.","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        return fips_count[\u0027count\u0027]"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # Security Group handlers"},{"line_number":769,"context_line":"    def _make_security_group_rule_dict(self, security_group_rule, fields\u003dNone):"},{"line_number":770,"context_line":"        res \u003d {\u0027id\u0027: security_group_rule[\u0027id\u0027],"},{"line_number":771,"context_line":"               \u0027tenant_id\u0027: security_group_rule[\u0027tenant_id\u0027],"},{"line_number":772,"context_line":"               \u0027security_group_id\u0027: security_group_rule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_c8c0757e","line":769,"updated":"2014-06-14 08:30:00.000000000","message":"why not use the base class implementation?","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        return fips_count[\u0027count\u0027]"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    # Security Group handlers"},{"line_number":769,"context_line":"    def _make_security_group_rule_dict(self, security_group_rule, fields\u003dNone):"},{"line_number":770,"context_line":"        res \u003d {\u0027id\u0027: security_group_rule[\u0027id\u0027],"},{"line_number":771,"context_line":"               \u0027tenant_id\u0027: security_group_rule[\u0027tenant_id\u0027],"},{"line_number":772,"context_line":"               \u0027security_group_id\u0027: security_group_rule[\u0027security_group_id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_421d2172","line":769,"in_reply_to":"1ae5cdf2_c8c0757e","updated":"2014-06-14 22:41:47.000000000","message":"yeah I could use the base class implementation here, will fix.","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fac34f6c57b8c1d2bb86d34e18f4e1cb4fff8cb0","unresolved":false,"context_lines":[{"line_number":779,"context_line":"               \u0027remote_group_id\u0027: security_group_rule[\u0027remote_group_id\u0027]}"},{"line_number":780,"context_line":"        return self._fields(res, fields)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def _make_security_group_dict(self, security_group, fields\u003dNone):"},{"line_number":783,"context_line":"        res \u003d {\u0027id\u0027: security_group[\u0027id\u0027],"},{"line_number":784,"context_line":"               \u0027name\u0027: security_group[\u0027name\u0027],"},{"line_number":785,"context_line":"               \u0027tenant_id\u0027: security_group[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_08b7bd21","line":782,"updated":"2014-06-14 08:30:00.000000000","message":"ditto","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"20890ccbedea02576da82ab8e101634a9cfd959b","unresolved":false,"context_lines":[{"line_number":779,"context_line":"               \u0027remote_group_id\u0027: security_group_rule[\u0027remote_group_id\u0027]}"},{"line_number":780,"context_line":"        return self._fields(res, fields)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def _make_security_group_dict(self, security_group, fields\u003dNone):"},{"line_number":783,"context_line":"        res \u003d {\u0027id\u0027: security_group[\u0027id\u0027],"},{"line_number":784,"context_line":"               \u0027name\u0027: security_group[\u0027name\u0027],"},{"line_number":785,"context_line":"               \u0027tenant_id\u0027: security_group[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_e22c6dae","line":782,"in_reply_to":"1ae5cdf2_08b7bd21","updated":"2014-06-14 22:41:47.000000000","message":"Base class has db related code. Opencontrail doesn\u0027t use db","commit_id":"97c87ab87e510200ff05835dfbfc77cac6744588"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bcd4ba704bf86498081eed8c18b830287269dc78","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def __getattr__(self, name):"},{"line_number":145,"context_line":"        # Each contrail extension is designed to have a unique method"},{"line_number":146,"context_line":"        # for the target extension. No two extensions will have the"},{"line_number":147,"context_line":"        # the name method name."},{"line_number":148,"context_line":"        for extension_class in self._contrail_extensions_instances:"},{"line_number":149,"context_line":"            try:"},{"line_number":150,"context_line":"                return getattr(extension_class, name)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_0ffed5ae","line":147,"range":{"start_line":147,"start_character":10,"end_line":147,"end_character":13},"updated":"2014-06-16 02:14:17.000000000","message":"the the?","commit_id":"7e02d4dcab46e0a2cf7e9b0164c228e132bbf72f"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ba3629ea9f4743d82b4d3b58bd6c300c3903c2d3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def __getattr__(self, name):"},{"line_number":145,"context_line":"        # Each contrail extension is designed to have a unique method"},{"line_number":146,"context_line":"        # for the target extension. No two extensions will have the"},{"line_number":147,"context_line":"        # the name method name."},{"line_number":148,"context_line":"        for extension_class in self._contrail_extensions_instances:"},{"line_number":149,"context_line":"            try:"},{"line_number":150,"context_line":"                return getattr(extension_class, name)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_ca6cdba0","line":147,"in_reply_to":"1ae5cdf2_0ffed5ae","updated":"2014-06-16 20:47:58.000000000","message":"Done","commit_id":"7e02d4dcab46e0a2cf7e9b0164c228e132bbf72f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59c93bf63a22af9657090999bfd4f2e7d9d5bd19","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return all_subnets"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":368,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_2771f544","line":367,"updated":"2014-06-16 07:09:26.000000000","message":"Correct me if I\u0027m wrong, but the only difference in this method is the expected format of the network parameter.\n\nput this somewhere up top:\n\nclass Assignable(object):\n    pass\n    \n\nthen you can change this method to:\n\ndef _validate_subnet_cidr(self, context, network, new_subnet_cidr):\n    net \u003d Assignable()\n    net.subnets \u003d [self._get_subnet(context, id) for id in network[\u0027subnets\u0027]]\n    super(NeutronPluginContrailCoreV2,\n          self)._validate_subnet_cidr(context, net, new_subnet_cidr)\n\n\nThe other alternative is that this method could then be eliminated completely if the return from get_network were an object with the subnets attribute already available (maybe an @property method that looks up the subnets when accessed).","commit_id":"7e02d4dcab46e0a2cf7e9b0164c228e132bbf72f"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ba3629ea9f4743d82b4d3b58bd6c300c3903c2d3","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return all_subnets"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":368,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_015e8576","line":367,"in_reply_to":"1ae5cdf2_2771f544","updated":"2014-06-16 20:47:58.000000000","message":"The functions needs more subnet parameter too in object format. \nI will convert dict into an object that provides attribute access to values","commit_id":"7e02d4dcab46e0a2cf7e9b0164c228e132bbf72f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bcd4ba704bf86498081eed8c18b830287269dc78","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"},{"line_number":371,"context_line":"        for the other subnets specified for this network, or with any other"},{"line_number":372,"context_line":"        CIDR if overlapping IPs are disabled."},{"line_number":373,"context_line":"        \"\"\""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        new_subnet_ipset \u003d netaddr.IPSet([new_subnet_cidr])"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_2f0391bf","line":372,"updated":"2014-06-16 02:14:17.000000000","message":"is it difficult to refactor the base class so that its corresponding method can be used here?","commit_id":"7e02d4dcab46e0a2cf7e9b0164c228e132bbf72f"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ba3629ea9f4743d82b4d3b58bd6c300c3903c2d3","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"},{"line_number":371,"context_line":"        for the other subnets specified for this network, or with any other"},{"line_number":372,"context_line":"        CIDR if overlapping IPs are disabled."},{"line_number":373,"context_line":"        \"\"\""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        new_subnet_ipset \u003d netaddr.IPSet([new_subnet_cidr])"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_8a12d307","line":372,"in_reply_to":"1ae5cdf2_2f0391bf","updated":"2014-06-16 20:47:58.000000000","message":"I will convert dict into an object that provides attribute access to values.\nThen we can use the base class method.","commit_id":"7e02d4dcab46e0a2cf7e9b0164c228e132bbf72f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b8c842ea296c9bffd7b41fdaa4f77b00d6a5868d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        except KeyError as e:"},{"line_number":86,"context_line":"            raise AttributeError(e)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __setattr__(self, name, value):"},{"line_number":89,"context_line":"        self[name] \u003d value"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __delattr__(self, name):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_37873fb8","line":88,"updated":"2014-06-16 21:40:49.000000000","message":"Is this needed?","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"5cc6cd19ccaaa600d24e1e18b4a1c3c4d2619f48","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        except KeyError as e:"},{"line_number":86,"context_line":"            raise AttributeError(e)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __setattr__(self, name, value):"},{"line_number":89,"context_line":"        self[name] \u003d value"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __delattr__(self, name):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_6d49f85f","line":88,"in_reply_to":"1ae5cdf2_37873fb8","updated":"2014-06-16 22:07:50.000000000","message":"it will be needed if we update the dict. Will remove it for now.","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b8c842ea296c9bffd7b41fdaa4f77b00d6a5868d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def __setattr__(self, name, value):"},{"line_number":89,"context_line":"        self[name] \u003d value"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __delattr__(self, name):"},{"line_number":92,"context_line":"        del self[name]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_7791c7f0","line":91,"updated":"2014-06-16 21:40:49.000000000","message":"Is this needed?","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"5cc6cd19ccaaa600d24e1e18b4a1c3c4d2619f48","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def __setattr__(self, name, value):"},{"line_number":89,"context_line":"        self[name] \u003d value"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __delattr__(self, name):"},{"line_number":92,"context_line":"        del self[name]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_4d635cdd","line":91,"in_reply_to":"1ae5cdf2_7791c7f0","updated":"2014-06-16 22:07:50.000000000","message":"Will remove it","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b8c842ea296c9bffd7b41fdaa4f77b00d6a5868d","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return all_subnets"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":387,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_37757fcc","line":386,"updated":"2014-06-16 21:40:49.000000000","message":"I thought we are trying to use base class method, right?","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"26c87b2cd90631e35426b36373aebeac4099ffbb","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return all_subnets"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":387,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_0d24f4ad","line":386,"in_reply_to":"1ae5cdf2_37757fcc","updated":"2014-06-16 22:05:48.000000000","message":"+1\n\nlooking at timestamps, i guess he\u0027s still working on it.","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"5cc6cd19ccaaa600d24e1e18b4a1c3c4d2619f48","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return all_subnets"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _validate_subnet_cidr(self, context, network, new_subnet_cidr):"},{"line_number":387,"context_line":"        \"\"\"Validate the CIDR for a subnet."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        Verifies the specified CIDR does not overlap with the ones defined"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ae5cdf2_cd9e8cb8","line":386,"in_reply_to":"1ae5cdf2_37757fcc","updated":"2014-06-16 22:07:50.000000000","message":"Missed it. Will remove it.","commit_id":"61a0e2b31f46f6fd8143d60709d4af8fa69b9128"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    message \u003d _(\"Invalid Contrail Extension: %(ext_name) %(ext_class)\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ContrailModel(dict):"},{"line_number":77,"context_line":"    \"\"\"Convert dict into an object that provides attribute access to values.\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_4bc97fab","line":76,"updated":"2014-06-17 03:13:50.000000000","message":"This is essentially DictModel from the the DHCP agent.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    message \u003d _(\"Invalid Contrail Extension: %(ext_name) %(ext_class)\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ContrailModel(dict):"},{"line_number":77,"context_line":"    \"\"\"Convert dict into an object that provides attribute access to values.\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_2b9dfc57","line":76,"in_reply_to":"1ae5cdf2_4bc97fab","updated":"2014-06-17 22:40:45.000000000","message":"yes it is, but we don\u0027t want to use models in dhcp code. We can make it move to util if you want, but it should be separated refactoring patch","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"CONTRAIL_EXCEPTION_MAP \u003d {"},{"line_number":93,"context_line":"    webob.exc.HTTPNotFound.code: ContrailNotFoundError,"},{"line_number":94,"context_line":"    webob.exc.HTTPConflict.code: ContrailConflictError,"},{"line_number":95,"context_line":"    webob.exc.HTTPBadRequest.code: ContrailBadRequestError,"},{"line_number":96,"context_line":"    webob.exc.HTTPServiceUnavailable.code: ContrailServiceUnavaiableError,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_cb6aef80","line":93,"updated":"2014-06-17 03:13:50.000000000","message":"You should use the request status code and not the ones from webob.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"CONTRAIL_EXCEPTION_MAP \u003d {"},{"line_number":93,"context_line":"    webob.exc.HTTPNotFound.code: ContrailNotFoundError,"},{"line_number":94,"context_line":"    webob.exc.HTTPConflict.code: ContrailConflictError,"},{"line_number":95,"context_line":"    webob.exc.HTTPBadRequest.code: ContrailBadRequestError,"},{"line_number":96,"context_line":"    webob.exc.HTTPServiceUnavailable.code: ContrailServiceUnavaiableError,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_cbe738ab","line":93,"in_reply_to":"1ae5cdf2_cb6aef80","updated":"2014-06-17 22:40:45.000000000","message":"yes I will do that","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class NeutronPluginContrailCoreV2(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":102,"context_line":"                                  securitygroups_db.SecurityGroupDbMixin,"},{"line_number":103,"context_line":"                                  portbindings_base.PortBindingBaseMixin,"},{"line_number":104,"context_line":"                                  external_net.External_net):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_cbc2ef33","line":101,"updated":"2014-06-17 03:13:50.000000000","message":"You are importing the database backed implementation, but never invoking the super() versions of the methods (and not saving anything into the configured database).  This class should be used as a parent if you\u0027re not using the database.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"64c37d21d7c7fd582c32d7df90c3f74f8fe1082a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class NeutronPluginContrailCoreV2(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":102,"context_line":"                                  securitygroups_db.SecurityGroupDbMixin,"},{"line_number":103,"context_line":"                                  portbindings_base.PortBindingBaseMixin,"},{"line_number":104,"context_line":"                                  external_net.External_net):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_00017f04","line":101,"in_reply_to":"1ae5cdf2_a6286386","updated":"2014-06-20 01:06:06.000000000","message":"The wrong import hierarchy is an in-scope discussion that has been ignored by the contrail team for 2 cycles now.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class NeutronPluginContrailCoreV2(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":102,"context_line":"                                  securitygroups_db.SecurityGroupDbMixin,"},{"line_number":103,"context_line":"                                  portbindings_base.PortBindingBaseMixin,"},{"line_number":104,"context_line":"                                  external_net.External_net):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_a6286386","line":101,"in_reply_to":"1ae5cdf2_cbc2ef33","updated":"2014-06-17 22:40:45.000000000","message":"we are reusing a bunch of validation method which are part of the DB class. I think some refactoring is needed for db base plugin but it is out of scope of this plugin.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f7c89367202488fd66211dec2614181cf670efac","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                  external_net.External_net):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"router\","},{"line_number":107,"context_line":"                                   \"port-security\", \"binding\", \"agent\","},{"line_number":108,"context_line":"                                   \"quotas\", \"external-net\"]"},{"line_number":109,"context_line":"    _args \u003d None"},{"line_number":110,"context_line":"    PLUGIN_URL_PREFIX \u003d \u0027/neutron\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_20ed3226","line":107,"updated":"2014-06-17 02:37:04.000000000","message":"Why is it needed to load agent extension? If you don\u0027t load this, I believe you might not need to override the get_agents() method as well.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                  external_net.External_net):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"router\","},{"line_number":107,"context_line":"                                   \"port-security\", \"binding\", \"agent\","},{"line_number":108,"context_line":"                                   \"quotas\", \"external-net\"]"},{"line_number":109,"context_line":"    _args \u003d None"},{"line_number":110,"context_line":"    PLUGIN_URL_PREFIX \u003d \u0027/neutron\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_ab14ac9f","line":107,"in_reply_to":"1ae5cdf2_20ed3226","updated":"2014-06-17 22:40:45.000000000","message":"Horizon throws a 404 if we don\u0027t implement it. I will see if I can get rid of it or put a comment","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"router\","},{"line_number":107,"context_line":"                                   \"port-security\", \"binding\", \"agent\","},{"line_number":108,"context_line":"                                   \"quotas\", \"external-net\"]"},{"line_number":109,"context_line":"    _args \u003d None"},{"line_number":110,"context_line":"    PLUGIN_URL_PREFIX \u003d \u0027/neutron\u0027"},{"line_number":111,"context_line":"    __native_bulk_support \u003d False"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_eb67abb5","line":109,"updated":"2014-06-17 03:13:50.000000000","message":"What is this for?","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    supported_extension_aliases \u003d [\"security-group\", \"router\","},{"line_number":107,"context_line":"                                   \"port-security\", \"binding\", \"agent\","},{"line_number":108,"context_line":"                                   \"quotas\", \"external-net\"]"},{"line_number":109,"context_line":"    _args \u003d None"},{"line_number":110,"context_line":"    PLUGIN_URL_PREFIX \u003d \u0027/neutron\u0027"},{"line_number":111,"context_line":"    __native_bulk_support \u003d False"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_0b3e8029","line":109,"in_reply_to":"1ae5cdf2_eb67abb5","updated":"2014-06-17 22:40:45.000000000","message":"Will remove it.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Each contrail extension is designed to have a unique method"},{"line_number":162,"context_line":"        # for the target extension. No two extensions will have the"},{"line_number":163,"context_line":"        # same method name."},{"line_number":164,"context_line":"        for extension_class in self._contrail_extensions_instances:"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                return getattr(extension_class, name)"},{"line_number":167,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_ebfecbad","line":164,"updated":"2014-06-17 03:13:50.000000000","message":"If each has a unique method why not cache these in a dict vs looping through the extension_instances?","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # Each contrail extension is designed to have a unique method"},{"line_number":162,"context_line":"        # for the target extension. No two extensions will have the"},{"line_number":163,"context_line":"        # same method name."},{"line_number":164,"context_line":"        for extension_class in self._contrail_extensions_instances:"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                return getattr(extension_class, name)"},{"line_number":167,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_860447c7","line":164,"in_reply_to":"1ae5cdf2_ebfecbad","updated":"2014-06-17 22:40:45.000000000","message":"sure, will do that","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0ccae8d0797c401c675460a3fec501f767c42886","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        raise AttributeError()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":173,"context_line":"        return []"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _request_api_server(self, url, data\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_ee5ed478","line":172,"updated":"2014-06-17 07:37:30.000000000","message":"It is just for horizon to go well, we should add a NOTE","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        raise AttributeError()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":173,"context_line":"        return []"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _request_api_server(self, url, data\u003dNone, headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_e628ab35","line":172,"in_reply_to":"1ae5cdf2_ee5ed478","updated":"2014-06-17 22:40:45.000000000","message":"will do","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def _relay_request(self, url_path, data\u003dNone):"},{"line_number":179,"context_line":"        \"\"\"Send received request to api server.\"\"\""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        url \u003d \"http://%s:%s%s\" % (cfg.CONF.APISERVER.api_server_ip,"},{"line_number":182,"context_line":"                                  cfg.CONF.APISERVER.api_server_port,"},{"line_number":183,"context_line":"                                  url_path)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_8b1e270c","line":181,"updated":"2014-06-17 03:13:50.000000000","message":"See not about changing group name to [CONTRAIL]","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def _relay_request(self, url_path, data\u003dNone):"},{"line_number":179,"context_line":"        \"\"\"Send received request to api server.\"\"\""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        url \u003d \"http://%s:%s%s\" % (cfg.CONF.APISERVER.api_server_ip,"},{"line_number":182,"context_line":"                                  cfg.CONF.APISERVER.api_server_port,"},{"line_number":183,"context_line":"                                  url_path)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_86d28732","line":181,"in_reply_to":"1ae5cdf2_8b1e270c","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        url_path \u003d \"%s/%s\" % (self.PLUGIN_URL_PREFIX, obj_name)"},{"line_number":193,"context_line":"        response \u003d self._relay_request(url_path, data\u003ddata)"},{"line_number":194,"context_line":"        if response.content:"},{"line_number":195,"context_line":"            return response.status_code, json.loads(response.content)"},{"line_number":196,"context_line":"        else:"},{"line_number":197,"context_line":"            return response.status_code, response.content"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_4bdc1f47","line":195,"updated":"2014-06-17 03:13:50.000000000","message":"request will do the deserialization for your.\nreturn response.status_code, response.json","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        url_path \u003d \"%s/%s\" % (self.PLUGIN_URL_PREFIX, obj_name)"},{"line_number":193,"context_line":"        response \u003d self._relay_request(url_path, data\u003ddata)"},{"line_number":194,"context_line":"        if response.content:"},{"line_number":195,"context_line":"            return response.status_code, json.loads(response.content)"},{"line_number":196,"context_line":"        else:"},{"line_number":197,"context_line":"            return response.status_code, response.content"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_c6dc8f49","line":195,"in_reply_to":"1ae5cdf2_4bdc1f47","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        resource_dict[\u0027fields\u0027] \u003d fields"},{"line_number":220,"context_line":"        return resource_dict"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def _transform_response(self, status_code, info\u003dNone, info_list\u003dNone,"},{"line_number":223,"context_line":"                            fields\u003dNone, obj_name\u003dNone):"},{"line_number":224,"context_line":"        if status_code \u003d\u003d requests.codes.ok:"},{"line_number":225,"context_line":"            func \u003d getattr(self, \"_make_%s_dict\" % obj_name)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_4b57bfca","line":222,"updated":"2014-06-17 03:13:50.000000000","message":"Why the two parameters here?  If info_list is an iterable, but not a dict you can assume it is a list.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        resource_dict[\u0027fields\u0027] \u003d fields"},{"line_number":220,"context_line":"        return resource_dict"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def _transform_response(self, status_code, info\u003dNone, info_list\u003dNone,"},{"line_number":223,"context_line":"                            fields\u003dNone, obj_name\u003dNone):"},{"line_number":224,"context_line":"        if status_code \u003d\u003d requests.codes.ok:"},{"line_number":225,"context_line":"            func \u003d getattr(self, \"_make_%s_dict\" % obj_name)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_26e1b3fc","line":222,"in_reply_to":"1ae5cdf2_4b57bfca","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            raise ContrailBadRequestError("},{"line_number":236,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":237,"context_line":"        error_clazz \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":238,"context_line":"        e \u003d error_clazz(msg\u003dinfo[\u0027message\u0027])"},{"line_number":239,"context_line":"        e.__class__.__name__ \u003d str(info[\u0027type\u0027])"},{"line_number":240,"context_line":"        raise e"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_4bb33f0a","line":238,"updated":"2014-06-17 03:13:50.000000000","message":"no need to mangle the name error_class is acceptable here","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            raise ContrailBadRequestError("},{"line_number":236,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":237,"context_line":"        error_clazz \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":238,"context_line":"        e \u003d error_clazz(msg\u003dinfo[\u0027message\u0027])"},{"line_number":239,"context_line":"        e.__class__.__name__ \u003d str(info[\u0027type\u0027])"},{"line_number":240,"context_line":"        raise e"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_06e67716","line":238,"in_reply_to":"1ae5cdf2_4bb33f0a","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":237,"context_line":"        error_clazz \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":238,"context_line":"        e \u003d error_clazz(msg\u003dinfo[\u0027message\u0027])"},{"line_number":239,"context_line":"        e.__class__.__name__ \u003d str(info[\u0027type\u0027])"},{"line_number":240,"context_line":"        raise e"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _create_resource(self, res_type, context, res_data):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_abe203ff","line":239,"updated":"2014-06-17 03:13:50.000000000","message":"Setting the class name for the Exception at Runtime should be avoided.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":237,"context_line":"        error_clazz \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":238,"context_line":"        e \u003d error_clazz(msg\u003dinfo[\u0027message\u0027])"},{"line_number":239,"context_line":"        e.__class__.__name__ \u003d str(info[\u0027type\u0027])"},{"line_number":240,"context_line":"        raise e"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _create_resource(self, res_type, context, res_data):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_86b9a7ee","line":239,"in_reply_to":"1ae5cdf2_abe203ff","updated":"2014-06-17 22:40:45.000000000","message":"ok will fix it.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        \"\"\"Creates a new subnet, and assigns it a symbolic name.\"\"\""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":395,"context_line":"        # turn the CIDR into a proper subnet"},{"line_number":396,"context_line":"        subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":397,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":398,"context_line":"        for key, value in subnet[\u0027subnet\u0027].items():"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_0bb5b7cf","line":395,"updated":"2014-06-17 03:13:50.000000000","message":"Not clear why this is necessary.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        \"\"\"Creates a new subnet, and assigns it a symbolic name.\"\"\""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":395,"context_line":"        # turn the CIDR into a proper subnet"},{"line_number":396,"context_line":"        subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":397,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":398,"context_line":"        for key, value in subnet[\u0027subnet\u0027].items():"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_06af572c","line":395,"in_reply_to":"1ae5cdf2_0bb5b7cf","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":395,"context_line":"        # turn the CIDR into a proper subnet"},{"line_number":396,"context_line":"        subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":397,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":398,"context_line":"        for key, value in subnet[\u0027subnet\u0027].items():"},{"line_number":399,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":400,"context_line":"                plugin_subnet[\u0027subnet\u0027][key] \u003d None"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_2b8c3335","line":397,"updated":"2014-06-17 03:13:50.000000000","message":"Why is a deep copy needed here over a shallow copy?","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":395,"context_line":"        # turn the CIDR into a proper subnet"},{"line_number":396,"context_line":"        subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":397,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":398,"context_line":"        for key, value in subnet[\u0027subnet\u0027].items():"},{"line_number":399,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":400,"context_line":"                plugin_subnet[\u0027subnet\u0027][key] \u003d None"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_e6842b0d","line":397,"in_reply_to":"1ae5cdf2_2b8c3335","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0ccae8d0797c401c675460a3fec501f767c42886","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":395,"context_line":"        # turn the CIDR into a proper subnet"},{"line_number":396,"context_line":"        subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":397,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":398,"context_line":"        for key, value in subnet[\u0027subnet\u0027].items():"},{"line_number":399,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":400,"context_line":"                plugin_subnet[\u0027subnet\u0027][key] \u003d None"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_2ee7dcad","line":397,"in_reply_to":"1ae5cdf2_2b8c3335","updated":"2014-06-17 07:37:30.000000000","message":"I think there is no need to use another dict. we can update in place.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        net \u003d netaddr.IPNetwork(subnet[\u0027subnet\u0027][\u0027cidr\u0027])"},{"line_number":395,"context_line":"        # turn the CIDR into a proper subnet"},{"line_number":396,"context_line":"        subnet[\u0027subnet\u0027][\u0027cidr\u0027] \u003d \u0027%s/%s\u0027 % (net.network, net.prefixlen)"},{"line_number":397,"context_line":"        plugin_subnet \u003d copy.deepcopy(subnet)"},{"line_number":398,"context_line":"        for key, value in subnet[\u0027subnet\u0027].items():"},{"line_number":399,"context_line":"            if value \u003d\u003d attr.ATTR_NOT_SPECIFIED:"},{"line_number":400,"context_line":"                plugin_subnet[\u0027subnet\u0027][key] \u003d None"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_26761340","line":397,"in_reply_to":"1ae5cdf2_2ee7dcad","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0ccae8d0797c401c675460a3fec501f767c42886","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        return fips_count[\u0027count\u0027]"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    # Security Group handlers"},{"line_number":695,"context_line":"    def create_security_group(self, context, security_group):"},{"line_number":696,"context_line":"        \"\"\"Creates a Security Group.\"\"\""},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        return self._create_resource(\u0027security_group\u0027, context,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_aefa0c41","line":695,"updated":"2014-06-17 07:37:30.000000000","message":"how do we implement security_group? do we use vrouter to implemenet it?","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        return fips_count[\u0027count\u0027]"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    # Security Group handlers"},{"line_number":695,"context_line":"    def create_security_group(self, context, security_group):"},{"line_number":696,"context_line":"        \"\"\"Creates a Security Group.\"\"\""},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        return self._create_resource(\u0027security_group\u0027, context,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_a606a383","line":695,"in_reply_to":"1ae5cdf2_aefa0c41","updated":"2014-06-17 22:40:45.000000000","message":"yes we use vrouter","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b81a15b9d2a8e3d07500e0ec6623995a6aa0899a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":224,"context_line":"        error_class \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":225,"context_line":"        e \u003d error_class(msg\u003dinfo[\u0027message\u0027])"},{"line_number":226,"context_line":"        raise e"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _create_resource(self, res_type, context, res_data):"},{"line_number":229,"context_line":"        \"\"\"Create a resource in API server."}],"source_content_type":"text/x-python","patch_set":21,"id":"1ae5cdf2_5a46427c","line":226,"updated":"2014-06-18 22:35:03.000000000","message":"nit: e isn\u0027t needed here.","commit_id":"fc71a70dd7e654515693b00e8f42e92105484381"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"2ee09bbd8f6dfb35392652f207764a67f87dd1bd","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":224,"context_line":"        error_class \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":225,"context_line":"        e \u003d error_class(msg\u003dinfo[\u0027message\u0027])"},{"line_number":226,"context_line":"        raise e"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _create_resource(self, res_type, context, res_data):"},{"line_number":229,"context_line":"        \"\"\"Create a resource in API server."}],"source_content_type":"text/x-python","patch_set":21,"id":"1ae5cdf2_f50561c2","line":226,"in_reply_to":"1ae5cdf2_5a46427c","updated":"2014-06-18 22:42:16.000000000","message":"Done","commit_id":"fc71a70dd7e654515693b00e8f42e92105484381"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8d9ffb4a2299fd482cdcd27b85faa958c72129ae","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# ContrailError message have translated already."},{"line_number":46,"context_line":"# so there is no need to use i18n here."},{"line_number":47,"context_line":"class ContrailNotFoundError(exc.NotFound):"},{"line_number":48,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_5fe538a2","line":46,"updated":"2014-07-13 02:32:57.000000000","message":"Add ContrailError here","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"76b31109ac7c609dae7fe76ae08d93aa13b959d2","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# ContrailError message have translated already."},{"line_number":46,"context_line":"# so there is no need to use i18n here."},{"line_number":47,"context_line":"class ContrailNotFoundError(exc.NotFound):"},{"line_number":48,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_11faac74","line":46,"in_reply_to":"baada198_5fe538a2","updated":"2014-07-14 18:28:29.000000000","message":"Done","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8d9ffb4a2299fd482cdcd27b85faa958c72129ae","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    requests.codes.bad_request: ContrailBadRequestError,"},{"line_number":75,"context_line":"    requests.codes.service_unavailable: ContrailServiceUnavailableError,"},{"line_number":76,"context_line":"    requests.codes.unauthorized: ContrailNotAuthorizedError,"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class NeutronPluginContrailCoreV2(neutron_plugin_base_v2.NeutronPluginBaseV2,"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_3ff4045a","line":77,"updated":"2014-07-13 02:32:57.000000000","message":"You should add 500(internal server error in contrail side) and default error for we don\u0027t have specific error.","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"76b31109ac7c609dae7fe76ae08d93aa13b959d2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    requests.codes.bad_request: ContrailBadRequestError,"},{"line_number":75,"context_line":"    requests.codes.service_unavailable: ContrailServiceUnavailableError,"},{"line_number":76,"context_line":"    requests.codes.unauthorized: ContrailNotAuthorizedError,"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class NeutronPluginContrailCoreV2(neutron_plugin_base_v2.NeutronPluginBaseV2,"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_b1302057","line":77,"in_reply_to":"baada198_3ff4045a","updated":"2014-07-14 18:28:29.000000000","message":"Done","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"8d9ffb4a2299fd482cdcd27b85faa958c72129ae","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        if status_code \u003d\u003d requests.codes.bad_request:"},{"line_number":209,"context_line":"            raise ContrailBadRequestError("},{"line_number":210,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":211,"context_line":"        error_class \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":212,"context_line":"        raise error_class(msg\u003dinfo[\u0027message\u0027])"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _create_resource(self, res_type, context, res_data):"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_7feafc74","line":211,"updated":"2014-07-13 02:32:57.000000000","message":"CONTRAIL_EXCEPTION_MAP.get(status_code, ContrailError)","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"76b31109ac7c609dae7fe76ae08d93aa13b959d2","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        if status_code \u003d\u003d requests.codes.bad_request:"},{"line_number":209,"context_line":"            raise ContrailBadRequestError("},{"line_number":210,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"},{"line_number":211,"context_line":"        error_class \u003d CONTRAIL_EXCEPTION_MAP[status_code]"},{"line_number":212,"context_line":"        raise error_class(msg\u003dinfo[\u0027message\u0027])"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _create_resource(self, res_type, context, res_data):"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_d133d45f","line":211,"in_reply_to":"baada198_7feafc74","updated":"2014-07-14 18:28:29.000000000","message":"Done","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Hampapur Ajay, Praneet Bachheti, Rudra Rugge, Atul Moghe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_cad181cd","line":15,"updated":"2014-07-25 17:54:00.000000000","message":"Consider removing names, you can add authors on the commit message","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Hampapur Ajay, Praneet Bachheti, Rudra Rugge, Atul Moghe"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo.config import cfg"},{"line_number":18,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_60309107","line":15,"in_reply_to":"baada198_cad181cd","updated":"2014-07-25 21:47:37.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vnc_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":40,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_4af49154","line":37,"updated":"2014-07-25 17:54:00.000000000","message":"VNC controller? What is the meaning of VNC here?\nConsider simple said: \"opencontrail controller\" as you have it in the .ini file","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"vnc_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027api_server_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027IP address to connect to VNC controller\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027api_server_port\u0027, default\u003d\u00278082\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Port to connect to VNC controller\u0027),"},{"line_number":40,"context_line":"    cfg.DictOpt(\u0027contrail_extensions\u0027, default\u003d{},"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_801cc578","line":37,"in_reply_to":"baada198_4af49154","updated":"2014-07-25 21:47:37.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ContrailBadRequestError(exc.BadRequest):"},{"line_number":60,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_6a623517","line":59,"updated":"2014-07-25 17:54:00.000000000","message":"For a cleaner implementation move all the Exceptions code to a different module","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ContrailBadRequestError(exc.BadRequest):"},{"line_number":60,"context_line":"    message \u003d \u0027%(msg)s\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_33dfd167","line":59,"in_reply_to":"baada198_6a623517","updated":"2014-07-25 21:47:37.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"31919e9da6d74211f612525fcf2b5d567a52478b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                self.supported_extension_aliases.append(ext_name)"},{"line_number":114,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"},{"line_number":115,"context_line":"                ext_instance \u003d ext_class()"},{"line_number":116,"context_line":"                ext_instance.set_core(self)"},{"line_number":117,"context_line":"                for method in dir(ext_instance):"},{"line_number":118,"context_line":"                    for prefix in [\u0027get\u0027, \u0027update\u0027, \u0027delete\u0027, \u0027create\u0027]:"},{"line_number":119,"context_line":"                        if method.startswith(\u0027%s_\u0027 % prefix):"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_2297d6ec","line":116,"updated":"2014-07-23 20:50:44.000000000","message":"Why is this necessary?  You are creating loops which are hard to gc.  Where is the corresponding unit test for this branch of the code?","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8ee3307df6e68b1bd1915fc29bae0738a098e534","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                self.supported_extension_aliases.append(ext_name)"},{"line_number":114,"context_line":"                ext_class \u003d importutils.import_class(ext_class)"},{"line_number":115,"context_line":"                ext_instance \u003d ext_class()"},{"line_number":116,"context_line":"                ext_instance.set_core(self)"},{"line_number":117,"context_line":"                for method in dir(ext_instance):"},{"line_number":118,"context_line":"                    for prefix in [\u0027get\u0027, \u0027update\u0027, \u0027delete\u0027, \u0027create\u0027]:"},{"line_number":119,"context_line":"                        if method.startswith(\u0027%s_\u0027 % prefix):"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_cb1b9571","line":116,"in_reply_to":"baada198_2297d6ec","updated":"2014-07-25 06:41:45.000000000","message":"Mark this piece of code is for future extensions support. I figured out we can do this using service plugin, so we will remove this code for now. When we have extensions in future we will use the service plugin approach.","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"31919e9da6d74211f612525fcf2b5d567a52478b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        super(NeutronPluginContrailCoreV2, self).__init__()"},{"line_number":130,"context_line":"        portbindings_base.register_port_dict_function()"},{"line_number":131,"context_line":"        self.base_binding_dict \u003d self._get_base_binding_dict()"},{"line_number":132,"context_line":"        cfg.CONF.register_opts(vnc_opts, \u0027CONTRAIL\u0027)"},{"line_number":133,"context_line":"        self._parse_class_args()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _get_base_binding_dict(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_c5ef04e8","line":132,"updated":"2014-07-23 20:50:44.000000000","message":"These should be registered as part of the module load.","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8ee3307df6e68b1bd1915fc29bae0738a098e534","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        super(NeutronPluginContrailCoreV2, self).__init__()"},{"line_number":130,"context_line":"        portbindings_base.register_port_dict_function()"},{"line_number":131,"context_line":"        self.base_binding_dict \u003d self._get_base_binding_dict()"},{"line_number":132,"context_line":"        cfg.CONF.register_opts(vnc_opts, \u0027CONTRAIL\u0027)"},{"line_number":133,"context_line":"        self._parse_class_args()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _get_base_binding_dict(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_f0d4c4ea","line":132,"in_reply_to":"baada198_c5ef04e8","updated":"2014-07-25 06:41:45.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"31919e9da6d74211f612525fcf2b5d567a52478b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                return [self._prune(items, fields) for items in info]"},{"line_number":210,"context_line":"        self._raise_contrail_error(status_code, info, obj_name)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _raise_contrail_error(self, status_code, info, obj_name):"},{"line_number":213,"context_line":"        if status_code \u003d\u003d requests.codes.bad_request:"},{"line_number":214,"context_line":"            raise ContrailBadRequestError("},{"line_number":215,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_a56bf084","line":212,"updated":"2014-07-23 20:50:44.000000000","message":"Where are the Unit Test that validate that this error handler works?","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8ee3307df6e68b1bd1915fc29bae0738a098e534","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                return [self._prune(items, fields) for items in info]"},{"line_number":210,"context_line":"        self._raise_contrail_error(status_code, info, obj_name)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def _raise_contrail_error(self, status_code, info, obj_name):"},{"line_number":213,"context_line":"        if status_code \u003d\u003d requests.codes.bad_request:"},{"line_number":214,"context_line":"            raise ContrailBadRequestError("},{"line_number":215,"context_line":"                msg\u003dinfo[\u0027message\u0027], resource\u003dobj_name)"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_d004201a","line":212,"in_reply_to":"baada198_a56bf084","updated":"2014-07-25 06:41:45.000000000","message":"Existing test plugin code has test cases to test this error handler.\n\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L2320\n\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L2369\n\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L2758\n\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L2767","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    def add_router_interface(self, context, router_id, interface_info):"},{"line_number":538,"context_line":"        \"\"\"Add interface to a router.\"\"\""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if not interface_info:"},{"line_number":541,"context_line":"            msg \u003d _(\"Either subnet_id or port_id must be specified\")"},{"line_number":542,"context_line":"            raise exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_25b94e16","line":540,"updated":"2014-07-25 17:54:00.000000000","message":"Lines 540 - 542 should be:\n\nport_id_specified \u003d interface_info and \u0027port_id\u0027 in interface_info\nsubnet_id_specified \u003d interface_info and \u0027subnet_id\u0027 in interface_info\nif not (port_id_specified or subnet_id_specified):\n    msg \u003d _(\"Either subnet_id or port_id must be specified\")\n    raise exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    def add_router_interface(self, context, router_id, interface_info):"},{"line_number":538,"context_line":"        \"\"\"Add interface to a router.\"\"\""},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if not interface_info:"},{"line_number":541,"context_line":"            msg \u003d _(\"Either subnet_id or port_id must be specified\")"},{"line_number":542,"context_line":"            raise exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_d33db52d","line":540,"in_reply_to":"baada198_25b94e16","updated":"2014-07-25 21:47:37.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"f4493a5d4eed1023cf46f693619fae15fe86f71b","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        if not interface_info:"},{"line_number":562,"context_line":"            msg \u003d _(\"Either subnet_id or port_id must be specified\")"},{"line_number":563,"context_line":"            raise exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        res_dict \u003d self._encode_resource(resource_id\u003drouter_id,"},{"line_number":566,"context_line":"                                         resource\u003dinterface_info)"},{"line_number":567,"context_line":"        status_code, res_info \u003d self._request_backend(context, res_dict,"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_25e22e30","line":564,"updated":"2014-07-25 17:54:00.000000000","message":"same than above... well you can actually create a helper function for this..","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"1ba330e8f7889af598363bf446a683b00d88544a","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        if not interface_info:"},{"line_number":562,"context_line":"            msg \u003d _(\"Either subnet_id or port_id must be specified\")"},{"line_number":563,"context_line":"            raise exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        res_dict \u003d self._encode_resource(resource_id\u003drouter_id,"},{"line_number":566,"context_line":"                                         resource\u003dinterface_info)"},{"line_number":567,"context_line":"        status_code, res_info \u003d self._request_backend(context, res_dict,"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_f33ab932","line":564,"in_reply_to":"baada198_25e22e30","updated":"2014-07-25 21:47:37.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"231d2877225a5cbf9e4c4653c48f618a7d93a845","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo.config import cfg"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_c1c5465e","line":15,"updated":"2014-07-30 20:48:47.000000000","message":"I would recommend to remove the \"core\" part from the name of this file. In future if you need to extend this file the 80 characters allowed will make difficult to fit everything in only one line.","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"b74d26cb8fdbd4cefb174ef37914550d4777f483","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo.config import cfg"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_ccef3db1","line":15,"in_reply_to":"baada198_c1c5465e","updated":"2014-07-30 21:23:14.000000000","message":"Done","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a5d14c0dead9601cd27396c2df8cc8d9a2cec6f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        return self._make_subnet_dict(subnet_created)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _make_subnet_dict(self, subnet):"},{"line_number":303,"context_line":"        if \u0027gateway_ip\u0027 in subnet and subnet[\u0027gateway_ip\u0027] \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":304,"context_line":"            subnet[\u0027gateway_ip\u0027] \u003d None"},{"line_number":305,"context_line":"        return subnet"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_6d0113b5","line":303,"updated":"2014-07-29 12:22:26.000000000","message":"Can do\n    if subnet.get(\u0027gateway_ip\u0027) \u003d\u003d \u00270.0.0.0\u0027:","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"b74d26cb8fdbd4cefb174ef37914550d4777f483","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        return self._make_subnet_dict(subnet_created)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _make_subnet_dict(self, subnet):"},{"line_number":303,"context_line":"        if \u0027gateway_ip\u0027 in subnet and subnet[\u0027gateway_ip\u0027] \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":304,"context_line":"            subnet[\u0027gateway_ip\u0027] \u003d None"},{"line_number":305,"context_line":"        return subnet"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_0cea15a0","line":303,"in_reply_to":"baada198_6d0113b5","updated":"2014-07-30 21:23:14.000000000","message":"Done","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"}],"neutron/tests/unit/opencontrail/test_contrail_plugin.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"73e713cda698fafaea2e44a68ff2f83aafe1d2b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9e31100e","line":2,"updated":"2014-05-30 20:34:41.000000000","message":"nit: please drop the above","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"ce3dc84acf1315fe39f0e956c0edfc48588eb022","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_91c49e93","line":2,"in_reply_to":"1ae5cdf2_9e31100e","updated":"2014-05-30 23:17:30.000000000","message":"Done","commit_id":"fb729d007630a6440b90a7de70025fe30a590f72"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e86ce6f775ecc9e949a1c3907c34b7ce7a2217c0","unresolved":false,"context_lines":[{"line_number":898,"context_line":"fake_requests \u003d mock.MagicMock(name\u003d\u0027fake_requests_pkg\u0027)"},{"line_number":899,"context_line":"sys.modules[\u0027requests\u0027] \u003d fake_requests"},{"line_number":900,"context_line":"fake_requests.post \u003d fake_requests_post"},{"line_number":901,"context_line":"fake_requests.codes.ok \u003d 200"},{"line_number":902,"context_line":"fake_requests.codes.conflict \u003d 409"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5a6e8702","line":901,"updated":"2014-06-02 13:00:56.000000000","message":"\u003d requests.codes.ok?","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"dc01c1bbcbc117842969a88ea3ab26475a92eaad","unresolved":false,"context_lines":[{"line_number":898,"context_line":"fake_requests \u003d mock.MagicMock(name\u003d\u0027fake_requests_pkg\u0027)"},{"line_number":899,"context_line":"sys.modules[\u0027requests\u0027] \u003d fake_requests"},{"line_number":900,"context_line":"fake_requests.post \u003d fake_requests_post"},{"line_number":901,"context_line":"fake_requests.codes.ok \u003d 200"},{"line_number":902,"context_line":"fake_requests.codes.conflict \u003d 409"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7440a5a5","line":901,"in_reply_to":"1ae5cdf2_5a6e8702","updated":"2014-06-02 23:45:42.000000000","message":"Done","commit_id":"d890bc3c8052039c7eb0a3f05b4da74a29633c52"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"45898adf18ee48336a327264b112f8edbe95863f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_461a3f18","line":47,"updated":"2014-06-10 02:48:10.000000000","message":"why not use NeutronPluginContrailCoreV2 directly and mock the _request_api_server?","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"46ec464eb0adbef2f9a17ca68193869bbffe383a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_e934dbfc","line":47,"in_reply_to":"1ae5cdf2_461a3f18","updated":"2014-06-11 04:37:42.000000000","message":"This Fakeserver simulates contrail api server. so this one act as backend for _request_api_server.","commit_id":"af6aa4c2f1ac04f1cd92359c2c105b3f61e52406"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"},{"line_number":51,"context_line":"    supported_extension_aliases \u003d [\u0027external-net\u0027, \u0027router\u0027, \u0027floatingip\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def _core_plugin(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_f10e708b","line":51,"updated":"2014-06-11 05:50:46.000000000","message":"Please add comments for the new classes to specify what they do.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"},{"line_number":51,"context_line":"    supported_extension_aliases \u003d [\u0027external-net\u0027, \u0027router\u0027, \u0027floatingip\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def _core_plugin(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_3a9df60a","line":51,"in_reply_to":"1ae5cdf2_f10e708b","updated":"2014-06-11 19:05:39.000000000","message":"Done","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9a5291f59addd207c3707e9d22de8dda2429ab9a","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_delete_subnet_dhcp_port_associated_with_other_subnets(self):"},{"line_number":297,"context_line":"        self.skipTest(\"There is no dhcp port in contrail\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":301,"context_line":"                          JVContrailPluginTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_51ef24b1","line":298,"updated":"2014-06-11 05:50:46.000000000","message":"you may want to test the helper functions in the actual plugin here. I mean plugin itself implementation. check whether those helper functions return the dicts as expected using a fake expected_dict.","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"30ae8f943598b9fa784088893e1080698f94a016","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_delete_subnet_dhcp_port_associated_with_other_subnets(self):"},{"line_number":297,"context_line":"        self.skipTest(\"There is no dhcp port in contrail\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":301,"context_line":"                          JVContrailPluginTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_497af9f1","line":298,"in_reply_to":"1ae5cdf2_1a9cba0e","updated":"2014-06-12 01:00:54.000000000","message":"I don\u0027t see why it is needed because these help functions are well tested in the many db plugin tests, right?","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"e8e3aa28e5ac25f9027c46b5fc7a0fb54cda193a","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_delete_subnet_dhcp_port_associated_with_other_subnets(self):"},{"line_number":297,"context_line":"        self.skipTest(\"There is no dhcp port in contrail\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":301,"context_line":"                          JVContrailPluginTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_acd9aa23","line":298,"in_reply_to":"1ae5cdf2_497af9f1","updated":"2014-06-12 21:15:41.000000000","message":"I agree with Nachi. These functions are tested heavily in the unit test cases","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"9ab43e8c2a04cbbbb1da79fa9ff20d885988f87b","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_delete_subnet_dhcp_port_associated_with_other_subnets(self):"},{"line_number":297,"context_line":"        self.skipTest(\"There is no dhcp port in contrail\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":301,"context_line":"                          JVContrailPluginTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_1a9cba0e","line":298,"in_reply_to":"1ae5cdf2_51ef24b1","updated":"2014-06-11 19:05:39.000000000","message":"good idea. will do","commit_id":"cb8c47bfc95d4a4dacc95953f154081da56efff0"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_4bd09fc9","line":47,"updated":"2014-06-17 03:13:50.000000000","message":"Your fake server has duplicate logic of the class under test due to the same inheritance. You should choose a different style of mocking.  httmock is being use elsewhere in Neutron.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"efd5af27c16e56f1a0ad4a5ff970eb3b5177d70f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_4745e641","line":47,"in_reply_to":"1ae5cdf2_4bd09fc9","updated":"2014-06-17 11:14:01.000000000","message":"Actually, httmock is NOT being used. It is included in one VPN UT module, which has been disabled, because the httmock package has not been approved in global requirements (I wish it was). At this time, you\u0027d need to use httpretty, or roll your own using Mock (not recommended).\n\nI\u0027ve been discussing this with Jamie Lennox, as we\u0027re both thinking about how to replace HTTPretty (the only package that is approved), with a more comprehensive package.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":48,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":49,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":50,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_9078fdf9","line":47,"in_reply_to":"1ae5cdf2_4bd09fc9","updated":"2014-06-17 22:40:45.000000000","message":"Spec of the Contrail api server implementation is based on db plugin. so, if contrail api server behaves differently with db plugin, it is bug in contrail side.  it only uses some validation logic from db code.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"79476334b5dbe102c67cef173eecff37f0f9dbb3","unresolved":false,"context_lines":[{"line_number":279,"context_line":"class TestContrailNetworksV2(test_plugin.TestNetworksV2,"},{"line_number":280,"context_line":"                             JVContrailPluginTestCase):"},{"line_number":281,"context_line":"    def setUp(self):"},{"line_number":282,"context_line":"        init_mock()"},{"line_number":283,"context_line":"        super(TestContrailNetworksV2, self).setUp()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_0b7857f7","line":282,"updated":"2014-06-17 03:13:50.000000000","message":"Why not just set this up in JVContrailPluginTestCase?","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":279,"context_line":"class TestContrailNetworksV2(test_plugin.TestNetworksV2,"},{"line_number":280,"context_line":"                             JVContrailPluginTestCase):"},{"line_number":281,"context_line":"    def setUp(self):"},{"line_number":282,"context_line":"        init_mock()"},{"line_number":283,"context_line":"        super(TestContrailNetworksV2, self).setUp()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_105dcd48","line":282,"in_reply_to":"1ae5cdf2_0b7857f7","updated":"2014-06-17 22:40:45.000000000","message":"Done","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"144bcd48fb08bb146fb28458f0b0619b26746157","unresolved":false,"context_lines":[{"line_number":238,"context_line":"FAKE_SERVER \u003d FakeServer()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def init_mock():"},{"line_number":242,"context_line":"    mock.patch(\u0027requests.post\u0027).start().side_effect \u003d FAKE_SERVER.request"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1ae5cdf2_f5880124","line":241,"updated":"2014-06-18 22:46:15.000000000","message":"I think we don\u0027t need this method.","commit_id":"fc71a70dd7e654515693b00e8f42e92105484381"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"36ee3a8e988cdfc443edd0f075ab0b2eff4634a6","unresolved":false,"context_lines":[{"line_number":238,"context_line":"FAKE_SERVER \u003d FakeServer()"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def init_mock():"},{"line_number":242,"context_line":"    mock.patch(\u0027requests.post\u0027).start().side_effect \u003d FAKE_SERVER.request"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1ae5cdf2_70207f49","line":241,"in_reply_to":"1ae5cdf2_f5880124","updated":"2014-06-18 23:22:17.000000000","message":"Done","commit_id":"fc71a70dd7e654515693b00e8f42e92105484381"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"dcd4f440b0eafa7e731060a1c0419c5f6edc07bf","unresolved":false,"context_lines":[{"line_number":47,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":51,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":52,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":53,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_f46858bc","line":50,"updated":"2014-07-02 01:49:32.000000000","message":"given that the plugin is not using this base class, is it required here?","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"17f14bb2f41db9e1615907130b55cfb2d10062eb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":51,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":52,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":53,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_ada3999c","line":50,"in_reply_to":"baada198_f46858bc","updated":"2014-07-11 23:54:49.000000000","message":"FakeServer mocks behavior of contrail API server. It inherits from the NeutronDBPluginV2 so it can persist the data and validate it. If we don\u0027t inherit from it, we will have unnecessarily duplicate a lot of code.","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"31919e9da6d74211f612525fcf2b5d567a52478b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import datetime"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_820a6225","line":18,"updated":"2014-07-23 20:50:44.000000000","message":"from neutron.openstack.common import jsonutils as json","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8ee3307df6e68b1bd1915fc29bae0738a098e534","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import datetime"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_e54248aa","line":18,"in_reply_to":"baada198_820a6225","updated":"2014-07-25 06:41:45.000000000","message":"Done","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a5d14c0dead9601cd27396c2df8cc8d9a2cec6f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":51,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":52,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":53,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_ad7fabde","line":50,"updated":"2014-07-29 12:22:26.000000000","message":"I do agree with Mark\u0027s comment in version 20, in that this FakeServer duplicates production code. You can use httpretty or the newer (preferred) requests-mock package to mock the request calls providing desired mock responses, and utilize the production server.\n\nIn v20, I was just commenting that the httmock package shouldn\u0027t be used, because it was not approved in global-requirements. The plan for the VPN code that uses that package, is to change to using requests-mock, now that it is available.","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"6bd6af68a1707a7bbecf550ad2a27aeb87851f6f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":51,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":52,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":53,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_dd4b9b84","line":50,"in_reply_to":"baada198_ad7fabde","updated":"2014-07-29 19:42:24.000000000","message":"I\u0027m ok with this approach.\nIn version 20, this patch uses db-plugin for both of plugin and fake server. However,  version 26 doesn\u0027t use db-plugin on plugin side, so it doesn\u0027t duplicates production code.\nInternal API mismatch should be found in integration test because contrail is a external project.","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"b74d26cb8fdbd4cefb174ef37914550d4777f483","unresolved":false,"context_lines":[{"line_number":47,"context_line":"CONTRAIL_PKG_PATH \u003d \"neutron.plugins.opencontrail.contrail_plugin_core\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FakeServer(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":51,"context_line":"                 external_net_db.External_net_db_mixin,"},{"line_number":52,"context_line":"                 securitygroups_db.SecurityGroupDbMixin,"},{"line_number":53,"context_line":"                 l3_db.L3_NAT_db_mixin):"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_2c15194c","line":50,"in_reply_to":"baada198_dd4b9b84","updated":"2014-07-30 21:23:14.000000000","message":"I agree with Nachi\u0027s comment, The Contrail Plugin is not inheriting from DBClass anymore. We are mocking the \"requests.post\" method and making FakeServer handle it which uses the validation logic from the DB class.","commit_id":"c397ee6e94d93c065fec8a9105b59f5b1e550d35"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import datetime"},{"line_number":18,"context_line":"from neutron.openstack.common import jsonutils as json"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_ab627ad6","line":18,"updated":"2014-08-04 05:40:01.000000000","message":"This needs to be sorted below the other neutron imports","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import datetime"},{"line_number":18,"context_line":"from neutron.openstack.common import jsonutils as json"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_c1feadae","line":18,"in_reply_to":"baada198_ab627ad6","updated":"2014-08-04 07:00:35.000000000","message":"Done","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.delete_disassociated_floatingips(context, id)"},{"line_number":112,"context_line":"        super(FakeServer, self).delete_network(context, id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def request(self, *args, **kwargs):"},{"line_number":115,"context_line":"        request_data \u003d json.loads(kwargs[\u0027data\u0027])"},{"line_number":116,"context_line":"        context_dict \u003d request_data[\u0027context\u0027]"},{"line_number":117,"context_line":"        context \u003d neutron_context.Context.from_dict(context_dict)"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_4be39ed7","line":114,"updated":"2014-08-04 05:40:01.000000000","message":"Why do you need args* if it is never used?","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.delete_disassociated_floatingips(context, id)"},{"line_number":112,"context_line":"        super(FakeServer, self).delete_network(context, id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def request(self, *args, **kwargs):"},{"line_number":115,"context_line":"        request_data \u003d json.loads(kwargs[\u0027data\u0027])"},{"line_number":116,"context_line":"        context_dict \u003d request_data[\u0027context\u0027]"},{"line_number":117,"context_line":"        context \u003d neutron_context.Context.from_dict(context_dict)"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_212f693f","line":114,"in_reply_to":"baada198_4be39ed7","updated":"2014-08-04 07:00:35.000000000","message":"Mock requires it that way","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ad56a2de9df8e5cdb91c4f416a0af8230373879f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                obj \u003d self.remove_router_interface("},{"line_number":158,"context_line":"                    context, data[\u0027id\u0027], data[\u0027resource\u0027])"},{"line_number":159,"context_line":"        except (exc.NeutronException,"},{"line_number":160,"context_line":"                netaddr.AddrFormatError) as e:"},{"line_number":161,"context_line":"            for fault in api_base.FAULT_MAP:"},{"line_number":162,"context_line":"                if isinstance(e, fault):"},{"line_number":163,"context_line":"                    mapped_exc \u003d api_base.FAULT_MAP[fault]"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_abc43a41","line":160,"updated":"2014-08-04 05:40:01.000000000","message":"normally we try to avoid the name \"e\" for variables","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d4c9aad993d5cc07f2f2add98c1b74983d4e41f1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                obj \u003d self.remove_router_interface("},{"line_number":158,"context_line":"                    context, data[\u0027id\u0027], data[\u0027resource\u0027])"},{"line_number":159,"context_line":"        except (exc.NeutronException,"},{"line_number":160,"context_line":"                netaddr.AddrFormatError) as e:"},{"line_number":161,"context_line":"            for fault in api_base.FAULT_MAP:"},{"line_number":162,"context_line":"                if isinstance(e, fault):"},{"line_number":163,"context_line":"                    mapped_exc \u003d api_base.FAULT_MAP[fault]"}],"source_content_type":"text/x-python","patch_set":27,"id":"baada198_0188a520","line":160,"in_reply_to":"baada198_abc43a41","updated":"2014-08-04 07:00:35.000000000","message":"Done","commit_id":"7ddbccad6f56df6e6214fbaef156f022e7204053"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5edf83aab8292b80f5f153fce4fbeca292967f49","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    admin_tenant_name \u003d \u0027neutron\u0027"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"class JVContrailPluginTestCase(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":210,"context_line":"    _plugin_name \u003d (\u0027%s.NeutronPluginContrailCoreV2\u0027 % CONTRAIL_PKG_PATH)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def setUp(self, plugin\u003dNone, ext_mgr\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_bc28f785","line":209,"updated":"2014-08-04 10:44:02.000000000","message":"Stupid question.... why the \"JV\" prefix?","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"4a6946a2e02d7e6ae69b04a130c468617c3f5bb7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    admin_tenant_name \u003d \u0027neutron\u0027"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"class JVContrailPluginTestCase(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":210,"context_line":"    _plugin_name \u003d (\u0027%s.NeutronPluginContrailCoreV2\u0027 % CONTRAIL_PKG_PATH)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def setUp(self, plugin\u003dNone, ext_mgr\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_580d2034","line":209,"in_reply_to":"baada198_bc28f785","updated":"2014-08-04 21:51:10.000000000","message":"Will remove the prefix.","commit_id":"f495e7d4bd0d2e3c68b57adc2b5daae2ee2c2b0c"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"3138203a74eca3401182de8c4806182901166b11","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    admin_user \u003d \u0027neutron\u0027"},{"line_number":210,"context_line":"    admin_password \u003d \u0027neutron\u0027"},{"line_number":211,"context_line":"    admin_token \u003d \u0027neutron\u0027"},{"line_number":212,"context_line":"    admin_tenant_name \u003d \u0027neutron\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class ContrailPluginTestCase(test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":31,"id":"baada198_2929f682","line":212,"updated":"2014-08-12 09:04:26.000000000","message":"I think this information can be used from neutron.conf [keystone].\ncan you recheck it.","commit_id":"907c807d4ee2c8cdfab95c5364ba13c7b4447520"},{"author":{"_account_id":8306,"name":"Rudra Rugge","email":"rrugge@juniper.net","username":"rudrarugge"},"change_message_id":"98522c01687f106a9914926d3a091b0115aa0d64","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    admin_user \u003d \u0027neutron\u0027"},{"line_number":210,"context_line":"    admin_password \u003d \u0027neutron\u0027"},{"line_number":211,"context_line":"    admin_token \u003d \u0027neutron\u0027"},{"line_number":212,"context_line":"    admin_tenant_name \u003d \u0027neutron\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class ContrailPluginTestCase(test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":31,"id":"baada198_4aaa866d","line":212,"in_reply_to":"baada198_2929f682","updated":"2014-08-12 17:37:50.000000000","message":"Looks like this information is not available for tests.","commit_id":"907c807d4ee2c8cdfab95c5364ba13c7b4447520"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"052a34dab1513083b24d719a0fd21a94ee136701","unresolved":false,"context_lines":[{"line_number":2417,"context_line":"                                   \u0027create_subnet\u0027) as patched_plugin:"},{"line_number":2418,"context_line":""},{"line_number":2419,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2420,"context_line":"                    self._fail_second_call(patched_plugin, orig,"},{"line_number":2421,"context_line":"                                           *args, **kwargs)"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"                patched_plugin.side_effect \u003d side_effect"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_b35ba784","side":"PARENT","line":2420,"updated":"2014-06-13 19:07:54.000000000","message":"Is this related to the Contrail plugin?","commit_id":"442960d2b21c3ce5b5e94766ae910518c85dedda"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"52c32af917f8af7e6b6f35ab976b3e5107212a4a","unresolved":false,"context_lines":[{"line_number":2417,"context_line":"                                   \u0027create_subnet\u0027) as patched_plugin:"},{"line_number":2418,"context_line":""},{"line_number":2419,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2420,"context_line":"                    self._fail_second_call(patched_plugin, orig,"},{"line_number":2421,"context_line":"                                           *args, **kwargs)"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"                patched_plugin.side_effect \u003d side_effect"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_e6c64f48","side":"PARENT","line":2420,"in_reply_to":"1ae5cdf2_b35ba784","updated":"2014-06-13 19:40:47.000000000","message":"Seems this one was actually broken. (see L2440)","commit_id":"442960d2b21c3ce5b5e94766ae910518c85dedda"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f7c89367202488fd66211dec2614181cf670efac","unresolved":false,"context_lines":[{"line_number":2418,"context_line":""},{"line_number":2419,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2420,"context_line":"                    return self._fail_second_call(patched_plugin, orig,"},{"line_number":2421,"context_line":"                                                  *args, **kwargs)"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"                patched_plugin.side_effect \u003d side_effect"},{"line_number":2424,"context_line":"                with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_2051b20e","line":2421,"updated":"2014-06-17 02:37:04.000000000","message":"this seems to be an unrelated change?","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8dc3c19f7129f7a894e6786028da8b6c4e69734a","unresolved":false,"context_lines":[{"line_number":2418,"context_line":""},{"line_number":2419,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2420,"context_line":"                    return self._fail_second_call(patched_plugin, orig,"},{"line_number":2421,"context_line":"                                                  *args, **kwargs)"},{"line_number":2422,"context_line":""},{"line_number":2423,"context_line":"                patched_plugin.side_effect \u003d side_effect"},{"line_number":2424,"context_line":"                with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ae5cdf2_f00b0122","line":2421,"in_reply_to":"1ae5cdf2_2051b20e","updated":"2014-06-17 22:40:45.000000000","message":"Look at L2440, there was a missing return.","commit_id":"31e6a6f0fe8260d4222c2b3603df65cafdd90190"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"68db1f7b6ea5acd2677a467483f1745ebc22cb6a","unresolved":false,"context_lines":[{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2418,"context_line":"                    return self._fail_second_call(patched_plugin, orig,"},{"line_number":2419,"context_line":"                                                  *args, **kwargs)"},{"line_number":2420,"context_line":""},{"line_number":2421,"context_line":"                patched_plugin.side_effect \u003d side_effect"},{"line_number":2422,"context_line":"                with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_84bf1cd0","line":2419,"updated":"2014-07-01 02:19:44.000000000","message":"Is this change related to this patch?","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"d290cd0b78e98f4145b4f8a226e5fbe8df2e1a19","unresolved":false,"context_lines":[{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2418,"context_line":"                    return self._fail_second_call(patched_plugin, orig,"},{"line_number":2419,"context_line":"                                                  *args, **kwargs)"},{"line_number":2420,"context_line":""},{"line_number":2421,"context_line":"                patched_plugin.side_effect \u003d side_effect"},{"line_number":2422,"context_line":"                with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":23,"id":"baada198_bfb989eb","line":2419,"in_reply_to":"baada198_84bf1cd0","updated":"2014-07-01 03:10:30.000000000","message":"yes Sumit, this change is needed for our unit test to pass. It was missing a return. Same as Line 2438","commit_id":"99ceb396414af928533fab57f0e0b8986bb824f3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"31919e9da6d74211f612525fcf2b5d567a52478b","unresolved":false,"context_lines":[{"line_number":2415,"context_line":"                                   \u0027create_subnet\u0027) as patched_plugin:"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2418,"context_line":"                    return self._fail_second_call(patched_plugin, orig,"},{"line_number":2419,"context_line":"                                                  *args, **kwargs)"},{"line_number":2420,"context_line":""},{"line_number":2421,"context_line":"                patched_plugin.side_effect \u003d side_effect"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_6559d834","line":2418,"updated":"2014-07-23 20:50:44.000000000","message":"Why this unrelated change?","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"},{"author":{"_account_id":8887,"name":"Praneet Bachheti","email":"praneetb@juniper.net","username":"praneetb"},"change_message_id":"8ee3307df6e68b1bd1915fc29bae0738a098e534","unresolved":false,"context_lines":[{"line_number":2415,"context_line":"                                   \u0027create_subnet\u0027) as patched_plugin:"},{"line_number":2416,"context_line":""},{"line_number":2417,"context_line":"                def side_effect(*args, **kwargs):"},{"line_number":2418,"context_line":"                    return self._fail_second_call(patched_plugin, orig,"},{"line_number":2419,"context_line":"                                                  *args, **kwargs)"},{"line_number":2420,"context_line":""},{"line_number":2421,"context_line":"                patched_plugin.side_effect \u003d side_effect"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_6514784d","line":2418,"in_reply_to":"baada198_6559d834","updated":"2014-07-25 06:41:45.000000000","message":"I will remove the change in my next patch.","commit_id":"20ce62b39e76876fa48b914737f2cca11e189ff5"}]}
