)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a44d44ece7c1e1125d848b22a13c31be8f26b326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be01b15b_6ef6c010","updated":"2025-11-14 17:29:08.000000000","message":"I need to fix the FTs, trivial stuff","commit_id":"5127c8dfa667ba3817af0b6dc65ad4ac4573d44c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c39569565653cc116373372b0d79f36bf46ca378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"db7d01b2_8bd3c47e","updated":"2025-11-17 17:19:12.000000000","message":"-1 just for my test question","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"78dbee269c8c02b8344c37d629a84a36be63dc59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b19b566_efcf8cc0","updated":"2025-11-17 13:23:20.000000000","message":"How hard would it be to make a functional test that spawns an agent (calling subprocess), waits until it initializes and then sends the SIGTERM signal and makes sure it stops in a reasonable timeframe?","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f99b0957e7adf9b3026488008f58e7d2aa71343f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8c33ef1_5b847649","updated":"2025-11-17 14:44:46.000000000","message":"I check the same pattern for other agents","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ce8d02705bf894d9c0c009b6fc238534c0da010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4914a890_56b24c03","in_reply_to":"5b19b566_efcf8cc0","updated":"2025-11-17 14:40:49.000000000","message":"This agent will require OVS and OVN DB connectivity. But this is provided by the ``TestOVNFunctionalBase``. Let me check that. In any case, could this be implemented in a follow-up patch?","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c6baa1cb2eb31ce60966911450b5d427c34a359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1623eb6b_6ab13f72","updated":"2025-11-18 15:01:01.000000000","message":"Increasing review priority. This patch needs to be backported too.","commit_id":"6e60773958bae446223e28e59c385c6c24f42ab5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bfed81693ffc268704e6a2f6969f04de44b1c861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09cc1a26_fc34f5ce","updated":"2025-11-19 22:02:46.000000000","message":"recheck neutron-functional","commit_id":"6e60773958bae446223e28e59c385c6c24f42ab5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"22ac9c75840483513fb3543bbdd37d858fa78f29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b7511ed3_743fb487","in_reply_to":"09cc1a26_fc34f5ce","updated":"2025-11-19 23:14:49.000000000","message":"I saw the same failure in an unrelated neutron patch, seems to be pointing at ovsdbapp.","commit_id":"6e60773958bae446223e28e59c385c6c24f42ab5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8472aa93d9a0d3e3cbe920f46b1da987d3567079","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89a87d02_4e410f54","updated":"2025-11-20 14:23:14.000000000","message":"Rebased on top of https://review.opendev.org/c/openstack/neutron/+/967813 to WA the ovsdbapp issue with the last release.","commit_id":"5e92bbfa5080b219de21829f42e5f372001fc78f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ce9d19b4386eca2d3daacd2df7aab18d4658e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"748cbe1a_f1d6a738","updated":"2025-11-20 16:41:30.000000000","message":"recheck neutron-functional","commit_id":"5e92bbfa5080b219de21829f42e5f372001fc78f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a5b578ab580d02c174294fa19ca2dd07cd3e6257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d726cbb_3346ada1","updated":"2025-11-21 07:31:58.000000000","message":"recheck neutron-ovn-tempest-ipv6-only-ovs-release","commit_id":"5e92bbfa5080b219de21829f42e5f372001fc78f"}],"neutron/agent/ovn/agent/ovn_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c39569565653cc116373372b0d79f36bf46ca378","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        \"\"\""},{"line_number":242,"context_line":"        if not self.ext_manager_api:"},{"line_number":243,"context_line":"            self.ext_manager_api \u003d ext_mgr.OVNAgentExtensionAPI()"},{"line_number":244,"context_line":"        if not self.ext_manager:"},{"line_number":245,"context_line":"            self.ext_manager \u003d ext_mgr.OVNAgentExtensionManager(self._conf)"},{"line_number":246,"context_line":"            self.ext_manager.initialize(None, \u0027ovn\u0027, self)"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"99fe7021_89eef932","line":244,"updated":"2025-11-17 17:19:12.000000000","message":"nit: these maybe could be under the same \u0027if\u0027 since i don\u0027t see them ever being un-set.","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c297685f99aff5c911f87ab50c3e845a5632f28","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        \"\"\""},{"line_number":242,"context_line":"        if not self.ext_manager_api:"},{"line_number":243,"context_line":"            self.ext_manager_api \u003d ext_mgr.OVNAgentExtensionAPI()"},{"line_number":244,"context_line":"        if not self.ext_manager:"},{"line_number":245,"context_line":"            self.ext_manager \u003d ext_mgr.OVNAgentExtensionManager(self._conf)"},{"line_number":246,"context_line":"            self.ext_manager.initialize(None, \u0027ovn\u0027, self)"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dafa717e_71976fb2","line":244,"in_reply_to":"99fe7021_89eef932","updated":"2025-11-18 07:04:33.000000000","message":"Done","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"}],"neutron/tests/functional/agent/ovn/agent/test_ovn_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c39569565653cc116373372b0d79f36bf46ca378","unresolved":true,"context_lines":[{"line_number":107,"context_line":"                                  \u0027_load_ovs_idl\u0027) as mock_load_ovs_idl:"},{"line_number":108,"context_line":"            agt._initialize_ext_manager()"},{"line_number":109,"context_line":"            mock_load_ovs_idl.return_value \u003d self._create_ovs_idl(agt)"},{"line_number":110,"context_line":"            agt.start()"},{"line_number":111,"context_line":"            external_ids \u003d agt.sb_idl.db_get("},{"line_number":112,"context_line":"                \u0027Chassis_Private\u0027, agt.chassis, \u0027external_ids\u0027).execute("},{"line_number":113,"context_line":"                check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6d2b5698_210bd05d","line":110,"updated":"2025-11-17 17:19:12.000000000","message":"Shouldn\u0027t this have called _initialize_ext_manager() ?","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c297685f99aff5c911f87ab50c3e845a5632f28","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                  \u0027_load_ovs_idl\u0027) as mock_load_ovs_idl:"},{"line_number":108,"context_line":"            agt._initialize_ext_manager()"},{"line_number":109,"context_line":"            mock_load_ovs_idl.return_value \u003d self._create_ovs_idl(agt)"},{"line_number":110,"context_line":"            agt.start()"},{"line_number":111,"context_line":"            external_ids \u003d agt.sb_idl.db_get("},{"line_number":112,"context_line":"                \u0027Chassis_Private\u0027, agt.chassis, \u0027external_ids\u0027).execute("},{"line_number":113,"context_line":"                check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8719683f_12180752","line":110,"in_reply_to":"6d2b5698_210bd05d","updated":"2025-11-18 07:04:33.000000000","message":"Yes, indeed. I\u0027ve implemented the `_initialize_ext_manager` method idempotent to allow calling it several times. We need to \"insert\" the L109 mock between the `__init__` method and the `start` method, this is why I created `_initialize_ext_manager`. Of course, it will be called again in `start` with no effect, but we need to have the extension manager loaded and NOT the IDLs to add L109 mock.","commit_id":"0a8a8072ba92bd37abede67745184657f15300eb"}]}
