)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"394d449eab70cb784a0903a8c17dd0fca4e6b402","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Therefore, we would assume port groups necessarily had a security group"},{"line_number":11,"context_line":"ID referenced on their external IDs. With the support of FWaaS this is"},{"line_number":12,"context_line":"no longer true, since the mechanism behind it is also ACLs and port"},{"line_number":13,"context_line":"groups."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2131209"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e5d771de_93e6225c","line":13,"updated":"2025-11-19 08:22:12.000000000","message":"nit: fwaas was supported in u/s neutron even earlier, its just that we have added it now to RHOSO 😊 and that we have never tested those two plugins together in u/s probably. IMHO you should change this description","commit_id":"b2183a32a8a9a902efc0d8e494712c78885aeafa"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"4613e49d37dce780ed81fe34f5b6d5731296327f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Therefore, we would assume port groups necessarily had a security group"},{"line_number":11,"context_line":"ID referenced on their external IDs. With the support of FWaaS this is"},{"line_number":12,"context_line":"no longer true, since the mechanism behind it is also ACLs and port"},{"line_number":13,"context_line":"groups."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2131209"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa8df880_4783ee69","line":13,"in_reply_to":"e5d771de_93e6225c","updated":"2025-11-19 09:17:39.000000000","message":"Sure! Hope this is better","commit_id":"b2183a32a8a9a902efc0d8e494712c78885aeafa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"1990149ab289dfd5a73c463a75f93fae86796e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"098591e7_aef31db3","updated":"2025-11-18 16:43:25.000000000","message":"I\u0027m aware this could be more precise and check explicitly if the firewall key is on external_ids for pgs and if it is not, raise an error (since we should not have any more types of ACLs or PGs as of now. However, this fix seems more useful on the long run in case we start using ACLs for different uses or corner cases.\n\nI can easily change this to the more strict way if it is considered better though.","commit_id":"6c8780adf09490611d5946d266f960356e081d79"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"394d449eab70cb784a0903a8c17dd0fca4e6b402","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2277086_5f16b677","in_reply_to":"098591e7_aef31db3","updated":"2025-11-19 08:22:12.000000000","message":"I think that this solution is ok. We shouldn\u0027t have anything fwaas related directly in neutron code. From neutron perspective this ACL is unknown and should be treated as such.","commit_id":"6c8780adf09490611d5946d266f960356e081d79"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"e78acbb983764998a3b7ff53a2fc8c0fee5f35ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f15ffdd6_b462c510","updated":"2025-11-20 09:02:32.000000000","message":"functionals failing because of https://bugs.launchpad.net/neutron/+bug/2131994","commit_id":"c0f6145b871de7fa750fbf09c125d6feb1829031"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"a4051ea257667ffee37c1aae81c1b7fa7fb951d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16d375b5_66daed1a","updated":"2025-11-21 14:07:14.000000000","message":"recheck (fix to gates has been merged iiuc)","commit_id":"c0f6145b871de7fa750fbf09c125d6feb1829031"}],"neutron/services/logapi/drivers/ovn/driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"394d449eab70cb784a0903a8c17dd0fca4e6b402","unresolved":true,"context_lines":[{"line_number":160,"context_line":"            if pg[\"name\"] !\u003d ovn_const.OVN_DROP_PORT_GROUP_NAME:"},{"line_number":161,"context_line":"                if ovn_const.OVN_SG_EXT_ID_KEY not in pg[\"external_ids\"]:"},{"line_number":162,"context_line":"                    LOG.info(\"Port Group %s is not part of any security \""},{"line_number":163,"context_line":"                            \"group, skipping its network log \""},{"line_number":164,"context_line":"                             \"setting...\", pg[\"name\"])"},{"line_number":165,"context_line":"                    continue"},{"line_number":166,"context_line":"                sg \u003d sg_obj.SecurityGroup.get_sg_by_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"be6ac264_86ccd458","line":163,"updated":"2025-11-19 08:22:12.000000000","message":"nitty nit: please fix allignment here 😊","commit_id":"b2183a32a8a9a902efc0d8e494712c78885aeafa"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"4613e49d37dce780ed81fe34f5b6d5731296327f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            if pg[\"name\"] !\u003d ovn_const.OVN_DROP_PORT_GROUP_NAME:"},{"line_number":161,"context_line":"                if ovn_const.OVN_SG_EXT_ID_KEY not in pg[\"external_ids\"]:"},{"line_number":162,"context_line":"                    LOG.info(\"Port Group %s is not part of any security \""},{"line_number":163,"context_line":"                            \"group, skipping its network log \""},{"line_number":164,"context_line":"                             \"setting...\", pg[\"name\"])"},{"line_number":165,"context_line":"                    continue"},{"line_number":166,"context_line":"                sg \u003d sg_obj.SecurityGroup.get_sg_by_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"19e80e4c_2a38696c","line":163,"in_reply_to":"be6ac264_86ccd458","updated":"2025-11-19 09:17:39.000000000","message":"Done","commit_id":"b2183a32a8a9a902efc0d8e494712c78885aeafa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"394d449eab70cb784a0903a8c17dd0fca4e6b402","unresolved":true,"context_lines":[{"line_number":433,"context_line":"            if pg[\u0027name\u0027] !\u003d ovn_const.OVN_DROP_PORT_GROUP_NAME:"},{"line_number":434,"context_line":"                if ovn_const.OVN_SG_EXT_ID_KEY not in pg[\"external_ids\"]:"},{"line_number":435,"context_line":"                    LOG.info(\"Port Group %s is not part of any security \""},{"line_number":436,"context_line":"                              \"group, skipping its network log \""},{"line_number":437,"context_line":"                              \"setting...\", pg[\"name\"])"},{"line_number":438,"context_line":"                    continue"},{"line_number":439,"context_line":"                sg \u003d sg_obj.SecurityGroup.get_sg_by_id(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7eec714b_58de08f9","line":436,"updated":"2025-11-19 08:22:12.000000000","message":"ditto","commit_id":"b2183a32a8a9a902efc0d8e494712c78885aeafa"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"4613e49d37dce780ed81fe34f5b6d5731296327f","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            if pg[\u0027name\u0027] !\u003d ovn_const.OVN_DROP_PORT_GROUP_NAME:"},{"line_number":434,"context_line":"                if ovn_const.OVN_SG_EXT_ID_KEY not in pg[\"external_ids\"]:"},{"line_number":435,"context_line":"                    LOG.info(\"Port Group %s is not part of any security \""},{"line_number":436,"context_line":"                              \"group, skipping its network log \""},{"line_number":437,"context_line":"                              \"setting...\", pg[\"name\"])"},{"line_number":438,"context_line":"                    continue"},{"line_number":439,"context_line":"                sg \u003d sg_obj.SecurityGroup.get_sg_by_id(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a224ec55_a09dbf49","line":436,"in_reply_to":"7eec714b_58de08f9","updated":"2025-11-19 09:17:39.000000000","message":"Done","commit_id":"b2183a32a8a9a902efc0d8e494712c78885aeafa"}]}