)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b6919e7afeb97ef84b612231ee5c8897268bd745","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-24 14:41:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch sriov agent to threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2603cbf36240f06fc8272618a03bbf32991a14e7"},{"line_number":10,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4ea921a7_7773cb70","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"updated":"2025-11-24 08:29:57.000000000","message":"macvtap?","commit_id":"cd41b5ed1de23141daccfe650cb4072407f095a4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9294af1d400fff7cb683d0b0cede1b74d8ec1097","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-24 14:41:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch sriov agent to threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2603cbf36240f06fc8272618a03bbf32991a14e7"},{"line_number":10,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7c05746f_469c53e8","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"in_reply_to":"2a0d14fa_1c81c9fa","updated":"2025-11-24 15:21:41.000000000","message":"I\u0027ve reported this issue in https://bugs.launchpad.net/neutron/+bug/2132327. We would maybe need to refactor the RPC initialization, apart from the oslo.service change. Because this patch is also affecting SR-IOV agent, I would -W until we have if properly migrated.\n\nThanks for your patches!","commit_id":"cd41b5ed1de23141daccfe650cb4072407f095a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"401eb706bfbb242a2450425df39df7240c3994d1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-24 14:41:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch sriov agent to threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2603cbf36240f06fc8272618a03bbf32991a14e7"},{"line_number":10,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2a0d14fa_1c81c9fa","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"in_reply_to":"4ea921a7_7773cb70","updated":"2025-11-24 08:48:52.000000000","message":"no macvtap agent was already running in thread mode. This effectively adds the oslo.messaging patching to use threading mode for sriov-agent, which didn\u0027t have the local patching in its .py file","commit_id":"cd41b5ed1de23141daccfe650cb4072407f095a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"28ba79076f28f8425a78dfbc086c4052c7df756b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-24 14:41:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch sriov agent to threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2603cbf36240f06fc8272618a03bbf32991a14e7"},{"line_number":10,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"808e0cfb_71417f9e","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"in_reply_to":"7c05746f_469c53e8","updated":"2025-11-24 15:23:19.000000000","message":"yeah I agree with taking that step first. I\u0027ll put WIP to the parent patch so that I can cover both refactorings.","commit_id":"cd41b5ed1de23141daccfe650cb4072407f095a4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4fffb2daeb9ff19a670c798ad143f098f3f60d3c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-24 14:41:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch sriov agent to threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2603cbf36240f06fc8272618a03bbf32991a14e7"},{"line_number":10,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"46c0f6e1_bc7735bf","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"in_reply_to":"808e0cfb_71417f9e","updated":"2025-11-24 15:55:43.000000000","message":"Actually, checking the SR-IOV agent code, we are not using `oslo_service.service.launch`. We are just spawning executing `SriovNicSwitchAgent.daemon_loop` (implemented 11 years ago) and handling the SIGTERM signal with [1]. So maybe we can create a LP bug to refactor this agent to use oslo.service, but for now this is not necessary.\n\nI would keep Lajos\u0027 comment about changing the name of the patch.\n\n[1]https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py#L482","commit_id":"cd41b5ed1de23141daccfe650cb4072407f095a4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9294af1d400fff7cb683d0b0cede1b74d8ec1097","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"333c19e4_81abac36","updated":"2025-11-24 15:21:41.000000000","message":"This patch should mention only MAC vTAP agent, not SR-IOV (at least for now). Please wait for [1] fix.\n\n[1]https://bugs.launchpad.net/neutron/+bug/2132327","commit_id":"cd41b5ed1de23141daccfe650cb4072407f095a4"}]}
