)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"13d1639b03b554593e28d5915d12c43646004264","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Edgar Magana \u003cemagana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-04 13:50:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the LOG level when dnsmasq version is not determined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When it is not possible to determinate the dnsmasq version"},{"line_number":10,"context_line":"or dnsmasq is not installed, neutron shows only a warning message."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_83e68642","line":7,"updated":"2014-06-04 21:35:33.000000000","message":"shouldn\u0027t this be something like: \"Stop the dhcp-agent process when dnsmasq version is not determined\" ?","commit_id":"58b38bc657b01fe11a1582c256b2b982f89d9d95"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"7c9265b808327614956319e171bead9321565106","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Edgar Magana \u003cemagana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-04 13:50:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change the LOG level when dnsmasq version is not determined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When it is not possible to determinate the dnsmasq version"},{"line_number":10,"context_line":"or dnsmasq is not installed, neutron shows only a warning message."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_260ce03a","line":7,"in_reply_to":"1ae5cdf2_83e68642","updated":"2014-06-04 22:01:09.000000000","message":"Actually you are right! The previous ,one made sense because I was just changing the LOG level. I will add a new patch","commit_id":"58b38bc657b01fe11a1582c256b2b982f89d9d95"},{"author":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"change_message_id":"84f998e9c130240d0121d472117e69506af68f2e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When it is not possible to determinate the dnsmasq version"},{"line_number":10,"context_line":"or dnsmasq is not installed, neutron shows only a warning message."},{"line_number":11,"context_line":"With this commit the dhcp-agent process will be stoppped if the"},{"line_number":12,"context_line":"dnsmasq service is not installed."},{"line_number":13,"context_line":"Modifies the dhcp version unit test with the expected SystemExit exception"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_064b3bb1","line":11,"updated":"2014-06-20 20:57:29.000000000","message":"nit:  stoppped","commit_id":"8583988ca5faa28e6cc940058e9546f9b4fb123d"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"94d2a0c3585c7cc72c3970631c493f2f091faf87","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When it is not possible to determinate the dnsmasq version"},{"line_number":10,"context_line":"or dnsmasq is not installed, neutron shows only a warning message."},{"line_number":11,"context_line":"With this commit the dhcp-agent process will be stoppped if the"},{"line_number":12,"context_line":"dnsmasq service is not installed."},{"line_number":13,"context_line":"Modifies the dhcp version unit test with the expected SystemExit exception"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_bb19a725","line":11,"in_reply_to":"1ae5cdf2_064b3bb1","updated":"2014-06-23 04:40:12.000000000","message":"Done","commit_id":"8583988ca5faa28e6cc940058e9546f9b4fb123d"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"fd2baee122e0ebce9a36d27f39585a29ff110d51","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":293,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError):"},{"line_number":294,"context_line":"            LOG.error(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":295,"context_line":"                          \u0027Please ensure that its version is %s \u0027"},{"line_number":296,"context_line":"                          \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":297,"context_line":"        return float(ver)"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_25e972e6","line":295,"updated":"2014-06-03 14:38:01.000000000","message":"pep8 issue here.\nAnd I think that we need to stop the service if  it is unable to determine dnsmasq version here.","commit_id":"bf02d010be4fd23b17f332aa4f70441b53c38d9f"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"241370efe17f598b424e440dd9e23193c63622c9","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":293,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError):"},{"line_number":294,"context_line":"            LOG.error(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":295,"context_line":"                          \u0027Please ensure that its version is %s \u0027"},{"line_number":296,"context_line":"                          \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":297,"context_line":"        return float(ver)"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_cd96303f","line":295,"in_reply_to":"1ae5cdf2_25e972e6","updated":"2014-06-03 17:23:44.000000000","message":"Yes, we are discussing that with Armando and Paul, It seems that we have a consensus about it. I will submit a new patch.","commit_id":"bf02d010be4fd23b17f332aa4f70441b53c38d9f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"038d5e5741f31756dd06951152ff6cbd286960d3","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                              \u0027Please ensure that its version is %s \u0027"},{"line_number":292,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":293,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError):"},{"line_number":294,"context_line":"            sys.exit(_(\u0027ERROR: Unable to determine dnsmasq version. \u0027"},{"line_number":295,"context_line":"                       \u0027Please ensure that its version is %s \u0027"},{"line_number":296,"context_line":"                       \u0027or above!\u0027) % cls.MINIMUM_VERSION)"},{"line_number":297,"context_line":"        return float(ver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_caea3f73","line":294,"updated":"2014-06-05 17:49:50.000000000","message":"This should be:\nLOG.error()\nraise SystemExit(1)","commit_id":"58b38bc657b01fe11a1582c256b2b982f89d9d95"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"a77ea65a6a276f8923e2a8b5defdda0ca3fc9798","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                              \u0027Please ensure that its version is %s \u0027"},{"line_number":292,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":293,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError):"},{"line_number":294,"context_line":"            sys.exit(_(\u0027ERROR: Unable to determine dnsmasq version. \u0027"},{"line_number":295,"context_line":"                       \u0027Please ensure that its version is %s \u0027"},{"line_number":296,"context_line":"                       \u0027or above!\u0027) % cls.MINIMUM_VERSION)"},{"line_number":297,"context_line":"        return float(ver)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c111425e","line":294,"in_reply_to":"1ae5cdf2_caea3f73","updated":"2014-06-05 20:14:17.000000000","message":"Done","commit_id":"58b38bc657b01fe11a1582c256b2b982f89d9d95"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c66e7dd1baea6cf68a9cdd5d851af20ca1d492c","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            LOG.error(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":295,"context_line":"                        \u0027Please ensure that its version is %s \u0027"},{"line_number":296,"context_line":"                        \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":297,"context_line":"            raise SystemExit(1)"},{"line_number":298,"context_line":"        return float(ver)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_88e1da9c","line":297,"updated":"2014-06-09 08:32:27.000000000","message":"Does this need to be a SystemExit? Is there a loop catching regular exceptions above this that prevents a regular raise from working?","commit_id":"05d71c1d68bbcc765db341eacbb98a727a1e71ec"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9473877c08f826b23a7e78ec883c271b87cd821d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            LOG.error(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":295,"context_line":"                        \u0027Please ensure that its version is %s \u0027"},{"line_number":296,"context_line":"                        \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":297,"context_line":"            raise SystemExit(1)"},{"line_number":298,"context_line":"        return float(ver)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_bdf084ca","line":297,"in_reply_to":"1ae5cdf2_88e1da9c","updated":"2014-06-09 16:23:29.000000000","message":"Yes, it needs to be. Please, see previous comments and suggestions. Two core member from Neutron have recommended the SystemExit.","commit_id":"05d71c1d68bbcc765db341eacbb98a727a1e71ec"}],"neutron/tests/unit/test_linux_dhcp.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"679598fdd8f8e389810b3585d3a2504bd086a89c","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class FakeV6HostRoute:"},{"line_number":130,"context_line":"    destination \u003d \u00272001:0200:feed:7ac0::/64\u0027"},{"line_number":131,"context_line":"    nexthop \u003d \u00272001:0200:feed:7ac0::1\u0027"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_5b57c35a","line":130,"updated":"2014-06-23 05:00:36.000000000","message":"is this an intentional change or just override of changes made by some other commit?","commit_id":"04b3d8f662f98c83099a89675e7dbb73a5b5481f"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"a396db83809f5590ce82eae38191f34f4ab0488f","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class FakeV6HostRoute:"},{"line_number":130,"context_line":"    destination \u003d \u00272001:0200:feed:7ac0::/64\u0027"},{"line_number":131,"context_line":"    nexthop \u003d \u00272001:0200:feed:7ac0::1\u0027"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_3f0588c2","line":130,"in_reply_to":"1ae5cdf2_5b57c35a","updated":"2014-06-30 17:38:28.000000000","message":"By \"these\" do you mean the changes on lines 1253-1254?\nIf yes, then my answer is also yes.\nJust asking because your question shows in a different line that my code changes.","commit_id":"04b3d8f662f98c83099a89675e7dbb73a5b5481f"}]}